CodeCow/stack
1
0
Fork 0
mirror of https://github.com/stack-auth/stack.git synced 2026-06-04 21:04:37 +08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Stricter types for Project.updateConfig

Browse Source
This commit is contained in:
Konstantin Wohlwend 2025-11-20 09:48:17 -08:00
parent 4b955ced3e
commit 772d984354
2 changed files with 19 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
apps/dashboard/src/app/(main)/(protected)/projects/[projectId]/emails/page-client.tsx
View File

@ -146,18 +146,16 @@ function EditEmailServerDialog(props: {
}
setError(null);
await project.updateConfig({
emails: {
server: {
isShared: false,
host: emailConfig.host,
port: emailConfig.port,
username: emailConfig.username,
password: emailConfig.password,
senderEmail: emailConfig.senderEmail,
senderName: emailConfig.senderName,
provider: emailConfig.type === 'resend' ? 'resend' : 'smtp',
}
}
"emails.server": {
isShared: false,
host: emailConfig.host,
port: emailConfig.port,
username: emailConfig.username,
password: emailConfig.password,
senderEmail: emailConfig.senderEmail,
senderName: emailConfig.senderName,
provider: emailConfig.type === 'resend' ? 'resend' : 'smtp',
},
});
toast({

12
packages/template/src/lib/stack-app/projects/index.ts
View File

@ -1,8 +1,7 @@
import { ProductionModeError } from "@stackframe/stack-shared/dist/helpers/production-mode";
import { AdminUserProjectsCrud, ProjectsCrud } from "@stackframe/stack-shared/dist/interface/crud/projects";
import { CompleteConfig, EnvironmentConfigOverrideOverride } from "@stackframe/stack-shared/dist/config/schema";
import { CurrentUser } from "..";
import { CompleteConfig, EnvironmentConfigNormalizedOverride, EnvironmentConfigOverrideOverride } from "@stackframe/stack-shared/dist/config/schema";
import { StackAdminApp } from "../apps/interfaces/admin-app";
import { AdminProjectConfig, AdminProjectConfigUpdateOptions, ProjectConfig } from "../project-configs";
@ -33,7 +32,14 @@ export type AdminProject = {
getConfig(this: AdminProject): Promise<CompleteConfig>,
// NEXT_LINE_PLATFORM react-like
useConfig(this: AdminProject): CompleteConfig,
updateConfig(this: AdminProject, config: EnvironmentConfigOverrideOverride): Promise<void>,
// We have some strict types here in order to prevent accidental overwriting of a top-level property of a config object
updateConfig(
this: AdminProject,
config: EnvironmentConfigOverrideOverride & {
[K in keyof EnvironmentConfigNormalizedOverride]: "............................ERROR MESSAGE AFTER THIS LINE............................ You have attempted to update a config object with a top-level property in it (for example `emails`). This is very likely a mistake, and you probably meant to update a nested property instead (for example `emails.server`). If you really meant to update a top-level property (resetting all nested properties to their defaults), cast as any (the code will work at runtime) ............................ERROR MESSAGE BEFORE THIS LINE............................";
}
): Promise<void>,
getProductionModeErrors(this: AdminProject): Promise<ProductionModeError[]>,
// NEXT_LINE_PLATFORM react-like