From 59f831def501c38b1cd73d528e3ba2f21995ea69 Mon Sep 17 00:00:00 2001
From: Stan Wohlwend <n2d4xc@gmail.com>
Date: Fri, 17 May 2024 13:09:29 +0200
Subject: [PATCH] Table hover only if row is clickable

---
 .../(protected)/projects/[projectId]/api-keys/page-client.tsx | 4 ++--
 .../projects/[projectId]/auth-methods/providers.tsx           | 2 +-
 .../src/components/data-table/team-permission-table.tsx       | 2 +-
 packages/stack-server/src/components/ui/dialog.tsx            | 2 +-
 packages/stack-server/src/components/ui/table.tsx             | 3 ++-
 5 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/packages/stack-server/src/app/(main)/(protected)/projects/[projectId]/api-keys/page-client.tsx b/packages/stack-server/src/app/(main)/(protected)/projects/[projectId]/api-keys/page-client.tsx
index 0ea48eab0..cddf87128 100644
--- a/packages/stack-server/src/app/(main)/(protected)/projects/[projectId]/api-keys/page-client.tsx
+++ b/packages/stack-server/src/app/(main)/(protected)/projects/[projectId]/api-keys/page-client.tsx
@@ -107,7 +107,7 @@ function ShowKeyDialog(props: {
     title="API Key"
     okButton={{ label: "Close" }}
     onClose={props.onClose}
-    confirmText="I understand that I will not be able to view this key again"
+    confirmText="I understand that I will not be able to view this key again."
   >
     <div className="flex flex-col gap-4">
       <Typography>
@@ -120,4 +120,4 @@ function ShowKeyDialog(props: {
       />
     </div>
   </ActionDialog>;
-}
\ No newline at end of file
+}
diff --git a/packages/stack-server/src/app/(main)/(protected)/projects/[projectId]/auth-methods/providers.tsx b/packages/stack-server/src/app/(main)/(protected)/projects/[projectId]/auth-methods/providers.tsx
index 7a8566d4f..b9932e30a 100644
--- a/packages/stack-server/src/app/(main)/(protected)/projects/[projectId]/auth-methods/providers.tsx
+++ b/packages/stack-server/src/app/(main)/(protected)/projects/[projectId]/auth-methods/providers.tsx
@@ -144,7 +144,7 @@ export function TurnOffProviderDialog(props: {
         },
       }}
       cancelButton
-      confirmText="I understand that this will disable sign-in and sign-up for new and existing users with this provider"
+      confirmText="I understand that this will disable sign-in and sign-up for new and existing users with this provider."
     >
       <Typography>
         Disabling this provider will prevent users from signing in with it, including existing users who have used it before. They might not be able to log in anymore. Are you sure you want to do this?
diff --git a/packages/stack-server/src/components/data-table/team-permission-table.tsx b/packages/stack-server/src/components/data-table/team-permission-table.tsx
index c47109f3d..566d9e7b9 100644
--- a/packages/stack-server/src/components/data-table/team-permission-table.tsx
+++ b/packages/stack-server/src/components/data-table/team-permission-table.tsx
@@ -122,7 +122,7 @@ const columns: ColumnDef<PermissionDefinitionJson>[] =  [
   },
   {
     accessorKey: "containPermissionIds",
-    header: ({ column }) => <DataTableColumnHeader column={column} title="Contains Permissions" />,
+    header: ({ column }) => <DataTableColumnHeader column={column} title="Contained Permissions" />,
     cell: ({ row }) => <BadgeCell size={120} badges={row.getValue("containPermissionIds")} />,
   },
   {
diff --git a/packages/stack-server/src/components/ui/dialog.tsx b/packages/stack-server/src/components/ui/dialog.tsx
index b0e20abe1..fa9fcb21e 100644
--- a/packages/stack-server/src/components/ui/dialog.tsx
+++ b/packages/stack-server/src/components/ui/dialog.tsx
@@ -57,7 +57,7 @@ const DialogBody = ({
   className,
   ...props
 }: React.HTMLAttributes<HTMLDivElement>) => (
-  <div className={cn("overflow-y-auto flex flex-col w-full gap-4", className)} {...props} />
+  <div className={cn("overflow-y-auto flex flex-col gap-4 w-[calc(100%+3rem)] -mx-6 px-6", className)} {...props} />
 );
 
 const DialogHeader = ({
diff --git a/packages/stack-server/src/components/ui/table.tsx b/packages/stack-server/src/components/ui/table.tsx
index a8c9ec4a0..1d27b3663 100644
--- a/packages/stack-server/src/components/ui/table.tsx
+++ b/packages/stack-server/src/components/ui/table.tsx
@@ -58,7 +58,8 @@ const TableRow = React.forwardRef<
   <tr
     ref={ref}
     className={cn(
-      "border-b hover:bg-muted/50 data-[state=selected]:bg-muted",
+      "border-b data-[state=selected]:bg-muted",
+      props.onClick ? "hover:bg-muted/50 cursor-pointer" : "",
       className
     )}
     {...props}