CodeCow/stack
1
0
Fork 0
mirror of https://github.com/stack-auth/stack.git synced 2026-07-20 21:29:36 +08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

fix: treat missing access_token in refresh response as failure

Browse Source 
Return (False, None) instead of (True, None) when the OAuth token
endpoint returns 200 but the response has no access_token field.
Also moved Awaitable/Callable imports behind TYPE_CHECKING guard
since they are only used for type annotations.
This commit is contained in:
Ejiro Asiuwhu
2026-03-26 11:28:50 +01:00
parent 94293c14bd
commit 573fe23ea8
1 changed files with 12 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
sdks/implementations/python/src/stack_auth/_token_store.py
+12 -4
View File
@@ -16,8 +16,10 @@ import json
import threading
import time
from abc import ABC, abstractmethod
from collections.abc import Awaitable, Callable
from typing import Any, Literal
from typing import TYPE_CHECKING, Any, Literal
if TYPE_CHECKING:
from collections.abc import Awaitable, Callable
import logging
@@ -393,7 +395,10 @@ def _refresh_access_token_sync(
data = resp.json()
if not isinstance(data, dict):
return (False, None)
return (True, data.get("access_token"))
access_token = data.get("access_token")
if not access_token:
return (False, None)
return (True, access_token)
return (False, None)
except (httpx.HTTPError, ValueError, KeyError) as exc:
logger.debug("Token refresh failed (sync)", exc_info=exc)
@@ -426,7 +431,10 @@ async def _refresh_access_token_async(
data = resp.json()
if not isinstance(data, dict):
return (False, None)
return (True, data.get("access_token"))
access_token = data.get("access_token")
if not access_token:
return (False, None)
return (True, access_token)
return (False, None)
except (httpx.HTTPError, ValueError, KeyError) as exc:
logger.debug("Token refresh failed (async)", exc_info=exc)