From 2c6bb4b4ee4a30dcfdde28e2bedbd48bc2af1740 Mon Sep 17 00:00:00 2001
From: TheCactusBlue <thecactusblue@gmail.com>
Date: Tue, 25 Mar 2025 15:20:47 -0700
Subject: [PATCH] fix binding issues

---
 .../data-table/permission-table.tsx           | 23 +++++++++++--------
 1 file changed, 13 insertions(+), 10 deletions(-)

diff --git a/apps/dashboard/src/components/data-table/permission-table.tsx b/apps/dashboard/src/components/data-table/permission-table.tsx
index 2eb7127b5..459cbc250 100644
--- a/apps/dashboard/src/components/data-table/permission-table.tsx
+++ b/apps/dashboard/src/components/data-table/permission-table.tsx
@@ -62,10 +62,6 @@ function EditDialog(props: {
     })
   }).default(currentPermission);
 
-  const updatePermission = props.permissionType === 'project'
-    ? stackAdminApp.updateProjectPermissionDefinition
-    : stackAdminApp.updateTeamPermissionDefinition;
-
   return <SmartFormDialog
     open={props.open}
     onOpenChange={props.onOpenChange}
@@ -74,7 +70,11 @@ function EditDialog(props: {
     okButton={{ label: "Save" }}
     onSubmit={(values) => {
       runAsynchronously(async () => {
-        await updatePermission(props.selectedPermissionId, values);
+        if (props.permissionType === 'project') {
+          await stackAdminApp.updateProjectPermissionDefinition(props.selectedPermissionId, values);
+        } else {
+          await stackAdminApp.updateTeamPermissionDefinition(props.selectedPermissionId, values);
+        }
       });
     }}
     cancelButton
@@ -87,10 +87,7 @@ function DeleteDialog<T extends AdminPermissionDefinition>(props: {
   onOpenChange: (open: boolean) => void,
   permissionType: PermissionType,
 }) {
-  const stackApp = useAdminApp();
-  const deletePermission = props.permissionType === 'project'
-    ? stackApp.deleteProjectPermissionDefinition
-    : stackApp.deleteTeamPermissionDefinition;
+  const stackAdminApp = useAdminApp();
 
   return <ActionDialog
     open={props.open}
@@ -98,7 +95,13 @@ function DeleteDialog<T extends AdminPermissionDefinition>(props: {
     title="Delete Permission"
     danger
     cancelButton
-    okButton={{ label: "Delete Permission", onClick: async () => { await deletePermission(props.permission.id); } }}
+    okButton={{ label: "Delete Permission", onClick: async () => {
+      if (props.permissionType === 'project') {
+        await stackAdminApp.deleteProjectPermissionDefinition(props.permission.id);
+      } else {
+        await stackAdminApp.deleteTeamPermissionDefinition(props.permission.id);
+      }
+    } }}
     confirmText="I understand this will remove the permission from all users and other permissions that contain it."
   >
     {`Are you sure you want to delete the permission "${props.permission.id}"?`}