diff --git a/apps/dashboard/src/components/data-table/permission-table.tsx b/apps/dashboard/src/components/data-table/permission-table.tsx index 2eb7127b5..459cbc250 100644 --- a/apps/dashboard/src/components/data-table/permission-table.tsx +++ b/apps/dashboard/src/components/data-table/permission-table.tsx @@ -62,10 +62,6 @@ function EditDialog(props: { }) }).default(currentPermission); - const updatePermission = props.permissionType === 'project' - ? stackAdminApp.updateProjectPermissionDefinition - : stackAdminApp.updateTeamPermissionDefinition; - return { runAsynchronously(async () => { - await updatePermission(props.selectedPermissionId, values); + if (props.permissionType === 'project') { + await stackAdminApp.updateProjectPermissionDefinition(props.selectedPermissionId, values); + } else { + await stackAdminApp.updateTeamPermissionDefinition(props.selectedPermissionId, values); + } }); }} cancelButton @@ -87,10 +87,7 @@ function DeleteDialog(props: { onOpenChange: (open: boolean) => void, permissionType: PermissionType, }) { - const stackApp = useAdminApp(); - const deletePermission = props.permissionType === 'project' - ? stackApp.deleteProjectPermissionDefinition - : stackApp.deleteTeamPermissionDefinition; + const stackAdminApp = useAdminApp(); return (props: { title="Delete Permission" danger cancelButton - okButton={{ label: "Delete Permission", onClick: async () => { await deletePermission(props.permission.id); } }} + okButton={{ label: "Delete Permission", onClick: async () => { + if (props.permissionType === 'project') { + await stackAdminApp.deleteProjectPermissionDefinition(props.permission.id); + } else { + await stackAdminApp.deleteTeamPermissionDefinition(props.permission.id); + } + } }} confirmText="I understand this will remove the permission from all users and other permissions that contain it." > {`Are you sure you want to delete the permission "${props.permission.id}"?`}