CodeCow/stack
1
0
Fork 0
mirror of https://github.com/stack-auth/stack.git synced 2026-06-30 21:01:54 +08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

fix: stop config agent sandbox on apply failure

Browse Source
This commit is contained in:
mantrakp04 2026-06-25 17:53:44 -07:00
parent 49a0c1083f
commit 212502a00b
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
apps/backend/src/app/api/latest/internal/config/github/apply/route.tsx
View File

@ -100,9 +100,13 @@ export const POST = createSmartRouteHandler({
// can produce server-side (a target-project admin route has no authority to
// mint GitHub tokens for the internal user — that would be a priv-esc).
const getGithubToken = async () => githubToken;
let runningSandboxId: string | null = null;
// Record the live sandbox id while running so a cancel (another invocation)
// can hard-stop it.
// can hard-stop it. Keep an in-memory copy too: if the agent fails after
// boot, the background catch path must stop the sandbox before marking the
// run terminal.
const onSandboxId = async (sandboxId: string) => {
runningSandboxId = sandboxId;
await recordConfigAgentRunSandbox({ projectId, branchId, sandboxId });
};
// Sanitized live activity feed surfaced to the dashboard (no secrets/tokens).
@ -149,6 +153,9 @@ export const POST = createSmartRouteHandler({
}
} catch (error) {
captureError("config-github-apply", error);
if (runningSandboxId != null) {
await stopConfigAgentSandbox(runningSandboxId).catch((e) => captureError("config-github-apply-stop-sandbox", e));
}
await recordConfigAgentRunResult({
projectId,
branchId,