CodeCow/stack
1
0
Fork 0
mirror of https://github.com/stack-auth/stack.git synced 2026-07-20 21:29:36 +08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Trust cached null entry augmentation in range path (!== undefined)

Browse Source 
The range-augmentation path used ?? , so a legitimately-cached null
augmentation was treated as a miss and re-extracted. Match make()'s
!== undefined check so null-augmentation entries hit the cache.

Co-Authored-By: Konstantin Wohlwend <n2d4xc@gmail.com>
This commit is contained in:
Devin AI 2026-07-08 17:56:36 +00:00
parent a04b0afa1e
commit 20a304fc36
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
apps/bulldozer-js/src/databases/piledriver/data-structures/augmented-tree-map.ts
View File

@ -637,8 +637,12 @@ export class AugmentedTreeMultiMap<Key extends PiledriverObject, Value extends P
for (let i = 0; i < node.entries.length; i++) {
result = await this.merge(result, await this.augmentation(node.children[i] ?? null, range));
if (aboveLowerBound(node.entries[i][0]) && belowUpperBound(node.entries[i][0])) {
const entryAug = ((node.version ?? 0) >= 1 ? node.entryAugmentations?.[i] : undefined)
?? await this.options.extractAugmentation(await this.loadValue(node.entries[i][1]), node.entries[i][0].key, node.entries[i][0].id);
// Trust the cached augmentation only for versioned nodes, and check `!== undefined` (not
// `??`) so a legitimately-cached `null` augmentation is still a hit rather than re-extracted.
const cachedEntryAug = (node.version ?? 0) >= 1 ? node.entryAugmentations?.[i] : undefined;
const entryAug = cachedEntryAug !== undefined
? cachedEntryAug
: await this.options.extractAugmentation(await this.loadValue(node.entries[i][1]), node.entries[i][0].key, node.entries[i][0].id);
result = await this.merge(result, entryAug);
}
}