Sync stale SpacetimeDB bindings with requestId and add structural drift test

The server schema added `qa_entries.requestId` (4th column) and
`add_manual_qa.requestId` (6th arg) on May 11 but the auto-generated client
bindings were last regenerated on May 5 and never picked up the new field.
Because BSATN is positional, every column after position 3 in
`my_visible_qa_entries` would deserialize one slot off (question bytes read as
answer, etc.) once the new schema is published — corrupting the Knowledge Base
view in the internal-tool.

Add `requestId` to `my_visible_qa_entries_table.ts`, `types.ts:QaEntries`, and
`add_manual_qa_reducer.ts` in the same positions the codegen would produce,
plus a structural test that parses both the server schema and the generated
bindings and asserts field/arg orders match. The test fails on the prior
state with the exact missing-`requestId` diff and passes after the patch,
catching any future drift in CI.

Co-authored-by: Cursor <cursoragent@cursor.com>

apps/backend/src/lib/ai/spacetimedb-bindings-sync.test.ts

@@ -0,0 +1,133 @@
+/**
+ * Repro for the SpacetimeDB binding drift hazard.
+ *
+ * The internal-tool's SpacetimeDB schema (`apps/internal-tool/spacetimedb/src/index.ts`)
+ * is the single source of truth for table column order and reducer arg order.
+ * Auto-generated client bindings under `apps/internal-tool/src/module_bindings/`
+ * MUST match it positionally — SpacetimeDB encodes table rows and reducer
+ * arguments as positional BSATN (https://spacetimedb.com/docs/bsatn). Field
+ * names are not transmitted on the wire, so a missing or misordered field in
+ * a binding silently shifts every subsequent field in deserialization.
+ *
+ * Concrete impact on this PR:
+ *   - `qa_entries.requestId` (4th column on the server) is missing from
+ *     `my_visible_qa_entries_table.ts`. Once the new schema is published,
+ *     `my_visible_qa_entries` subscriptions will deserialize `requestId`
+ *     bytes as `question`, `question` bytes as `answer`, etc. The Knowledge
+ *     Base tab in the internal-tool would render garbage.
+ *   - `add_manual_qa.requestId` (6th arg on the server) is missing from
+ *     `add_manual_qa_reducer.ts`. The backend currently calls this reducer
+ *     over HTTP (`callReducerStrict`) with all six args, so the production
+ *     code path is unaffected — but any direct WebSocket reducer call
+ *     would be rejected for arg-count mismatch, and the binding type drift
+ *     hides the requirement from future contributors.
+ *
+ * These tests parse both the server schema source and the generated
+ * bindings as text, extract the field/arg order, and assert they match.
+ * They will FAIL on the current (drifted) state and PASS once the
+ * bindings are regenerated (via `pnpm -C apps/internal-tool spacetime:generate`)
+ * or hand-patched to match.
+ */
+import { readFileSync } from "node:fs";
+import { resolve } from "node:path";
+import { describe, expect, it } from "vitest";
+
+const REPO_ROOT = resolve(__dirname, "../../../../..");
+
+function read(relPath: string): string {
+  return readFileSync(resolve(REPO_ROOT, relPath), "utf8");
+}
+
+/**
+ * Extracts ordered field names from a `t.someThing(...)` block in the server
+ * schema source. Given `tableName: 'qa_entries'` (or a reducer call like
+ * `add_manual_qa = spacetimedb.reducer({...}, ...)`), we slice from the
+ * matching anchor through the next matching `}` and collect every line of
+ * shape `<indent>fieldName: ...,?`.
+ */
+function extractServerFields(source: string, anchor: RegExp): string[] {
+  const match = anchor.exec(source);
+  if (match == null) throw new Error(`anchor ${anchor} not found in server schema`);
+  const startIdx = match.index + match[0].length;
+  // Find the matching closing brace by tracking depth from the opening `{`
+  // that immediately follows the anchor.
+  const openIdx = source.indexOf("{", startIdx);
+  if (openIdx === -1) throw new Error(`opening brace not found after anchor ${anchor}`);
+  let depth = 0;
+  let endIdx = -1;
+  for (let i = openIdx; i < source.length; i++) {
+    const ch = source[i];
+    if (ch === "{") depth++;
+    else if (ch === "}") {
+      depth--;
+      if (depth === 0) {
+        endIdx = i;
+        break;
+      }
+    }
+  }
+  if (endIdx === -1) throw new Error(`closing brace not found for anchor ${anchor}`);
+  const block = source.slice(openIdx + 1, endIdx);
+  const fieldRe = /^\s*([a-zA-Z_][a-zA-Z0-9_]*)\s*:/gm;
+  const out: string[] = [];
+  let m: RegExpExecArray | null;
+  while ((m = fieldRe.exec(block)) != null) out.push(m[1]);
+  return out;
+}
+
+/**
+ * The generated row binding format is `__t.row({ field: __t.something() })`.
+ * The reducer binding format is `export default { field: __t.something() }`.
+ * Both share the field-name extraction pattern.
+ */
+function extractClientFields(source: string, blockStartRe: RegExp): string[] {
+  const match = blockStartRe.exec(source);
+  if (match == null) throw new Error(`anchor ${blockStartRe} not found in binding`);
+  const openIdx = source.indexOf("{", match.index);
+  if (openIdx === -1) throw new Error(`opening brace not found after anchor ${blockStartRe}`);
+  let depth = 0;
+  let endIdx = -1;
+  for (let i = openIdx; i < source.length; i++) {
+    const ch = source[i];
+    if (ch === "{") depth++;
+    else if (ch === "}") {
+      depth--;
+      if (depth === 0) {
+        endIdx = i;
+        break;
+      }
+    }
+  }
+  if (endIdx === -1) throw new Error(`closing brace not found for anchor ${blockStartRe}`);
+  const block = source.slice(openIdx + 1, endIdx);
+  const fieldRe = /^\s*([a-zA-Z_][a-zA-Z0-9_]*)\s*:/gm;
+  const out: string[] = [];
+  let m: RegExpExecArray | null;
+  while ((m = fieldRe.exec(block)) != null) out.push(m[1]);
+  return out;
+}
+
+describe("SpacetimeDB bindings stay in sync with server schema", () => {
+  const serverSchema = read("apps/internal-tool/spacetimedb/src/index.ts");
+
+  it("qa_entries server columns match my_visible_qa_entries client row binding", () => {
+    const serverFields = extractServerFields(serverSchema, /name:\s*'qa_entries',\s*public:\s*false\s*\},\s*/);
+    const clientSource = read("apps/internal-tool/src/module_bindings/my_visible_qa_entries_table.ts");
+    const clientFields = extractClientFields(clientSource, /__t\.row\(/);
+    expect(clientFields).toEqual(serverFields);
+  });
+
+  it("qa_entries server columns match QaEntries algebraic type in types.ts", () => {
+    const serverFields = extractServerFields(serverSchema, /name:\s*'qa_entries',\s*public:\s*false\s*\},\s*/);
+    const typesSource = read("apps/internal-tool/src/module_bindings/types.ts");
+    const clientFields = extractClientFields(typesSource, /export const QaEntries = __t\.object\("QaEntries",\s*/);
+    expect(clientFields).toEqual(serverFields);
+  });
+
+  it("add_manual_qa server reducer args match client reducer binding", () => {
+    const serverFields = extractServerFields(serverSchema, /export const add_manual_qa = spacetimedb\.reducer\(\s*/);
+    const clientSource = read("apps/internal-tool/src/module_bindings/add_manual_qa_reducer.ts");
+    const clientFields = extractClientFields(clientSource, /export default\s*/);
+    expect(clientFields).toEqual(serverFields);
+  });
+});

apps/internal-tool/src/module_bindings/add_manual_qa_reducer.ts

@@ -16,4 +16,5 @@ export default {
   answer: __t.string(),
   publish: __t.bool(),
   createdBy: __t.string(),
+  requestId: __t.string(),
 };

apps/internal-tool/src/module_bindings/my_visible_qa_entries_table.ts

@@ -14,6 +14,7 @@ export default __t.row({
   id: __t.u64(),
   shard: __t.u8(),
   sourceMcpCorrelationId: __t.option(__t.string()).name("source_mcp_correlation_id"),
+  requestId: __t.option(__t.string()).name("request_id"),
   question: __t.string(),
   answer: __t.string(),
   createdBy: __t.string().name("created_by"),

apps/internal-tool/src/module_bindings/types.ts

@@ -108,6 +108,7 @@ export const QaEntries = __t.object("QaEntries", {
   id: __t.u64(),
   shard: __t.u8(),
   sourceMcpCorrelationId: __t.option(__t.string()),
+  requestId: __t.option(__t.string()),
   question: __t.string(),
   answer: __t.string(),
   createdBy: __t.string(),