From 08d4b04e28cb45d30721f2bbd63d757907c15425 Mon Sep 17 00:00:00 2001 From: Developing-Gamer Date: Tue, 14 Jul 2026 11:14:28 -0700 Subject: [PATCH] Revert "Test DataGrid schema-pending loading skeleton." This reverts commit 08e9527d04fcecb3caf17abd434174c39c3f531f. --- .../components/data-grid/data-grid.test.tsx | 57 ------------------- 1 file changed, 57 deletions(-) diff --git a/packages/dashboard-ui-components/src/components/data-grid/data-grid.test.tsx b/packages/dashboard-ui-components/src/components/data-grid/data-grid.test.tsx index e2a4bf133..a7e5c4e65 100644 --- a/packages/dashboard-ui-components/src/components/data-grid/data-grid.test.tsx +++ b/packages/dashboard-ui-components/src/components/data-grid/data-grid.test.tsx @@ -611,60 +611,3 @@ describe("DataGrid horizontal scrolling", () => { expect((bodyScroll as HTMLElement).scrollLeft).toBe(120); }); }); - -describe("DataGrid loading skeleton", () => { - beforeEach(() => { - vi.stubGlobal("ResizeObserver", MockResizeObserver); - }); - - afterEach(() => { - cleanup(); - vi.restoreAllMocks(); - vi.unstubAllGlobals(); - }); - - it("shows a full-width shimmer when loading before any columns are known", () => { - function SchemaPendingHarness() { - const [state, setState] = useState(() => createDefaultDataGridState([])); - return ( - - columns={[]} - rows={[]} - getRowId={(row) => row.id} - state={state} - onChange={setState} - isLoading - /> - ); - } - - const { container } = render(); - - const skeleton = container.querySelector("[data-data-grid-schema-pending-skeleton]"); - expect(skeleton).toBeInstanceOf(HTMLElement); - // Five placeholder columns × 10 rows → visible shimmer cells, not an empty pane. - expect(skeleton?.querySelectorAll("[role='row']").length).toBe(10); - }); - - it("uses per-column skeleton rows once the schema is known", () => { - function KnownSchemaHarness() { - const [state, setState] = useState(() => createDefaultDataGridState(columns)); - return ( - - columns={columns} - rows={[]} - getRowId={(row) => row.id} - state={state} - onChange={setState} - isLoading - /> - ); - } - - const { container } = render(); - - expect(container.querySelector("[data-data-grid-schema-pending-skeleton]")).toBeNull(); - const rowsClip = container.querySelector("[data-data-grid-rows-clip]"); - expect(rowsClip?.querySelectorAll("[role='row']").length).toBe(8); - }); -});