From 85c55c99516972145605fd335b455f5e10380204 Mon Sep 17 00:00:00 2001 From: Rui Chen Date: Mon, 2 Dec 2024 03:51:29 -0500 Subject: [PATCH] fix: add missing explicit lifetime in `ExcelSubrange` return type for rust 1.83 build (#353) seeing some regression build failure when building roapi 0.12.0 against rust 1.83.0 ``` error: elided lifetime has a name --> columnq/src/table/excel.rs:48:10 | 41 | impl<'a> ExcelSubrange<'a> { | -- lifetime `'a` declared here ... 48 | ) -> ExcelSubrange { | ^^^^^^^^^^^^^ this elided lifetime gets resolved as `'a` | note: the lint level is defined here --> columnq/src/lib.rs:1:9 | 1 | #![deny(warnings)] | ^^^^^^^^ = note: `#[deny(elided_named_lifetimes)]` implied by `#[deny(warnings)]` ``` relates to https://github.com/Homebrew/homebrew-core/pull/199379 Signed-off-by: Rui Chen --- columnq/src/table/excel.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/columnq/src/table/excel.rs b/columnq/src/table/excel.rs index 00314eb..55b8d62 100644 --- a/columnq/src/table/excel.rs +++ b/columnq/src/table/excel.rs @@ -45,7 +45,7 @@ impl<'a> ExcelSubrange<'a> { rows_range_end: Option, columns_range_start: Option, columns_range_end: Option, - ) -> ExcelSubrange { + ) -> ExcelSubrange<'a> { let rows_range_start = rows_range_start.unwrap_or(usize::MIN); let rows_range_end = rows_range_end .or(range.end().map(|v| v.0 as usize))