Merge pull request #2599 from querydsl/oracle-tests

Run tests against Oracle

.github/workflows/ci.yml

@@ -23,7 +23,7 @@ jobs:
         target: [test-without-scala, test-scala, test-hibernate-5]
         include:
           - target: test-without-scala
-            containers: db2 mysql postgresql mongo sqlserver
+            containers: db2 mysql postgresql mongo sqlserver oracle
             maven-args: --activate-profiles all,travis,examples --projects !querydsl-scala
 
           - target: test-scala
@@ -31,7 +31,7 @@ jobs:
             maven-args: --activate-profiles all,travis --projects querydsl-scala --resume-from querydsl-scala
 
           - target: test-hibernate-5
-            containers: db2 mysql postgresql mongo sqlserver
+            containers: db2 mysql postgresql mongo sqlserver oracle
             maven-args: --activate-profiles jpa,hibernate5,travis,examples --projects !querydsl-jpa-codegen
 
     runs-on: ubuntu-latest

pom.xml

@@ -696,7 +696,6 @@
           com.querydsl.core.testutil.ReportingOnly,
 
           com.querydsl.core.testutil.Teradata,
-          com.querydsl.core.testutil.Oracle,
           com.querydsl.core.testutil.CUBRID,
           com.querydsl.core.testutil.Firebird
         </excludedGroups>

querydsl-jpa/src/test/java/com/querydsl/jpa/AbstractJPATest.java

@@ -1679,7 +1679,7 @@ public abstract class AbstractJPATest {
 
     @Test
     @NoEclipseLink @NoOpenJPA @NoBatooJPA
-    @ExcludeIn(SQLSERVER)
+    @ExcludeIn({ORACLE, SQLSERVER})
     public void test() {
         Cat kitten = savedCats.get(0);
         Cat noKitten = savedCats.get(savedCats.size() - 1);
@@ -1827,7 +1827,7 @@ public abstract class AbstractJPATest {
     }
 
     @Test
-    @ExcludeIn(DERBY)
+    @ExcludeIn({DERBY, ORACLE})
     public void byte_array() {
         QSimpleTypes simpleTypes = QSimpleTypes.simpleTypes;
         assertEquals(ImmutableList.of(), query().from(simpleTypes)

querydsl-jpa/src/test/resources/META-INF/persistence.xml

@@ -285,8 +285,8 @@
             <property name="hibernate.dialect" value="com.querydsl.jpa.support.QOracle10gDialect" />
             <property name="hibernate.connection.driver_class" value="oracle.jdbc.driver.OracleDriver" />
             <property name="hibernate.connection.url" value="jdbc:oracle:thin:@localhost:1521:xe" />
-            <property name="hibernate.connection.username" value="system" />
-            <property name="hibernate.connection.password" value="oracle" />
+            <property name="hibernate.connection.username" value="querydsl" />
+            <property name="hibernate.connection.password" value="querydsl" />
             <property name="hibernate.show_sql" value="true"/>
             <property name="hibernate.flushMode" value="FLUSH_AUTO" />
             <property name="hibernate.hbm2ddl.auto" value="update" />

querydsl-sql/src/test/java/com/querydsl/sql/Connections.java

@@ -126,7 +126,7 @@ public final class Connections {
     private static Connection getOracle() throws SQLException, ClassNotFoundException {
         Class.forName("oracle.jdbc.driver.OracleDriver");
         String url = "jdbc:oracle:thin:@localhost:1521:xe";
-        return DriverManager.getConnection(url, "system", "oracle");
+        return DriverManager.getConnection(url, "querydsl", "querydsl");
     }
 
     private static Connection getPostgreSQL() throws ClassNotFoundException, SQLException {

querydsl-sql/src/test/java/com/querydsl/sql/SelectBase.java

@@ -2119,7 +2119,7 @@ public class SelectBase extends AbstractBaseTest {
     }
 
     @Test
-    @ExcludeIn({DB2, DERBY, SQLSERVER})
+    @ExcludeIn({DB2, DERBY, ORACLE, SQLSERVER})
     public void groupConcat() {
         List<String> expected = ImmutableList.of("Mike,Mary", "Joe,Peter,Steve,Jim", "Jennifer,Helen,Daisy,Barbara");
         if (Connections.getTarget() == POSTGRESQL) {
@@ -2133,7 +2133,7 @@ public class SelectBase extends AbstractBaseTest {
     }
 
     @Test
-    @ExcludeIn({DB2, DERBY, SQLSERVER})
+    @ExcludeIn({DB2, DERBY, ORACLE, SQLSERVER})
     public void groupConcat2() {
         List<String> expected = ImmutableList.of("Mike-Mary", "Joe-Peter-Steve-Jim", "Jennifer-Helen-Daisy-Barbara");
         if (Connections.getTarget() == POSTGRESQL) {

travis/docker-compose.yml

@@ -32,9 +32,11 @@ services:
       - POSTGRES_DB=querydsl
 
   oracle:
-    image: wnameless/oracle-xe-11g:16.04
+    image: wnameless/oracle-xe-11g-r2:latest
     ports:
       - "1521:1521"
+    volumes:
+    - "../devops/sql-snippets/oracle.sql:/docker-entrypoint-initdb.d/oracle.sql"
 
   cubrid:
     image: lighthopper/cubrid:9.2.26.0004