From e6225de7487f6bb89b13ea973cd46b8270cbbc99 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timo=20Westk=C3=A4mper?= <timo.westkamper@mysema.com>
Date: Mon, 5 Jan 2009 13:10:25 +0000
Subject: [PATCH]

---
 .../com/mysema/query/collections/SimpleExprFactory.java   | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/querydsl-collections/src/main/java/com/mysema/query/collections/SimpleExprFactory.java b/querydsl-collections/src/main/java/com/mysema/query/collections/SimpleExprFactory.java
index 55868bc2c..22d6d43cc 100644
--- a/querydsl-collections/src/main/java/com/mysema/query/collections/SimpleExprFactory.java
+++ b/querydsl-collections/src/main/java/com/mysema/query/collections/SimpleExprFactory.java
@@ -29,6 +29,8 @@ class SimpleExprFactory implements ExprFactory {
     
     private long counter = 0;
     
+    private final PBoolean btrue = new PBoolean(md()), bfalse = new PBoolean(md());
+    
     private final ExtString strExt = new ExtString(PathMetadata.forVariable("str"));
     
     private final Map<Object,PBooleanArray> baToPath = new PathFactory<Object,PBooleanArray>(new Transformer<Object,PBooleanArray>(){
@@ -75,9 +77,7 @@ class SimpleExprFactory implements ExprFactory {
      * @see com.mysema.query.collections.ExprFactory#create(java.lang.Boolean)
      */
     public PBoolean create(Boolean arg){
-        // NOTE : we can't really cache Booleans, since there are only two values,
-        // but possibly more variables to be tracked
-        return new PBoolean(md());
+        return arg.booleanValue() ? btrue : bfalse;
     }
     
     /* (non-Javadoc)
@@ -126,7 +126,7 @@ class SimpleExprFactory implements ExprFactory {
     }
     
     private PathMetadata<String> md(){
-        return PathMetadata.forVariable("var"+String.valueOf(++counter));
+        return PathMetadata.forVariable("v"+String.valueOf(++counter));
     }
     
     private static class PathFactory<K,V> extends LazyMap<K,V>{