diff --git a/src/main/java/com/mysema/query/QueryBase.java b/src/main/java/com/mysema/query/QueryBase.java index 433572c02..d67ce67c5 100644 --- a/src/main/java/com/mysema/query/QueryBase.java +++ b/src/main/java/com/mysema/query/QueryBase.java @@ -25,7 +25,7 @@ public class QueryBase> implements Query { DEFAULT,IJ,LJ,J } - public class JoinExpression{ + public static class JoinExpression{ public final JoinType type; public final ExprEntity target; JoinExpression(JoinType type, ExprEntity target){ @@ -36,10 +36,10 @@ public class QueryBase> implements Query { } protected final List joins = new ArrayList(); - protected final List groupBy = new ArrayList(); + protected final List> groupBy = new ArrayList>(); protected final List having = new ArrayList(); - protected final List orderBy = new ArrayList(); - protected final List select = new ArrayList(); + protected final List> orderBy = new ArrayList>(); + protected final List> select = new ArrayList>(); protected final List where = new ArrayList(); protected void clear(){ @@ -50,7 +50,7 @@ public class QueryBase> implements Query { select.clear(); where.clear(); } - + public A from(ExprEntity... o) { for (ExprEntity expr : o){ joins.add(new JoinExpression(JoinType.DEFAULT,expr)); diff --git a/src/main/java/com/mysema/query/grammar/Types.java b/src/main/java/com/mysema/query/grammar/Types.java index eae36c0fe..36936dba8 100644 --- a/src/main/java/com/mysema/query/grammar/Types.java +++ b/src/main/java/com/mysema/query/grammar/Types.java @@ -90,6 +90,10 @@ public class Types { ExprBoolean lt(Expr right); } + public interface ExprString extends ExprComparable{ + + } + /** * Reference to an entity @@ -133,8 +137,7 @@ public class Types { implements ExprBoolean { public ExprBoolean and(ExprBoolean right) {return Grammar.and(this, right);} public ExprBoolean or(ExprBoolean right) {return Grammar.or(this, right);} - } - + } public enum Order{ ASC,DESC } @@ -202,7 +205,6 @@ public class Types { public static class PathEntityCollection extends Path> implements ExprEntity>{ PathEntityCollection(Class type, String p) { - // FIXME super(null, p); } public AliasCollection as(PathEntity to) { @@ -219,7 +221,7 @@ public class Types { } } - public static class PathString extends PathComparable{ + public static class PathString extends PathComparable implements ExprString{ public PathString(String p) { super(String.class, p); }