From cb2e6175421a458be8d91b0424baf41cdf6a381e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timo=20Westk=C3=A4mper?= <timo.westkamper@mysema.com>
Date: Thu, 8 Apr 2010 08:33:20 +0000
Subject: [PATCH] fixes based on Sonar reports

---
 src/main/java/com/mysema/codegen/EvaluatorFactory.java      | 3 +--
 src/main/java/com/mysema/codegen/MemFileSystemRegistry.java | 6 +++---
 src/main/java/com/mysema/codegen/MemJavaFileObject.java     | 6 +++---
 3 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/src/main/java/com/mysema/codegen/EvaluatorFactory.java b/src/main/java/com/mysema/codegen/EvaluatorFactory.java
index d68d575fa..314679813 100644
--- a/src/main/java/com/mysema/codegen/EvaluatorFactory.java
+++ b/src/main/java/com/mysema/codegen/EvaluatorFactory.java
@@ -54,8 +54,7 @@ public class EvaluatorFactory {
     }
 
     private void compile(String source, Class<?> projectionType,
-            String[] names, Class<?>[] types, String id) throws IOException,
-            UnsupportedEncodingException {
+            String[] names, Class<?>[] types, String id) throws IOException {
         // create source
         StringWriter writer = new StringWriter();
         JavaWriter javaw = new JavaWriter(writer);
diff --git a/src/main/java/com/mysema/codegen/MemFileSystemRegistry.java b/src/main/java/com/mysema/codegen/MemFileSystemRegistry.java
index 0a62977f6..1a079805c 100644
--- a/src/main/java/com/mysema/codegen/MemFileSystemRegistry.java
+++ b/src/main/java/com/mysema/codegen/MemFileSystemRegistry.java
@@ -17,7 +17,7 @@ import javax.tools.JavaFileManager;
  * @author tiwe
  *
  */
-public class MemFileSystemRegistry {
+public final class MemFileSystemRegistry {
     
     public static final MemFileSystemRegistry DEFAULT = new MemFileSystemRegistry();
     
@@ -31,9 +31,9 @@ public class MemFileSystemRegistry {
     
     private MemFileSystemRegistry() {
         String pkgName = MemFileSystemRegistry.class.getPackage().getName();
-        protocolName = pkgName.substring(pkgName.lastIndexOf(".") + 1);
+        protocolName = pkgName.substring(pkgName.lastIndexOf('.') + 1);
         String pkgs = System.getProperty("java.protocol.handler.pkgs");
-        String parentPackage = pkgName.substring(0,pkgName.lastIndexOf("."));
+        String parentPackage = pkgName.substring(0,pkgName.lastIndexOf('.'));
         pkgs = pkgs == null ? parentPackage : pkgs + "|" + parentPackage;
         System.setProperty("java.protocol.handler.pkgs",pkgs);
     }
diff --git a/src/main/java/com/mysema/codegen/MemJavaFileObject.java b/src/main/java/com/mysema/codegen/MemJavaFileObject.java
index a61f85993..510c6794e 100644
--- a/src/main/java/com/mysema/codegen/MemJavaFileObject.java
+++ b/src/main/java/com/mysema/codegen/MemJavaFileObject.java
@@ -34,7 +34,7 @@ public class MemJavaFileObject extends SimpleJavaFileObject {
     
     @Override
     public CharSequence getCharContent(boolean ignoreEncodingErrors)
-        throws IOException, IllegalStateException, UnsupportedOperationException {
+        throws IOException, UnsupportedOperationException {
         if(baos == null){
             throw new FileNotFoundException(name);
         }
@@ -51,7 +51,7 @@ public class MemJavaFileObject extends SimpleJavaFileObject {
     }
 
     @Override
-    public InputStream openInputStream() throws IOException, IllegalStateException, UnsupportedOperationException {
+    public InputStream openInputStream() throws IOException, UnsupportedOperationException {
         if(baos == null){
             throw new FileNotFoundException(name);
         }
@@ -59,7 +59,7 @@ public class MemJavaFileObject extends SimpleJavaFileObject {
     }
     
     @Override
-    public OutputStream openOutputStream() throws IOException, IllegalStateException, UnsupportedOperationException {
+    public OutputStream openOutputStream() throws IOException, UnsupportedOperationException {
         if (baos == null){
             baos = new ByteArrayOutputStream();
         }