From b403746f06668b255a94e764cdafe2a7664138ef Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timo=20Westk=C3=A4mper?= Date: Fri, 6 Mar 2015 23:59:05 +0200 Subject: [PATCH] Improve Scala usage --- .../com/querydsl/scala/Expressions.scala | 2 +- .../com/querydsl/scala/ManifestUtils.scala | 2 +- .../com/querydsl/scala/Projections.scala | 2 +- ...alizer.scala => ScalaBeanSerializer.scala} | 14 +- ...izer.scala => ScalaEntitySerializer.scala} | 12 +- .../com/querydsl/scala/TypeMappings.scala | 2 +- .../{Paths.scala => RelationalPathImpl.scala} | 2 +- ...rs.scala => ScalaMetaDataSerializer.scala} | 0 .../scala/CaseClassSerializerTest.scala | 8 +- .../com/querydsl/scala/CompileTestUtils.scala | 8 +- .../com/querydsl/scala/ExampleDomain.scala | 6 +- .../com/querydsl/scala/ExpressionTest.scala | 8 +- .../scala/GenericExporterJPATest.scala | 2 +- .../querydsl/scala/GenericExporterTest.scala | 2 +- .../scala/com/querydsl/scala/QPerson.scala | 13 +- .../com/querydsl/scala/QPersonTest.scala | 6 +- ...st.scala => ScalaBeanSerializerTest.scala} | 14 +- ....scala => ScalaEntitySerializerTest.scala} | 0 .../test/scala/com/querydsl/scala/Types.scala | 2 +- .../scala/com/querydsl/scala/ext/Types2.scala | 2 +- .../scala/sql/MetaDataExporterTest.scala | 168 +++++++++--------- .../scala/sql/MetaDataSerializerTest.scala | 12 +- .../src/test/scala/test/Employee.scala | 20 +-- .../src/test/scala/test/QEmployee.scala | 18 +- .../src/test/scala/test/QSurvey.scala | 16 +- .../src/test/scala/test/Survey.scala | 14 +- 26 files changed, 177 insertions(+), 178 deletions(-) rename querydsl-scala/src/main/scala/com/querydsl/scala/{BeanSerializer.scala => ScalaBeanSerializer.scala} (91%) rename querydsl-scala/src/main/scala/com/querydsl/scala/{EntitySerializer.scala => ScalaEntitySerializer.scala} (94%) rename querydsl-scala/src/main/scala/com/querydsl/scala/sql/{Paths.scala => RelationalPathImpl.scala} (99%) rename querydsl-scala/src/main/scala/com/querydsl/scala/sql/{Serializers.scala => ScalaMetaDataSerializer.scala} (100%) rename querydsl-scala/src/test/scala/com/querydsl/scala/{BeanSerializerTest.scala => ScalaBeanSerializerTest.scala} (87%) rename querydsl-scala/src/test/scala/com/querydsl/scala/{EntitySerializerTest.scala => ScalaEntitySerializerTest.scala} (100%) diff --git a/querydsl-scala/src/main/scala/com/querydsl/scala/Expressions.scala b/querydsl-scala/src/main/scala/com/querydsl/scala/Expressions.scala index b2c8a0bbb..5df8efa68 100644 --- a/querydsl-scala/src/main/scala/com/querydsl/scala/Expressions.scala +++ b/querydsl-scala/src/main/scala/com/querydsl/scala/Expressions.scala @@ -21,7 +21,7 @@ import com.querydsl.core.types.PathMetadataFactory._ import com.querydsl.core.types.Ops._ import java.util.Collection -import java.util.Arrays._; +import java.util.Arrays._ import Constants._ import Operations._ diff --git a/querydsl-scala/src/main/scala/com/querydsl/scala/ManifestUtils.scala b/querydsl-scala/src/main/scala/com/querydsl/scala/ManifestUtils.scala index ed47bec14..b64e379fc 100644 --- a/querydsl-scala/src/main/scala/com/querydsl/scala/ManifestUtils.scala +++ b/querydsl-scala/src/main/scala/com/querydsl/scala/ManifestUtils.scala @@ -20,6 +20,6 @@ package com.querydsl.scala */ object ManifestUtils { - implicit def toClass[X](mf: Manifest[X]) = mf.runtimeClass.asInstanceOf[Class[X]] + implicit def toClass[X](mf: Manifest[X]): Class[X] = mf.runtimeClass.asInstanceOf[Class[X]] } \ No newline at end of file diff --git a/querydsl-scala/src/main/scala/com/querydsl/scala/Projections.scala b/querydsl-scala/src/main/scala/com/querydsl/scala/Projections.scala index cff5669fb..50f5c27ea 100644 --- a/querydsl-scala/src/main/scala/com/querydsl/scala/Projections.scala +++ b/querydsl-scala/src/main/scala/com/querydsl/scala/Projections.scala @@ -374,7 +374,7 @@ abstract class FactoryExpressionBase[T](cl: Class[T], args: Ex[_]*) def accept[R,C](v: Visitor[R,C], context: C): R = v.visit(this, context) - def getArgs(): java.util.List[Ex[_]] = Arrays.asList(args:_*) + def getArgs: java.util.List[Ex[_]] = Arrays.asList(args:_*) def apply(i: Int): Ex[_] = args(i) diff --git a/querydsl-scala/src/main/scala/com/querydsl/scala/BeanSerializer.scala b/querydsl-scala/src/main/scala/com/querydsl/scala/ScalaBeanSerializer.scala similarity index 91% rename from querydsl-scala/src/main/scala/com/querydsl/scala/BeanSerializer.scala rename to querydsl-scala/src/main/scala/com/querydsl/scala/ScalaBeanSerializer.scala index fcc134002..3d00a37ba 100644 --- a/querydsl-scala/src/main/scala/com/querydsl/scala/BeanSerializer.scala +++ b/querydsl-scala/src/main/scala/com/querydsl/scala/ScalaBeanSerializer.scala @@ -24,7 +24,7 @@ import javax.inject.Inject import java.util._ import java.io.IOException -import scala.reflect.BeanProperty +import scala.beans.BeanProperty import scala.collection.JavaConversions._ import scala.collection.mutable.Set @@ -48,8 +48,8 @@ object Serializer { def writeImports(model: EntityType, javaBeanSupport: Boolean, writer: ScalaWriter) { val importedClasses = getAnnotationTypes(model) if (javaBeanSupport) importedClasses.add("scala.reflect.BeanProperty") - if (model.hasLists()) importedClasses.add(classOf[List[_]].getName) - if (model.hasMaps()) importedClasses.add(classOf[Map[_, _]].getName) + if (model.hasLists) importedClasses.add(classOf[List[_]].getName) + if (model.hasMaps) importedClasses.add(classOf[Map[_, _]].getName) writer.importClasses(importedClasses.toArray: _*) } @@ -105,12 +105,12 @@ class ScalaBeanSerializer @Inject() (typeMappings: TypeMappings) extends Seriali def writeClass(model: EntityType, writer: ScalaWriter) = { writer.javadoc(model.getSimpleName + javadocSuffix) - model.getAnnotations foreach(writer.annotation(_)) + model.getAnnotations foreach(writer.annotation) writer.beginClass(model) for (property <- model.getProperties) { - property.getAnnotations.foreach(writer.annotation(_)) + property.getAnnotations.foreach(writer.annotation) if (javaBeanSupport) writer.line("@BeanProperty") - writer.publicField(property.getType(), property.getEscapedName, "_") + writer.publicField(property.getType, property.getEscapedName, "_") } writer.end() } @@ -139,7 +139,7 @@ class CaseClassSerializer @Inject() (typeMappings: TypeMappings) extends Seriali } def writeClass(model: EntityType, writer: ScalaWriter) = { - model.getAnnotations foreach (writer.annotation(_)) + model.getAnnotations foreach writer.annotation val parameters = model.getProperties .map(p => new Parameter(p.getEscapedName, p.getType)).toArray writer.caseClass(model.getSimpleName, parameters:_*) diff --git a/querydsl-scala/src/main/scala/com/querydsl/scala/EntitySerializer.scala b/querydsl-scala/src/main/scala/com/querydsl/scala/ScalaEntitySerializer.scala similarity index 94% rename from querydsl-scala/src/main/scala/com/querydsl/scala/EntitySerializer.scala rename to querydsl-scala/src/main/scala/com/querydsl/scala/ScalaEntitySerializer.scala index 5ec2b9e7a..ea737231f 100644 --- a/querydsl-scala/src/main/scala/com/querydsl/scala/EntitySerializer.scala +++ b/querydsl-scala/src/main/scala/com/querydsl/scala/ScalaEntitySerializer.scala @@ -26,7 +26,7 @@ import com.querydsl.sql.codegen.support._ import com.querydsl.core.types._ import java.util._ import java.io.IOException -import scala.reflect.BeanProperty +import scala.beans.BeanProperty import scala.collection.JavaConversions._ import scala.collection.mutable.Set import scala.collection.immutable.Map @@ -57,15 +57,15 @@ class ScalaEntitySerializer @Inject()(val typeMappings: TypeMappings) extends Se val simpleName: String = model.getSimpleName // package - if (!model.getPackageName.isEmpty()) writer.packageDecl(model.getPackageName) + if (!model.getPackageName.isEmpty) writer.packageDecl(model.getPackageName) // imports writer.importPackages("com.querydsl.core.types","com.querydsl.scala") writer.staticimports(classOf[PathMetadataFactory]) var importedClasses = getAnnotationTypes(model) - if (model.hasLists()) importedClasses.add(classOf[java.util.List[_]].getName) - if (model.hasMaps()) importedClasses.add(classOf[java.util.Map[_, _]].getName) + if (model.hasLists) importedClasses.add(classOf[java.util.List[_]].getName) + if (model.hasMaps) importedClasses.add(classOf[java.util.Map[_, _]].getName) writer.importClasses(importedClasses.toArray: _*) writeHeader(model, scalaWriter) @@ -121,7 +121,7 @@ class ScalaEntitySerializer @Inject()(val typeMappings: TypeMappings) extends Se } def writeAnnotations(model: EntityType, queryType: Type, writer: ScalaWriter) = { - model.getAnnotations.foreach(writer.annotation(_)) + model.getAnnotations.foreach(writer.annotation) } def writeAdditionalCompanionContent(model: EntityType, writer: ScalaWriter) = {} @@ -194,7 +194,7 @@ class ScalaEntitySerializer @Inject()(val typeMappings: TypeMappings) extends Se } def getAnnotationTypes(model: EntityType): Set[String] = { - Set() ++ (model.getAnnotations.map(_.annotationType.getName)) + Set() ++ model.getAnnotations.map(_.annotationType.getName) } private def getRaw(t : Type): Type = { diff --git a/querydsl-scala/src/main/scala/com/querydsl/scala/TypeMappings.scala b/querydsl-scala/src/main/scala/com/querydsl/scala/TypeMappings.scala index 903c8d19a..c9ba1fde5 100644 --- a/querydsl-scala/src/main/scala/com/querydsl/scala/TypeMappings.scala +++ b/querydsl-scala/src/main/scala/com/querydsl/scala/TypeMappings.scala @@ -27,7 +27,7 @@ import com.querydsl.core.types.Path */ object ScalaTypeMappings { - def create: TypeMappings = new ScalaTypeMappings(); + def create: TypeMappings = new ScalaTypeMappings() } diff --git a/querydsl-scala/src/main/scala/com/querydsl/scala/sql/Paths.scala b/querydsl-scala/src/main/scala/com/querydsl/scala/sql/RelationalPathImpl.scala similarity index 99% rename from querydsl-scala/src/main/scala/com/querydsl/scala/sql/Paths.scala rename to querydsl-scala/src/main/scala/com/querydsl/scala/sql/RelationalPathImpl.scala index 3404ad6cf..474076db9 100644 --- a/querydsl-scala/src/main/scala/com/querydsl/scala/sql/Paths.scala +++ b/querydsl-scala/src/main/scala/com/querydsl/scala/sql/RelationalPathImpl.scala @@ -24,7 +24,7 @@ import com.querydsl.core.types._ import com.querydsl.core.types.PathMetadataFactory._ import java.util.{List => JavaList, ArrayList, Map => JavaMap, HashMap} import java.lang.reflect._ -import scala.reflect.BeanProperty +import scala.beans.BeanProperty /** * Implementation of RelationalPath for Scala diff --git a/querydsl-scala/src/main/scala/com/querydsl/scala/sql/Serializers.scala b/querydsl-scala/src/main/scala/com/querydsl/scala/sql/ScalaMetaDataSerializer.scala similarity index 100% rename from querydsl-scala/src/main/scala/com/querydsl/scala/sql/Serializers.scala rename to querydsl-scala/src/main/scala/com/querydsl/scala/sql/ScalaMetaDataSerializer.scala diff --git a/querydsl-scala/src/test/scala/com/querydsl/scala/CaseClassSerializerTest.scala b/querydsl-scala/src/test/scala/com/querydsl/scala/CaseClassSerializerTest.scala index 6c2a2daab..61afa7662 100644 --- a/querydsl-scala/src/test/scala/com/querydsl/scala/CaseClassSerializerTest.scala +++ b/querydsl-scala/src/test/scala/com/querydsl/scala/CaseClassSerializerTest.scala @@ -1,10 +1,10 @@ package com.querydsl.scala -import com.mysema.codegen._; -import com.mysema.codegen.model._; -import com.querydsl.codegen._; +import com.mysema.codegen._ +import com.mysema.codegen.model._ +import com.querydsl.codegen._ -import java.io.StringWriter; +import java.io.StringWriter import org.junit._ import org.junit.Assert._ diff --git a/querydsl-scala/src/test/scala/com/querydsl/scala/CompileTestUtils.scala b/querydsl-scala/src/test/scala/com/querydsl/scala/CompileTestUtils.scala index 5af461de3..387c0880b 100644 --- a/querydsl-scala/src/test/scala/com/querydsl/scala/CompileTestUtils.scala +++ b/querydsl-scala/src/test/scala/com/querydsl/scala/CompileTestUtils.scala @@ -16,7 +16,7 @@ trait CompileTestUtils { Class.forName(className).getProtectionDomain.getCodeSource.getLocation } - val currentLibraries = (this.getClass.getClassLoader).asInstanceOf[java.net.URLClassLoader].getURLs().toList + val currentLibraries = this.getClass.getClassLoader.asInstanceOf[java.net.URLClassLoader].getURLs.toList val cp = jarPathOfClass("scala.tools.nsc.Interpreter") :: jarPathOfClass("scala.ScalaObject") :: currentLibraries classpath.value = cp.mkString(pathSeparator) @@ -40,14 +40,14 @@ trait CompileTestUtils { throw new AssertionError("Compile failed, interpreter output:\n" + out.toString("utf-8")) } } finally { - interpreterWriter.close - interpreter.close + interpreterWriter.close() + interpreter.close() } } def recursiveFileList(file: File): Array[File] = { if (file.isDirectory) { - file.listFiles.flatMap(recursiveFileList(_)) + file.listFiles.flatMap(recursiveFileList) } else { Array(file) } diff --git a/querydsl-scala/src/test/scala/com/querydsl/scala/ExampleDomain.scala b/querydsl-scala/src/test/scala/com/querydsl/scala/ExampleDomain.scala index 5f419d30a..e94a5f3c7 100644 --- a/querydsl-scala/src/test/scala/com/querydsl/scala/ExampleDomain.scala +++ b/querydsl-scala/src/test/scala/com/querydsl/scala/ExampleDomain.scala @@ -1,7 +1,7 @@ -package com.querydsl.scala; +package com.querydsl.scala -import com.querydsl.core.types._; -import com.querydsl.core.types.PathMetadataFactory._; +import com.querydsl.core.types._ +import com.querydsl.core.types.PathMetadataFactory._ class Person { var scalaInt: Int = _ diff --git a/querydsl-scala/src/test/scala/com/querydsl/scala/ExpressionTest.scala b/querydsl-scala/src/test/scala/com/querydsl/scala/ExpressionTest.scala index 819cdd0fc..034943d07 100644 --- a/querydsl-scala/src/test/scala/com/querydsl/scala/ExpressionTest.scala +++ b/querydsl-scala/src/test/scala/com/querydsl/scala/ExpressionTest.scala @@ -1,8 +1,8 @@ -package com.querydsl.scala; +package com.querydsl.scala -import com.querydsl.core.types._; +import com.querydsl.core.types._ -import org.junit.{ Test, Before, After, Assert }; +import org.junit.{ Test, Before, After, Assert } import Matchers._ @@ -16,7 +16,7 @@ class ExpressionTest { @Test def Double_Negation { - assertEquals("person.javaInt", person.javaInt.negate.negate); + assertEquals("person.javaInt", person.javaInt.negate.negate) } @Test diff --git a/querydsl-scala/src/test/scala/com/querydsl/scala/GenericExporterJPATest.scala b/querydsl-scala/src/test/scala/com/querydsl/scala/GenericExporterJPATest.scala index 53b7473dc..535a82245 100644 --- a/querydsl-scala/src/test/scala/com/querydsl/scala/GenericExporterJPATest.scala +++ b/querydsl-scala/src/test/scala/com/querydsl/scala/GenericExporterJPATest.scala @@ -1,4 +1,4 @@ -package com.querydsl.scala; +package com.querydsl.scala import javax.persistence._ import com.querydsl.codegen.GenericExporter diff --git a/querydsl-scala/src/test/scala/com/querydsl/scala/GenericExporterTest.scala b/querydsl-scala/src/test/scala/com/querydsl/scala/GenericExporterTest.scala index 56fc3a5d8..42dc5e6a2 100644 --- a/querydsl-scala/src/test/scala/com/querydsl/scala/GenericExporterTest.scala +++ b/querydsl-scala/src/test/scala/com/querydsl/scala/GenericExporterTest.scala @@ -1,4 +1,4 @@ -package com.querydsl.scala; +package com.querydsl.scala import com.querydsl.core.annotations._ import com.querydsl.codegen.GenericExporter diff --git a/querydsl-scala/src/test/scala/com/querydsl/scala/QPerson.scala b/querydsl-scala/src/test/scala/com/querydsl/scala/QPerson.scala index f9a2d04ef..d589229f1 100644 --- a/querydsl-scala/src/test/scala/com/querydsl/scala/QPerson.scala +++ b/querydsl-scala/src/test/scala/com/querydsl/scala/QPerson.scala @@ -1,11 +1,10 @@ -package com.querydsl.scala; +package com.querydsl.scala -import com.querydsl.core.types._; -import com.querydsl.scala._; - -import com.querydsl.core.types.PathMetadataFactory._; -import java.util.List; -import java.util.Map; +import com.querydsl.core.types._ +import com.querydsl.scala._ +import com.querydsl.core.types.PathMetadataFactory._ +import java.util.List +import java.util.Map object QPerson extends QPerson("person"){ override def as(variable: String) = new QPerson(variable) diff --git a/querydsl-scala/src/test/scala/com/querydsl/scala/QPersonTest.scala b/querydsl-scala/src/test/scala/com/querydsl/scala/QPersonTest.scala index 33d3b4d5f..4bc704d55 100644 --- a/querydsl-scala/src/test/scala/com/querydsl/scala/QPersonTest.scala +++ b/querydsl-scala/src/test/scala/com/querydsl/scala/QPersonTest.scala @@ -1,8 +1,8 @@ -package com.querydsl.scala; +package com.querydsl.scala -import com.querydsl.core.types._; +import com.querydsl.core.types._ -import org.junit.{ Test, Before, After, Assert }; +import org.junit.{ Test, Before, After, Assert } import Matchers._ diff --git a/querydsl-scala/src/test/scala/com/querydsl/scala/BeanSerializerTest.scala b/querydsl-scala/src/test/scala/com/querydsl/scala/ScalaBeanSerializerTest.scala similarity index 87% rename from querydsl-scala/src/test/scala/com/querydsl/scala/BeanSerializerTest.scala rename to querydsl-scala/src/test/scala/com/querydsl/scala/ScalaBeanSerializerTest.scala index d0e111cd5..840c23b0b 100644 --- a/querydsl-scala/src/test/scala/com/querydsl/scala/BeanSerializerTest.scala +++ b/querydsl-scala/src/test/scala/com/querydsl/scala/ScalaBeanSerializerTest.scala @@ -1,10 +1,10 @@ package com.querydsl.scala -import com.mysema.codegen._; -import com.mysema.codegen.model._; -import com.querydsl.codegen._; +import com.mysema.codegen._ +import com.mysema.codegen.model._ +import com.querydsl.codegen._ -import java.io.StringWriter; +import java.io.StringWriter import org.junit._ import org.junit.Assert._ @@ -47,11 +47,11 @@ class ScalaBeanSerializerTest extends CompileTestUtils { @BeanProperty var setField: java.util.Set[DomainClass] = _ @BeanProperty var time: java.sql.Time = _""" - val str = writer.toString().replaceAll("\\s+", " ") + val str = writer.toString.replaceAll("\\s+", " ") //println(str) toMatch.split("\\n").map(_.trim).foreach { line => - assertTrue(line, str.contains(line)); + assertTrue(line, str.contains(line)) } } @@ -62,7 +62,7 @@ class ScalaBeanSerializerTest extends CompileTestUtils { serializer.createCompanionObject = false typeMappings.register(entityType, new QueryTypeFactoryImpl("Q", "", "").create(entityType)) serializer.serialize(entityType, SimpleSerializerConfig.DEFAULT, new ScalaWriter(writer)) - val str = writer.toString() + val str = writer.toString assertCompileSuccess(str) } } \ No newline at end of file diff --git a/querydsl-scala/src/test/scala/com/querydsl/scala/EntitySerializerTest.scala b/querydsl-scala/src/test/scala/com/querydsl/scala/ScalaEntitySerializerTest.scala similarity index 100% rename from querydsl-scala/src/test/scala/com/querydsl/scala/EntitySerializerTest.scala rename to querydsl-scala/src/test/scala/com/querydsl/scala/ScalaEntitySerializerTest.scala diff --git a/querydsl-scala/src/test/scala/com/querydsl/scala/Types.scala b/querydsl-scala/src/test/scala/com/querydsl/scala/Types.scala index 0de84ccee..35389a318 100644 --- a/querydsl-scala/src/test/scala/com/querydsl/scala/Types.scala +++ b/querydsl-scala/src/test/scala/com/querydsl/scala/Types.scala @@ -1,4 +1,4 @@ -package com.querydsl.scala; +package com.querydsl.scala import com.querydsl.core.annotations._ diff --git a/querydsl-scala/src/test/scala/com/querydsl/scala/ext/Types2.scala b/querydsl-scala/src/test/scala/com/querydsl/scala/ext/Types2.scala index 1f7c6e5d8..deb0a2bf1 100644 --- a/querydsl-scala/src/test/scala/com/querydsl/scala/ext/Types2.scala +++ b/querydsl-scala/src/test/scala/com/querydsl/scala/ext/Types2.scala @@ -1,4 +1,4 @@ -package com.querydsl.scala.ext; +package com.querydsl.scala.ext import com.querydsl.core.annotations._ import scala.runtime.RichChar diff --git a/querydsl-scala/src/test/scala/com/querydsl/scala/sql/MetaDataExporterTest.scala b/querydsl-scala/src/test/scala/com/querydsl/scala/sql/MetaDataExporterTest.scala index 1642e69aa..49e5e2721 100644 --- a/querydsl-scala/src/test/scala/com/querydsl/scala/sql/MetaDataExporterTest.scala +++ b/querydsl-scala/src/test/scala/com/querydsl/scala/sql/MetaDataExporterTest.scala @@ -7,7 +7,7 @@ import com.querydsl.codegen._ import com.querydsl.sql._ import com.querydsl.sql.codegen._ -import java.io.StringWriter; +import java.io.StringWriter import org.junit._ import org.junit.Assert._ @@ -18,124 +18,124 @@ import com.querydsl.scala._ class MetaDataExporterTest extends CompileTestUtils { - var connection: java.sql.Connection = _; + var connection: java.sql.Connection = _ @Before def setUp() { - Class.forName("org.h2.Driver"); - val url = "jdbc:h2:mem:testdb" + System.currentTimeMillis(); - connection = java.sql.DriverManager.getConnection(url, "sa", ""); + Class.forName("org.h2.Driver") + val url = "jdbc:h2:mem:testdb" + System.currentTimeMillis() + connection = java.sql.DriverManager.getConnection(url, "sa", "") - val stmt = connection.createStatement(); + val stmt = connection.createStatement() + + try { + stmt.execute("create table reserved (id int, while int)") + stmt.execute("create table underscore (e_id int, c_id int)") + stmt.execute("create table beangen1 (\"SEP_Order\" int)") + stmt.execute("create table definstance (id int, definstance int, definstance1 int)") + stmt.execute("create table pkfk (id int primary key, pk int, fk int)") + stmt.execute("create table \"camelCase\" (id int)") + stmt.execute("create table \"vwServiceName\" (id int)") + stmt.execute("create table date_test (d date)") + stmt.execute("create table date_time_test (dt datetime)") + stmt.execute("create table survey (id int, name varchar(30))") + stmt.execute("create table typetest (type int, constraint pk_typetest primary key(type))") - try{ - stmt.execute("create table reserved (id int, while int)"); - stmt.execute("create table underscore (e_id int, c_id int)"); - stmt.execute("create table beangen1 (\"SEP_Order\" int)"); - stmt.execute("create table definstance (id int, definstance int, definstance1 int)"); - stmt.execute("create table pkfk (id int primary key, pk int, fk int)"); - stmt.execute("create table \"camelCase\" (id int)"); - stmt.execute("create table \"vwServiceName\" (id int)"); - stmt.execute("create table date_test (d date)"); - stmt.execute("create table date_time_test (dt datetime)"); - stmt.execute("create table survey (id int, name varchar(30))"); - stmt.execute("create table typetest (type int, constraint pk_typetest primary key(type))"); - stmt.execute("""create table employee( - id INT, firstname VARCHAR(50), lastname VARCHAR(50), salary DECIMAL(10, 2), - datefield DATE, timefield TIME, - superior_id int, survey_id int, survey_name varchar(30), - CONSTRAINT PK_employee PRIMARY KEY (id), - CONSTRAINT FK_superior FOREIGN KEY (superior_id) REFERENCES employee(id))"""); - - + id INT, firstname VARCHAR(50), lastname VARCHAR(50), salary DECIMAL(10, 2), + datefield DATE, timefield TIME, + superior_id int, survey_id int, survey_name varchar(30), + CONSTRAINT PK_employee PRIMARY KEY (id), + CONSTRAINT FK_superior FOREIGN KEY (superior_id) REFERENCES employee(id))""") + + // table with count column - stmt.execute("create table count_table(count int)"); - + stmt.execute("create table count_table(count int)") + // multi primary key stmt.execute("create table multikey(id INT, id2 VARCHAR, id3 INT," + - " CONSTRAINT pk_multikey PRIMARY KEY (id, id2, id3) )"); - + " CONSTRAINT pk_multikey PRIMARY KEY (id, id2, id3) )") + // multi foreign key stmt.execute("create table multikey2(id INT, id2 INT, id3 INT, id4 INT, id5 INT, id6 INT," + - " CONSTRAINT pk_multikey2 FOREIGN KEY (id4, id5, id6) REFERENCES multikey2(id, id2, id3) )"); + " CONSTRAINT pk_multikey2 FOREIGN KEY (id4, id5, id6) REFERENCES multikey2(id, id2, id3) )") } finally { - stmt.close(); + stmt.close() } } @Test def Generate_Without_BeanTypes() { - val directory = new java.io.File("target/jdbcgen1"); - val namingStrategy = new DefaultNamingStrategy(); - val exporter = new MetaDataExporter(); - exporter.setNamePrefix("Q"); - exporter.setPackageName("com.querydsl"); - exporter.setSchemaPattern("PUBLIC"); - exporter.setTargetFolder(directory); - exporter.setSerializerClass(classOf[ScalaMetaDataSerializer]); - exporter.setCreateScalaSources(true); - exporter.setTypeMappings(ScalaTypeMappings.create); - exporter.export(connection.getMetaData); + val directory = new java.io.File("target/jdbcgen1") + val namingStrategy = new DefaultNamingStrategy() + val exporter = new MetaDataExporter() + exporter.setNamePrefix("Q") + exporter.setPackageName("com.querydsl") + exporter.setSchemaPattern("PUBLIC") + exporter.setTargetFolder(directory) + exporter.setSerializerClass(classOf[ScalaMetaDataSerializer]) + exporter.setCreateScalaSources(true) + exporter.setTypeMappings(ScalaTypeMappings.create) + exporter.export(connection.getMetaData) assertCompileSuccess(recursiveFileList(directory)) } @Test def Generate_With_BeanTypes() { - val directory = new java.io.File("target/jdbcgen2"); - val namingStrategy = new DefaultNamingStrategy(); - //val beanSerializer = new ScalaBeanSerializer(); - val exporter = new MetaDataExporter(); - exporter.setNamePrefix("Q"); - exporter.setPackageName("com.querydsl"); - exporter.setSchemaPattern("PUBLIC"); - exporter.setTargetFolder(directory); - exporter.setSerializerClass(classOf[ScalaMetaDataSerializer]); - exporter.setBeanSerializerClass(classOf[ScalaBeanSerializer]); - exporter.setCreateScalaSources(true); - exporter.setTypeMappings(ScalaTypeMappings.create); - exporter.export(connection.getMetaData); + val directory = new java.io.File("target/jdbcgen2") + val namingStrategy = new DefaultNamingStrategy() + //val beanSerializer = new ScalaBeanSerializer() + val exporter = new MetaDataExporter() + exporter.setNamePrefix("Q") + exporter.setPackageName("com.querydsl") + exporter.setSchemaPattern("PUBLIC") + exporter.setTargetFolder(directory) + exporter.setSerializerClass(classOf[ScalaMetaDataSerializer]) + exporter.setBeanSerializerClass(classOf[ScalaBeanSerializer]) + exporter.setCreateScalaSources(true) + exporter.setTypeMappings(ScalaTypeMappings.create) + exporter.export(connection.getMetaData) assertCompileSuccess(recursiveFileList(directory)) } @Test def Generate_With_Schema() { - val directory = new java.io.File("target/jdbcgen3"); - val namingStrategy = new DefaultNamingStrategy(); - //val beanSerializer = new ScalaBeanSerializer(); - val exporter = new MetaDataExporter(); - exporter.setNamePrefix("Q"); - exporter.setPackageName("com.querydsl"); - exporter.setSchemaPattern("PUBLIC"); - exporter.setSchemaToPackage(true); - exporter.setTargetFolder(directory); - exporter.setSerializerClass(classOf[ScalaMetaDataSerializer]); - exporter.setCreateScalaSources(true); - exporter.setTypeMappings(ScalaTypeMappings.create); - exporter.export(connection.getMetaData); - + val directory = new java.io.File("target/jdbcgen3") + val namingStrategy = new DefaultNamingStrategy() + //val beanSerializer = new ScalaBeanSerializer() + val exporter = new MetaDataExporter() + exporter.setNamePrefix("Q") + exporter.setPackageName("com.querydsl") + exporter.setSchemaPattern("PUBLIC") + exporter.setSchemaToPackage(true) + exporter.setTargetFolder(directory) + exporter.setSerializerClass(classOf[ScalaMetaDataSerializer]) + exporter.setCreateScalaSources(true) + exporter.setTypeMappings(ScalaTypeMappings.create) + exporter.export(connection.getMetaData) + assertCompileSuccess(recursiveFileList(directory)) } @Test def Generate_With_BeanTypes_And_Schema() { - val directory = new java.io.File("target/jdbcgen4"); - val namingStrategy = new DefaultNamingStrategy(); - //val beanSerializer = new ScalaBeanSerializer(); - val exporter = new MetaDataExporter(); - exporter.setNamePrefix("Q"); - exporter.setPackageName("com.querydsl"); - exporter.setSchemaPattern("PUBLIC"); - exporter.setSchemaToPackage(true); - exporter.setTargetFolder(directory); - exporter.setSerializerClass(classOf[ScalaMetaDataSerializer]); - exporter.setBeanSerializerClass(classOf[ScalaBeanSerializer]); - exporter.setCreateScalaSources(true); - exporter.setTypeMappings(ScalaTypeMappings.create); - exporter.export(connection.getMetaData); + val directory = new java.io.File("target/jdbcgen4") + val namingStrategy = new DefaultNamingStrategy() + //val beanSerializer = new ScalaBeanSerializer() + val exporter = new MetaDataExporter() + exporter.setNamePrefix("Q") + exporter.setPackageName("com.querydsl") + exporter.setSchemaPattern("PUBLIC") + exporter.setSchemaToPackage(true) + exporter.setTargetFolder(directory) + exporter.setSerializerClass(classOf[ScalaMetaDataSerializer]) + exporter.setBeanSerializerClass(classOf[ScalaBeanSerializer]) + exporter.setCreateScalaSources(true) + exporter.setTypeMappings(ScalaTypeMappings.create) + exporter.export(connection.getMetaData) assertCompileSuccess(recursiveFileList(directory)) } diff --git a/querydsl-scala/src/test/scala/com/querydsl/scala/sql/MetaDataSerializerTest.scala b/querydsl-scala/src/test/scala/com/querydsl/scala/sql/MetaDataSerializerTest.scala index c2cb8c04e..2911c4ac4 100644 --- a/querydsl-scala/src/test/scala/com/querydsl/scala/sql/MetaDataSerializerTest.scala +++ b/querydsl-scala/src/test/scala/com/querydsl/scala/sql/MetaDataSerializerTest.scala @@ -1,13 +1,13 @@ package com.querydsl.scala.sql -import com.mysema.codegen._; -import com.mysema.codegen.model._; +import com.mysema.codegen._ +import com.mysema.codegen.model._ -import com.querydsl.codegen._; +import com.querydsl.codegen._ import com.querydsl.sql._ import com.querydsl.sql.codegen._ -import java.io.StringWriter; +import java.io.StringWriter import org.junit._ import org.junit.Assert._ @@ -29,7 +29,7 @@ class ScalaMetaDataSerializerTest { "com.querydsl.DomainClass", "com.querydsl", "DomainClass", false, false) entityType = new EntityType(typeModel) //entityType.addAnnotation(new TableImpl("DOMAIN_TYPE")) - entityType.getData().put("table", "DOMAIN_TYPE") + entityType.getData.put("table", "DOMAIN_TYPE") // properties List(classOf[java.lang.Boolean], classOf[Comparable[_]], classOf[Integer], @@ -49,7 +49,7 @@ class ScalaMetaDataSerializerTest { val namingStrategy = new DefaultNamingStrategy() val serializer = new ScalaMetaDataSerializer(typeMappings, namingStrategy) serializer.serialize(entityType, SimpleSerializerConfig.DEFAULT, new ScalaWriter(writer)) - val str = writer.toString() + val str = writer.toString //System.err.println(str) assertTrue("companion object isn't before class", str.indexOf("object") < str.indexOf("class")) //assertTrue("companion object isn't before annotations", str.indexOf("object") < str.indexOf("@Table")) diff --git a/querydsl-scala/src/test/scala/test/Employee.scala b/querydsl-scala/src/test/scala/test/Employee.scala index 9f00f6b57..df156c777 100644 --- a/querydsl-scala/src/test/scala/test/Employee.scala +++ b/querydsl-scala/src/test/scala/test/Employee.scala @@ -1,24 +1,24 @@ -package test; +package test -import scala.reflect.BeanProperty; -import javax.validation.constraints.Size; -import javax.validation.constraints.NotNull; -import com.querydsl.sql._; +import scala.beans.BeanProperty +import javax.validation.constraints.Size +import javax.validation.constraints.NotNull +import com.querydsl.sql._ -object Employee extends QEmployee("employee"){ +object Employee extends QEmployee("employee") { override def as(variable: String) = new QEmployee(variable) } class Employee { - var firstname: String = _; + var firstname: String = _ - var id: Integer = _; + var id: Integer = _ - var lastname: String = _; + var lastname: String = _ - var superiorId: Integer = _; + var superiorId: Integer = _ } diff --git a/querydsl-scala/src/test/scala/test/QEmployee.scala b/querydsl-scala/src/test/scala/test/QEmployee.scala index 7194fb6ea..ce2a45578 100644 --- a/querydsl-scala/src/test/scala/test/QEmployee.scala +++ b/querydsl-scala/src/test/scala/test/QEmployee.scala @@ -1,13 +1,13 @@ -package test; +package test -import com.querydsl.core.types._; -import com.querydsl.scala._; +import com.querydsl.core.types._ +import com.querydsl.scala._ -import com.querydsl.core.types.PathMetadataFactory._; +import com.querydsl.core.types.PathMetadataFactory._ -import com.querydsl.scala.sql.RelationalPathImpl; +import com.querydsl.scala.sql.RelationalPathImpl -import com.querydsl.sql._; +import com.querydsl.sql._ object QEmployee extends QEmployee("employee"){ override def as(variable: String) = new QEmployee(variable) @@ -27,11 +27,11 @@ class QEmployee(md: PathMetadata) extends RelationalPathImpl[Employee](md, "PUBL val superiorId = createNumber[Integer]("superiorId") - val sysIdx55: PrimaryKey[Employee] = createPrimaryKey(id); + val sysIdx55: PrimaryKey[Employee] = createPrimaryKey(id) - val superiorFk: ForeignKey[Employee] = createForeignKey(superiorId, "ID"); + val superiorFk: ForeignKey[Employee] = createForeignKey(superiorId, "ID") - val _superiorFk: ForeignKey[Employee] = createInvForeignKey(id, "SUPERIOR_ID"); + val _superiorFk: ForeignKey[Employee] = createInvForeignKey(id, "SUPERIOR_ID") addMetadata(firstname, ColumnMetadata.named("FIRSTNAME")) addMetadata(id, ColumnMetadata.named("ID")) diff --git a/querydsl-scala/src/test/scala/test/QSurvey.scala b/querydsl-scala/src/test/scala/test/QSurvey.scala index c042b77c7..21e302257 100644 --- a/querydsl-scala/src/test/scala/test/QSurvey.scala +++ b/querydsl-scala/src/test/scala/test/QSurvey.scala @@ -1,14 +1,14 @@ -package test; +package test -import com.querydsl.core.types._; -import com.querydsl.scala._; +import com.querydsl.core.types._ +import com.querydsl.scala._ -import com.querydsl.core.types.PathMetadataFactory._; -import com.querydsl.scala.sql.RelationalPathImpl; +import com.querydsl.core.types.PathMetadataFactory._ +import com.querydsl.scala.sql.RelationalPathImpl -import com.querydsl.sql._; +import com.querydsl.sql._ -object QSurvey extends QSurvey("survey"){ +object QSurvey extends QSurvey("survey") { override def as(variable: String) = new QSurvey(variable) } @@ -22,7 +22,7 @@ class QSurvey(md: PathMetadata) extends RelationalPathImpl[Survey](md, "PUBLIC", val name = createString("name") - val sysIdx54: PrimaryKey[Survey] = createPrimaryKey(id); + val sysIdx54: PrimaryKey[Survey] = createPrimaryKey(id) addMetadata(id, ColumnMetadata.named("ID")) addMetadata(name, ColumnMetadata.named("NAME")) diff --git a/querydsl-scala/src/test/scala/test/Survey.scala b/querydsl-scala/src/test/scala/test/Survey.scala index 92c7742ca..1dce1e5c5 100644 --- a/querydsl-scala/src/test/scala/test/Survey.scala +++ b/querydsl-scala/src/test/scala/test/Survey.scala @@ -1,9 +1,9 @@ -package test; +package test -import scala.reflect.BeanProperty; -import javax.validation.constraints.Size; -import javax.validation.constraints.NotNull; -import com.querydsl.sql._; +import scala.beans.BeanProperty +import javax.validation.constraints.Size +import javax.validation.constraints.NotNull +import com.querydsl.sql._ object Survey extends QSurvey("survey"){ override def as(variable: String) = new QSurvey(variable) @@ -12,9 +12,9 @@ object Survey extends QSurvey("survey"){ class Survey { - var id: Integer = _; + var id: Integer = _ - var name: String = _; + var name: String = _ }