From 97f53725240ac58d9aa99bcdfda8a301926e690e Mon Sep 17 00:00:00 2001 From: Vesa Martilla Date: Tue, 21 Sep 2010 14:47:06 +0000 Subject: [PATCH] Changed for-loop string concat into a map mkstring combination. --- .../scala/sql/ScalaMetaDataSerializer.scala | 24 +++++++++++-------- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/querydsl-scala/src/main/scala/com/mysema/query/scala/sql/ScalaMetaDataSerializer.scala b/querydsl-scala/src/main/scala/com/mysema/query/scala/sql/ScalaMetaDataSerializer.scala index d1b5bde36..862926b7a 100644 --- a/querydsl-scala/src/main/scala/com/mysema/query/scala/sql/ScalaMetaDataSerializer.scala +++ b/querydsl-scala/src/main/scala/com/mysema/query/scala/sql/ScalaMetaDataSerializer.scala @@ -114,17 +114,21 @@ class ScalaMetaDataSerializer(val namePrefix: String, val namingStrategy: Naming def serializePrimaryKeys(model: EntityType, writer: CodeWriter, primaryKeys: Collection[PrimaryKeyData]) { for (primaryKey <- primaryKeys){ val fieldName = namingStrategy.getPropertyNameForPrimaryKey(primaryKey.getName(), model); - val value: StringBuilder = new StringBuilder("createPrimaryKey("); - var first = true; - for (column <- primaryKey.getColumns()){ - if (!first){ - value.append(", "); - } - value.append(namingStrategy.getPropertyName(column, namePrefix, model)); - first = false; - } + val value = new StringBuilder("createPrimaryKey("); +// var first = true; +// for (column <- primaryKey.getColumns()){ +// if (!first){ +// value.append(", "); +// } +// value.append(namingStrategy.getPropertyName(column, namePrefix, model)); +// first = false; +// } + value.append(primaryKey.getColumns().map({ column => + namingStrategy.getPropertyName(column, namePrefix, model) + }).mkString(", ")); + value.append(")"); - writer.publicFinal(new ClassType(classOf[PrimaryKey[_]], model), fieldName, value.toString()); + writer.publicFinal(new ClassType(classOf[PrimaryKey[_]], model), fieldName, value.toString); } }