From 8eee26015f63d7441e1626562e5dcd72636acce1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timo=20Westk=C3=A4mper?= <timo.westkamper@mysema.com>
Date: Thu, 2 Apr 2009 07:41:04 +0000
Subject: [PATCH]

---
 .../java/com/mysema/query/grammar/Ops.java    |  6 ++---
 .../mysema/query/grammar/types/Operation.java | 22 +++++--------------
 2 files changed, 9 insertions(+), 19 deletions(-)

diff --git a/querydsl-core/src/main/java/com/mysema/query/grammar/Ops.java b/querydsl-core/src/main/java/com/mysema/query/grammar/Ops.java
index 355e67896..ffe42c94e 100644
--- a/querydsl-core/src/main/java/com/mysema/query/grammar/Ops.java
+++ b/querydsl-core/src/main/java/com/mysema/query/grammar/Ops.java
@@ -37,13 +37,13 @@ public interface Ops {
     public static class Op<RT>{
         private final List<Class<?>> types;
         public Op(Class<?> type){
-            this.types = unmodifiableList(Collections.<Class<?>>singletonList(type));
+            this(Collections.<Class<?>>singletonList(type));
         }
         public Op(Class<?>... types){
-            this.types = unmodifiableList(Arrays.<Class<?>>asList(types));
+            this(Arrays.<Class<?>>asList(types));
         }                
         public Op(List<Class<?>> types){
-            this.types = types;
+            this.types = unmodifiableList(types);
         }        
         public List<Class<?>> getTypes(){
             return types;
diff --git a/querydsl-core/src/main/java/com/mysema/query/grammar/types/Operation.java b/querydsl-core/src/main/java/com/mysema/query/grammar/types/Operation.java
index 7f6e01511..920914fb7 100644
--- a/querydsl-core/src/main/java/com/mysema/query/grammar/types/Operation.java
+++ b/querydsl-core/src/main/java/com/mysema/query/grammar/types/Operation.java
@@ -35,8 +35,7 @@ public interface Operation<OP,RT> {
         private final List<Expr<?>> args;
         private final Op<Boolean> op;
         public OBoolean(Op<Boolean> op, Expr<?>... args){
-            this.op = op;
-            this.args = unmodifiableList(asList(args));
+            this(op, asList(args));
         }
         public OBoolean(Op<Boolean> op, List<Expr<?>> args){
             this.op = op;
@@ -50,9 +49,7 @@ public interface Operation<OP,RT> {
         private final List<Expr<?>> args;
         private final Op<OpType> op;
         public OComparable(Class<D> type, Op<OpType> op, Expr<?>... args){
-            super(type);
-            this.op = op;
-            this.args = unmodifiableList(asList(args));
+            this(type, op, asList(args));
         }
         public OComparable(Class<D> type, Op<OpType> op, List<Expr<?>> args){
             super(type);
@@ -67,9 +64,7 @@ public interface Operation<OP,RT> {
         private final List<Expr<?>> args;
         private final Op<OpType> op;
         public ONumber(Class<? extends D> type, Op<OpType> op, Expr<?>... args){
-            super(type);
-            this.op = op;
-            this.args = unmodifiableList(asList(args));
+            this(type, op, asList(args));
         }
         public ONumber(Class<? extends D> type, Op<OpType> op, List<Expr<?>> args){
             super(type);
@@ -84,9 +79,7 @@ public interface Operation<OP,RT> {
         private final List<Expr<?>> args;
         private final Op<OpType> op;
         public OSimple(Class<D> type, Op<OpType> op, Expr<?>... args){
-            super(type);
-            this.op = op;
-            this.args = unmodifiableList(asList(args));
+            this(type, op, asList(args));
         }
         public OSimple(Class<D> type, Op<OpType> op, List<Expr<?>> args){
             super(type);
@@ -101,8 +94,7 @@ public interface Operation<OP,RT> {
         private final List<Expr<?>> args;
         private final Op<String> op;
         public OString(Op<String> op, Expr<?>... args){
-            this.op = op;
-            this.args = unmodifiableList(asList(args));
+            this(op, asList(args));
         }
         public OString(Op<String> op, List<Expr<?>> args){
             this.op = op;
@@ -116,9 +108,7 @@ public interface Operation<OP,RT> {
         private final List<Expr<?>> args;
         private final Op<String> op;
         public OStringArray(Op<String> op, Expr<?>... args){
-            super(null);
-            this.op = op;
-            this.args = unmodifiableList(asList(args));
+            this(op, asList(args));
         }
         public OStringArray(Op<String> op, List<Expr<?>> args){
             super(null);