From 63400735b0d6760660f2577d3f0bab484df291a4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timo=20Westk=C3=A4mper?= <timo.westkamper@gmail.com>
Date: Sun, 3 May 2015 12:07:04 +0300
Subject: [PATCH 1/3] Improve javadocs for querydsl-jdo

---
 .../com/querydsl/jdo/AbstractJDOQuery.java    | 12 ++++-----
 .../java/com/querydsl/jdo/JDOExpressions.java | 26 ++++++++++---------
 .../java/com/querydsl/jdo/JDOQLQuery.java     | 23 ++++++++--------
 .../com/querydsl/jdo/JDOQLSerializer.java     |  1 -
 .../java/com/querydsl/jdo/JDOQLTemplates.java |  2 +-
 .../main/java/com/querydsl/jdo/JDOQuery.java  | 15 ++++++-----
 .../com/querydsl/jdo/JDOQueryFactory.java     | 26 ++++++++++---------
 .../java/com/querydsl/jdo/JDOQueryMixin.java  |  2 +-
 .../querydsl/jdo/sql/AbstractSQLQuery.java    |  8 ++++--
 .../com/querydsl/jdo/sql/JDOSQLQuery.java     |  2 ++
 10 files changed, 64 insertions(+), 53 deletions(-)

diff --git a/querydsl-jdo/src/main/java/com/querydsl/jdo/AbstractJDOQuery.java b/querydsl-jdo/src/main/java/com/querydsl/jdo/AbstractJDOQuery.java
index d6ca27740..6a41c4c94 100644
--- a/querydsl-jdo/src/main/java/com/querydsl/jdo/AbstractJDOQuery.java
+++ b/querydsl-jdo/src/main/java/com/querydsl/jdo/AbstractJDOQuery.java
@@ -31,14 +31,14 @@ import com.mysema.commons.lang.IteratorAdapter;
 import com.querydsl.core.*;
 import com.querydsl.core.support.FetchableSubQueryBase;
 import com.querydsl.core.types.*;
-import com.querydsl.core.types.dsl.CollectionPath;
 
 /**
  * Abstract base class for custom implementations of the JDOCommonQuery interface.
  *
  * @author tiwe
  *
- * @param <Q>
+ * @param <T> result type
+ * @param <Q> concrete subclass
  */
 public abstract class AbstractJDOQuery<T, Q extends AbstractJDOQuery<T, Q>> extends FetchableSubQueryBase<T, Q> implements JDOQLQuery<T> {
 
@@ -89,8 +89,8 @@ public abstract class AbstractJDOQuery<T, Q extends AbstractJDOQuery<T, Q>> exte
     /**
      * Add the fetch group to the set of active fetch groups.
      *
-     * @param fetchGroupName
-     * @return
+     * @param fetchGroupName fetch group name
+     * @return the current object
      */
     @Override
     public Q addFetchGroup(String fetchGroupName) {
@@ -283,8 +283,8 @@ public abstract class AbstractJDOQuery<T, Q extends AbstractJDOQuery<T, Q>> exte
      * A positive integer will result in that number of references from the
      * initial object to be fetched.
      *
-     * @param depth
-     * @return
+     * @param depth fetch depth
+     * @return the current object
      */
     @Override
     public Q setMaxFetchDepth(int depth) {
diff --git a/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOExpressions.java b/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOExpressions.java
index 93d4be051..a59820060 100644
--- a/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOExpressions.java
+++ b/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOExpressions.java
@@ -26,9 +26,9 @@ public final class JDOExpressions {
     /**
      * Create a new detached JDOQuery instance with the given projection
      *
-     * @param expr
+     * @param expr projection
      * @param <T>
-     * @return
+     * @return select(expr)
      */
     public static <T> JDOQuery<T> select(Expression<T> expr) {
         return new JDOQuery<Void>().select(expr);
@@ -37,8 +37,8 @@ public final class JDOExpressions {
     /**
      * Create a new detached JDOQuery instance with the given projection
      *
-     * @param exprs
-     * @return
+     * @param exprs projection
+     * @return select(exprs)
      */
     public static JDOQuery<Tuple> select(Expression<?>... exprs) {
         return new JDOQuery<Void>().select(exprs);
@@ -47,9 +47,9 @@ public final class JDOExpressions {
     /**
      * Create a new detached JDOQuery instance with the given projection
      *
-     * @param expr
+     * @param expr projection
      * @param <T>
-     * @return
+     * @return select(distinct expr)
      */
     public static <T> JDOQuery<T> selectDistinct(Expression<T> expr) {
         return new JDOQuery<Void>().select(expr).distinct();
@@ -58,8 +58,8 @@ public final class JDOExpressions {
     /**
      * Create a new detached JDOQuery instance with the given projection
      *
-     * @param exprs
-     * @return
+     * @param exprs projection
+     * @return select(distinct exprs)
      */
     public static JDOQuery<Tuple> selectDistinct(Expression<?>... exprs) {
         return new JDOQuery<Void>().select(exprs).distinct();
@@ -67,16 +67,18 @@ public final class JDOExpressions {
 
 
     /**
+     * Create a new detached JDOQuery instance with the given projection 0
      *
-     * @return
+     * @return select(0)
      */
     public static JDOQuery<Integer> selectZero() {
         return select(Expressions.ZERO);
     }
 
     /**
+     * Create a new detached JDOQuery instance with the projection 1
      *
-     * @return
+     * @return select(1)
      */
     public static JDOQuery<Integer> selectOne() {
         return select(Expressions.ONE);
@@ -85,9 +87,9 @@ public final class JDOExpressions {
     /**
      * Create a new detached JDOQuery instance with the given projection
      *
-     * @param expr
+     * @param expr projection and source
      * @param <T>
-     * @return
+     * @return select(expr).from(expr)
      */
     public static <T> JDOQuery<T> selectFrom(EntityPath<T> expr) {
         return select(expr).from(expr);
diff --git a/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOQLQuery.java b/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOQLQuery.java
index 4be03428e..5b80c13dd 100644
--- a/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOQLQuery.java
+++ b/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOQLQuery.java
@@ -29,40 +29,41 @@ import com.querydsl.core.types.Path;
  *
  * @author tiwe
  *
+ * @param <T> result type
  */
 public interface JDOQLQuery<T> extends FetchableQuery<T, JDOQLQuery<T>>, Query<JDOQLQuery<T>>, ExtendedSubQuery<T>, Closeable {
 
     /**
      * Add query sources
      *
-     * @param sources
-     * @return
+     * @param sources sources
+     * @return the current object
      */
     JDOQLQuery<T> from(EntityPath<?>... sources);
 
     /**
      * Add query sources
      *
-     * @param path
-     * @param alias
+     * @param path source
+     * @param alias alias
      * @param <U>
-     * @return
+     * @return the current object
      */
     <U> JDOQLQuery<T> from(CollectionExpression<?, U> path, Path<U> alias);
 
     /**
      * Clone the state of the query for the given PersistenceManager
      *
-     * @param persistenceManager
-     * @return
+     * @param persistenceManager persistence manager
+     * @return cloned query
      */
     JDOQLQuery<T> clone(PersistenceManager persistenceManager);
 
     /**
      * Add the fetch group to the set of active fetch groups.
      * 
-     * @param fetchGroupName
-     * @return
+     * @param fetchGroupName fetch group  name
+     * @return the current object
      */
     JDOQLQuery<T> addFetchGroup(String fetchGroupName);
 
@@ -73,8 +74,8 @@ public interface JDOQLQuery<T> extends FetchableQuery<T, JDOQLQuery<T>>, Query<J
      * A positive integer will result in that number of references from the
      * initial object to be fetched.
      * 
-     * @param maxFetchDepth
-     * @return
+     * @param maxFetchDepth max fetch depth
+     * @return the current object
      */
     JDOQLQuery<T> setMaxFetchDepth(int maxFetchDepth);
     
diff --git a/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOQLSerializer.java b/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOQLSerializer.java
index 0e8e078ad..d837af66b 100644
--- a/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOQLSerializer.java
+++ b/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOQLSerializer.java
@@ -273,7 +273,6 @@ public final class JDOQLSerializer extends SerializerBase<JDOQLSerializer> {
         return null;
     }
 
-//    @SuppressWarnings({ "unchecked", "rawtypes" })
     @Override
     protected void visitOperation(Class<?> type, Operator operator, List<? extends Expression<?>> args) {
         if (operator == Ops.INSTANCE_OF) {
diff --git a/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOQLTemplates.java b/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOQLTemplates.java
index 231c3bba4..c3d440086 100644
--- a/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOQLTemplates.java
+++ b/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOQLTemplates.java
@@ -17,7 +17,7 @@ import com.querydsl.core.types.JavaTemplates;
 import com.querydsl.core.types.Ops;
 
 /**
- * JDOQLTemplates provides patterns for JDOQL serialization
+ * {@code JDOQLTemplates} provides patterns for JDOQL serialization
  *
  * @author tiwe
  *
diff --git a/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOQuery.java b/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOQuery.java
index 872f6c3ca..ae4879120 100644
--- a/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOQuery.java
+++ b/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOQuery.java
@@ -21,10 +21,11 @@ import com.querydsl.core.Tuple;
 import com.querydsl.core.types.Expression;
 
 /**
- * JDOQuery is the default implementation of the JDOQLQuery interface
+ * {@code JDOQuery} is the default implementation of the JDOQLQuery interface
  *
  * @author tiwe
  *
+ * @param <T> result type
  */
 public class JDOQuery<T> extends AbstractJDOQuery<T, JDOQuery<T>> {
 
@@ -70,10 +71,10 @@ public class JDOQuery<T> extends AbstractJDOQuery<T, JDOQuery<T>> {
     /**
      * Create a new JDOQuery instance
      * 
-     * @param persistenceManager
-     * @param templates
-     * @param metadata
-     * @param detach
+     * @param persistenceManager PersistenceManager instance to use
+     * @param templates templates to use
+     * @param metadata query metadata
+     * @param detach detached results or not
      */
     protected JDOQuery(PersistenceManager persistenceManager, JDOQLTemplates templates, 
             QueryMetadata metadata, boolean detach) {
@@ -83,8 +84,8 @@ public class JDOQuery<T> extends AbstractJDOQuery<T, JDOQuery<T>> {
     /**
      * Clone the state of this query to a new JDOQuery instance with the given PersistenceManager
      *
-     * @param persistenceManager
-     * @return
+     * @param persistenceManager PersistenceManager instance to use
+     * @return cloned query
      */
     public JDOQuery<T> clone(PersistenceManager persistenceManager) {
         JDOQuery<T> query = new JDOQuery<T>(persistenceManager, getTemplates(),
diff --git a/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOQueryFactory.java b/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOQueryFactory.java
index f1138fb81..5ac90432e 100644
--- a/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOQueryFactory.java
+++ b/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOQueryFactory.java
@@ -44,9 +44,9 @@ public class JDOQueryFactory implements QueryFactory<JDOQuery<?>> {
     /**
      * Create a new JDOQuery instance with the given projection
      *
-     * @param expr
+     * @param expr projection
      * @param <T>
-     * @return
+     * @return select(expr)
      */
     public <T> JDOQuery<T> select(Expression<T> expr) {
         return query().select(expr);
@@ -55,8 +55,8 @@ public class JDOQueryFactory implements QueryFactory<JDOQuery<?>> {
     /**
      * Create a new JDOQuery instance with the given projection
      *
-     * @param exprs
-     * @return
+     * @param exprs projection
+     * @return select(exprs)
      */
     public JDOQuery<Tuple> select(Expression<?>... exprs) {
         return query().select(exprs);
@@ -65,9 +65,9 @@ public class JDOQueryFactory implements QueryFactory<JDOQuery<?>> {
     /**
      * Create a new JDOQuery instance with the given projection
      *
-     * @param expr
+     * @param expr projection
      * @param <T>
-     * @return
+     * @return select(distinct expr)
      */
     public <T> JDOQuery<T> selectDistinct(Expression<T> expr) {
         return query().select(expr).distinct();
@@ -76,24 +76,26 @@ public class JDOQueryFactory implements QueryFactory<JDOQuery<?>> {
     /**
      * Create a new JDOQuery instance with the given projection
      *
-     * @param exprs
-     * @return
+     * @param exprs projection
+     * @return select(distinct exprs)
      */
     public JDOQuery<Tuple> selectDistinct(Expression<?>... exprs) {
         return query().select(exprs).distinct();
     }
 
     /**
+     * Create a new JDOQuery instance with the projection zero
      *
-     * @return
+     * @return select(0)
      */
     public JDOQuery<Integer> selectZero() {
         return select(Expressions.ZERO);
     }
 
     /**
+     * Create a new JDOQuery instance with the projection one
      *
-     * @return
+     * @return select(1)
      */
     public JDOQuery<Integer> selectOne() {
         return select(Expressions.ONE);
@@ -102,9 +104,9 @@ public class JDOQueryFactory implements QueryFactory<JDOQuery<?>> {
     /**
      * Create a new JDOQuery instance with the given projection
      *
-     * @param expr
+     * @param expr projection and source
      * @param <T>
-     * @return
+     * @return select(expr).from(expr)
      */
     public <T> JDOQuery<T> selectFrom(EntityPath<T> expr) {
         return select(expr).from(expr);
diff --git a/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOQueryMixin.java b/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOQueryMixin.java
index 6b6574987..bec33ecd7 100644
--- a/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOQueryMixin.java
+++ b/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOQueryMixin.java
@@ -19,7 +19,7 @@ import com.querydsl.core.support.QueryMixin;
 import com.querydsl.core.types.*;
 
 /**
- * JDOQueryMixin extends {@link QueryMixin} to provide module specific extensions 
+ * {@code JDOQueryMixin} extends {@link QueryMixin} to provide module specific extensions
  * 
  * @author tiwe
  *
diff --git a/querydsl-jdo/src/main/java/com/querydsl/jdo/sql/AbstractSQLQuery.java b/querydsl-jdo/src/main/java/com/querydsl/jdo/sql/AbstractSQLQuery.java
index 9ce3d10f6..b241203c0 100644
--- a/querydsl-jdo/src/main/java/com/querydsl/jdo/sql/AbstractSQLQuery.java
+++ b/querydsl-jdo/src/main/java/com/querydsl/jdo/sql/AbstractSQLQuery.java
@@ -43,7 +43,8 @@ import com.querydsl.sql.SQLSerializer;
  *
  * @author tiwe
  *
- * @param <T>
+ * @param <T> result type
+ * @param <Q> concrete subclass
  */
 @SuppressWarnings("rawtypes")
 public abstract class AbstractSQLQuery<T, Q extends AbstractSQLQuery<T, Q>> extends ProjectableSQLQuery<T, Q> {
@@ -81,6 +82,9 @@ public abstract class AbstractSQLQuery<T, Q extends AbstractSQLQuery<T, Q>> exte
         this.detach = detach;
     }
 
+    /**
+     * Close the query and related resources
+     */
     public void close() {
         for (Query query : queries) {
             query.closeAll();
@@ -144,7 +148,7 @@ public abstract class AbstractSQLQuery<T, Q extends AbstractSQLQuery<T, Q>> exte
         } else if (row.getClass().isArray()) {
             return expr.newInstance((Object[])row);
         } else {
-            return expr.newInstance(new Object[]{row});
+            return expr.newInstance(row);
         }
     }
 
diff --git a/querydsl-jdo/src/main/java/com/querydsl/jdo/sql/JDOSQLQuery.java b/querydsl-jdo/src/main/java/com/querydsl/jdo/sql/JDOSQLQuery.java
index baa04954d..eb98e8616 100644
--- a/querydsl-jdo/src/main/java/com/querydsl/jdo/sql/JDOSQLQuery.java
+++ b/querydsl-jdo/src/main/java/com/querydsl/jdo/sql/JDOSQLQuery.java
@@ -30,6 +30,8 @@ import com.querydsl.sql.SQLTemplates;
  *
  * @author tiwe
  *
+ * @param <T> result type
+ *
  */
 public final class JDOSQLQuery<T> extends AbstractSQLQuery<T, JDOSQLQuery<T>> {
 

From ed94a998bfdd3f28cc50d5169b923f3f7ebdce0f Mon Sep 17 00:00:00 2001
From: John Tims <john.k.tims@gmail.com>
Date: Tue, 5 May 2015 00:05:57 -0400
Subject: [PATCH 2/3] Improve JDO javadocs

---
 .../com/querydsl/jdo/AbstractJDOQuery.java     |  3 ++-
 .../java/com/querydsl/jdo/JDOExpressions.java  | 18 +++++++++---------
 .../main/java/com/querydsl/jdo/JDOQLQuery.java |  2 +-
 .../java/com/querydsl/jdo/JDOQLSerializer.java |  2 +-
 .../main/java/com/querydsl/jdo/JDOQuery.java   | 14 +++++++-------
 .../java/com/querydsl/jdo/JDOQueryFactory.java | 14 +++++++-------
 .../java/com/querydsl/jdo/JDOQueryMixin.java   |  2 +-
 .../com/querydsl/jdo/dml/JDODeleteClause.java  |  2 +-
 .../com/querydsl/jdo/dml/JDOUpdateClause.java  |  2 +-
 .../com/querydsl/jdo/sql/AbstractSQLQuery.java |  5 +++--
 .../java/com/querydsl/jdo/sql/JDOSQLQuery.java |  3 ++-
 11 files changed, 35 insertions(+), 32 deletions(-)

diff --git a/querydsl-jdo/src/main/java/com/querydsl/jdo/AbstractJDOQuery.java b/querydsl-jdo/src/main/java/com/querydsl/jdo/AbstractJDOQuery.java
index 6a41c4c94..5f238e7d7 100644
--- a/querydsl-jdo/src/main/java/com/querydsl/jdo/AbstractJDOQuery.java
+++ b/querydsl-jdo/src/main/java/com/querydsl/jdo/AbstractJDOQuery.java
@@ -18,6 +18,7 @@ import java.io.IOException;
 import java.util.*;
 
 import javax.annotation.Nullable;
+import javax.jdo.JDOUserException;
 import javax.jdo.PersistenceManager;
 import javax.jdo.Query;
 
@@ -278,7 +279,7 @@ public abstract class AbstractJDOQuery<T, Q extends AbstractJDOQuery<T, Q>> exte
 
     /**
      * Set the maximum fetch depth when fetching.
-     * A value of 0 has no meaning and will throw a JDOUserException.
+     * A value of 0 has no meaning and will throw a {@link JDOUserException}.
      * A value of -1 means that no limit is placed on fetching.
      * A positive integer will result in that number of references from the
      * initial object to be fetched.
diff --git a/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOExpressions.java b/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOExpressions.java
index a59820060..c60cf62d2 100644
--- a/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOExpressions.java
+++ b/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOExpressions.java
@@ -24,7 +24,7 @@ import com.querydsl.core.types.dsl.Expressions;
 public final class JDOExpressions {
 
     /**
-     * Create a new detached JDOQuery instance with the given projection
+     * Create a new detached {@link JDOQuery} instance with the given projection
      *
      * @param expr projection
      * @param <T>
@@ -35,7 +35,7 @@ public final class JDOExpressions {
     }
 
     /**
-     * Create a new detached JDOQuery instance with the given projection
+     * Create a new detached {@link JDOQuery} instance with the given projection
      *
      * @param exprs projection
      * @return select(exprs)
@@ -45,29 +45,29 @@ public final class JDOExpressions {
     }
 
     /**
-     * Create a new detached JDOQuery instance with the given projection
+     * Create a new detached {@link JDOQuery} instance with the given projection
      *
      * @param expr projection
      * @param <T>
      * @return select(distinct expr)
      */
     public static <T> JDOQuery<T> selectDistinct(Expression<T> expr) {
-        return new JDOQuery<Void>().select(expr).distinct();
+        return select(expr).distinct();
     }
 
     /**
-     * Create a new detached JDOQuery instance with the given projection
+     * Create a new detached {@link JDOQuery} instance with the given projection
      *
      * @param exprs projection
      * @return select(distinct exprs)
      */
     public static JDOQuery<Tuple> selectDistinct(Expression<?>... exprs) {
-        return new JDOQuery<Void>().select(exprs).distinct();
+        return select(exprs).distinct();
     }
 
 
     /**
-     * Create a new detached JDOQuery instance with the given projection 0
+     * Create a new detached {@link JDOQuery} instance with the given projection 0
      *
      * @return select(0)
      */
@@ -76,7 +76,7 @@ public final class JDOExpressions {
     }
 
     /**
-     * Create a new detached JDOQuery instance with the projection 1
+     * Create a new detached {@link JDOQuery} instance with the projection 1
      *
      * @return select(1)
      */
@@ -85,7 +85,7 @@ public final class JDOExpressions {
     }
 
     /**
-     * Create a new detached JDOQuery instance with the given projection
+     * Create a new detached {@link JDOQuery} instance with the given projection
      *
      * @param expr projection and source
      * @param <T>
diff --git a/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOQLQuery.java b/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOQLQuery.java
index 5b80c13dd..3e75c3ad2 100644
--- a/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOQLQuery.java
+++ b/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOQLQuery.java
@@ -62,7 +62,7 @@ public interface JDOQLQuery<T> extends FetchableQuery<T, JDOQLQuery<T>>, Query<J
     /**
      * Add the fetch group to the set of active fetch groups.
      * 
-     * @param fetchGroupName fetch group  name
+     * @param fetchGroupName fetch group name
      * @return the current object
      */
     JDOQLQuery<T> addFetchGroup(String fetchGroupName);
diff --git a/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOQLSerializer.java b/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOQLSerializer.java
index d837af66b..b56524190 100644
--- a/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOQLSerializer.java
+++ b/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOQLSerializer.java
@@ -27,7 +27,7 @@ import com.querydsl.core.types.*;
 import com.querydsl.core.types.dsl.Param;
 
 /**
- * JDOQLSerializer serializes Querydsl queries and expressions into JDOQL strings
+ * {@code JDOQLSerializer} serializes Querydsl queries and expressions into JDOQL strings
  *
  * @author tiwe
  *
diff --git a/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOQuery.java b/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOQuery.java
index ae4879120..1d0198274 100644
--- a/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOQuery.java
+++ b/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOQuery.java
@@ -21,7 +21,7 @@ import com.querydsl.core.Tuple;
 import com.querydsl.core.types.Expression;
 
 /**
- * {@code JDOQuery} is the default implementation of the JDOQLQuery interface
+ * {@code JDOQuery} is the default implementation of the {@link JDOQLQuery} interface
  *
  * @author tiwe
  *
@@ -30,7 +30,7 @@ import com.querydsl.core.types.Expression;
 public class JDOQuery<T> extends AbstractJDOQuery<T, JDOQuery<T>> {
 
     /**
-     * Create a detached JDOQuery instance
+     * Create a detached {@link JDOQuery} instance
      * The query can be attached via the clone method
      *
      */
@@ -39,7 +39,7 @@ public class JDOQuery<T> extends AbstractJDOQuery<T, JDOQuery<T>> {
     }
 
     /**
-     * Create a new JDOQuery instance
+     * Create a new {@link JDOQuery} instance
      *
      * @param persistenceManager PersistenceManager instance to use
      * @param templates JDOQLTemplates to use
@@ -50,7 +50,7 @@ public class JDOQuery<T> extends AbstractJDOQuery<T, JDOQuery<T>> {
     }
 
     /**
-     * Create a new JDOQuery instance
+     * Create a new {@link JDOQuery} instance
      *
      * @param persistenceManager PersistenceManager instance to use
      * @param detach detached results or not
@@ -60,7 +60,7 @@ public class JDOQuery<T> extends AbstractJDOQuery<T, JDOQuery<T>> {
     }
 
     /**
-     * Create a new JDOQuery instance
+     * Create a new {@link JDOQuery} instance
      *
      * @param persistenceManager PersistenceManager instance to use
      */
@@ -69,7 +69,7 @@ public class JDOQuery<T> extends AbstractJDOQuery<T, JDOQuery<T>> {
     }
 
     /**
-     * Create a new JDOQuery instance
+     * Create a new {@link JDOQuery} instance
      * 
      * @param persistenceManager PersistenceManager instance to use
      * @param templates templates to use
@@ -82,7 +82,7 @@ public class JDOQuery<T> extends AbstractJDOQuery<T, JDOQuery<T>> {
     }
 
     /**
-     * Clone the state of this query to a new JDOQuery instance with the given PersistenceManager
+     * Clone the state of this query to a new {@link JDOQuery} instance with the given {@link PersistenceManager}
      *
      * @param persistenceManager PersistenceManager instance to use
      * @return cloned query
diff --git a/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOQueryFactory.java b/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOQueryFactory.java
index 5ac90432e..5c998bbac 100644
--- a/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOQueryFactory.java
+++ b/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOQueryFactory.java
@@ -42,7 +42,7 @@ public class JDOQueryFactory implements QueryFactory<JDOQuery<?>> {
     }
 
     /**
-     * Create a new JDOQuery instance with the given projection
+     * Create a new {@link JDOQuery} instance with the given projection
      *
      * @param expr projection
      * @param <T>
@@ -53,7 +53,7 @@ public class JDOQueryFactory implements QueryFactory<JDOQuery<?>> {
     }
 
     /**
-     * Create a new JDOQuery instance with the given projection
+     * Create a new {@link JDOQuery} instance with the given projection
      *
      * @param exprs projection
      * @return select(exprs)
@@ -63,7 +63,7 @@ public class JDOQueryFactory implements QueryFactory<JDOQuery<?>> {
     }
 
     /**
-     * Create a new JDOQuery instance with the given projection
+     * Create a new {@link JDOQuery} instance with the given projection
      *
      * @param expr projection
      * @param <T>
@@ -74,7 +74,7 @@ public class JDOQueryFactory implements QueryFactory<JDOQuery<?>> {
     }
 
     /**
-     * Create a new JDOQuery instance with the given projection
+     * Create a new {@link JDOQuery} instance with the given projection
      *
      * @param exprs projection
      * @return select(distinct exprs)
@@ -84,7 +84,7 @@ public class JDOQueryFactory implements QueryFactory<JDOQuery<?>> {
     }
 
     /**
-     * Create a new JDOQuery instance with the projection zero
+     * Create a new {@link JDOQuery} instance with the projection 0
      *
      * @return select(0)
      */
@@ -93,7 +93,7 @@ public class JDOQueryFactory implements QueryFactory<JDOQuery<?>> {
     }
 
     /**
-     * Create a new JDOQuery instance with the projection one
+     * Create a new {@link JDOQuery} instance with the projection 1
      *
      * @return select(1)
      */
@@ -102,7 +102,7 @@ public class JDOQueryFactory implements QueryFactory<JDOQuery<?>> {
     }
 
     /**
-     * Create a new JDOQuery instance with the given projection
+     * Create a new {@link JDOQuery} instance with the given projection
      *
      * @param expr projection and source
      * @param <T>
diff --git a/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOQueryMixin.java b/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOQueryMixin.java
index bec33ecd7..24866abed 100644
--- a/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOQueryMixin.java
+++ b/querydsl-jdo/src/main/java/com/querydsl/jdo/JDOQueryMixin.java
@@ -19,7 +19,7 @@ import com.querydsl.core.support.QueryMixin;
 import com.querydsl.core.types.*;
 
 /**
- * {@code JDOQueryMixin} extends {@link QueryMixin} to provide module specific extensions
+ * {@code JDOQueryMixin} extends {@link QueryMixin} to provide module-specific extensions
  * 
  * @author tiwe
  *
diff --git a/querydsl-jdo/src/main/java/com/querydsl/jdo/dml/JDODeleteClause.java b/querydsl-jdo/src/main/java/com/querydsl/jdo/dml/JDODeleteClause.java
index 8c4542997..507b6fce8 100644
--- a/querydsl-jdo/src/main/java/com/querydsl/jdo/dml/JDODeleteClause.java
+++ b/querydsl-jdo/src/main/java/com/querydsl/jdo/dml/JDODeleteClause.java
@@ -30,7 +30,7 @@ import com.querydsl.core.types.EntityPath;
 import com.querydsl.core.types.Predicate;
 
 /**
- * DeleteClause implementation for JDO
+ * {@link DeleteClause} implementation for JDO
  *
  * @author tiwe
  *
diff --git a/querydsl-jdo/src/main/java/com/querydsl/jdo/dml/JDOUpdateClause.java b/querydsl-jdo/src/main/java/com/querydsl/jdo/dml/JDOUpdateClause.java
index 36e6ff2f3..31653397d 100644
--- a/querydsl-jdo/src/main/java/com/querydsl/jdo/dml/JDOUpdateClause.java
+++ b/querydsl-jdo/src/main/java/com/querydsl/jdo/dml/JDOUpdateClause.java
@@ -26,7 +26,7 @@ import com.querydsl.core.types.Path;
 import com.querydsl.core.types.Predicate;
 
 /**
- * UpdateClause implementation for JDO
+ * {@link UpdateClause} implementation for JDO
  *
  * @author tiwe
  *
diff --git a/querydsl-jdo/src/main/java/com/querydsl/jdo/sql/AbstractSQLQuery.java b/querydsl-jdo/src/main/java/com/querydsl/jdo/sql/AbstractSQLQuery.java
index b241203c0..c6e64125c 100644
--- a/querydsl-jdo/src/main/java/com/querydsl/jdo/sql/AbstractSQLQuery.java
+++ b/querydsl-jdo/src/main/java/com/querydsl/jdo/sql/AbstractSQLQuery.java
@@ -36,10 +36,11 @@ import com.querydsl.core.types.Expression;
 import com.querydsl.core.types.FactoryExpression;
 import com.querydsl.sql.Configuration;
 import com.querydsl.sql.ProjectableSQLQuery;
+import com.querydsl.sql.SQLQuery;
 import com.querydsl.sql.SQLSerializer;
 
 /**
- * Base class for JDO based SQLQuery implementations
+ * Base class for JDO-based {@link SQLQuery} implementations
  *
  * @author tiwe
  *
@@ -117,7 +118,7 @@ public abstract class AbstractSQLQuery<T, Q extends AbstractSQLQuery<T, Q>> exte
         if (logger.isDebugEnabled()) {
             logger.debug(serializer.toString());
         }
-        Query query = persistenceManager.newQuery("javax.jdo.query.SQL",serializer.toString());
+        Query query = persistenceManager.newQuery("javax.jdo.query.SQL", serializer.toString());
         orderedConstants = serializer.getConstants();
         queries.add(query);
 
diff --git a/querydsl-jdo/src/main/java/com/querydsl/jdo/sql/JDOSQLQuery.java b/querydsl-jdo/src/main/java/com/querydsl/jdo/sql/JDOSQLQuery.java
index eb98e8616..44b3c2b07 100644
--- a/querydsl-jdo/src/main/java/com/querydsl/jdo/sql/JDOSQLQuery.java
+++ b/querydsl-jdo/src/main/java/com/querydsl/jdo/sql/JDOSQLQuery.java
@@ -21,11 +21,12 @@ import com.querydsl.core.QueryMetadata;
 import com.querydsl.core.Tuple;
 import com.querydsl.core.types.Expression;
 import com.querydsl.sql.Configuration;
+import com.querydsl.sql.SQLQuery;
 import com.querydsl.sql.SQLSerializer;
 import com.querydsl.sql.SQLTemplates;
 
 /**
- * JDOSQLQuery is an SQLQuery implementation that uses JDO's SQL query functionality
+ * {@code JDOSQLQuery} is a {@link SQLQuery} implementation that uses JDO's SQL query functionality
  * to execute queries
  *
  * @author tiwe

From 43aca4600aa7e057023d4d7b061dcdd9360fc8e5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timo=20Westk=C3=A4mper?= <timo.westkamper@gmail.com>
Date: Tue, 5 May 2015 18:01:12 +0300
Subject: [PATCH 3/3] Fix reference

---
 .../src/main/java/com/querydsl/jdo/AbstractJDOQuery.java        | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/querydsl-jdo/src/main/java/com/querydsl/jdo/AbstractJDOQuery.java b/querydsl-jdo/src/main/java/com/querydsl/jdo/AbstractJDOQuery.java
index 5f238e7d7..44553dc19 100644
--- a/querydsl-jdo/src/main/java/com/querydsl/jdo/AbstractJDOQuery.java
+++ b/querydsl-jdo/src/main/java/com/querydsl/jdo/AbstractJDOQuery.java
@@ -34,7 +34,7 @@ import com.querydsl.core.support.FetchableSubQueryBase;
 import com.querydsl.core.types.*;
 
 /**
- * Abstract base class for custom implementations of the JDOCommonQuery interface.
+ * Abstract base class for custom implementations of the {@link JDOQLQuery} interface.
  *
  * @author tiwe
  *