From d5261c3319a98363f4d328016a5e769b17f060d4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timo=20Westk=C3=A4mper?= Date: Fri, 26 Jun 2015 21:37:14 +0300 Subject: [PATCH 1/2] Rename SearchResults to QueryResults in javadocs and test names --- .../src/main/java/com/querydsl/core/QueryResults.java | 4 ++-- querydsl-jdo/src/test/java/com/querydsl/jdo/OrderingTest.java | 2 +- .../src/test/java/com/querydsl/jpa/AbstractJPATest.java | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/querydsl-core/src/main/java/com/querydsl/core/QueryResults.java b/querydsl-core/src/main/java/com/querydsl/core/QueryResults.java index b8f6329cc..9028aefd8 100644 --- a/querydsl-core/src/main/java/com/querydsl/core/QueryResults.java +++ b/querydsl-core/src/main/java/com/querydsl/core/QueryResults.java @@ -44,7 +44,7 @@ public final class QueryResults implements Serializable { private final List results; /** - * Create a new SearchResults instance + * Create a new QueryResults instance * * @param results paged results * @param limit used limit @@ -59,7 +59,7 @@ public final class QueryResults implements Serializable { } /** - * Create a new SearchResults instance + * Create a new QueryResults instance * * @param results paged results * @param mod limit and offset diff --git a/querydsl-jdo/src/test/java/com/querydsl/jdo/OrderingTest.java b/querydsl-jdo/src/test/java/com/querydsl/jdo/OrderingTest.java index dc1fa5e5b..e857f65e3 100644 --- a/querydsl-jdo/src/test/java/com/querydsl/jdo/OrderingTest.java +++ b/querydsl-jdo/src/test/java/com/querydsl/jdo/OrderingTest.java @@ -92,7 +92,7 @@ public class OrderingTest extends AbstractJDOTest { } @Test - public void SearchResults() { + public void QueryResults() { QueryResults results = query().from(product).orderBy( product.name.asc()).limit(2).select(product.name).fetchResults(); assertEquals(Arrays.asList("A0", "A1"), results.getResults()); diff --git a/querydsl-jpa/src/test/java/com/querydsl/jpa/AbstractJPATest.java b/querydsl-jpa/src/test/java/com/querydsl/jpa/AbstractJPATest.java index 01aadbf89..bbb9d7668 100644 --- a/querydsl-jpa/src/test/java/com/querydsl/jpa/AbstractJPATest.java +++ b/querydsl-jpa/src/test/java/com/querydsl/jpa/AbstractJPATest.java @@ -1506,7 +1506,7 @@ public abstract class AbstractJPATest { } @Test - public void TupleProjection_As_SearchResults() { + public void TupleProjection_As_QueryResults() { QueryResults tuples = query().from(cat).limit(1) .select(cat.name, cat).fetchResults(); assertEquals(1, tuples.getResults().size()); From 735853a17423aec75dc0f880154174e3885e2427 Mon Sep 17 00:00:00 2001 From: John Tims Date: Fri, 26 Jun 2015 20:52:43 -0400 Subject: [PATCH 2/2] Polish javadocs in QueryResults --- .../src/main/java/com/querydsl/core/QueryResults.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/querydsl-core/src/main/java/com/querydsl/core/QueryResults.java b/querydsl-core/src/main/java/com/querydsl/core/QueryResults.java index 9028aefd8..7ae04469f 100644 --- a/querydsl-core/src/main/java/com/querydsl/core/QueryResults.java +++ b/querydsl-core/src/main/java/com/querydsl/core/QueryResults.java @@ -44,7 +44,7 @@ public final class QueryResults implements Serializable { private final List results; /** - * Create a new QueryResults instance + * Create a new {@link QueryResults} instance * * @param results paged results * @param limit used limit @@ -59,7 +59,7 @@ public final class QueryResults implements Serializable { } /** - * Create a new QueryResults instance + * Create a new {@link QueryResults} instance * * @param results paged results * @param mod limit and offset @@ -81,7 +81,7 @@ public final class QueryResults implements Serializable { } /** - * Get the number of total results + * Get the total number of results * * @return total rows */