diff --git a/querydsl-collections/src/main/java/com/mysema/query/collections/AbstractColQuery.java b/querydsl-collections/src/main/java/com/mysema/query/collections/AbstractColQuery.java index 0fb8de2b1..753dcc25d 100644 --- a/querydsl-collections/src/main/java/com/mysema/query/collections/AbstractColQuery.java +++ b/querydsl-collections/src/main/java/com/mysema/query/collections/AbstractColQuery.java @@ -137,7 +137,6 @@ public class AbstractColQuery> impleme return new DefaultIndexSupport(new SimpleIteratorSource(exprToIt), ops, sources); } - // TODO : this signature isn't right when used with custom iterator source public SubType from(Expr entity, A first, A... rest) { List list = new ArrayList(rest.length + 1); list.add(first); @@ -145,7 +144,6 @@ public class AbstractColQuery> impleme return from(entity, list); } - // TODO : this signature isn't right when used with custom iterator source public SubType from(Expr entity, Iterable col) { alias(entity, col); query.from((Expr)entity); diff --git a/querydsl-collections/src/test/java/com/mysema/query/collections/ColQueryTest.java b/querydsl-collections/src/test/java/com/mysema/query/collections/ColQueryTest.java index f0d58c53d..8bb38a3be 100644 --- a/querydsl-collections/src/test/java/com/mysema/query/collections/ColQueryTest.java +++ b/querydsl-collections/src/test/java/com/mysema/query/collections/ColQueryTest.java @@ -181,6 +181,10 @@ public class ColQueryTest extends AbstractQueryTest{ assertEquals("null path in expression", e.getMessage()); } + // 12 + TestQuery query = query().from(cat, c1, c2).from(cat, c1, c2); + assertEquals(1, query.getMetadata().getJoins().size()); + } @Test