From 44e551bf4ee732af52f934da42ae8296da7d3f6c Mon Sep 17 00:00:00 2001 From: Tillerino Date: Sun, 25 Oct 2015 21:49:25 +0100 Subject: [PATCH] Fixed detach for Collections. --- .../src/main/java/com/querydsl/jdo/AbstractJDOQuery.java | 2 +- .../test/java/com/querydsl/jdo/JDOQueryStandardTest.java | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/querydsl-jdo/src/main/java/com/querydsl/jdo/AbstractJDOQuery.java b/querydsl-jdo/src/main/java/com/querydsl/jdo/AbstractJDOQuery.java index 8e1aaf552..0639189bd 100644 --- a/querydsl-jdo/src/main/java/com/querydsl/jdo/AbstractJDOQuery.java +++ b/querydsl-jdo/src/main/java/com/querydsl/jdo/AbstractJDOQuery.java @@ -177,7 +177,7 @@ public abstract class AbstractJDOQuery> exte @SuppressWarnings("unchecked") private T detach(T results) { if (results instanceof Collection) { - return (T) persistenceManager.detachCopyAll(results); + return (T) persistenceManager.detachCopyAll((Collection) results); } else { return persistenceManager.detachCopy(results); } diff --git a/querydsl-jdo/src/test/java/com/querydsl/jdo/JDOQueryStandardTest.java b/querydsl-jdo/src/test/java/com/querydsl/jdo/JDOQueryStandardTest.java index 30dee3b26..77413adfc 100644 --- a/querydsl-jdo/src/test/java/com/querydsl/jdo/JDOQueryStandardTest.java +++ b/querydsl-jdo/src/test/java/com/querydsl/jdo/JDOQueryStandardTest.java @@ -30,7 +30,9 @@ import com.querydsl.core.types.ParamNotSetException; import com.querydsl.core.types.Predicate; import com.querydsl.core.types.Projections; import com.querydsl.core.types.dsl.Param; +import com.querydsl.jdo.test.domain.Book; import com.querydsl.jdo.test.domain.Product; +import com.querydsl.jdo.test.domain.QBook; import com.querydsl.jdo.test.domain.QProduct; import com.querydsl.jdo.test.domain.QStore; import com.querydsl.jdo.test.domain.Store; @@ -185,4 +187,10 @@ public class JDOQueryStandardTest extends AbstractJDOTest { .select(product.name).fetchFirst()); } + @Test + public void DetatchCollection() { + new JDOQuery(pm, true) + .select(QBook.book).from(QBook.book) + .fetch(); + } }