From d11d9d2c3bc776881ac3b5a48362f699bfb69fe1 Mon Sep 17 00:00:00 2001 From: Kirill Vlasov Date: Thu, 31 Dec 2015 11:51:43 +0500 Subject: [PATCH] Fixing squid:S2583 - Conditions should not unconditionally evaluate to "TRUE" or to "FALSE" --- .../src/main/java/com/querydsl/apt/VisitorConfig.java | 4 ++-- .../java/com/querydsl/sql/teradata/SetQueryBandClause.java | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/querydsl-apt/src/main/java/com/querydsl/apt/VisitorConfig.java b/querydsl-apt/src/main/java/com/querydsl/apt/VisitorConfig.java index b80eca3e2..860df2186 100644 --- a/querydsl-apt/src/main/java/com/querydsl/apt/VisitorConfig.java +++ b/querydsl-apt/src/main/java/com/querydsl/apt/VisitorConfig.java @@ -51,9 +51,9 @@ public enum VisitorConfig { public static VisitorConfig get(boolean fields, boolean methods, VisitorConfig defaultConfig) { if (fields && methods) { return VisitorConfig.ALL; - } else if (fields && !methods) { + } else if (fields) { return VisitorConfig.FIELDS_ONLY; - } else if (methods && !fields) { + } else if (methods) { return VisitorConfig.METHODS_ONLY; } else { return defaultConfig; diff --git a/querydsl-sql/src/main/java/com/querydsl/sql/teradata/SetQueryBandClause.java b/querydsl-sql/src/main/java/com/querydsl/sql/teradata/SetQueryBandClause.java index bf0399aea..3979ce359 100644 --- a/querydsl-sql/src/main/java/com/querydsl/sql/teradata/SetQueryBandClause.java +++ b/querydsl-sql/src/main/java/com/querydsl/sql/teradata/SetQueryBandClause.java @@ -124,7 +124,7 @@ public class SetQueryBandClause extends AbstractSQLClause { + (forSession ? "' for session" : "' for transaction"); parameter = null; } else { - queryString = "set query_band=?" + (forSession ? " for session" : " for transaction"); + queryString = "set query_band=? for transaction"; parameter = builder.toString(); }