diff --git a/querydsl-core/src/main/java/com/mysema/query/JoinFlag.java b/querydsl-core/src/main/java/com/mysema/query/JoinFlag.java index 51f2d7062..76e4afd0d 100644 --- a/querydsl-core/src/main/java/com/mysema/query/JoinFlag.java +++ b/querydsl-core/src/main/java/com/mysema/query/JoinFlag.java @@ -10,7 +10,7 @@ import java.io.Serializable; import net.jcip.annotations.Immutable; import com.mysema.query.types.Expression; -import com.mysema.query.types.template.StringTemplate; +import com.mysema.query.types.TemplateExpressionImpl; /** * JoinFlag defines a join related flag using an Expr instance @@ -26,7 +26,7 @@ public class JoinFlag implements Serializable{ private final Expression flag; public JoinFlag(String flag) { - this.flag = StringTemplate.create(flag); + this.flag = TemplateExpressionImpl.create(flag); } public JoinFlag(Expression flag) { diff --git a/querydsl-core/src/main/java/com/mysema/query/QueryFlag.java b/querydsl-core/src/main/java/com/mysema/query/QueryFlag.java index ce88debab..88f42fb0e 100644 --- a/querydsl-core/src/main/java/com/mysema/query/QueryFlag.java +++ b/querydsl-core/src/main/java/com/mysema/query/QueryFlag.java @@ -11,7 +11,7 @@ import net.jcip.annotations.Immutable; import com.mysema.commons.lang.Assert; import com.mysema.query.types.Expression; -import com.mysema.query.types.template.StringTemplate; +import com.mysema.query.types.TemplateExpressionImpl; /** * Defines a positioned flag in a query for customization of query serialization @@ -59,7 +59,7 @@ public class QueryFlag implements Serializable{ private final Expression flag; public QueryFlag(Position position, String flag) { - this(position, StringTemplate.create(flag)); + this(position, TemplateExpressionImpl.create(flag)); } public QueryFlag(Position position, Expression flag) { diff --git a/querydsl-core/src/main/java/com/mysema/query/types/PathImpl.java b/querydsl-core/src/main/java/com/mysema/query/types/PathImpl.java index 213515dd4..d365088ce 100644 --- a/querydsl-core/src/main/java/com/mysema/query/types/PathImpl.java +++ b/querydsl-core/src/main/java/com/mysema/query/types/PathImpl.java @@ -12,7 +12,7 @@ import javax.annotation.Nullable; import com.mysema.util.ReflectionUtils; /** - * PathImpl defines a mixin version of the Path interface which can be used + * PathImpl defines a default implementation of the Path interface which can be used * as a component and target in actual Path implementations * * @author tiwe diff --git a/querydsl-core/src/main/java/com/mysema/query/types/TemplateExpression.java b/querydsl-core/src/main/java/com/mysema/query/types/TemplateExpression.java index 0950a8cc6..13e979f96 100644 --- a/querydsl-core/src/main/java/com/mysema/query/types/TemplateExpression.java +++ b/querydsl-core/src/main/java/com/mysema/query/types/TemplateExpression.java @@ -8,7 +8,7 @@ package com.mysema.query.types; import java.util.List; /** - * Custom provides base types for custom expressions with integrated + * TemplateExpression provides base types for custom expressions with integrated * serialization templates * * @author tiwe diff --git a/querydsl-core/src/main/java/com/mysema/query/types/TemplateImpl.java b/querydsl-core/src/main/java/com/mysema/query/types/TemplateExpressionImpl.java similarity index 65% rename from querydsl-core/src/main/java/com/mysema/query/types/TemplateImpl.java rename to querydsl-core/src/main/java/com/mysema/query/types/TemplateExpressionImpl.java index 41d0972a9..b62e54648 100644 --- a/querydsl-core/src/main/java/com/mysema/query/types/TemplateImpl.java +++ b/querydsl-core/src/main/java/com/mysema/query/types/TemplateExpressionImpl.java @@ -5,17 +5,18 @@ */ package com.mysema.query.types; +import java.util.Arrays; import java.util.List; /** - * Mixin implementation of the TemplateExpression interface + * Default implementation of the TemplateExpression interface * * @author tiwe * * @param */ -public class TemplateImpl extends ExpressionBase implements TemplateExpression { +public class TemplateExpressionImpl extends ExpressionBase implements TemplateExpression { private static final long serialVersionUID = 6951623726800809083L; @@ -23,7 +24,15 @@ public class TemplateImpl extends ExpressionBase implements TemplateExpres private final Template template; - public TemplateImpl(Class type, List> args, Template template){ + public static Expression create(String template, Expression... args){ + return create(TemplateFactory.DEFAULT.create(template), args); + } + + public static Expression create(Template template, Expression... args){ + return new TemplateExpressionImpl(String.class, Arrays.>asList(args), template); + } + + public TemplateExpressionImpl(Class type, List> args, Template template){ super(type); this.args = args; this.template = template; diff --git a/querydsl-core/src/main/java/com/mysema/query/types/template/BooleanTemplate.java b/querydsl-core/src/main/java/com/mysema/query/types/template/BooleanTemplate.java index 59328ee93..94b1f1a32 100644 --- a/querydsl-core/src/main/java/com/mysema/query/types/template/BooleanTemplate.java +++ b/querydsl-core/src/main/java/com/mysema/query/types/template/BooleanTemplate.java @@ -12,7 +12,7 @@ import com.mysema.query.types.TemplateExpression; import com.mysema.query.types.Expression; import com.mysema.query.types.Template; import com.mysema.query.types.TemplateFactory; -import com.mysema.query.types.TemplateImpl; +import com.mysema.query.types.TemplateExpressionImpl; import com.mysema.query.types.Visitor; import com.mysema.query.types.expr.BooleanExpression; @@ -34,10 +34,10 @@ public class BooleanTemplate extends BooleanExpression implements TemplateExpres return new BooleanTemplate(template, Arrays.>asList(args)); } - private final TemplateExpression customMixin; + private final TemplateExpression templateMixin; public BooleanTemplate(Template template, List> args){ - customMixin = new TemplateImpl(Boolean.class, args, template); + templateMixin = new TemplateExpressionImpl(Boolean.class, args, template); } @Override @@ -47,22 +47,22 @@ public class BooleanTemplate extends BooleanExpression implements TemplateExpres @Override public Expression getArg(int index) { - return customMixin.getArg(index); + return templateMixin.getArg(index); } @Override public List> getArgs() { - return customMixin.getArgs(); + return templateMixin.getArgs(); } @Override public Template getTemplate() { - return customMixin.getTemplate(); + return templateMixin.getTemplate(); } @Override public boolean equals(Object o){ - return customMixin.equals(o); + return templateMixin.equals(o); } @Override diff --git a/querydsl-core/src/main/java/com/mysema/query/types/template/ComparableTemplate.java b/querydsl-core/src/main/java/com/mysema/query/types/template/ComparableTemplate.java index c50e7ec83..97cffbfa9 100644 --- a/querydsl-core/src/main/java/com/mysema/query/types/template/ComparableTemplate.java +++ b/querydsl-core/src/main/java/com/mysema/query/types/template/ComparableTemplate.java @@ -12,7 +12,7 @@ import com.mysema.query.types.TemplateExpression; import com.mysema.query.types.Expression; import com.mysema.query.types.Template; import com.mysema.query.types.TemplateFactory; -import com.mysema.query.types.TemplateImpl; +import com.mysema.query.types.TemplateExpressionImpl; import com.mysema.query.types.Visitor; import com.mysema.query.types.expr.ComparableExpression; @@ -35,11 +35,11 @@ public class ComparableTemplate> extends ComparableExpre return new ComparableTemplate(type, template, Arrays.>asList(args)); } - private final TemplateExpression customMixin; + private final TemplateExpression templateMixin; public ComparableTemplate(Class type, Template template, List> args) { super(type); - customMixin = new TemplateImpl(type, args, template); + templateMixin = new TemplateExpressionImpl(type, args, template); } @Override @@ -49,22 +49,22 @@ public class ComparableTemplate> extends ComparableExpre @Override public Expression getArg(int index) { - return customMixin.getArg(index); + return templateMixin.getArg(index); } @Override public List> getArgs() { - return customMixin.getArgs(); + return templateMixin.getArgs(); } @Override public Template getTemplate() { - return customMixin.getTemplate(); + return templateMixin.getTemplate(); } @Override public boolean equals(Object o){ - return customMixin.equals(o); + return templateMixin.equals(o); } @Override diff --git a/querydsl-core/src/main/java/com/mysema/query/types/template/DateTemplate.java b/querydsl-core/src/main/java/com/mysema/query/types/template/DateTemplate.java index 465bfaea4..601e72c8c 100644 --- a/querydsl-core/src/main/java/com/mysema/query/types/template/DateTemplate.java +++ b/querydsl-core/src/main/java/com/mysema/query/types/template/DateTemplate.java @@ -12,7 +12,7 @@ import com.mysema.query.types.TemplateExpression; import com.mysema.query.types.Expression; import com.mysema.query.types.Template; import com.mysema.query.types.TemplateFactory; -import com.mysema.query.types.TemplateImpl; +import com.mysema.query.types.TemplateExpressionImpl; import com.mysema.query.types.Visitor; import com.mysema.query.types.expr.DateExpression; @@ -33,11 +33,11 @@ public class DateTemplate> extends DateExpression imp return new DateTemplate(type, template, Arrays.>asList(args)); } - private final TemplateExpression customMixin; + private final TemplateExpression templateMixin; public DateTemplate(Class type, Template template, List> args) { super(type); - customMixin = new TemplateImpl(type, args, template); + templateMixin = new TemplateExpressionImpl(type, args, template); } @Override @@ -47,22 +47,22 @@ public class DateTemplate> extends DateExpression imp @Override public Expression getArg(int index) { - return customMixin.getArg(index); + return templateMixin.getArg(index); } @Override public List> getArgs() { - return customMixin.getArgs(); + return templateMixin.getArgs(); } @Override public Template getTemplate() { - return customMixin.getTemplate(); + return templateMixin.getTemplate(); } @Override public boolean equals(Object o){ - return customMixin.equals(o); + return templateMixin.equals(o); } @Override diff --git a/querydsl-core/src/main/java/com/mysema/query/types/template/DateTimeTemplate.java b/querydsl-core/src/main/java/com/mysema/query/types/template/DateTimeTemplate.java index f1b44c015..2c6e66c44 100644 --- a/querydsl-core/src/main/java/com/mysema/query/types/template/DateTimeTemplate.java +++ b/querydsl-core/src/main/java/com/mysema/query/types/template/DateTimeTemplate.java @@ -12,7 +12,7 @@ import com.mysema.query.types.TemplateExpression; import com.mysema.query.types.Expression; import com.mysema.query.types.Template; import com.mysema.query.types.TemplateFactory; -import com.mysema.query.types.TemplateImpl; +import com.mysema.query.types.TemplateExpressionImpl; import com.mysema.query.types.Visitor; import com.mysema.query.types.expr.DateTimeExpression; @@ -33,11 +33,11 @@ public class DateTimeTemplate> extends DateTimeExpressio return new DateTimeTemplate(type, template, Arrays.>asList(args)); } - private final TemplateExpression customMixin; + private final TemplateExpression templateMixin; public DateTimeTemplate(Class type, Template template, List> args) { super(type); - customMixin = new TemplateImpl(type, args, template); + templateMixin = new TemplateExpressionImpl(type, args, template); } @Override @@ -47,22 +47,22 @@ public class DateTimeTemplate> extends DateTimeExpressio @Override public Expression getArg(int index) { - return customMixin.getArg(index); + return templateMixin.getArg(index); } @Override public List> getArgs() { - return customMixin.getArgs(); + return templateMixin.getArgs(); } @Override public Template getTemplate() { - return customMixin.getTemplate(); + return templateMixin.getTemplate(); } @Override public boolean equals(Object o){ - return customMixin.equals(o); + return templateMixin.equals(o); } @Override diff --git a/querydsl-core/src/main/java/com/mysema/query/types/template/EnumTemplate.java b/querydsl-core/src/main/java/com/mysema/query/types/template/EnumTemplate.java index 0f7940269..79812a305 100644 --- a/querydsl-core/src/main/java/com/mysema/query/types/template/EnumTemplate.java +++ b/querydsl-core/src/main/java/com/mysema/query/types/template/EnumTemplate.java @@ -12,7 +12,7 @@ import com.mysema.query.types.TemplateExpression; import com.mysema.query.types.Expression; import com.mysema.query.types.Template; import com.mysema.query.types.TemplateFactory; -import com.mysema.query.types.TemplateImpl; +import com.mysema.query.types.TemplateExpressionImpl; import com.mysema.query.types.Visitor; import com.mysema.query.types.expr.EnumExpression; @@ -35,11 +35,11 @@ public class EnumTemplate> extends EnumExpression implement return new EnumTemplate(type, template, Arrays.>asList(args)); } - private final TemplateExpression customMixin; + private final TemplateExpression templateMixin; public EnumTemplate(Class type, Template template, List> args) { super(type); - customMixin = new TemplateImpl(type, args, template); + templateMixin = new TemplateExpressionImpl(type, args, template); } @Override @@ -49,22 +49,22 @@ public class EnumTemplate> extends EnumExpression implement @Override public Expression getArg(int index) { - return customMixin.getArg(index); + return templateMixin.getArg(index); } @Override public List> getArgs() { - return customMixin.getArgs(); + return templateMixin.getArgs(); } @Override public Template getTemplate() { - return customMixin.getTemplate(); + return templateMixin.getTemplate(); } @Override public boolean equals(Object o){ - return customMixin.equals(o); + return templateMixin.equals(o); } @Override diff --git a/querydsl-core/src/main/java/com/mysema/query/types/template/NumberTemplate.java b/querydsl-core/src/main/java/com/mysema/query/types/template/NumberTemplate.java index 39dd73492..54ac1191e 100644 --- a/querydsl-core/src/main/java/com/mysema/query/types/template/NumberTemplate.java +++ b/querydsl-core/src/main/java/com/mysema/query/types/template/NumberTemplate.java @@ -12,7 +12,7 @@ import com.mysema.query.types.TemplateExpression; import com.mysema.query.types.Expression; import com.mysema.query.types.Template; import com.mysema.query.types.TemplateFactory; -import com.mysema.query.types.TemplateImpl; +import com.mysema.query.types.TemplateExpressionImpl; import com.mysema.query.types.Visitor; import com.mysema.query.types.expr.NumberExpression; @@ -35,11 +35,11 @@ public class NumberTemplate> extends NumberExpr return new NumberTemplate(type, template, Arrays.>asList(args)); } - private final TemplateExpression customMixin; + private final TemplateExpression templateMixin; public NumberTemplate(Class type, Template template, List> args) { super(type); - customMixin = new TemplateImpl(type, args, template); + templateMixin = new TemplateExpressionImpl(type, args, template); } @Override @@ -49,22 +49,22 @@ public class NumberTemplate> extends NumberExpr @Override public Expression getArg(int index) { - return customMixin.getArg(index); + return templateMixin.getArg(index); } @Override public List> getArgs() { - return customMixin.getArgs(); + return templateMixin.getArgs(); } @Override public Template getTemplate() { - return customMixin.getTemplate(); + return templateMixin.getTemplate(); } @Override public boolean equals(Object o){ - return customMixin.equals(o); + return templateMixin.equals(o); } @Override diff --git a/querydsl-core/src/main/java/com/mysema/query/types/template/SimpleTemplate.java b/querydsl-core/src/main/java/com/mysema/query/types/template/SimpleTemplate.java index 7c8c11285..41a854263 100644 --- a/querydsl-core/src/main/java/com/mysema/query/types/template/SimpleTemplate.java +++ b/querydsl-core/src/main/java/com/mysema/query/types/template/SimpleTemplate.java @@ -12,7 +12,7 @@ import com.mysema.query.types.TemplateExpression; import com.mysema.query.types.Expression; import com.mysema.query.types.Template; import com.mysema.query.types.TemplateFactory; -import com.mysema.query.types.TemplateImpl; +import com.mysema.query.types.TemplateExpressionImpl; import com.mysema.query.types.Visitor; import com.mysema.query.types.expr.SimpleExpression; @@ -35,11 +35,11 @@ public class SimpleTemplate extends SimpleExpression implements TemplateEx return new SimpleTemplate(type, template, Arrays.>asList(args)); } - private final TemplateExpression customMixin; + private final TemplateExpression templateMixin; public SimpleTemplate(Class type, Template template, List> args) { super(type); - customMixin = new TemplateImpl(type, args, template); + templateMixin = new TemplateExpressionImpl(type, args, template); } @Override @@ -49,22 +49,22 @@ public class SimpleTemplate extends SimpleExpression implements TemplateEx @Override public Expression getArg(int index) { - return customMixin.getArg(index); + return templateMixin.getArg(index); } @Override public List> getArgs() { - return customMixin.getArgs(); + return templateMixin.getArgs(); } @Override public Template getTemplate() { - return customMixin.getTemplate(); + return templateMixin.getTemplate(); } @Override public boolean equals(Object o){ - return customMixin.equals(o); + return templateMixin.equals(o); } @Override diff --git a/querydsl-core/src/main/java/com/mysema/query/types/template/StringTemplate.java b/querydsl-core/src/main/java/com/mysema/query/types/template/StringTemplate.java index e4a52628f..fe7559a10 100644 --- a/querydsl-core/src/main/java/com/mysema/query/types/template/StringTemplate.java +++ b/querydsl-core/src/main/java/com/mysema/query/types/template/StringTemplate.java @@ -12,7 +12,7 @@ import com.mysema.query.types.TemplateExpression; import com.mysema.query.types.Expression; import com.mysema.query.types.Template; import com.mysema.query.types.TemplateFactory; -import com.mysema.query.types.TemplateImpl; +import com.mysema.query.types.TemplateExpressionImpl; import com.mysema.query.types.Visitor; import com.mysema.query.types.expr.StringExpression; @@ -34,10 +34,10 @@ public class StringTemplate extends StringExpression implements TemplateExpressi return new StringTemplate(template, Arrays.>asList(args)); } - private final TemplateExpression customMixin; + private final TemplateExpression templateMixin; public StringTemplate(Template template, List> args){ - customMixin = new TemplateImpl(String.class, args, template); + templateMixin = new TemplateExpressionImpl(String.class, args, template); } @Override @@ -47,22 +47,22 @@ public class StringTemplate extends StringExpression implements TemplateExpressi @Override public Expression getArg(int index) { - return customMixin.getArg(index); + return templateMixin.getArg(index); } @Override public List> getArgs() { - return customMixin.getArgs(); + return templateMixin.getArgs(); } @Override public Template getTemplate() { - return customMixin.getTemplate(); + return templateMixin.getTemplate(); } @Override public boolean equals(Object o){ - return customMixin.equals(o); + return templateMixin.equals(o); } @Override diff --git a/querydsl-core/src/main/java/com/mysema/query/types/template/TimeTemplate.java b/querydsl-core/src/main/java/com/mysema/query/types/template/TimeTemplate.java index 342d5a319..8edb59768 100644 --- a/querydsl-core/src/main/java/com/mysema/query/types/template/TimeTemplate.java +++ b/querydsl-core/src/main/java/com/mysema/query/types/template/TimeTemplate.java @@ -12,7 +12,7 @@ import com.mysema.query.types.Expression; import com.mysema.query.types.Template; import com.mysema.query.types.TemplateExpression; import com.mysema.query.types.TemplateFactory; -import com.mysema.query.types.TemplateImpl; +import com.mysema.query.types.TemplateExpressionImpl; import com.mysema.query.types.Visitor; import com.mysema.query.types.expr.TimeExpression; @@ -33,11 +33,11 @@ public class TimeTemplate> extends TimeExpression imp return new TimeTemplate(type, template, Arrays.>asList(args)); } - private final TemplateExpression customMixin; + private final TemplateExpression templateMixin; public TimeTemplate(Class type, Template template, List> args) { super(type); - customMixin = new TemplateImpl(type, args, template); + templateMixin = new TemplateExpressionImpl(type, args, template); } @Override @@ -47,22 +47,22 @@ public class TimeTemplate> extends TimeExpression imp @Override public Expression getArg(int index) { - return customMixin.getArg(index); + return templateMixin.getArg(index); } @Override public List> getArgs() { - return customMixin.getArgs(); + return templateMixin.getArgs(); } @Override public Template getTemplate() { - return customMixin.getTemplate(); + return templateMixin.getTemplate(); } @Override public boolean equals(Object o){ - return customMixin.equals(o); + return templateMixin.equals(o); } @Override diff --git a/querydsl-core/src/test/java/com/mysema/query/serialization/SerializerBaseTest.java b/querydsl-core/src/test/java/com/mysema/query/serialization/SerializerBaseTest.java index 18bebd8d7..9ce8945ec 100644 --- a/querydsl-core/src/test/java/com/mysema/query/serialization/SerializerBaseTest.java +++ b/querydsl-core/src/test/java/com/mysema/query/serialization/SerializerBaseTest.java @@ -11,9 +11,9 @@ import org.junit.Test; import com.mysema.query.types.ConstantImpl; import com.mysema.query.types.JavaTemplates; +import com.mysema.query.types.TemplateExpressionImpl; import com.mysema.query.types.path.PathBuilder; import com.mysema.query.types.path.StringPath; -import com.mysema.query.types.template.StringTemplate; public class SerializerBaseTest { @@ -30,7 +30,7 @@ public class SerializerBaseTest { // constant serializer.handle(ConstantImpl.create("")); // custom - serializer.handle(StringTemplate.create("xxx", ConstantImpl.create(""))); + serializer.handle(TemplateExpressionImpl.create("xxx", ConstantImpl.create(""))); } }