diff --git a/querydsl-core/src/main/java/com/querydsl/core/types/ConstantImpl.java b/querydsl-core/src/main/java/com/querydsl/core/types/ConstantImpl.java index 96c9f610d..2157ac187 100644 --- a/querydsl-core/src/main/java/com/querydsl/core/types/ConstantImpl.java +++ b/querydsl-core/src/main/java/com/querydsl/core/types/ConstantImpl.java @@ -28,50 +28,53 @@ public final class ConstantImpl extends ExpressionBase implements Constant private static final int CACHE_SIZE = 256; - @SuppressWarnings({"rawtypes", "unchecked"}) //generic array creation not possible - private static final Constant[] CHARACTERS = new Constant[CACHE_SIZE]; + private static class Constants { - @SuppressWarnings({"rawtypes", "unchecked"}) //generic array creation not possible - private static final Constant[] BYTES = new Constant[CACHE_SIZE]; + @SuppressWarnings({"rawtypes", "unchecked"}) //generic array creation not possible + private static final Constant[] CHARACTERS = new Constant[CACHE_SIZE]; - @SuppressWarnings({"rawtypes", "unchecked"}) //generic array creation not possible - private static final Constant[] INTEGERS = new Constant[CACHE_SIZE]; + @SuppressWarnings({"rawtypes", "unchecked"}) //generic array creation not possible + private static final Constant[] BYTES = new Constant[CACHE_SIZE]; - @SuppressWarnings({"rawtypes", "unchecked"}) //generic array creation not possible - private static final Constant[] LONGS = new Constant[CACHE_SIZE]; + @SuppressWarnings({"rawtypes", "unchecked"}) //generic array creation not possible + private static final Constant[] INTEGERS = new Constant[CACHE_SIZE]; - @SuppressWarnings({"rawtypes", "unchecked"}) //generic array creation not possible - private static final Constant[] SHORTS = new Constant[CACHE_SIZE]; + @SuppressWarnings({"rawtypes", "unchecked"}) //generic array creation not possible + private static final Constant[] LONGS = new Constant[CACHE_SIZE]; - private static final Constant FALSE = new ConstantImpl(Boolean.FALSE); + @SuppressWarnings({"rawtypes", "unchecked"}) //generic array creation not possible + private static final Constant[] SHORTS = new Constant[CACHE_SIZE]; - private static final Constant TRUE = new ConstantImpl(Boolean.TRUE); + private static final Constant FALSE = new ConstantImpl(Boolean.FALSE); - static { - for (int i = 0; i < CACHE_SIZE; i++) { - INTEGERS[i] = new ConstantImpl(Integer.class, i); - SHORTS[i] = new ConstantImpl(Short.class, (short) i); - BYTES[i] = new ConstantImpl(Byte.class, (byte) i); - CHARACTERS[i] = new ConstantImpl(Character.class, (char) i); - LONGS[i] = new ConstantImpl(Long.class, (long) i); + private static final Constant TRUE = new ConstantImpl(Boolean.TRUE); + + static { + for (int i = 0; i < CACHE_SIZE; i++) { + INTEGERS[i] = new ConstantImpl(Integer.class, i); + SHORTS[i] = new ConstantImpl(Short.class, (short) i); + BYTES[i] = new ConstantImpl(Byte.class, (byte) i); + CHARACTERS[i] = new ConstantImpl(Character.class, (char) i); + LONGS[i] = new ConstantImpl(Long.class, (long) i); + } } } public static Constant create(boolean b) { - return b ? TRUE : FALSE; + return b ? Constants.TRUE : Constants.FALSE; } public static Constant create(byte i) { - if (i >= 0 && i < CACHE_SIZE) { - return BYTES[i]; + if (i >= 0) { + return Constants.BYTES[i]; } else { return new ConstantImpl(Byte.class, i); } } public static Constant create(char i) { - if (i >= 0 && i < CACHE_SIZE) { - return CHARACTERS[i]; + if (i < CACHE_SIZE) { + return Constants.CHARACTERS[i]; } else { return new ConstantImpl(Character.class, i); } @@ -79,7 +82,7 @@ public final class ConstantImpl extends ExpressionBase implements Constant public static Constant create(int i) { if (i >= 0 && i < CACHE_SIZE) { - return INTEGERS[i]; + return Constants.INTEGERS[i]; } else { return new ConstantImpl(Integer.class, i); } @@ -87,7 +90,7 @@ public final class ConstantImpl extends ExpressionBase implements Constant public static Constant create(long i) { if (i >= 0 && i < CACHE_SIZE) { - return LONGS[(int) i]; + return Constants.LONGS[(int) i]; } else { return new ConstantImpl(Long.class, i); } @@ -95,7 +98,7 @@ public final class ConstantImpl extends ExpressionBase implements Constant public static Constant create(short i) { if (i >= 0 && i < CACHE_SIZE) { - return SHORTS[i]; + return Constants.SHORTS[i]; } else { return new ConstantImpl(Short.class, i); } diff --git a/querydsl-core/src/main/java/com/querydsl/core/types/dsl/DateExpression.java b/querydsl-core/src/main/java/com/querydsl/core/types/dsl/DateExpression.java index 167f9ebf7..027bb9966 100644 --- a/querydsl-core/src/main/java/com/querydsl/core/types/dsl/DateExpression.java +++ b/querydsl-core/src/main/java/com/querydsl/core/types/dsl/DateExpression.java @@ -33,7 +33,9 @@ import com.querydsl.core.types.Path; */ public abstract class DateExpression extends TemporalExpression { - private static final DateExpression CURRENT_DATE = currentDate(Date.class); + private static class Constants { + private static final DateExpression CURRENT_DATE = currentDate(Date.class); + } private static final long serialVersionUID = 6054664454254721302L; @@ -43,7 +45,7 @@ public abstract class DateExpression extends TemporalExpre * @return current date */ public static DateExpression currentDate() { - return CURRENT_DATE; + return Constants.CURRENT_DATE; } /** diff --git a/querydsl-core/src/main/java/com/querydsl/core/types/dsl/DateTimeExpression.java b/querydsl-core/src/main/java/com/querydsl/core/types/dsl/DateTimeExpression.java index 754ea6d27..f82c7a2fd 100644 --- a/querydsl-core/src/main/java/com/querydsl/core/types/dsl/DateTimeExpression.java +++ b/querydsl-core/src/main/java/com/querydsl/core/types/dsl/DateTimeExpression.java @@ -33,9 +33,10 @@ import com.querydsl.core.types.Path; */ public abstract class DateTimeExpression extends TemporalExpression { - private static final DateTimeExpression CURRENT_DATE = currentDate(Date.class); - - private static final DateTimeExpression CURRENT_TIMESTAMP = currentTimestamp(Date.class); + private static class Constants { + private static final DateTimeExpression CURRENT_DATE = currentDate(Date.class); + private static final DateTimeExpression CURRENT_TIMESTAMP = currentTimestamp(Date.class); + } private static final long serialVersionUID = -6879277113694148047L; @@ -45,7 +46,7 @@ public abstract class DateTimeExpression extends TemporalE * @return current date */ public static DateTimeExpression currentDate() { - return CURRENT_DATE; + return Constants.CURRENT_DATE; } /** @@ -63,7 +64,7 @@ public abstract class DateTimeExpression extends TemporalE * @return current timestamp */ public static DateTimeExpression currentTimestamp() { - return CURRENT_TIMESTAMP; + return Constants.CURRENT_TIMESTAMP; } /** diff --git a/querydsl-core/src/main/java/com/querydsl/core/types/dsl/NumberExpression.java b/querydsl-core/src/main/java/com/querydsl/core/types/dsl/NumberExpression.java index a973e68e2..23c4a0ad8 100644 --- a/querydsl-core/src/main/java/com/querydsl/core/types/dsl/NumberExpression.java +++ b/querydsl-core/src/main/java/com/querydsl/core/types/dsl/NumberExpression.java @@ -34,8 +34,9 @@ public abstract class NumberExpression> extends private static final long serialVersionUID = -5485902768703364888L; - @Nullable - private static final NumberExpression random = Expressions.numberOperation(Double.class, MathOps.RANDOM); + private static class Constants { + private static final NumberExpression RANDOM = Expressions.numberOperation(Double.class, MathOps.RANDOM); + } /** * Create a {@code max(left, right)} expression @@ -67,7 +68,7 @@ public abstract class NumberExpression> extends * @return random() */ public static NumberExpression random() { - return random; + return Constants.RANDOM; } @Nullable diff --git a/querydsl-core/src/main/java/com/querydsl/core/types/dsl/TimeExpression.java b/querydsl-core/src/main/java/com/querydsl/core/types/dsl/TimeExpression.java index b1ff81fb0..e0253ce37 100644 --- a/querydsl-core/src/main/java/com/querydsl/core/types/dsl/TimeExpression.java +++ b/querydsl-core/src/main/java/com/querydsl/core/types/dsl/TimeExpression.java @@ -33,7 +33,9 @@ public abstract class TimeExpression extends TemporalExpre private static final long serialVersionUID = 7360552308332457990L; - private static final TimeExpression