CodeCow/playwright-go
1
0
Fork 0
mirror of https://github.com/playwright-community/playwright-go.git synced 2026-06-03 21:02:27 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Revert "encrypted sensitive data"

Browse Source 
This reverts commit ccb9dd4dd6.
This commit is contained in:
KishorKumar 2025-09-17 22:30:32 +05:30
parent ccb9dd4dd6
commit 2aeadff577
2 changed files with 3 additions and 56 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
jsonPipe.go
View File

@ -39,18 +39,6 @@ func newJsonPipe(parent *channelOwner, objectType string, guid string, initializ
j.channel.On("message", func(ev map[string]interface{}) {
var msg message
m, err := json.Marshal(ev["message"])
// Ensure marshalled bytes are cleared after use - fixes memory dump visibility issue
defer func() {
if m != nil {
// Clear sensitive JSON data from memory to prevent memory dump exposure
for i := range m {
m[i] = 0
}
m = nil
}
}()
if err == nil {
err = json.Unmarshal(m, &msg)
}

47
transport.go
View File

@ -40,25 +40,13 @@ func (t *pipeTransport) Poll() (*message, error) {
return nil, fmt.Errorf("could not read protocol data: %w", err)
}
// Ensure data buffer is cleared after use - fixes memory dump visibility issue
defer func() {
// Clear sensitive JSON data from memory to prevent memory dump exposure
for i := range data {
data[i] = 0
}
data = nil
}()
msg := &message{}
if err := json.Unmarshal(data, &msg); err != nil {
return nil, fmt.Errorf("could not decode json: %w", err)
}
if os.Getenv("DEBUGP") != "" {
// Only show message metadata in debug, not content
fmt.Fprintf(os.Stdout, "\x1b[33mRECV>\x1b[0m Message ID: %d, Method: %s, GUID: %s\n",
msg.ID, msg.Method, msg.GUID)
fmt.Fprintf(os.Stdout, "\x1b[33mRECV>\x1b[0m\n%s\n", data)
}
// Only log metadata, not message content
return msg, nil
}
@ -81,42 +69,13 @@ func (t *pipeTransport) Send(msg map[string]interface{}) error {
if err != nil {
return fmt.Errorf("pipeTransport: could not marshal json: %w", err)
}
// Ensure msgBytes is cleared after use - fixes memory dump visibility issue
defer func() {
// Clear sensitive JSON data from memory to prevent memory dump exposure
for i := range msgBytes {
msgBytes[i] = 0
}
msgBytes = nil
}()
if os.Getenv("DEBUGP") != "" {
fmt.Fprintf(os.Stderr, "\x1b[32mSEND>\x1b[0m\n[JSON DATA REDACTED FOR SECURITY]\n")
fmt.Fprintf(os.Stdout, "\x1b[32mSEND>\x1b[0m\n%s\n", msgBytes)
}
lengthPadding := make([]byte, 4)
binary.LittleEndian.PutUint32(lengthPadding, uint32(len(msgBytes)))
// Create secure write buffer to avoid keeping msgBytes in append result
writeBuffer := make([]byte, 4+len(msgBytes))
copy(writeBuffer, lengthPadding)
copy(writeBuffer[4:], msgBytes)
// Clear intermediate buffers
for i := range lengthPadding {
lengthPadding[i] = 0
}
defer func() {
// Clear write buffer to prevent memory dump exposure
for i := range writeBuffer {
writeBuffer[i] = 0
}
writeBuffer = nil
}()
if _, err = t.writer.Write(writeBuffer); err != nil {
if _, err = t.writer.Write(append(lengthPadding, msgBytes...)); err != nil {
return err
}
return nil