Commit Graph

373 Commits

Author SHA1 Message Date
Eric Leung
8287438d57 Clarify Counting Cards instructions & add tests
- Clarify instructions by changing table column "Value" to "Count Change"
- Add two more tests with mix of 7, 8, 9 and other card values
2016-02-16 07:31:41 -08:00
Logan Tegman
866b14b61a Merge pull request #6925 from erictleung/fix/further-clarify-dot-operator
Clarify instructions on saving object properties
2016-02-14 13:32:26 -08:00
Ankit Aggarwal
41e1c6a282 Improve test cases of Record Collection challenge 2016-02-12 19:15:28 +05:30
Eric Leung
e24abbdf29 Clarify instructions on saving object properties 2016-02-11 19:12:33 -08:00
Rex Schrader
5026ba7fde Migrate invalid Challenge IDs 2016-02-10 15:18:48 -08:00
Alister N. Mada
7ad4ef5b44 Fix test for Iterate Through An Array With For Loop 2016-02-10 06:29:11 +07:00
Joshua Henson
9a0bc20667 Clarify "Nest one Array..." challenge to include multiple arrays 2016-02-06 11:27:54 -08:00
Rex Schrader
b62f675802 Merge pull request #6729 from alistermada/fix/test-for-loop-challenge-too-strict
Fix test for Iterate Through an Array with a For Loop
2016-02-05 20:35:57 -08:00
Alister N. Mada
493b7f4f15 Make Iterate Through Array for loop test less strict 2016-02-05 14:21:49 +07:00
Mrugesh Mohapatra
0608c759e2 Fix Range Error : Maximum Call Stack Size Exceeded
This commit fixes the `capture` console.log, with an alternate logic
to resolve the objects with correct scope.

Refer the PR FreeCodeCamp/FreeCodeCamp#6681 discussion for details.
Tested locally.

Updated fix to resolve broken CI
2016-02-04 14:51:37 +05:30
Quincy Larson
23aa1db530 Merge pull request #6562 from SaintPeter/fix/restore-es-translations
Restore Prior Spanish Translations to basic-javascript.json
2016-02-02 00:16:39 -08:00
Mrugesh Mohapatra
509ae8a6c5 Add Instructions Clarification to Using Objects for Lookups
This commit adds clarification to the Instructions.
Tested locally.
2016-02-02 02:17:56 +05:30
BKinahan
a7869cf072 Changed 'will gives' to 'will give'
Corrected typo for challenge Generate Random Whole Numbers with Javascript, 'will gives' to 'will give'.
2016-02-01 11:24:19 +00:00
Eric Leung
cbcdb8df4f Clarify escape literal quotes instructions
- Change example quote to valid JavaScript
- Add example of what you will get if you print said example quote
- Place emphasis on "if" in the instructions so that it'll hopefully be clear
  you do not actually need to print it
2016-01-31 01:39:47 -08:00
Rex Schrader
ee2b7e5ef9 Merge pull request #6581 from raisedadead/fix/comparison-with-the-greater-than-or-equal-to-operator
Fix the test case for Comparison with operators
2016-01-30 11:35:53 -08:00
Rex Schrader
6292867132 Merge pull request #6583 from raisedadead/fix/undefined-is-not-explained
Add a hint to Return Early Pattern for Functions
2016-01-30 11:32:07 -08:00
Mrugesh Mohapatra
6761aa4aef Fix the test case for Comparison with operators
This commit fixes the test case with change to assert in one case,
and change to the test case message in another case.

I intentionally, changed the assert for one case and message for other

Tested locally.
2016-01-30 11:45:40 +05:30
Mrugesh Mohapatra
6af0f0f448 Add a hint to Return Early Pattern for Functions
This commit adds a hint as disccussed in the issue, to clarify,
the difference between `undefined` and `"undefined"`.

Tested locally.
2016-01-30 11:34:11 +05:30
Hallaathrad
7726989f9a Fix for "Multiple Identical Options in Switch Statements"
Corrects typo "ommitted".
Closes #6593
2016-01-29 22:58:29 -05:00
Rex Schrader
39b8ee0c97 Merge pull request #6567 from raisedadead/fix/introducing-javascript-object-notation-json
Fix the release year for Billy Joel - Piano Man
2016-01-29 09:26:52 -08:00
Mrugesh Mohapatra
2376c545ec Fix test case in Comparisons with the Logical And Operator
This fixes the test case to do the correct assert as per the message.

tested locally.
2016-01-29 13:55:59 +00:00
Mrugesh Mohapatra
74528cc98b Fix the release year for Billy Joel - Piano Man
This fixes the release year as mentioned in the issue.
Hope the fans will forgive us!

Tested locally.
closes #6561
2016-01-29 07:42:48 +00:00
SaintPeter
dac587cb67 Restore Prior Spanish Translations to basic-javascript.json
Tested Locally

Please review, @vtamara
2016-01-28 20:07:34 -08:00
Rex Schrader
495022aebe Merge pull request #6529 from robjloranger/fix/all-greaterthan-quotes
Fix for greater than + less than quotes
2016-01-28 10:20:48 -08:00
Alister N. Mada
ce38b2931e Fix test for Comparison with the Equality Operator 2016-01-28 11:15:52 +07:00
robjloranger
3a2fb76fa0 fixing regex asserts
Changed all regex test to accept option single/double quotes around digits in comparrisons.
Used ('|\")*

Mistakenly had strict comparisons changed, reverted those.

fixed typo

one last typo

how did i miss so many errors

last error i hope

..last .. one ..
2016-01-28 03:15:13 +00:00
Rex Schrader
f487270d23 Merge pull request #6467 from tahmid-ul/fix/improve-assignment-with-a-returned-value
Assignment with a Returned Value - Improved Challenge Seed
2016-01-27 10:58:27 -08:00
Rex Schrader
e4cf49807b Merge pull request #6455 from alistermada/fix/more-tests-basic-javascript
Add more tests for Basic JavaScript challenges
2016-01-27 10:55:59 -08:00
Tahmid ul karim
f2adce323e Improved Challenge Seed
Assignment with a Returned Value .
2016-01-26 21:36:55 +06:00
Eric Leung
c0dfcb1b39 Adds spaces between paragraphs
Tested locally. Closes #6374
2016-01-26 07:36:55 -08:00
Alister N. Mada
5a253e6027 Remove extra spaces from Basic Javascript challenge description 2016-01-26 17:24:21 +07:00
Alister N. Mada
5a1bbd158e Add more tests for Basic JavaScript challenges 2016-01-26 16:37:26 +07:00
Rex Schrader
e108861efa Merge pull request #6437 from raisedadead/fix/change-instruction-accesing-nested-objects-in-json
Fix the instruction text in the Accessing Nested objects challenge
2016-01-25 11:53:24 -08:00
Tahmid ul karim
3c9cf77f38 Removed double quotes
closes #5825
2016-01-25 21:19:59 +06:00
Mrugesh Mohapatra
8894ccd588 Fix the instruction text in the Accessing Nested objects challenge
This commit fixes the instruction text in the challenge to
`Use bracket notation for properties with a space in their name.`
from
`Only use object notation for properties with a space in their name.`
I have removed the extra `Only` on purpose for sake of grammar.

closes #6422
2016-01-25 12:13:50 +00:00
Arsen Melikyan
2c8952f9b3 Merge pull request #6415 from erictleung/fix/extra-spacing-in-editor
Remove unnecessary spaces in the editor
2016-01-25 11:11:25 +04:00
Arsen Melikyan
3a94ec2262 Merge pull request #6417 from erictleung/fix/add-open-new-tab-in-links
Added "target='_blank'" to links missing them
2016-01-25 11:09:56 +04:00
Eric Leung
2394fcc961 Added "target='_blank'" to links missing them 2016-01-24 12:46:30 -08:00
Eric Leung
d6250452db Remove extra word of 'use' in range challenge 2016-01-24 12:24:41 -08:00
Eric Leung
09085a04a9 Remove unnecessary spaces in the editor 2016-01-24 12:19:26 -08:00
Tahmid ul karim
dee07e7980 fixed an issue #6380 .... basic-javascript.json
added 'or' in between greater than equal to.
2016-01-23 01:43:22 +06:00
greyhammer
bf4edcd0e6 fixed typo in seed/challenges/01-front-end-development-certification/basic-javascript.json, removed extra , at the end of the array 2016-01-22 08:16:38 -06:00
Eric Leung
52da4a599e Remove extra parenthesis in unshift challenge 2016-01-21 22:17:05 -08:00
Arsen Melikyan
60e0c8d3c9 Merge pull request #6337 from SaintPeter/fix/record-collection-description
Update Record Collection with Bracket Notation Note
2016-01-21 22:02:35 +04:00
Rex Schrader
feb466e109 Merge pull request #6357 from ChristianLapinig/fix/basic_js-comparison_eqaulity_operator-correct_instructions
Grammar fix for Comparison with the Equality Operator
2016-01-21 08:56:33 -08:00
Rex Schrader
6dee7b0e28 Update Record Collection with Bracket Notation Note 2016-01-21 08:53:59 -08:00
Christian Lapinig
026745c22b Correct grammar for instructions 2016-01-20 23:23:57 -08:00
SaintPeter
0c40a0599e Normalize Challenges for COM1000 2016-01-20 15:45:32 -08:00
Rex Schrader
92712c6e94 Merge pull request #6341 from erictleung/fix/clarify-instructions-for-dot-operator
Clarify instructions for dot operator challenge
2016-01-20 12:42:26 -08:00
Eric Leung
b20914ae44 Clarify instructions for dot operator challenge 2016-01-19 23:36:36 -08:00
Eric Leung
55a6ec68d3 Be more specific on what decimal number is needed 2016-01-19 21:15:28 -08:00
Rex Schrader
0bf884e55a Merge pull request #6316 from raisedadead/fix/remove-typeof-error-basic-javascript
Remove unnecessary parentheses around the typeof
2016-01-19 12:56:08 -08:00
Mrugesh Mohapatra
feddce4c3b Remove unnecessary parentheses around the typeof
This commit:
    * removes unnecessary parentheses around the typeof
    * certain cases were ignored, to prevent a test case failure for example as in:
       - assert(typeof(runSlots($(\".slot\"))[0]) ...

This PR is an additional fix in relation to code review comments on FreeCodeCamp/FreeCodeCamp#6181
2016-01-19 14:17:43 +00:00
Alister N. Mada
4122ca41ef Fix inconsistent font sizes in challenge descriptions 2016-01-19 16:41:53 +07:00
Rex Schrader
53bd841f9f Merge pull request #6300 from joshuahenson/fix/default-switch-challenge
Correct typo on default switch challenge
2016-01-18 21:13:38 -08:00
Derek Keith
510af2810b Remove code blocks within blockquotes.
This removes code blocks within blockquotes on the following challenges:

- Access MultiDimensional Arrays With Indexes
- Understand String Immutability

closes #6283
2016-01-18 21:33:07 -07:00
Joshua Henson
cb34bd232e Correct typo on default switch challenge 2016-01-18 20:02:16 -08:00
Arsen Melikyan
7b5d04b78c Merge pull request #6274 from erictleung/fix/myStr-in-code-tags
Add code tags to myStr in instructions
2016-01-18 10:03:15 +04:00
Eric Leung
bcb7717b0e Add code tags to myStr in instructions 2016-01-17 21:56:12 -08:00
Eric Leung
5ee869ef49 Clarify instructions and remove code tag from test 2016-01-17 21:45:56 -08:00
Eric Leung
bd4a3f4b94 Fix inconsistent If spacing in Basic Javascript 2016-01-17 15:55:35 -08:00
Rex Schrader
b46758f196 Merge pull request #6181 from raisedadead/fix/waypoint-accessing-objects-properties-with-variables
Add an addtional example code and fix the console output
2016-01-17 13:00:07 -08:00
Mrugesh Mohapatra
067b6cc1d6 Add and addtional example code and fix the console output
This commit:
 * Adds an addtional example to the challenge Waypoint: Accessing Objects Properties with Variables
 * Adds the tail to display the console output

Tested locally.
Closes #6112
2016-01-17 20:31:18 +00:00
Nick Duffy
b876dbfad7 Update Declare Javascript Variables description wording.
Closes #6253
2016-01-17 07:35:21 -07:00
regonn
474ce52c9d fix indent at challenges/basic-javascript 2016-01-16 15:56:16 +09:00
Arsen Melikyan
cebbce9c61 Merge pull request #6042 from SaintPeter/change/challenge-verbiage-improvement
Improve Basic Javascript Flow, Change Code Block Color
2016-01-16 09:41:40 +04:00
Rex Schrader
5a66ffa3ab Merge pull request #6175 from erictleung/fix/multi-line-code-block-tags
Replace multi-line code block tags with blockquote
2016-01-15 16:31:21 -08:00
Eric Leung
bc0fb76220 Replace multi-line code block tags with blockquote 2016-01-15 16:03:50 -08:00
SaintPeter
bf6fe9be18 Improve Basic Javascript Flow 2016-01-15 15:38:01 -08:00
Quincy Larson
4c1e4cbbf4 further improvements of challenge ssed for better looking views 2016-01-15 04:49:46 -08:00
Quincy Larson
0871a0dcf5 add chatroom names 2016-01-15 04:46:20 -08:00
Eric Leung
225f6fb2f7 Fix inconsistent function naming 2016-01-14 21:16:50 -08:00
Alister N. Mada
f2c8f9a4f4 Fix bug on Waypoint: Iterate Through an Array with a For Loop
Conditions needed to pass the tests weren't showing. Problem was that the variable `total` was passed before it could be defined. Rewrote tail to fix.
closes #6137
2016-01-15 06:13:31 +07:00
Eric Leung
fa6fcbf95c Fix spelling of intriguing 2016-01-13 13:18:30 -08:00
Alister N. Mada
2dc9cd97c7 Fixed several typos on Basic JavaScript Waypoints
There were some misspellings of the word "referred".
closes #6118
2016-01-13 17:01:46 +07:00
Logan Tegman
871cedef97 Fix multiple challenge typos 2016-01-12 15:26:04 -08:00
Mrugesh Mohapatra
2f79d84205 fixes FreeCodeCamp/FreeCodeCamp#6066 2016-01-12 03:04:13 +05:30
Rex Schrader
c5c007f7cd Merge pull request #6065 from raisedadead/fix/waypoint-assignment-with-a-returned-value-improve-example
Fixes the example text for Waypoint: Assignment with a Returned Value
2016-01-11 13:19:25 -08:00
Mrugesh Mohapatra
2f59d455fc fixes FreeCodeCamp/FreeCodeCamp#6062 2016-01-12 02:18:02 +05:30
Mrugesh Mohapatra
94cf065482 fixes FreeCodeCamp/FreeCodecamp#6055 2016-01-12 01:56:19 +05:30
Rex Schrader
5605525fe8 Merge pull request #6031 from patsul12/fix/add-tests-for-concat-waypoint
Add Tests to Concat with Plus Waypoint
2016-01-10 19:53:13 -08:00
patsul12
842c1638db add tests 2016-01-10 18:55:08 -08:00
patsul12
d3399c41f8 added new logical order waypoint 2016-01-10 14:58:46 -08:00
Eric Leung
2c21b67e03 Add missing period in instructions 2016-01-10 14:58:46 -08:00
Eric Leung
ebcf6f0aea Clarify output format for counting card Checkpoint 2016-01-10 14:58:46 -08:00
Akira Laine
bb974a666a fixed spacing issue on waypoint: counting cards
readded language stuff
2016-01-10 14:58:46 -08:00
Akira Laine
697a38d540 fixed semicolon typo 2016-01-10 14:58:46 -08:00
Eric Leung
fbf251f348 Add note on adding commas between JSON objects 2016-01-10 14:58:46 -08:00
Adegbuyi Ademola
84dec60b0b fixed waypoint ins .hasOwnProperty([propname]) 2016-01-10 14:58:46 -08:00
patsul12
efc36bd0a6 changed instructions to be more clear on data type wanted 2016-01-10 14:58:46 -08:00
Mrugesh Mohapatra
02cbd49d95 closes FreeCodeCamp/FreeCodeCamp#5938 2016-01-10 14:58:46 -08:00
Akira Laine
fcb143c340 created checkpoint: profile-lookup
made final changes

added release date to Jan 8

made 'prop' argument clearer
2016-01-10 14:58:46 -08:00
Peter Benjamin
34c739b732 Improve Waypoint: Generate Random Whole Numbers with Javascript description 2016-01-10 14:58:46 -08:00
Gaurav Makhecha
cdc29fa6e8 Add target to anchor in Waypoint Size Your Images
Mad Libs link in instructions missing the target attribute to new tab.
2016-01-10 14:58:46 -08:00
Xiangyun Chi
4504cab299 added test to check if the string matches exactly 2016-01-10 14:58:46 -08:00
Rex Schrader
faca93d1f5 Record Collection Instruction Clarification 2016-01-10 14:58:46 -08:00
Rex Schrader
353c67622d Fix Note, Example, and Hint Spacing 2016-01-10 14:58:46 -08:00
Rex Schrader
fdc8efee75 Stand In Line - Improve Clarity 2016-01-10 14:58:46 -08:00
Harsha
71113b843a add tail to escape-sequences waypoint 2016-01-10 14:58:46 -08:00
Logan Tegman
56ad20dbe2 Merge pull request #5979 from patsul12/add/logical-ordering-of-elsif-waypoint
added new logical order waypoint
2016-01-10 12:46:44 -08:00