Commit Graph

193 Commits

Author SHA1 Message Date
Ahmad Abdolsaheb
da17fc6a00
fix: clean expose_donate_button AB test (#51262) 2023-08-15 16:09:00 +05:30
Shaun Hamilton
f5d0adf448
fix(client): default examInProgress to false (#51079)
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2023-07-29 17:00:37 +03:00
Manabu Matsumoto
f132c7e644
fix(UI): adjust the behavior of the elements in navbar (#50852)
Co-authored-by: Muhammed Mustafa <MuhammedElruby@gmail.com>
2023-07-05 09:01:05 +02:00
Tom
6d3f41d6fe
feat(client): add exam nav (#50776) 2023-07-01 06:59:51 +02:00
Jacques Metevier
4a9c0a4886
chore: remove unused code (#50507) 2023-05-25 22:14:42 +03:00
Huyen Nguyen
e50dd4a905
fix(client): typo in function name (#50464) 2023-05-22 10:03:38 +00:00
Shubham Lal
132a862901
feat(client): add contribute button on header's navbar (#50400) 2023-05-19 19:33:41 +03:00
Muhammed Mustafa
39538c8b22
feat(client): polish the styles for the lang button (#50256)
Co-authored-by: ahmad abdolsaheb <ahmad.abdolsaheb@gmail.com>
2023-05-08 13:16:19 +05:30
Krzysztof G
45d2ffa676
fix(client): LanguageList export (#50268)
fix: LanguageList export
2023-05-03 22:51:26 +03:00
Muhammed Mustafa
f0aecf173d
feat(client): expose the language button to the navbar (#50084)
* feat(client): expose the language button to the navbar

* clean extra logic

Co-authored-by: Huyen Nguyen <25715018+huyenltnguyen@users.noreply.github.com>

* show the language menu

* set keyboard navigation logic

* change the language icon

* sort float values

* fix the test

* remove the menu roles from the languagelist

Co-authored-by: Bruce B <bbsmooth@gmail.com>

* add id to button and polish the attributes

Co-authored-by: Co-authored-by: Bruce B <bbsmooth@gmail.com>

* revert to production focus events

Co-authored-by: Co-authored-by: Bruce B <bbsmooth@gmail.com>

* fix the menu not closing and fix the label

Co-authored-by: Co-authored-by: Bruce B <bbsmooth@gmail.com>

* make event passing more explicit

Co-authored-by: Co-authored-by: Bruce B <bbsmooth@gmail.com>

* Let screenreaders annouce that the expand is closed

Co-authored-by: Bruce Blaser <bbsmooth@gmail.com>

* let screenreader annouce list is closed

Co-authored-by: Bruce Blaser <bbsmooth@gmail.com>

* polish the logic around the styling

Co-authored-by: Bruce Blaser <bbsmooth@gmail.com>

* add comment about accessiblity function

* oh right active doesn't work like that

* hide the menu if the click is outside it

Co-authored-by:  Bruce B <bbsmooth@gmail.com>

* fix the contrast in the check mark

Co-authored-by:  Bruce B <bbsmooth@gmail.com>

* Stop the menu closing when clicking on the searchbar

Co-authored-by: Bruce Blaser <bbsmooth@gmail.com>

* make the list hover and focus consistent

Co-authored-by: Co-authored-by:  Bruce B <bbsmooth@gmail.com>

---------

Co-authored-by: Huyen Nguyen <25715018+huyenltnguyen@users.noreply.github.com>
Co-authored-by: Bruce B <bbsmooth@gmail.com>
2023-04-26 22:44:03 +02:00
Muhammed Mustafa
6cbd6be1e5
feat(client): remove extra if statement in the navigation header (#50156) 2023-04-24 13:51:47 -07:00
Muhammed Mustafa
fa1b424488
feat(client): remove eslint comments in auth or profile file (#50162)
* feat(client): remove eslint comments in auth or profile file

* update user
2023-04-24 18:00:11 +02:00
Muhammed Mustafa
91aa8b4aca
refactor(client): remove extra property (#50116) 2023-04-21 19:09:00 +02:00
Muhammed Mustafa
8b72e9af5f
feat(client): move the variables from style element to CSS file (#50085)
* refactor(client): move the variables from style element to header property

* sort the test and fix wrong value

* remove the fallbacks

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>

---------

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2023-04-20 13:08:36 -07:00
Muhammed Mustafa
1c51071c0b
refactor(client): link themes types to its input (#49862)
* refactor(client): link themes types to its input

add type in the imports for readiblity

* align formValues Types
2023-04-20 12:11:46 -05:00
Muhammed Mustafa
2123b447bc
feat(client): hide the outline instead of removing it (#49716)
* feat(client): hide the outline instead of removing it

* remove the old :focus outline values

Co-authored-by: Bruce B <bbsmooth@gmail.com>

---------

Co-authored-by: Bruce B <bbsmooth@gmail.com>
2023-04-20 10:02:15 -05:00
Lasse Jørgensen
d717dbda82
fix(client): conditionally render #universal-nav-left (#50092) 2023-04-19 16:13:32 +05:30
Muhammed Mustafa
04c8861c3e
refactor(client): align nav-links types with universal-nav types (#49857)
Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>
2023-04-18 22:04:09 +07:00
Muhammed Mustafa
fed78de7a1
fix(client): hack the outline look for the logo in the nav bar (#49903)
Co-authored-by: Bruce B <bbsmooth@gmail.com>
2023-04-03 14:05:15 +05:30
Muhammed Mustafa
a8d5fdeec1
fix(client): remove boolean value for non boolean attribute (#49831) 2023-03-30 15:03:28 -05:00
a2937
7a904e2e17
chore(a11y): standardize keyboard focus (#49579)
* Create a focus indicator

* Use two different colors for the palletes.

* Use focus-visible instead.

* Remove redundant css

* Use blue-mid for the focus outline color.

* Add a global fallback.

* Clean up the rules some more.

* Remove some bootstrap styling.

* fix: display focus outline on all sides of lower jaw icon buttons

* fix: breadcrumb focus outlines

---------

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>
Co-authored-by: Bruce B <bbsmooth@gmail.com>
2023-03-24 20:31:55 +02:00
renovate[bot]
90efc43149
fix(deps): update dependency i18next to v22 (#49799)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Sboonny <muhammedelruby@gmail.com>
Co-authored-by: Muhammed Mustafa <muhammed@freecodecamp.org>
2023-03-24 01:02:33 +05:30
Muhammed Mustafa
5a2b5f1ed2
fix(client): stop margin from pushing outline out of the container (#49647)
* feat(client): stop margin from pushing outline out of the container

* remove the parent because it was breaking the layout on mobile devices

* sort the mobile and laptop layout

* remove extra property

* Update client/src/components/Header/components/universal-nav.css

* center the logo and fix the extra pixel issue

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>

* increase padding top

---------

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2023-03-21 13:56:04 +05:30
Ahmad Abdolsaheb
d3396a2017
feat(client): expose nav donate button for non-donor (#49705)
Co-authored-by: Muhammed Mustafa <muhammed@freecodecamp.org>
2023-03-21 13:31:44 +05:30
Mrugesh Mohapatra
e1f0ff5b60
chore: rename components in kebab-case (#49737) 2023-03-18 23:03:37 +07:00
Slieptsov Denys
e64bac9a3f
fix(learn): progress bar label alignment (#49659)
Co-authored-by: Denys Slieptsov <denys.slieptsov@leaseplan.com>
2023-03-15 13:15:39 +00:00
Ahmad Abdolsaheb
9340566428
feat(client): turn nav-links component functional (#49690)
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Muhammed Mustafa <muhammed@freecodecamp.org>
2023-03-13 13:33:40 +00:00
Oliver Eyton-Williams
66438c271f
fix: add more explicit return types (#49567) 2023-03-02 17:26:40 +00:00
Muhammed Mustafa
f56816d3e1
refactor(client): fix types in the nav-links file (#49291)
* refactor(client): clean some mistype errors in the nav-links file

* fix showLanguage prop type in the other files

* add-ts-ignore-comment

* swap to map for easier maintainablity

* Change the eslint naming comment

* fix: using the wrong handlekeydown function

Co-authored-by: Bruce B <bbsmooth@gmail.com>

* hide the menu when focus is on the userimage

* hide the menu only if camper didn't press shift key

---------

Co-authored-by: Bruce B <bbsmooth@gmail.com>
2023-02-22 05:36:05 +02:00
Muhammed Mustafa
e5bf2ae97e
feat(client): make skip to content button translatable (#49439) 2023-02-20 21:22:39 +05:30
Mrugesh Mohapatra
96a5699c39
chore: rename icons (#49319) 2023-02-10 13:11:16 +00:00
Manabu Matsumoto
4aa3b4d6ad
fix(UI): refactor the searchbar from flex to grid (#48944)
* fix: refactor the searchbar from flex to grid

* fix: refactor the way of displaying searchbar input outline

* chore: remove unnecessary border settings

* fix: follow the RTL support best practice

* fix: follow the RTL support best practice

* fix: remove unnecessary grid gap and refactor for RTL

* fix: refactor the padding setting with padding block

Co-authored-by: Muhammed Mustafa <muhammed@freecodecamp.org>

* fix: refactor the padding setting with padding inline

Co-authored-by: Muhammed Mustafa <muhammed@freecodecamp.org>

* fix: refactor the positioning of reset button in searchbar

Co-authored-by: Muhammed Mustafa <muhammed@freecodecamp.org>
2023-01-10 16:19:55 +09:00
Oliver Eyton-Williams
0a20f8fd73
refactor: remove a lot of unused code (#48935)
Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>
2023-01-07 10:33:35 +05:30
Ahmad Abdolsaheb
a73996c174
Revert "fix(client): expose donate button on navigation bar" (#48902)
Revert "fix(client): expose donate button on navigation bar (#48820)"

This reverts commit 959d667aeb.
2023-01-03 18:26:15 +05:30
Ahmad Abdolsaheb
959d667aeb
fix(client): expose donate button on navigation bar (#48820)
* feat: expose donate nav button

* feat: add the ignores

* fix: adjust tests

* feat: adjust nav button styles
2023-01-03 10:40:47 +01:00
Muhammed Mustafa
1d3786f653
fix: spacing issue in RTL layout (#48824) 2023-01-02 23:08:28 +05:30
Manabu Matsumoto
95b724a3a2
feat(UI): visualize input clear button (#48702)
* feat: visualize search bar inputs clear button

* chore: remove redundant empty lines

* fix: make search bar input horizontally responsive

* fix: make search bar input width follow suggestion items

* fix: moving clear button to right of the searchbar

* feat: add search bar clear button in LP

* fix: add a bigger spacing between the icons and the text

* fix: make the clear button show visible focus indicator

* chore: refactor the css code to avoid redundancy

* fix: make the buttons in search bar accessible for screen reader

* fix: make the buttons and input in search bar more accessible
2022-12-23 17:00:38 -06:00
Muhammed Mustafa
8cc575c9b9
feat: swap to logical properties for spacing (#48769) 2022-12-22 10:51:19 +05:30
Muhammed Mustafa
4291e153f7
feat: add RTL language layout (#48287)
* add the previous layout

* add the import logic

Co-authored-by: Nestor <elnestinatorHD@gmail.com>

* WIP: RTL layout

* WIP: code snippet

* WIP: RTL layout

* WIP: RTL layout

* WIP: add selector that don't work

* WIP: fix code in tables direction

* change the dynamic import to static import

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* remove redundant imports

* fix the broken splitter and broken code element

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* revert the wrapper editor layout

* WIP: Timeline RTL layout

* add row reverse to account for splitter direction reverse

* Revert "add row reverse to account for splitter direction reverse"

This reverts commit f67ad002c8.

* add row reverse to account for splitter direction reverse

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>

* mirrior the nav bar by placing the logo in the right

* Use notosans as RTL font family

* Remove Arabic from the hiddenLangs

* fix(feedbac): the search and table alignment

Co-authored-by: Zaira <33151350+zairahira@users.noreply.github.com>

* fix(feedback): text alignment, icons rotation

Co-authered-by: moT01 <20648924+moT01@users.noreply.github.com>

* Revert "fix(feedback): text alignment, icons rotation"

This reverts commit 0c6dc4f909.

* fix(feedback): text-alignment, and icon rotation

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>

Co-authored-by: Nestor <elnestinatorHD@gmail.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>
Co-authored-by: Zaira <33151350+zairahira@users.noreply.github.com>
Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2022-12-16 18:03:18 +02:00
Muhammed Mustafa
b5371f56ce
refactor(client): searchbar - remove float values (#48292)
* feat(client): refactor searchbar by removing float values

* polish the style by adding border radius and removing padding

* Polish the style and account for donation text

* WIP: remove float values

* Revert "WIP: remove float values"

This reverts commit c1c32aa9d1.

* adjust magic numbers

* Adjust spacing to account and add position absolute

* revert the deletion of ais hits values

* move the padding value to searchbar file

* Remove RTL Values

* feat: allow for hint expansions

* Remove the left value on submit icon

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>

* add display none and remove their values

Co-authored-by: ahmad abdolsaheb <ahmad.abdolsaheb@gmail.com>
2022-12-08 14:31:05 +01:00
Tom
5f73773cd4
feat(client): move legacy rwd button to bottom of map (#47596)
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Closes https://github.com/freeCodeCamp/freeCodeCamp/issues/46523
2022-11-08 21:00:46 +05:30
Oliver Eyton-Williams
ecfe09c52d
fix: confirm modal (#48388)
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
2022-11-04 11:06:47 +00:00
Mrugesh Mohapatra
75f4ff10d5
feat(client): add a confirmation modal on signout (#48385)
* feat(client): add a confirmation modal on signout

* test: add and update universal nav

* chore: remove extraneous action

* chore: apply suggestions from code review
2022-11-04 10:31:06 +01:00
Muhammed Mustafa
3279ab161e
feat(client): refactor universal nav missing types (#48144)
* feat(client): refactor universal nav missing types

* extends link type from gatsby link types


Co-authored-by: auchynnikau <viachaslau_auchynnikau@epam.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2022-10-27 20:20:59 +05:30
Mrugesh Mohapatra
b393d88b9e
refactor: s/all-langs/i18n/g (#48258) 2022-10-26 10:08:27 -07:00
PakkuDon
e5f54cab5f
chore(client): remove exports for unused types (#48004)
* chore(client): remove exports for unused types

* chore(client): remove unused type
2022-10-14 19:10:21 +05:30
Anubhav Jain
88c54192b9
fix(client): remove unused files (#47974)
* removed unused files

Removed unused files as per comments for issue #47971

* fix: removed duplicate exports from 4 files

* Build fix

* made changes for build fix

* made changes for build fix
2022-10-14 18:54:09 +05:30
Danny Greenberg
93347ea285
fix(font): Replace Roboto Mono with Hack-ZeroSlash (#47767)
Co-authored-by: Bruce Blaser <bbsmooth@gmail.com>
2022-10-06 15:57:40 +00:00
Divyansh Singh
6dd8c6241b
feat: add hidden skip-to-content button (#47577)
* feat: add skip-to-content button

* fix: remove content start ids from everywhere and add to default layout

* chore: format landing-top.tsx

* use single quotes in skip-to-content component

* include breadcrumbs in navigation

* linting fail fix

* use anchor tag instead of new component

* update challenge title snap

* fix(test): reliably move focus onto the editor

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2022-10-05 20:43:00 +02:00
Niraj Nandish
53164e71f1
fix: circular dependencies (#46638)
* fix: circular dependency in formHelpers

* fix: circular dependency in Flash

* fix: circular dependency in helpers

* fix: circular dependency in current-challenge-saga (1/2)

* fix: circular dependency in code-lock-epic

* feat: eslint rule for circular dependencies

* fix: circular dependency in tools

* fix: import error and more circular dependencies in formHelpers

* fix prettier error

* fix: circular dependency in danger-zone-saga

* fix: circular dependency in update-email-saga

* fix: circular dependency in settings-saga

* fix: circular dependency in accept-terms-saga

* fix: circular dependency in codeally-saga

TODO: make a separate file for selectors

* fix: ci lint error

* fix: ci lint:prettier error

* fix: circular dependency in current-challenge-saga

* fix: cricular dependency in Challenges/redux

* fix: circular dependency in redux/settings

* fix: circular dependency in root redux

* fix: lint errors

* chore: remove unecessary comment

* chore: remove unused export

* fix: clear out actions and selectors

* revert changes to package.json

* test ci with maxDepth of 1

* fix: fallback to empty object

* test action if it will run for maxDepth of 2
2022-10-05 18:08:40 +01:00