* feat: npm -> pnpm
This resolves the issues with the gatsby client (gatsby-plugin-pnpm
deals with the fact that gatsby is relying on its own dependencies
being de-duped)
and challenge-editor (which doesn't seem to want to automatically install
codemirror and needed its own eslint config)
* fix: correct mocha path for curriculum tests
* fix: use select workspace with -F not -w
* fix: reorganise packages and restrict hoisting
pnpm works best if the workspaces keep their own dependencies, since
dependencies are not flattened and then what node resolves from a
require is predictable.
@types seem to be a special case and more care is required to prevent
them getting smushed together in the root (hence the .npmrc)
* fix: add types for tools + root
* fix: decouple challenge-auditor from client
* fix: add ui-components types
* fix(client): use the latest types for react 16
* fix: prettify
* fix: prettierignore pnpm-lock
* fix: relax hoisting
Turns out pnpm works just fine with types. I don't know what was going
wrong before, but there are no-longer any type conflicts.
* fix: add @redux-saga/core to fix eslint issue
It seems to only be redux-saga that import/named can't cope with, so it
is probably okay to work around this one.
* chore: add chai to tools/scripts/build
* fix: add store to root for cypress
* fix: allow cypress to download binaries
If we want to keep preventing cypress from downloading binaries, we can
figure out a workaround, but I'm allowing it to ease the transition to
pnpm.
My guess about why this is happening is that npm triggers Cypress's
postinstall script, but pnpm does not (because pnpm install only
installs if necessary, perferring to link)
* chore: re-enable pre/post scripts
* fix: update build scripts for client
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
* chore: update engines to use pnpm
* fix: enable choice of (super)block for tests
Only 'nix machines for now.
* chore: pin pnpm to version 7
* chore: remove last npms
Except web + curriculum-server. I'll update them when I start work on
them again.
* fix: lockfile check to catch any package-locks
* fix(action): install pnpm for upcoming tests
* chore: add nodemon to new api
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
* chore: add knip to ci
* DEBUG: checking things fail
* refactor: split into separate workflow
* fix: restrict to node 16
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
* feat: run on schedule only
* Revert "DEBUG: checking things fail"
This reverts commit b8b4fe1bb2.
* chore: rename file & name
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
Co-authored-by: Mrugesh Mohapatra <hi@mrugesh.dev>
* feat: first draft of action and cypress spec
* feat: test all generated challenges
* fix: better identification of block
* action: update cypress config
* action: upload to dashboard
* action: testing js cert challenges
* fix: unnecessary after user code for Make a Person
* feat: capture console log output for assert test
* fix: remove after seed code
* fix: change const to let
* fix: test
* action: disable js certification
* action: stop checking out branch in action
* action: check out right mobile repo
Co-authored-by: sembauke <semboot699@gmail.com>
* fix(tools): invalid -> spam
* feat: comment on spam
* chore: job name
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
* feat: add stripe donate page test for non donors
* fix: revert changes to see if ev is passed correctly
* feat: download artifacts
* fix: add quotations for spec args with global patterns
* fix: remove firefox from cypress donation tests
* fix: trigger action on main push
* Apply suggestions from code review
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* feat: remove matrix and simplify
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* test: increase timeouts for slow operations
* test: ignore ChunkLoadErrors again
* test: clean up commands
* Revert "fix(cypress): disable electron due to timeouts (#46231)"
This reverts commit 2b884d9dd9.
* test: various minor refactors
* chore(deps): Included dependency review
> Dependency Review GitHub Action in your repository to enforce dependency reviews on your pull requests.
> The action scans for vulnerable versions of dependencies introduced by package version changes in pull requests,
> and warns you about the associated security vulnerabilities.
> This gives you better visibility of what's changing in a pull request,
> and helps prevent vulnerabilities being added to your repository.
https://docs.github.com/en/code-security/supply-chain-security/understanding-your-software-supply-chain/about-dependency-review#dependency-review-enforcement
* Update .github/workflows/dependency-review.yml
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
* chore: initial setup of web package
This is *not* a workspace, yet, because it would be nice to use the
latest React, but /client can't migrate (yet).
Having two React versions creates issues in workspaces since /.bin/next
gets hoisted to root... and finds the root React version :(
* feat: add config for next
* fix: use jsx-runtime for web linting
* chore: init curriculum-server with json-server
* chore: integrate curriculum-server with TS/eslint
* feat: add patch script
json-server doesn't like keys with '/'s in so, for now I'm just patching
them out.
This lets us keep a strong separation between this WIP and the rest of
the code.
* fix: use port 8000 to avoid conflicts
* feat: crude ISR demo using challenge pages
* feat: extend ISR demo to use params
* feat: return props for specific superblocks
* chore: re-organise folders
* refactor: put data fetching in a single module
* refactor: challenge page slightly
* feat: add link to test ISR
You can see that, if you run next dev, the linked page gets regenerated
whenever you navigate to it. However, if you run next build that is no
longer the case and the page has to be reloaded for the user to see the
latest version.
The implication is that we'll need another method (Web worker, probably)
to detect if the page needs to be updated.
* feat: render static paths for rwd
* feat: add monaco Editor
* feat: send less data via props
Rather than sending superblocks, this now sends blocks. Next step, just
the challenge!
* fix: only send individual challenge's data
* feat: send /learn/stuff/<id> to the challenge page
* fix: redirect to path with trailing id
* fix: handle all possible path prefixes
* feat: add superblocks with trailing ids
* chore: rename block -> blockOrId
* chore: remove logs
* fix: return notFound if page id is missing
* chore: add a note about increasing TS strictness
* feat: serverside redirects
This should be a touch more performant, but mostly it separates the
concerns.
Since the server already has the responsibility of choosing what pages
to render, redirects fit naturally with its concerns.
* refactor: clean up param validation
* feat: create list of blocks in superblock
* feat: add challenge links to map
* feat: link to full path, not just id
* refactor: ensure props match getStaticProps
By specifying the props for GetStaticProps we ensure that it returns the
expected data and use InferGetStaticPropsType to get the type out again
for use in the component
* feat: improve and document dev experience
* refactor: separate routing from rendering
* refactor: extract routing logic into functions
* refactor: naming consistency
* refactor: move data wrangling into get-curriculum
* refactor: align blockOrId and id
* chore: remove the server from workspaces
* chore: remove the lock
* docs: paths
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
* chore: install before linting
* fix: create env.json before installing new client
* chore: ignore generated json file
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
* chore: Set permissions for GitHub actions
Restrict the GitHub token permissions only to the required ones; this way, even if the attackers will succeed in compromising your workflow, they won’t be able to do much.
- Included permissions for the action. https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissionshttps://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissionshttps://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs
[Keeping your GitHub Actions and workflows secure Part 1: Preventing pwn requests](https://securitylab.github.com/research/github-actions-preventing-pwn-requests/)
Signed-off-by: naveen <172697+naveensrinivasan@users.noreply.github.com>
* Update .github/workflows/codeql-analysis.yml
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
* Update .github/workflows/labeler.yaml
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
* Update .github/workflows/node.js-tests-upcoming.yml
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
* Update .github/workflows/node.js-tests.yml
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
* Update .github/workflows/codeql-analysis.yml
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
* Update .github/workflows/labeler.yaml
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
* Update .github/workflows/labeler.yaml
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
* fix: fallback to english challenges
All challenges will use the english version if a translated file is not
available. SHOW_NEW_CURRICULUM still gates what's shown in the client.
* refactor: use closures to simplify createChallenge
* refactor: remove messy destructure
* refactor: add meta via helper
* fix: fallback to [] for meta.required
* fix: repair challenge.block
* refactor: use CONST_CASE for meta + challenge dirs
* fix: catch empty superblocks immediately
* fix: clean up path.resolves
* fix: invalid syntax in JS project steps
* fix: default to english comments and relax tests
Instead of always throwing errors when a comment is not translated, the
tests now warn while SHOW_UPCOMING_CHANGES is true, so that tests will
pass while we're developing and allow translators time to work.
They still throw when SHOW_UPCOMING_CHANGES is false to catch issues
in production
* test: update createCommentMap test
* refactor: delete stale comment
* refactor: clarify validate with explanatory consts
* feat: throw if audited cert falls back to english
* fix: stop testing upcoming localized curriculum
* feat: allow more 1000 steps to be created at once
* refactor: start migrating to typescript
* refactor: delete-step to ts
* refactor: migrated some helpers
* refactor: migrate create-empty-steps
* refactor: migrate create-step-between
* refactor: finish migrating to TS
* refactor: migrate tests
* fix: ensure mock.restore is done after each test
* fix: prevent double-tscing
* fix: repair the tests
* chore: use ts-node for scripts
We don't need the performance boost of incremental compilation and
ts-node is easier to work with
* refactor: consolidate tsconfigs
* refactor: replace gulp
* fix: use ts-node for build-curriculum
* fix: allow ts compilation of config
* feat: create and use create:config script
* fix: add /config to eslint projects
* fix: remove gulp script
* fix: handle missing solutions correctly
Rather than creating an [[]] the parser now creates [] which isEmpty().
This makes the test suite check the next challenge for a solution.
In addition, the logic for testing solutions was fixed.
* chore: update snapshots
* test: build new superblock in node.js-tests CI
* test: allow forward slash in superblock slug
* fix: borked tests oops
* test: ignore duplicated projects
* fix: i did not break these shaun did :)
* fix: idIndex is index of id not id
Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com>
* test: login more directly
* test: separate login from other visits
In a single test, Cypress can only visit within a single domain, hence
the separation.
* chore: fail slowly for all strategies
* test: user certified user for showing cert
* test: fix and cleanup certifications
