Commit Graph

214 Commits

Author SHA1 Message Date
Rebekah Koon
5a3d22e76b
fix(curriculum): changing Charles -> Ada in JavaScript challenge descriptions (#42280)
* changing Charles -> Ada in JavaScript challenge descriptions

* fix: changing Charles -> Ada in JavaScript challenge descriptions

* fix: changing firstName value from Ada to Augusta in javascript lesson
2021-05-29 21:33:21 +05:30
alirezaghey
cbb7afd5b8
fix(curriculum): correct link text (#42143)
* Small language improvement

The correct term is assignment operator.

* Small language improvement

Co-authored-by: Niraj Nandish <nirajnandish@icloud.com>

Co-authored-by: Niraj Nandish <nirajnandish@icloud.com>
2021-05-15 17:10:19 +02:00
alirezaghey
79e799feb5
fix(curriculum): scoping variables language improvement (#42135) 2021-05-14 09:02:54 -07:00
Evgeny Klimenchenko
db369fbed1
fix(client): remove JS comments from user code for tests (#41873)
* Removes comments in js challanges by default

* fix local-scope-and-functions test regex

* fix all languages

* revert language changes

* removed unnecessary removeJSComments from challenges

* fix challanges in other languages

* removed removeJSComments from all challanges
2021-04-28 10:18:54 -05:00
Jeremy L Thompson
6ae186a8cf
fix(curriculum): record collection challenge - variable names shouldn't be keywords (#41904)
* style - update record collection challenge, variables shouldn't be name after keywords

* minor - typo fix

* Apply suggestions from code review

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
2021-04-23 21:51:41 +02:00
Shaun Hamilton
4171277dc9
fix(curriculum): clarify instructions for ouput (#41839) 2021-04-16 20:33:58 +02:00
Karen Blacktopp
422bded413
fix: remove quotation marks from 'Hi World' in Instructions (#41837) 2021-04-16 10:36:59 +02:00
Emer Conghaile
fe95d5bca2
fix(curriculum): Remove unnecessary comments (#41777)
* Remove unnecessary comments

https://github.com/freeCodeCamp/freeCodeCamp/pull/41612

* Remove unnecessary comment
2021-04-08 10:59:25 -07:00
Emer Conghaile
87b0e5bb7a
fix(curriculum): Remove unnecessary comments (#41781)
* Remove unnecessary comments

https://github.com/freeCodeCamp/freeCodeCamp/pull/41612

* Update the hints section
2021-04-08 10:49:47 -07:00
Emer Conghaile
c4ba0c692f
fix(curriculum): Remove unnecessary comments (#41776)
* Remove unnecessary comments

* Remove last comment, change instruction wording
2021-04-08 10:46:39 -07:00
Emer Conghaile
591a534701
Remove unnecessary comments (#41775)
https://github.com/freeCodeCamp/freeCodeCamp/pull/41612
2021-04-08 09:40:34 -07:00
Emer Conghaile
a9a68fa498
fix(curriculum): Remove unnecessary comments (#41774)
* fix: Remove unnecessary comments

https://github.com/freeCodeCamp/freeCodeCamp/pull/41612

* Add empty line
2021-04-08 09:36:05 -07:00
Saurabh Kumar singh
617f7b07e9
Update iterate-through-an-array-with-a-for-loop (#41742)
* Update iterate-through-an-array-with-a-for-loop

* Update iterate-through-an-array-with-a-for-loop

Add space around minus for better readablilty.

* Update iterate-through-an-array-with-a-for-loop

* Update iterate-through-an-array-with-a-for-loop

* Update iterate-through-an-array-with-a-for-loop.md
2021-04-08 09:56:49 -05:00
Nicholas Carrigan (he/him)
7d83a6b65d
fix(curriculum): verbiage (#41732)
* fix(curriculum): verbiage

Modify the wording of the tests in this challenge to avoid having
two tests which sound the same.

* fix: Shaun's arrays have elements

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
2021-04-03 23:00:15 +02:00
Sem Bauke
e75685f803
fix(curriculum): change tests to allow more solutions (#41703)
* fix(curriculum) only allow  new object to be the second value in array

* fix(curriculum) remove direct array index notation

* Apply suggestions from Shaun

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
2021-03-31 14:24:20 -07:00
Emer Conghaile
e5b4ae17a0
fix: Simplify wording to make more sense (#41586)
* fix: Simplify wording to make more sense

I think that "count odd numbers backward by twos" instead of "count backward by twos by odd numbers" is easier to understand.

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/count-backwards-with-a-for-loop.md

I think that this variation sounds better than what I originally wrote.

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-25 22:18:51 +00:00
Randell Dawson
b5ed2619eb
fix: replace inline code blocks (#41576) 2021-03-26 02:37:48 +05:30
Randell Dawson
e18c6955b0
fix(curriculum): Improve test to allow any valid function call for Write Reusable JavaScript with Functions challenge (#41538)
* fix: improve test to allow function call anywhere

* fix: force user to put console.log in function
2021-03-20 12:23:32 +00:00
Arjun Yadav
3f1cd6eb33
fixed the grammar of the description (#41531) 2021-03-19 06:55:21 -06:00
Kelvin Sánchez
35a8f55515
fix(learn): Remove unnecessary inline code tag in challenge (#41428)
* remove unnecessary inline code tag

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/comparison-with-the-less-than-or-equal-to-operator.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* improve challenge wording

* improve challenge wording

* keep wording consistency

* keep wording consistency between similar challenges

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-10 10:16:03 -08:00
Nicholas Carrigan (he/him)
c5bcebc724
fix(learn): revert backslash change (#41382)
* fix(learn): revert backslash change

Crowdin resolved the issue with backslashes escaping backtics in
the markdown parser, so this reverts the workaround we implemented
for that bug.

* Update curriculum/challenges/english/10-coding-interview-prep/rosetta-code/s-expressions.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-09 10:13:27 -06:00
Nicholas Carrigan (he/him)
77730ae209
fix(learn): address translator comments (#41381)
* fix(learn): address translator comments

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/quoting-strings-with-single-quotes.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-09 08:15:26 -06:00
Andrew Cen
65cc800689
fix: add blank lines on empty seeds (#41348) 2021-03-03 13:14:28 -08:00
Nicholas Carrigan (he/him)
7117919d36
chore(learn): audit javascript algorithms and data structures (#41092)
* chore(learn): audit basic algorithm scripting

* chore(learn): audit basic data structures

* chore(learn): audit basic javascript

* chore(learn): audit debugging

* chore(learn): audit es6

* chore(learn): audit functional programming

* chore(learn): audit intermidate algorithms

* chore(learn): audit js projects

* chore(learn): audit object oriented programming

* chore(learn): audit regex

* fix(learn): remove stray .

* fix(learn): string to code

* fix(learn): missed some

* fix(learn): clarify strings

Based on Randy's feedback, clarifies string instances where quotes
were removed in favour of back ticks.

* fix: apply suggestions - thanks Randy! :)

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: non-suggestion comments

* chore(learn): remove comments from codes

Removes the comments from the description and instruction code
blocks to ensure that all relevant information is translatable.

* fix: Apply suggestions from code review

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: revert crowdin fix

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-algorithm-scripting/mutations.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: Apply suggestions from code review

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-arrays.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: Apply suggestions from code review

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* chore: change voice

* fix: Christopher Nolan

* fix: expressions would evaluate

* fix: will -> would

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/object-oriented-programming/add-methods-after-inheritance.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: to work to push

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/iterate-with-javascript-for-loops.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/object-oriented-programming/add-methods-after-inheritance.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-03-02 17:12:12 -07:00
Randell Dawson
b11dd87047
fix: remove sentence not needed (#41235) 2021-02-23 11:21:58 -06:00
Randell Dawson
f4bbe3f34c
fix(learn): Updated code blocks to help with translation on two challenges (#41217) 2021-02-22 11:21:59 +05:30
Alexander Heß
b12360d4a8
Removed the hint Fixes #41192 (#41215)
* Removed the hint Fixes #41192

* Removed the blank line as suggested
2021-02-21 13:36:14 -07:00
Kelvin Sánchez
f08174b5b1
fix(learn): Remove unnecessary inline code tag in challenge (#41177)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-19 09:44:50 +05:30
Kelvin Sánchez
fad168b465
fix(learn): fix some code tags, capitalization and punctuation in challenge (#41161)
* fix some code tags, capitalization and punctuation

Note: The reserved word in JavaScript is "boolean", so I think it is appropriate to use it like this inside the code tags.

* Remove code tags and capitalize first letter

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* capitalize letter and replace slash

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-18 08:45:12 -07:00
Kelvin Sánchez
2c1280af65
fix(learn): Improve the clarity on a challenge sentence (#41154)
* Improve the clarity on a challenge sentence

* add string type and remove double quotes

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-18 08:29:31 -07:00
Kelvin Sánchez
1fe1371b16
add missing inline-code block (#41153) 2021-02-17 11:24:53 -08:00
Kelvin Sánchez
b45406ec9d
fix(learn): Remove repeated definition tag in challenge (#41151) 2021-02-17 23:01:42 +05:30
Nicholas Carrigan (he/him)
21c7abf584
fix(learn): update challenge for crowdin (#41089) 2021-02-16 19:47:40 +05:30
Nicholas Carrigan (he/him)
18e821bcd3
fix: remove clunky sentence (#40751) 2021-02-01 19:22:39 +05:30
matias-miller
8a9f3319c6
fix(learn): Fixed typos in count-backwards-with-a-for-loop.md (#40478)
* Spelling change in count-backwards-with-a-for-loop

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/count-backwards-with-a-for-loop.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-01-21 08:44:10 -08:00
Nicholas Carrigan (he/him)
062b1cd424
fix: replace h tags (#40750)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-01-21 13:41:46 +05:30
Nicholas Carrigan (he/him)
8d8d25e9f2
fix(learn): address escaped backticks (#40717)
* fix(learn): address escaped backticks

Addresses the instances of escaped backticks - where a backtick is
preceded by a backslash.  In most cases, this was left over from the
old parser. In some cases, a backtick was intended to be wrapped in
code tags and has been adjusted accordingly.

This issue came to light due to a bug in the translation flow on
Crowdin.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: EVEN MORE :( :( :(

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: backslash nightmares

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: When you wish upon a *******

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix(curriculum): md error introduced by formatter

* fix(curriculum): remove extra `s

* fix: restore quote symbol

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: Typo

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: apply review changes

Applying review feedback from call with @RandellDawson.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: markdown does weird stuff sometimes

Can't stick backticks together - use code.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-01-20 19:01:00 -07:00
Oliver Eyton-Williams
ee1e8abd87
feat(curriculum): restore seed + solution to Chinese (#40683)
* feat(tools): add seed/solution restore script

* chore(curriculum): remove empty sections' markers

* chore(curriculum): add seed + solution to Chinese

* chore: remove old formatter

* fix: update getChallenges

parse translated challenges separately, without reference to the source

* chore(curriculum): add dashedName to English

* chore(curriculum): add dashedName to Chinese

* refactor: remove unused challenge property 'name'

* fix: relax dashedName requirement

* fix: stray tag

Remove stray `pre` tag from challenge file.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

Co-authored-by: nhcarrigan <nhcarrigan@gmail.com>
2021-01-12 19:31:00 -07:00
Ilenia
7de8549e02
fix(learn): Made the Escaping literal quotes channel accept the dot inside the double quotes too (#40465)
* made valid solution dot inside and dot outside quotes

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/escaping-literal-quotes-in-strings.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-12-16 08:07:47 -08:00
vbinithyanandamv
7c19c82076
[BUG] Able to pass challenge "Basic JavaScript: Initializing Variables with the Assignment Operator" with incorrect answers #40406 (#40409)
* [BUG] #40406 Fix

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/initializing-variables-with-the-assignment-operator.md

Requested Change.

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-12-15 18:07:36 -07:00
Oliver Eyton-Williams
0bd52f8bd1
Feat: add new Markdown parser (#39800)
and change all the challenges to new `md` format.
2020-11-27 10:02:05 -08:00
Ilenia
f294d9cacc
fix(learn): removed use strict from various challenges (#40321) 2020-11-25 15:59:04 -08:00
rajapandi_vijayakumar
e8b6a9e5dd
fix(learn): add example declaration for clarity (#40207)
Variable declaration is added which is used inside the switch case.
2020-11-09 17:09:21 +00:00
Randell Dawson
895e6b8daf
fix(learn): add test to prevent hardcoded pass (#40179) 2020-11-06 17:05:20 +00:00
Oliver Eyton-Williams
a71150074d
fix(learn): preserve whitespace in the tool panel (#39973) 2020-10-14 21:40:15 +05:30
dhanush1909
a32427c120
fix(learn): make semicolon at end of line optional (#39821) 2020-10-08 21:02:59 +01:00
Oliver Eyton-Williams
2b9e38a17b
fix: replace .english.md extension with .md 2020-09-29 22:09:04 +02:00
Mainak Debnath
362e8254f8
fix(learn): update test to allow negative arguments (#39701)
* Updated the regex in test

* Changed regex

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* Updated changes in regex

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-09-28 16:03:24 +01:00
Nicholas Carrigan
6ccd0d21a1
fix(learn): Update test text in Profile Lookup (#39678) 2020-09-25 00:38:40 +05:30
Gaurav Khairnar
a338d4b79d
fix(learn): clear instructions for basic JavaScript: Appending Variables to Strings lesson (#39587) 2020-09-17 13:00:58 -05:00
Hassaan Pasha
80438cac3e
feat(client, learn): add helper functions for common validation operations (#38605)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-09-17 19:38:01 +05:30
Randell Dawson
30c61b808b
fix: consolidate misc comments (#39583) 2020-09-16 13:29:50 -05:00
Aleksa S. Stevic
5cb609dc5c
Changed "statement" to "expression" (#39564)
The ternary operator doesn't allow statements, just expressions.
2020-09-12 10:37:59 +02:00
Randell Dawson
c345bc9886
fix: removed scrimba video links that do not reflect current challenge (#39559) 2020-09-11 11:17:50 -05:00
Siddharth Pathak
5418307936
fix(learn): add whitespace check to else-if test (#39555) 2020-09-09 20:30:33 +01:00
Tom
b79a332984
fix: remove scrimba link for inaccurate video (#39545) 2020-09-08 13:09:53 -07:00
Oliver Eyton-Williams
bd68b70f3d
Feat: hide blocks not challenges (#39504)
* fix: remove isHidden flag from frontmatter

* fix: add isUpcomingChange

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>

* feat: hide blocks not challenges

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>
2020-09-03 15:07:40 -07:00
skaparate
f97c847e29
fix(learn): formatting bug preventing tests to pass (#39045)
* implemented object validation

* fix: formatting bug preventing tests to pass

* implemented object validation

* fix: formatting bug preventing tests to pass

* integrated changes again

* added suggested changes

* fix: refine instructions

* fix: revert some bad instructions and change album to albumTitle

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2020-09-03 12:34:12 +01:00
bhagerty
db15a44160
fix(learn): clarify instructions to remove confusion (#39479)
* Clarify instructions to remove confusion

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/accessing-object-properties-with-variables.english.md

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2020-09-02 18:41:59 +01:00
Beau Carnes
f334734e98
feat: split JS challenge into two (#39044)
* feat: split JS challenge into two

* fix/change-to-not-use-untaught-assignments

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2020-08-31 19:44:56 +01:00
anthony
20d397f719
remove MDN links from English challenges (#39337)
* remove MDN links from English challenges

* add push challenge reference to record-collection

* refactor truthy falsy verbiage

* replace MDN link with news link

* remove unnecessary whitespace
2020-07-31 15:19:49 +09:00
Bianca Zanardi
35f24c6085
Fix text inconsistency (#39203)
* Fix text inconsistency

To match the eight ECMAScript Language Types on the previous paragraph.

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2020-07-09 16:18:11 +02:00
Nicholas Carrigan
2aee480c46
Remove example code from challenge seed (#39083)
Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2020-06-22 16:13:21 +05:30
Nicholas Carrigan
62dcb1f3fa
fix(curriculum): remove whitespace typo (#39009) 2020-06-05 16:08:38 +02:00
jasnkwcz
95371f92b3
fix(learn): clarify formatting requirements for multiple ternary operators challenge (#38993)
* fix(learn): clarify formatting requirements for multiple ternary operators challenge

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-06-03 18:33:03 +02:00
JapneetSingh5
87ef15befa
Fixes a broken link to 'undefined is a keyword' (#38897)
Fixes a broken link to 'undefined is a keyword' by replacing the wrong link with the correct one.
2020-06-02 16:22:59 +09:00
Aditya Nagla
a6c2b5ee1d
fix(curriculum) remove unnecessary */ from description (#38969) 2020-05-31 10:49:10 -05:00
John Montgomery
5cd850f666
Update wording of what multiplyAll should do in "Nesting For Loops" (#38852) 2020-05-31 08:16:00 -05:00
DaVicki
2e819b2e0a
fix(curriculum): update instructions (#38865)
* fix(learn): update instructions

edited text - change "returns a random number" to "returns a random whole number" to be more clear on the problem statement.

Address review comments : add the keyword "whole" to description, to make it consistent with challenge title and Instructions.
2020-05-29 10:56:17 +02:00
PRAKASH
3c3ceaa3f5 Update declare-javascript-variables.english.md (#38884) 2020-05-27 09:37:34 +02:00
Oliver Eyton-Williams
f1c9b08cf3 fix(curriculum): add isHidden: false to challenges
This includes certificates (where it does nothing), but does not
include any translations.
2020-05-25 16:25:19 +05:30
Kristofer Koishigawa
b017ce192c
fix: dotall flag not supported in firefox (#38762)
Addresses https://github.com/freeCodeCamp/freeCodeCamp/pull/38546#issuecomment-625611675 where it's pointed out that Firefox doesn't support the /s regex flag yet. This workaround matches anything that's not blank.
2020-05-08 19:27:32 +02:00
Eric Elli
f757840624
fix(learn): add test to return early pattern (#38751)
* add: test to return early pattern

Currently no test for a = 0 or b = 0. This results in if(a<=0 || b<= 0) also being a valid solution

* fix: typo in test text

* fix: update return early pattern test

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-05-07 14:37:48 -05:00
Michael Schneider
1f2b66a432
feat: edit 2nd test description for clarity (#38661)
current description logically fits, yet fails this solution: myVar = ++myVar;
2020-05-02 08:27:52 -05:00
Farjad Fazli
fd85f57376
fix(learn): fixed typo "in the left" should be "at the left" (#38651)
* Fixed typo "in the left" should be "at the left"

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/comparison-with-the-equality-operator.english.md

Co-Authored-By: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-05-02 08:17:11 -05:00
Joel Duran
7035516483
fix: typo in 'Build JavaScript Objects' (#38690) 2020-04-30 17:41:55 +05:30
Oliver Eyton-Williams
f2f5dbc4b8
fix(curriculum): improve declaration tests (#38546) 2020-04-29 16:39:48 +05:30
Beau Carnes
756f33775e
fix(learn): update video challenge (#38564)
* fix(learn): update video challenge

* fix: update scrimba URL

Co-authored-by: Mrugesh Mohapatra <me@raisedadead.com>
2020-04-18 16:16:31 +05:30
Randell Dawson
a5818506f0
fix(curriculum): remove setup code not needed anymore from Testing Objects for Properties challenge (#38454)
* fix: remove setup code

* fix: remove call to function
2020-03-28 02:25:04 +12:00
Randell Dawson
1fdb691996
fix(learn): updated tests and deleted old sample code (#38450) 2020-03-26 23:12:18 +05:30
Randell Dawson
e0e6334628
fix(curriculum): Consolidated comments for JavaScript Algorithms and Data Structures challenges - part 3 of 4 (#38264)
* fix: remove example code from challenge seed

* fix: remove declaration from solution

* fix: added sum variable back in

* fix: reverted description back to original version

* fix: added examples to description section

* fix: added complete sentence

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: corrected typo

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* fix: reverted to original desc with formatted code

* fix: removed unnecessary code example from description section

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: failiing test on iterate through array with for loop

* fix: changed to Only change this line

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Manish Giri <manish.giri.me@gmail.com>
Co-authored-by: moT01 <tmondloch01@gmail.com>
2020-03-25 16:07:13 +01:00
Kalyanasundaram
8b0cbd6f83
Modify tests for testing objects for properties challenge (#38414)
* Stronger test cases for testing objects for properties

Change function signature to take in a custom object to be tested

* YML formatting mistake

* Yaml no space in string

* Small one more fix - most likely final

* REmove double space in return

* Update instruction Section
2020-03-24 22:09:57 -07:00
Shivam saini
4ef78f7f7d
Update use-recursion-to-create-a-countdown.english.md (#38366) 2020-03-13 16:05:59 +01:00
Randell Dawson
9252f96566
fix(curriculum): Consolidated comments for JavaScript Algorithms and Data Structures challenges - part 4 of 4 (#38267)
* fix: consolidate comments


Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2020-03-08 15:46:28 +01:00
Tom
17a55c6e18
fix(curriculum): Consolidated comments for JavaScript Algorithms and Data Structures challenges - part 1 of 4 (#38258)
* fix: consolidate/remove comments

* fix: remove => from comment

* fix: reverted changes to add same changes to another PR

* fix: removed 'the' from sentence

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: removed 'the' from the sentence

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-03-04 13:08:54 -06:00
Randell Dawson
6a7a7e6d7d
fix(curriculum): Consolidated comments for JavaScript Algorithms and Data Structures challenges - part 2 of 4 (#38259) 2020-03-03 10:18:30 +03:00
Oliver Eyton-Williams
2d7b1255cc
fix: add missing .english extensions (#38298) 2020-02-28 07:19:22 -08:00
Vincent Shury
b49b9f3e3c
Typo whitespace fix in access-multi-dimensional-arrays-with-indexes.english.md (#38247)
* Update access-multi-dimensional-arrays-with-indexes.english.md

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-02-24 17:02:53 +01:00
Oliver Eyton-Williams
b0f1fa4b96
fix: make recursion challenge more intuitive (#37399) 2020-02-20 21:36:33 +05:30
Ashraf Nazar
fda7fb174e fix: Correct paths in English exercises by prefixing "/" before "learn" (#38099)
* fix: Correct paths in English exercises by prefixing "/" before "learn"

* fix(lang): Correct paths to exercises by prefixing "/" before "learn" in remaining languages
2020-01-26 12:51:21 -06:00
Nikolas Broman
d07c85151b Fix typo (remove duplicate word 'should') (#37998) 2019-12-31 08:50:46 -08:00
Sean Coleman
203c9823e8 Fixed minor grammar issue in escape-sequences-in-strings.english.md (#37940)
* Update escape-sequences-in-strings.english.md

Fixed minor grammar issue in list item 1 of the description section.

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/escape-sequences-in-strings.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-12-16 06:16:16 -08:00
Randell Dawson
cb3524ee31 fix: simplify challenge testString (#37826) 2019-12-07 15:47:08 -05:00
Randell Dawson
623c08cbfa fix: removed semi-colon from regex (#37881) 2019-12-07 15:02:42 -05:00
Randell Dawson
dd2fb28ee0 fix: make tests more robust (#37830) 2019-12-02 18:42:32 -05:00
Randell Dawson
7454719334 fix(curriculum): Improved Use Recursion to Create a Countdown challenge (#37548)
* fix: improved recursive challenge

* fix: rewording of two challenges

* fix: add code tags

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
2019-12-02 17:58:07 +01:00
Tim dinia
c331b12413 fix(curriculum): correct typo in nest one array within another array challenge instruction (#37851) 2019-11-29 10:07:51 +01:00
Randell Dawson
2c15bcbb43 fix(curriculum): changed test text to use should for JavaScript Algorithms and Data Structures (#37761)
* fix: corrected typo

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
2019-11-27 11:57:38 +01:00
Marco Valero
fc1a923dd5 Made description of logical operator under "or operator" challenge a little more intuitive. (#37772)
* Update comparisons-with-the-logical-or-operator.english.md

* Update comparisons-with-the-logical-or-operator.english.md

* Update comparisons-with-the-logical-or-operator.english.md
2019-11-16 21:30:52 -05:00
Kiara Barias
c4dc0b297f Switch statement example updated (#37757)
* Switch statement example updated

* Update switch-statements.english.md example

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update switch-statements.english.md example

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-11-14 12:07:08 -08:00