Joel Bentley
815f460fd8
Modify sample function in code to match form of sample function in description
2015-09-13 14:04:52 -04:00
bugron
4321d85b4c
Fixes typos, word issues in Basic JS, part 3
2015-09-13 09:10:30 +04:00
bugron
fec58a7afb
Fixes typos, word issues in Basic JS, part 2
2015-09-13 09:02:54 +04:00
bugron
428ab7016c
Fixes typos, word issues in Basic JS, part 1
2015-09-13 08:52:51 +04:00
Berkeley Martinez
2f5e59cd36
Merge pull request #2892 from bugron/bugron-2256
...
fixes a test and some text
2015-09-12 21:31:46 -07:00
Leon Feng
fdecf1a5cf
Change the unshift() example to make it less confusing to beginners
2015-09-13 03:54:24 +08:00
Joel Bentley
ff2c297142
Fix description of Waypoint: Find Numbers with Regular Expressions
2015-09-12 15:00:04 -04:00
Aniruddh Agarwal
cf8c663c6d
Added external link to substantiate js waypoint
...
Added a link to FCC wiki to provide explanation of the formula used in the 'Create a JavaScript Slot Machine' basic javascript waypoint as well as the "Generate Random Whole Numbers within a Range" waypoint
closes #2595
2015-09-10 20:20:58 +08:00
bugron
8fed7d7f91
fixes a test and some text
2015-09-09 18:32:20 +04:00
Arsen Melikyan
ad16d75a34
Merge pull request #3125 from natac13/change-test-in-javascript-challenges-and-add-optional-spaces-in-jquery-aswell
...
Test improvements, single and double quote jQuery selectors
2015-09-09 08:39:42 +04:00
Aniruddh Agarwal
bb9ceb46f5
Fix typo in basic-javascript waypoint
...
Waypoint 'Invert Regular Expression Matches with JavaScript' had a semi-colon in the description for the regex example which is not needed.
closes #3148
2015-09-09 11:52:21 +08:00
Arsen Melikyan
410c1f3c3e
Merge pull request #3181 from awesomeaniruddh/awesomeaniruddh-3169
...
Fixed typo in Basic Javascript Waypoint
2015-09-09 07:44:40 +04:00
Arsen Melikyan
812e4c9467
Merge pull request #3102 from AryanJ-NYC/AryanJ-NYC-1875
...
Clarified instructions for shift() challenge
2015-09-09 07:25:03 +04:00
Aniruddh Agarwal
4769ece009
Fixed typo in Basic Javascript Waypoint
...
Waypoint 'Sift through Text with Regular Expressions' had `...` in its description instead of `.`. Made the required changes.
closes #3169
2015-09-09 10:02:08 +08:00
Aryan Jabbari
f835e9617a
Clarifies instructions for shift() challenge; closes #1875
2015-09-08 17:31:15 -04:00
Anton Strömkvist
7dfd84cf5e
Merge pull request #3087 from bugron/bugron-toLowerCase_fix
...
Fixes 'd[0].toLowerCase() is not a function' error
2015-09-08 22:33:54 +02:00
Anton Strömkvist
38b2ff2a54
Merge pull request #3091 from bugron/bugron-divide_fix
...
fixes a condition in assert
2015-09-08 22:29:04 +02:00
Anton Strömkvist
a8cd3e909f
Merge pull request #3088 from bugron/bugron-add_two_num-fix
...
fixes assert and adds a dot
2015-09-08 22:24:11 +02:00
Arsen Melikyan
38e134666a
Merge pull request #3153 from ahstro/ahstro-3152
...
Move brace out of user-edit scope
2015-09-08 23:25:25 +04:00
Anton Strömkvist
7ebe8de1fd
Merge pull request #2921 from bugron/bugron-2803
...
fixes an idle test and some text
2015-09-08 21:07:55 +02:00
Arsen Melikyan
87557159e8
Merge pull request #2953 from dmytroyarmak/dmytroyarmak-2948
...
Add output block to "Iterate with JavaScript For Loops" challange
2015-09-08 21:37:00 +04:00
bugron
6250e31e75
fixes an idle test and some text
2015-09-08 19:13:20 +04:00
Dmytro Yarmak
f830232139
Add output block to "Iterate with JavaScript While Loops" challange
2015-09-08 10:59:14 +03:00
Anton Strömkvist
00ee379b2a
Merge pull request #2739 from bugron/bugron-1881
...
Changes nonexistent variable name to proper one
2015-09-08 01:57:41 +02:00
ahstro
decaaead20
Move brace out of user-edit scope
...
Move the closing brace of a function down below the
`// Only change code above this line`-comment in
`Use Conditional Logic with IfElse Statements`
Fix #3152
2015-09-07 22:56:27 +02:00
Jakob Dahl
ad85e899c0
Updated and rebased pr
2015-09-07 03:08:08 +02:00
natac13
bb51636e78
Test improvements
...
changed the jquery selector to account for single and double quotes
as well as optional spaces on:
[Give your JavaScript Slot Machine some stylish images](http://www.freecodecamp.com/challenges/waypoint-give-your-javascript-slot-machine-some-stylish-images )
[Bring your JavaScript Slot Machine to Life](http://www.freecodecamp.com/challenges/waypoint-bring-your-javascript-slot-machine-to-life )
[Target the same element with multiple jQuery Selectors](http://www.freecodecamp.com/challenges/waypoint-target-the-same-element-with-multiple-jquery-selectors )
[Target the Parent of an Element Using jQuery](http://www.freecodecamp.com/challenges/waypoint-target-the-parent-of-an-element-using-jquery )
2015-09-06 13:12:06 -04:00
Arsen Melikyan
482c9cb5d1
Merge pull request #3109 from AryanJ-NYC/AryanJ-NYC-2136
...
Added details to instructions of JS arrays waypoint
2015-09-06 10:18:44 +04:00
Aryan Jabbari
06f611ebf8
Used strict equality for second assert
2015-09-06 00:39:07 -04:00
Aryan Jabbari
c4e0c363c2
Checks that length is used twice for JS bracket notation challenges; closes #3105
2015-09-06 00:37:12 -04:00
Aryan Jabbari
b14e2847ba
Added details to instructions of JS arrays waypoint; closes #2136
2015-09-05 20:53:54 -04:00
bugron
76cff4bdd3
fixes a condition in assert
2015-09-05 19:20:41 +04:00
bugron
1ce9ccb925
fixes assert and some text
2015-09-05 18:05:09 +04:00
bugron
9ab6911afa
Fixes 'd[0].toLowerCase() is not a function' error
2015-09-05 16:38:09 +04:00
Quincy Larson
1ea3605519
Merge pull request #3002 from dmytroyarmak/dmytroyarmak-2999
...
Improve test cases for Generate Random Whole Numbers within a Range
2015-09-04 15:27:36 -07:00
natac13
5b311b8943
Added tests to JavaScript Give Slot Machine Some Style
...
The challenge could be passed by copying the code 3 times.
Made new tests to stop this
closes #2111
2015-09-04 13:48:51 -04:00
Dmytro Yarmak
0227d20847
Improve test cases for Generate Random Whole Numbers within a Range
2015-09-02 23:17:33 +03:00
Dmytro Yarmak
142ce22a75
Add output block to "Iterate with JavaScript For Loops" challange
2015-09-01 13:41:40 +03:00
Atik Shaikh
b6ead17069
Update basic-javascript.json
2015-08-31 00:49:27 +05:30
Ben McMahon
579c91b87e
Merge pull request #2490 from abhisekp/patch-3
...
Add correction to Waypoint - Sift through Text with Regular Expressions
2015-08-30 16:16:48 +01:00
Abhisek Pattnaik
f680604534
Change challenge seed
2015-08-30 20:37:32 +05:30
Abhisek Pattnaik
b3a278a8f9
Merge remote-tracking branch 'upstream/staging' into patch-3
2015-08-30 13:49:04 +05:30
Natac13
3cd616e526
fixed minor typo where there was a 's' left when the sentence was changed. Issue #2853
2015-08-29 18:30:16 -04:00
Ben McMahon
513e25b185
Merge pull request #2820 from AEA2002/staging
...
Minor edit in Find the Nth Character
2015-08-29 19:25:29 +01:00
Ben McMahon
9a29a28155
Merge pull request #2821 from uwaseem/uwaseem-1979
...
Fixed typo for issue 1979
2015-08-29 19:23:46 +01:00
bugron
1ffaea093e
fixes 'editor.getValue(...).match(...) is null'
2015-08-29 02:35:06 +04:00
waseem
959645ab75
Fixed typo for issue 1979
2015-08-29 04:08:48 +08:00
ahstro
e23fbf2013
return(foo) => return foo
2015-08-27 22:19:03 +02:00
Arsen Melikyan
99fc557e8e
Changes nonexistent variable name to proper one
2015-08-26 18:59:59 +04:00
AEA2002
2d368f66ad
Minor edit in Find the Nth Character
...
In "Use Bracket Notation to Find the Nth Character in a String" section removed "last" from 'The third last letter of lastName should be..."
2015-08-25 18:34:31 -04:00
Aniruddh Agarwal
1577d362b3
replaced + by .
2015-08-25 22:42:58 +08:00
Aniruddh Agarwal
275fe55fe7
fixed conflicts
2015-08-25 22:21:33 +08:00
Aniruddh Agarwal
07262eb5f1
Cleaned up description for 'Sift through Text with Regular Expressions' waypoint
2015-08-25 20:26:32 +08:00
Aniruddh Agarwal
d59c504ec3
Expanded description of 'Build Javacript Objects' waypoint
2015-08-25 19:36:47 +08:00
Quincy Larson
f6816de455
Merge pull request #2620 from bugron/bugron-1522
...
Fixes missing backslash in waypoints' instructions'
2015-08-24 19:02:22 -07:00
Quincy Larson
3014722a28
Merge branch 'staging' of github.com:FreeCodeCamp/freecodecamp into staging
2015-08-24 17:54:00 -07:00
bugron
b3c33679b4
Adds a desctiption to avoid confusion in JS challenges
2015-08-25 04:41:02 +04:00
Berkeley Martinez
b49243ffe3
Merge pull request #2568 from AryanJ-NYC/AryanJ-NYC-1876
...
Fixed #1876 ; fixed some grammar issues; adhered to JS comment convent…
2015-08-24 11:14:32 -07:00
Berkeley Martinez
6a9c7aab12
Merge pull request #2596 from suhussai/suhussai-2592
...
Typo Fix. Closes #2592
2015-08-24 11:03:34 -07:00
Arsen Melikyan
7130f40b86
Fixes missing backslash in waypoints' instructions'
...
In three waypoints: [Find Numbers with Regular Expressions](http://www.freecodecamp.com/challenges/waypoint-find-numbers-with-regular-expressions ), [Find White Space with Regular Expressions](http://www.freecodecamp.com/challenges/waypoint-find-white-space-with-regular-expressions ), [Invert Regular Expression Matches with JavaScript](http://www.freecodecamp.com/challenges/waypoint-invert-regular-expression-matches-with-javascript ) there are confusing instructions: /d+/gi instead of /\d+/gi, /s+/gi instead of /\s+/gi, /S+/gi instead of /\S+/gi.This commit fixed them.
2015-08-24 14:48:38 +04:00
benmcmahon100
8704aa9a8d
Fix #2605
2015-08-24 00:22:35 +01:00
suhussai
b0d2ac24ec
Typo Fix. Closes #2592
...
Changed "greater then" to "greater than" in Waypoint 30, http://freecodecamp.com/challenges/waypoint-generate-random-whole-numbers-with-javascript
2015-08-23 12:20:28 -06:00
Aryan Jabbari
918f57d1c4
Fixed #1876 ; fixed some grammar issues; adhered to JS comment conventions
2015-08-23 05:19:45 -04:00
Quincy Larson
91cb86eca9
Merge branch 'staging' of github.com:FreeCodeCamp/freecodecamp into staging
2015-08-22 18:08:37 -07:00
Quincy Larson
f00a56580c
update JavaScript copy from pull request
2015-08-22 17:40:59 -07:00
Berkeley Martinez
ec5a4d62e3
Merge pull request #2505 from issyl0/fix_typo_iterate_with_js
...
In the while loop iterator section, advise while loops, not for loops
2015-08-22 17:22:14 -07:00
Abhisek Pattnaik
b44f537835
Fix error in string
2015-08-23 03:26:20 +05:30
Abhisek Pattnaik
b224955e2f
Fix Add your JavaScript Slot Machine Instructions
2015-08-23 03:22:05 +05:30
Isabell Long
6344f73a36
In the while loop iterator section, advise while loops, not for loops
...
- Fixes #2504 .
2015-08-22 20:27:08 +01:00
Berkeley Martinez
45f7fee772
Merge pull request #2498 from issyl0/add_full_stops
...
Add full stops at the end of "Random Whole Number" waypoint
2015-08-22 10:14:04 -07:00
Isabell Long
43f229a231
Add periods at the end of sentences in the Random Whole Number waypoint
...
- Partially fixes #1991 .
2015-08-22 18:08:58 +01:00
waseem
b9db124ea4
Fixed grammar - replaced 'but' with 'by'
2015-08-22 22:21:15 +08:00
Abhisek Pattnaik
a4e903847f
Correct Sift through Text with Regular Expressions
...
- Change information text
- Change regular expression
- Change code in editor
- Change assertion
2015-08-22 19:05:41 +05:30
benmcmahon100
6c56cfa238
Merge remote-tracking branch 'origin/staging' into staging
2015-08-21 22:40:18 +01:00
benmcmahon100
1f0b5d9e60
Fix a syntax(ish) error
2015-08-21 22:37:34 +01:00
benmcmahon100
5a1d45b766
Merge pull request #2451 from ahstro/ahstro-2440
...
Moved myArray into 'Only change code'-block
2015-08-21 22:34:16 +01:00
benmcmahon100
93b5961a12
Merge remote-tracking branch 'origin/staging' into staging
2015-08-21 22:01:11 +01:00
benmcmahon100
6a887bbf33
Fix #2444
2015-08-21 22:01:03 +01:00
Berkeley Martinez
fa4b330281
fix delete is a keyword not a function
2015-08-21 12:37:47 -07:00
ahstro
7714b0c4b7
Moved myArray into 'Only change code'-block
2015-08-21 21:22:25 +02:00
benmcmahon100
4959a23412
Update JSON
2015-08-21 20:20:56 +01:00
benmcmahon100
813d7509a1
Fix #2364
2015-08-20 23:38:16 +01:00
dokkillo
01fbec96a8
issue 2270
2015-08-20 17:21:10 +02:00
benmcmahon100
eb0a06c523
Merge pull request #2235 from dokkillo/dokkillo-2218
...
issue #2218
2015-08-19 23:14:09 +01:00
dokkillo
48e6f6a7bf
issue #2218
2015-08-19 23:45:58 +02:00
benmcmahon100
23625a3b09
Merge pull request #1975 from AryanJ-NYC/AryanJ-NYC-1909
...
Fixed #1909 #1972
2015-08-19 21:31:16 +01:00
benmcmahon100
525802cf07
Merge pull request #1977 from AryanJ-NYC/AryanJ-NYC-1944
...
Fixed #1944
2015-08-19 21:30:58 +01:00
benmcmahon100
8040dfbe14
Merge pull request #1985 from AryanJ-NYC/AryanJ-NYC-1982
...
Fixed #1982
2015-08-19 21:30:25 +01:00
benmcmahon100
16b91a9220
Merge pull request #1990 from AryanJ-NYC/AryanJ-NYC-1924
...
Fixes #1924
2015-08-19 21:30:17 +01:00
benmcmahon100
d0aab2569d
Merge pull request #1998 from itxchy/patch-2
...
Issue: Grammar #1994
2015-08-19 21:29:25 +01:00
benmcmahon100
08efc3ecb0
Merge pull request #2003 from michael-krebs/michael-krebs-1986
...
fix #1986
2015-08-19 21:28:13 +01:00
benmcmahon100
5bceb73887
Merge pull request #2004 from michael-krebs/michael-krebs-1988
...
fix #1988
2015-08-19 21:27:54 +01:00
benmcmahon100
16f83d544a
Merge pull request #2006 from itxchy/patch-4
...
Fixed: Misspell #1877
2015-08-19 21:27:34 +01:00
benmcmahon100
038d77776c
Merge pull request #2069 from AryanJ-NYC/AryanJ-NYC-2036
...
Fixes #2036
2015-08-19 21:24:24 +01:00
benmcmahon100
bdfb84ef86
Merge pull request #2074 from jbmartinez/jbmartinez-2049
...
Fixed #2049
2015-08-19 21:23:05 +01:00
benmcmahon100
3cdc703147
Merge pull request #2127 from ptsurbeleu/staging
...
fix issue #2124 and rephrase the challenge a bit to avoid confusion
2015-08-19 21:22:12 +01:00
benmcmahon100
97b54dd933
Merge pull request #2213 from dokkillo/staging
...
issue #2191
2015-08-19 19:11:27 +01:00
dokkillo
0b45c69d32
issue #2191
2015-08-19 19:12:51 +02:00
Ionut Costica
d22deb5f76
Fix for Issue #2179 , #2141 , #2077 , #1999
...
Fixes #2179 , #2141 , #2077 , #1999
2015-08-19 15:43:39 +03:00
Ionut Costica
72c69a7e19
Fix for Issue #2175
...
Fixes #2175
2015-08-19 15:08:57 +03:00
Pavel Tsurbeleu
d6752a0600
fix issue #2124 and rephrase the challenge a bit to avoid confusion
2015-08-18 15:17:26 -07:00
Juan Martínez
1b42bb4433
Fixed #2049
2015-08-18 14:05:51 +00:00
Aryan Jabbari
079d396770
Fixes #2036
2015-08-18 09:34:34 -04:00
Matt Trifilo
5119565411
Fixed: Misspell #1877
...
Issue #1877 's description's hint mentioned the wrong variable.
2015-08-17 23:29:11 -05:00
Michael Krebs
de9adc0aa8
fix #1988
2015-08-18 00:22:33 -04:00
Michael Krebs
3215c39b8b
fix #1986
2015-08-18 00:17:56 -04:00
Matt Trifilo
ee451a34fa
Issue: Grammar #1994
...
Put in the proposed grammar changes from [this issue](https://github.com/FreeCodeCamp/FreeCodeCamp/issues/1994 ).
2015-08-17 23:01:52 -05:00
Aryan Jabbari
ea131f3821
Fixes #1924
2015-08-17 22:54:08 -04:00
Aryan Jabbari
c31f6956c1
Fixed #1982
2015-08-17 22:31:37 -04:00
Aryan Jabbari
c8e41ef084
Fixed #1944
2015-08-17 22:21:57 -04:00
Aryan Jabbari
7bfe73ce26
Fixed #1909 #1972
2015-08-17 22:19:14 -04:00
Aryan Jabbari
79b2c0bd2c
Fixed #1926
2015-08-17 16:42:20 -04:00
Aryan Jabbari
237df7aa64
Moved closing code to line 961
2015-08-17 16:34:45 -04:00
Aryan Jabbari
14713a4c48
Fixes #1878
2015-08-17 16:19:02 -04:00
benmcmahon100
02e2e915f9
Spaced out code a bit more on the shift challenge
2015-08-17 21:12:19 +01:00
benmcmahon100
161138d4c6
fixed the moved some comments in a seed that were causing confusion
2015-08-17 21:11:01 +01:00
benmcmahon100
bbfa6b339e
Merge pull request #1812 from AryanJ-NYC/AryanJ-NYC-1807
...
Fixes #1807
2015-08-17 20:22:55 +01:00
benmcmahon100
1be658fdeb
Fix #1871
2015-08-17 20:11:04 +01:00
benmcmahon100
0e05a93d96
Fix #1870 #1874 and there was another issue but i cant find it related to the arithmetic on decimals challenge
2015-08-17 20:08:21 +01:00
benmcmahon100
154d38ed13
Merge pull request #1857 from AryanJ-NYC/AryanJ-NYC-1856
...
Fixes #1856
2015-08-17 14:53:40 +01:00
Aryan Jabbari
0be4d6f1dc
Fixes #1856
2015-08-17 09:52:34 -04:00
benmcmahon100
3565ef4903
Merge remote-tracking branch 'origin/staging' into staging
2015-08-17 14:28:54 +01:00
benmcmahon100
a18979a9ff
Fix #1838
2015-08-17 14:28:30 +01:00
benmcmahon100
477624b6bf
Update basic-javascript.json
2015-08-17 14:16:16 +01:00
benmcmahon100
9584dfb156
Merge pull request #1815 from AryanJ-NYC/AryanJ-NYC-1813
...
Fixed #1813
2015-08-17 14:15:37 +01:00
Aryan Jabbari
8cbde055af
Fixed #1813
2015-08-16 20:47:43 -04:00
Aryan Jabbari
d206e0b416
Fixes #1807
2015-08-16 20:14:12 -04:00
Aryan Jabbari
59a2765e27
Deleted extra comma
2015-08-16 20:08:37 -04:00
Aryan Jabbari
5041d6e472
Fixes #1801
2015-08-16 20:06:47 -04:00
benmcmahon100
5e3de0be68
Fixed a challenge test on modify array data with indexes
2015-08-16 20:17:06 +01:00
Quincy Larson
960931d41c
improvements to javascript challenges
2015-08-16 04:05:15 -07:00
Quincy Larson
0a0379eecf
fix nested array challenge
2015-08-15 15:56:56 -07:00
Quincy Larson
0d61531b4d
fix critical failing test in early waypoint
2015-08-15 15:33:21 -07:00
Quincy Larson
2b6bdd098f
update JavaScript challenges
2015-08-15 13:57:44 -07:00
Quincy Larson
4557711908
QA javascript challenges and remove slot machine for now
2015-08-15 11:11:25 -07:00
Quincy Larson
0c3e20977d
Merge branch 'staging' of github.com:FreeCodeCamp/freecodecamp into staging
2015-08-14 17:29:28 -07:00
Quincy Larson
7670d73ff5
improvements to copy of text and test output
2015-08-14 17:26:24 -07:00
benmcmahon100
273b731d29
Added a helper function to main.js for challenge making
2015-08-15 01:08:33 +01:00
Quincy Larson
fc7fcdc6a6
add semicolons to end of all tests in js-style challenges
2015-08-14 14:48:59 -07:00
Quincy Larson
56a8c203a7
improve javascript challenge copy
2015-08-14 14:40:02 -07:00
Quincy Larson
b56fd5b250
Merge branch 'staging' of github.com:FreeCodeCamp/freecodecamp into staging
2015-08-14 13:50:31 -07:00
Quincy Larson
a272b6f5ec
more improvements to javascript challenges
2015-08-14 13:50:20 -07:00
benmcmahon100
e55b3f1782
Fixed a weird error involving RegEx and single quotes
2015-08-14 20:26:05 +01:00
benmcmahon100
09c56cb73a
Allow optional white space when nesting arrays
2015-08-14 12:08:40 +01:00
Quincy Larson
dca68ef0b0
more improvements to javascript challenges
2015-08-14 01:13:07 -07:00
Quincy Larson
cd4fd1720d
make additional improvements to JavaScript challenge copy
2015-08-13 23:44:13 -07:00
Quincy Larson
edf9959fc9
finish jquery and start modifying javascript
2015-08-13 22:07:54 -07:00
Quincy Larson
9275bd5076
Merge branch 'staging' into jquery
...
Conflicts:
seed/challenges/basic-javascript.json
seed/challenges/object-oriented-and-functional-programming.json
2015-08-13 15:39:30 -07:00
Quincy Larson
837d412777
use double quotes for all string literals in waypoints
2015-08-13 15:32:40 -07:00
benmcmahon100
74ba74bb3b
Added a more specific example
2015-08-13 21:25:31 +01:00