Commit Graph

252 Commits

Author SHA1 Message Date
sidemt
6d7b49ffe0
fix(curriculum): remove reference to Mad Libs (#46490) 2022-06-13 20:56:38 +02:00
Muhammed Mustafa
5282994ad8
Chore(curriculum): removing copywriten wiki content (#46436)
* remove mad-labs link

* changed similar to wiki text in legacy JS

* let's go Sam got my back here as well

Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>

Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>
2022-06-10 08:54:51 -05:00
Bill Cheng
8397129aaa
fix(curriculum): Add test output to not change strings assigned to variables (#46353) 2022-06-05 10:51:36 -05:00
Titi
14bf77d3b8
chore: removed unneeded check for semicolon 2022-06-04 11:09:55 -05:00
Muhammed Mustafa
924fd04760
fix(curriculum): external golf wiki link in JS (#46170) 2022-05-27 10:51:40 +02:00
Muhammed Mustafa
864f4a199a
fix(curriculum): removed link in JS basic-JavaScript (#46143)
* fix(curriculum): removed link in JS basic-javascript

* removed JSON and its example
2022-05-26 16:36:21 +02:00
Muhammed Mustafa
5b4dc4ab6d
fix(curriculum): external Mad Libs link in JS steps (#46157) 2022-05-26 12:43:20 +05:30
Muhammed Mustafa
93f32b45e2
fix(curriculum): external card counting link in JS (#46158) 2022-05-26 12:42:39 +05:30
Muhammed Mustafa
f2592999f3
fix(curriculum): external floating link in JS (#46159)
Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>
2022-05-26 12:41:58 +05:30
Muhammed Mustafa
ddc55af8de
fix(curriculum): external link in words blank JS (#46145) 2022-05-26 00:14:37 +07:00
Benjamin Lu
2da688fbfe
fix(curriculum): add switch statement spaces for consistency (#46141)
Co-authored-by: Huyen Nguyen <25715018+huyenltnguyen@users.noreply.github.com>
2022-05-25 22:37:00 +05:30
Luke Harrison
e4c6883a20
fix(curriculum): updated wording on understanding uninitialized variables (#45860)
* updated wording on understanding uninitialized variables

* updated wording for case b to match case a

* updated case c to match the wording of both case a and b
2022-05-05 19:05:30 +02:00
Naomi Archibong
4ff9c2a6fc
feat: update wording for string length (#45602) 2022-04-15 08:13:42 -07:00
JuumanBeing
c92a71e11e
fix(curriculum): include note about counting spaces by .length property (#45641)
Added a sentence to bring attention to the fact that the JS string .length property counts space characters.
2022-04-09 12:27:50 +02:00
Lenin Kennedy
a6d2660c7c
fix(curriculum): remove style note (#45625) 2022-04-05 13:49:27 -06:00
Suph
405675261d
fix(curriculum): clear up confusion of array index (#45576) 2022-03-30 20:45:20 +02:00
Radi Totev
4d620dea1a
fix(curriculum): allow spaces before brackets (#45494)
* chore(curriculum): update regex in use-braket-notation-* tests

Update regex used in tests, so that tests are more forgiving and spaces tolerant.

* Allow for spaces within brackets
2022-03-22 13:52:13 +01:00
Naomi Carrigan
d781c63fdf
chore: resolve flagged Crowdin issues (#45442)
* chore: resolve bengali issues

* chore: resolve french issues

* chore: resolve hebrew issues

* chore: resolve persian issues

* chore: resolve portuguese brazilian issues

* chore: resolve russian issues

* chore: resolve spanish issues

* chore: resolve japanese issues
2022-03-19 13:26:57 +05:30
Kai Wei Mo
ce5b9b8aba
fix(curriculum): augment test for adding tracks property (#45424)
* Only English

* Consitent quotation marks
2022-03-17 19:13:16 +00:00
HenMoshe
d3304276ca
fix(curriculum) : Make tests stricter for challenge "Decrement a number with javascript" (#45242)
* Make tests stricter for challenge "Decrement a number with javascript" #44648

* Update decrement-a-number-with-javascript.md
2022-03-09 22:47:02 -06:00
Naomi Carrigan
1c65d5d34a
fix(curriculum): remove callback thereby stripping js comments (#45133)
* fix: strip js comments

* fix: revert helper export, better test approach

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2022-02-24 16:29:56 +05:30
HenMoshe
ea416b6dc2
fix(curriculum): add result of comparison expression evaluation to the inline comment (#45224)
* Add result of comparison expression evaluation in the inline comment #45183

* Apply suggestions from code review

thanks!

Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>

Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>
2022-02-23 18:58:42 +01:00
zelf0
3668422083
fix: add divider to stand in line challenge in basic javascript section (#45180)
* Fix: Update grammar in PR documnetation

* fix: add divider to stand in line challenge in basic javascript section

* Undo change outside of scope
2022-02-21 22:44:27 +05:30
Jagruti Tiwari
9b7d7ba716
fix(curriculum): inconsistancy on const Naming cases (#45149) 2022-02-17 11:35:16 -08:00
Madhu Sudhan Reddy Vinta
0a895dad47
fix(curriculum): make example less confusing (#45088)
* Local scope and functions: Make the example less confusing

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/local-scope-and-functions.md

Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>

Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>
2022-02-11 12:08:46 -08:00
sanberkzulfikar
50b554470d
fix(curriculum): wording consistency in counting-cards.md (#44390) 2021-12-08 07:32:56 -08:00
Michał Urbanek
9920b7c83c
fix(curriculum): point to all lines requiring change (#44056)
* fix comments for which place to edit

 solution should be placed in this line, previous comments was missleading.
as discussed in https://github.com/freeCodeCamp/freeCodeCamp/issues/44049

* shorter comments

clear of not needed ward Only

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/declare-a-read-only-variable-with-the-const-keyword.md

letter fixes

Co-authored-by: Ilenia <nethleen@gmail.com>

* fix for spelling of Change

only letter change

* fix for italian language

all other languages

* revert

revert of changes that will be done in other place

* revert

Co-authored-by: Ilenia <nethleen@gmail.com>
2021-10-29 12:37:01 +02:00
Oliver Eyton-Williams
da9e6ad0c1 fix(curriculum): consts must be initialized 2021-10-27 19:42:45 +05:30
Kristofer Koishigawa
bcc9beff1f
feat(curriculum): introduce let and const earlier (#43133)
* fix: move "Explore Differences Between..." to basic JS, update seed and tests

* fix: resequence "Declare String Variables"

* fix: move "Declare a Read-Only Variable..." to basic JS, update seed and tests

* fix: revert changes to non-English "Explore Differences Between..." test text

* fix: revert test strings, solutions, and seeds for non-English challenges

* fix: update "Declare String Variables" description

* fix: sync quotation marks in description and seed

* fix: modify note in "Declare a Read-Only..." challenge

* fix: update operator and compound assignment challenges

* fix: update string challenges

* fix: update array and array method challenges

* fix: update function and scope challenges, resequence slightly

* fix: "Word Blanks" solution

* fix: add spacing to seed

* fix: concatenating += challenge spacing

* fix: appending variables to strings spacing

* fix: find the length of a string spacing

* fix: removed instances of removedFromMyArray = 0

* fix: switch challenges

* fix: function argument and param spacing

* fix: update counting cards, object challenges, and record collection

* fix: finish rest of Basic JS section

* fix: introducing else statements solution

* fix: update spacing and wording

* fix: update wording for const challenge

* fix: update functional programming challenges

* fix: intermediate algorithms and cert challenges

* fix: revert some spacing and remove comments for fp challenge solutions

* feat: add notes with links to moved let and const challenges in first two es6 challenges

* fix: update es6 intro text

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/concatenating-strings-with-the-plus-equals-operator.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/finding-a-remainder-in-javascript.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/global-scope-and-functions.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/iterate-through-an-array-with-a-for-loop.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/iterate-through-an-array-with-a-for-loop.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/functional-programming/implement-map-on-a-prototype.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/declare-a-read-only-variable-with-the-const-keyword.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* fix: concatenating strings with plus operator seed

* fix: add comments back to Declare a Read-Only Variable... seed

* feat: add es6 to basic javascript redirect tests for let and const challenges

* fix: revert "Concatenating Strings with Plus Operator" seed

* fix: move test file to cypress/integration/learn/redirects, separate redirect tests

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2021-10-25 17:55:58 +01:00
Riadh Laabidi
304f245cd2
fix(curriculum): Remove outdated video (#43685)
* Remove outdated video from testing objects for properties challenge

* Remove outdated video from testing objects for properties challenge
2021-10-02 18:51:15 +02:00
Aaron McCollum
badeb6e2df
fix(curriculum): reworded grammar to do without hyphen (#43487)
Suggesting the removal of "-" on line 29 in the description, as the comma before "such" is sufficient to separate the examples from the rest of the sentence.
2021-09-18 13:13:05 +01:00
Patrick Lehmann
5371af7767
fix(learn): removed space from first sentence and added instruction to basic javascript challenges (#43198)
* sheesh

* added markdown formatting to challenge

* added formatting to keep space in concatenating strings with the plus equals operator

* Delete husky.sh

* added back in italian dictionary

* removed code formatting

* updating text formatting for challenges, removed space and added instruction

Co-authored-by: Pat Lehmann <patrick.lehmann@homes.com>
2021-08-24 10:26:45 -07:00
abfipes
db1a92611a
fix(curriculum): repair of a small logical underdevelopment (#43116)
* repair of a small logical underdevelopment 

a> b is false if a == b

* Apply suggestions (fix small typo )

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>
2021-08-05 14:54:32 +02:00
Innocent V.I
ac2fe62eef
fixed create-decimal-numbers-with-javascript challenge external link (#42801) 2021-07-09 09:02:47 -05:00
dogfood654
e5505cbe7b
fix(curriculum): minor indentation for readability (#42451)
* Fixed minor indentation for readability

* amended to 2 indentation
2021-06-16 14:35:34 +01:00
Ilenia
ce3ccc47d4
fix(curriculum): remove unnecessary backticks (#42458) 2021-06-12 20:53:45 +02:00
zoembrown
ca2f024aec
fix(curriculum): fixed typo in challenge (#42456) 2021-06-12 17:37:17 +02:00
Ilenia
28add4712a
Remove backticks from around data types to ease translations (#42403) 2021-06-08 14:03:16 +05:30
Rebekah Koon
5a3d22e76b
fix(curriculum): changing Charles -> Ada in JavaScript challenge descriptions (#42280)
* changing Charles -> Ada in JavaScript challenge descriptions

* fix: changing Charles -> Ada in JavaScript challenge descriptions

* fix: changing firstName value from Ada to Augusta in javascript lesson
2021-05-29 21:33:21 +05:30
alirezaghey
cbb7afd5b8
fix(curriculum): correct link text (#42143)
* Small language improvement

The correct term is assignment operator.

* Small language improvement

Co-authored-by: Niraj Nandish <nirajnandish@icloud.com>

Co-authored-by: Niraj Nandish <nirajnandish@icloud.com>
2021-05-15 17:10:19 +02:00
alirezaghey
79e799feb5
fix(curriculum): scoping variables language improvement (#42135) 2021-05-14 09:02:54 -07:00
Evgeny Klimenchenko
db369fbed1
fix(client): remove JS comments from user code for tests (#41873)
* Removes comments in js challanges by default

* fix local-scope-and-functions test regex

* fix all languages

* revert language changes

* removed unnecessary removeJSComments from challenges

* fix challanges in other languages

* removed removeJSComments from all challanges
2021-04-28 10:18:54 -05:00
Jeremy L Thompson
6ae186a8cf
fix(curriculum): record collection challenge - variable names shouldn't be keywords (#41904)
* style - update record collection challenge, variables shouldn't be name after keywords

* minor - typo fix

* Apply suggestions from code review

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
2021-04-23 21:51:41 +02:00
Shaun Hamilton
4171277dc9
fix(curriculum): clarify instructions for ouput (#41839) 2021-04-16 20:33:58 +02:00
Karen Blacktopp
422bded413
fix: remove quotation marks from 'Hi World' in Instructions (#41837) 2021-04-16 10:36:59 +02:00
Emer Conghaile
fe95d5bca2
fix(curriculum): Remove unnecessary comments (#41777)
* Remove unnecessary comments

https://github.com/freeCodeCamp/freeCodeCamp/pull/41612

* Remove unnecessary comment
2021-04-08 10:59:25 -07:00
Emer Conghaile
87b0e5bb7a
fix(curriculum): Remove unnecessary comments (#41781)
* Remove unnecessary comments

https://github.com/freeCodeCamp/freeCodeCamp/pull/41612

* Update the hints section
2021-04-08 10:49:47 -07:00
Emer Conghaile
c4ba0c692f
fix(curriculum): Remove unnecessary comments (#41776)
* Remove unnecessary comments

* Remove last comment, change instruction wording
2021-04-08 10:46:39 -07:00
Emer Conghaile
591a534701
Remove unnecessary comments (#41775)
https://github.com/freeCodeCamp/freeCodeCamp/pull/41612
2021-04-08 09:40:34 -07:00
Emer Conghaile
a9a68fa498
fix(curriculum): Remove unnecessary comments (#41774)
* fix: Remove unnecessary comments

https://github.com/freeCodeCamp/freeCodeCamp/pull/41612

* Add empty line
2021-04-08 09:36:05 -07:00
Saurabh Kumar singh
617f7b07e9
Update iterate-through-an-array-with-a-for-loop (#41742)
* Update iterate-through-an-array-with-a-for-loop

* Update iterate-through-an-array-with-a-for-loop

Add space around minus for better readablilty.

* Update iterate-through-an-array-with-a-for-loop

* Update iterate-through-an-array-with-a-for-loop

* Update iterate-through-an-array-with-a-for-loop.md
2021-04-08 09:56:49 -05:00
Nicholas Carrigan (he/him)
7d83a6b65d
fix(curriculum): verbiage (#41732)
* fix(curriculum): verbiage

Modify the wording of the tests in this challenge to avoid having
two tests which sound the same.

* fix: Shaun's arrays have elements

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
2021-04-03 23:00:15 +02:00
Sem Bauke
e75685f803
fix(curriculum): change tests to allow more solutions (#41703)
* fix(curriculum) only allow  new object to be the second value in array

* fix(curriculum) remove direct array index notation

* Apply suggestions from Shaun

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
2021-03-31 14:24:20 -07:00
Emer Conghaile
e5b4ae17a0
fix: Simplify wording to make more sense (#41586)
* fix: Simplify wording to make more sense

I think that "count odd numbers backward by twos" instead of "count backward by twos by odd numbers" is easier to understand.

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/count-backwards-with-a-for-loop.md

I think that this variation sounds better than what I originally wrote.

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-25 22:18:51 +00:00
Randell Dawson
b5ed2619eb
fix: replace inline code blocks (#41576) 2021-03-26 02:37:48 +05:30
Randell Dawson
e18c6955b0
fix(curriculum): Improve test to allow any valid function call for Write Reusable JavaScript with Functions challenge (#41538)
* fix: improve test to allow function call anywhere

* fix: force user to put console.log in function
2021-03-20 12:23:32 +00:00
Arjun Yadav
3f1cd6eb33
fixed the grammar of the description (#41531) 2021-03-19 06:55:21 -06:00
Kelvin Sánchez
35a8f55515
fix(learn): Remove unnecessary inline code tag in challenge (#41428)
* remove unnecessary inline code tag

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/comparison-with-the-less-than-or-equal-to-operator.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* improve challenge wording

* improve challenge wording

* keep wording consistency

* keep wording consistency between similar challenges

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-10 10:16:03 -08:00
Nicholas Carrigan (he/him)
c5bcebc724
fix(learn): revert backslash change (#41382)
* fix(learn): revert backslash change

Crowdin resolved the issue with backslashes escaping backtics in
the markdown parser, so this reverts the workaround we implemented
for that bug.

* Update curriculum/challenges/english/10-coding-interview-prep/rosetta-code/s-expressions.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-09 10:13:27 -06:00
Nicholas Carrigan (he/him)
77730ae209
fix(learn): address translator comments (#41381)
* fix(learn): address translator comments

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/quoting-strings-with-single-quotes.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-09 08:15:26 -06:00
Andrew Cen
65cc800689
fix: add blank lines on empty seeds (#41348) 2021-03-03 13:14:28 -08:00
Nicholas Carrigan (he/him)
7117919d36
chore(learn): audit javascript algorithms and data structures (#41092)
* chore(learn): audit basic algorithm scripting

* chore(learn): audit basic data structures

* chore(learn): audit basic javascript

* chore(learn): audit debugging

* chore(learn): audit es6

* chore(learn): audit functional programming

* chore(learn): audit intermidate algorithms

* chore(learn): audit js projects

* chore(learn): audit object oriented programming

* chore(learn): audit regex

* fix(learn): remove stray .

* fix(learn): string to code

* fix(learn): missed some

* fix(learn): clarify strings

Based on Randy's feedback, clarifies string instances where quotes
were removed in favour of back ticks.

* fix: apply suggestions - thanks Randy! :)

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: non-suggestion comments

* chore(learn): remove comments from codes

Removes the comments from the description and instruction code
blocks to ensure that all relevant information is translatable.

* fix: Apply suggestions from code review

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: revert crowdin fix

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-algorithm-scripting/mutations.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: Apply suggestions from code review

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-arrays.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: Apply suggestions from code review

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* chore: change voice

* fix: Christopher Nolan

* fix: expressions would evaluate

* fix: will -> would

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/object-oriented-programming/add-methods-after-inheritance.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: to work to push

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/iterate-with-javascript-for-loops.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/object-oriented-programming/add-methods-after-inheritance.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-03-02 17:12:12 -07:00
Randell Dawson
b11dd87047
fix: remove sentence not needed (#41235) 2021-02-23 11:21:58 -06:00
Randell Dawson
f4bbe3f34c
fix(learn): Updated code blocks to help with translation on two challenges (#41217) 2021-02-22 11:21:59 +05:30
Alexander Heß
b12360d4a8
Removed the hint Fixes #41192 (#41215)
* Removed the hint Fixes #41192

* Removed the blank line as suggested
2021-02-21 13:36:14 -07:00
Kelvin Sánchez
f08174b5b1
fix(learn): Remove unnecessary inline code tag in challenge (#41177)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-19 09:44:50 +05:30
Kelvin Sánchez
fad168b465
fix(learn): fix some code tags, capitalization and punctuation in challenge (#41161)
* fix some code tags, capitalization and punctuation

Note: The reserved word in JavaScript is "boolean", so I think it is appropriate to use it like this inside the code tags.

* Remove code tags and capitalize first letter

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* capitalize letter and replace slash

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-18 08:45:12 -07:00
Kelvin Sánchez
2c1280af65
fix(learn): Improve the clarity on a challenge sentence (#41154)
* Improve the clarity on a challenge sentence

* add string type and remove double quotes

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-18 08:29:31 -07:00
Kelvin Sánchez
1fe1371b16
add missing inline-code block (#41153) 2021-02-17 11:24:53 -08:00
Kelvin Sánchez
b45406ec9d
fix(learn): Remove repeated definition tag in challenge (#41151) 2021-02-17 23:01:42 +05:30
Nicholas Carrigan (he/him)
21c7abf584
fix(learn): update challenge for crowdin (#41089) 2021-02-16 19:47:40 +05:30
Nicholas Carrigan (he/him)
18e821bcd3
fix: remove clunky sentence (#40751) 2021-02-01 19:22:39 +05:30
matias-miller
8a9f3319c6
fix(learn): Fixed typos in count-backwards-with-a-for-loop.md (#40478)
* Spelling change in count-backwards-with-a-for-loop

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/count-backwards-with-a-for-loop.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-01-21 08:44:10 -08:00
Nicholas Carrigan (he/him)
062b1cd424
fix: replace h tags (#40750)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-01-21 13:41:46 +05:30
Nicholas Carrigan (he/him)
8d8d25e9f2
fix(learn): address escaped backticks (#40717)
* fix(learn): address escaped backticks

Addresses the instances of escaped backticks - where a backtick is
preceded by a backslash.  In most cases, this was left over from the
old parser. In some cases, a backtick was intended to be wrapped in
code tags and has been adjusted accordingly.

This issue came to light due to a bug in the translation flow on
Crowdin.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: EVEN MORE :( :( :(

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: backslash nightmares

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: When you wish upon a *******

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix(curriculum): md error introduced by formatter

* fix(curriculum): remove extra `s

* fix: restore quote symbol

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: Typo

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: apply review changes

Applying review feedback from call with @RandellDawson.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: markdown does weird stuff sometimes

Can't stick backticks together - use code.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-01-20 19:01:00 -07:00
Oliver Eyton-Williams
ee1e8abd87
feat(curriculum): restore seed + solution to Chinese (#40683)
* feat(tools): add seed/solution restore script

* chore(curriculum): remove empty sections' markers

* chore(curriculum): add seed + solution to Chinese

* chore: remove old formatter

* fix: update getChallenges

parse translated challenges separately, without reference to the source

* chore(curriculum): add dashedName to English

* chore(curriculum): add dashedName to Chinese

* refactor: remove unused challenge property 'name'

* fix: relax dashedName requirement

* fix: stray tag

Remove stray `pre` tag from challenge file.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

Co-authored-by: nhcarrigan <nhcarrigan@gmail.com>
2021-01-12 19:31:00 -07:00
Ilenia
7de8549e02
fix(learn): Made the Escaping literal quotes channel accept the dot inside the double quotes too (#40465)
* made valid solution dot inside and dot outside quotes

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/escaping-literal-quotes-in-strings.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-12-16 08:07:47 -08:00
vbinithyanandamv
7c19c82076
[BUG] Able to pass challenge "Basic JavaScript: Initializing Variables with the Assignment Operator" with incorrect answers #40406 (#40409)
* [BUG] #40406 Fix

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/initializing-variables-with-the-assignment-operator.md

Requested Change.

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-12-15 18:07:36 -07:00
Oliver Eyton-Williams
0bd52f8bd1
Feat: add new Markdown parser (#39800)
and change all the challenges to new `md` format.
2020-11-27 10:02:05 -08:00
Ilenia
f294d9cacc
fix(learn): removed use strict from various challenges (#40321) 2020-11-25 15:59:04 -08:00
rajapandi_vijayakumar
e8b6a9e5dd
fix(learn): add example declaration for clarity (#40207)
Variable declaration is added which is used inside the switch case.
2020-11-09 17:09:21 +00:00
Randell Dawson
895e6b8daf
fix(learn): add test to prevent hardcoded pass (#40179) 2020-11-06 17:05:20 +00:00
Oliver Eyton-Williams
a71150074d
fix(learn): preserve whitespace in the tool panel (#39973) 2020-10-14 21:40:15 +05:30
dhanush1909
a32427c120
fix(learn): make semicolon at end of line optional (#39821) 2020-10-08 21:02:59 +01:00
Oliver Eyton-Williams
2b9e38a17b
fix: replace .english.md extension with .md 2020-09-29 22:09:04 +02:00
Mainak Debnath
362e8254f8
fix(learn): update test to allow negative arguments (#39701)
* Updated the regex in test

* Changed regex

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* Updated changes in regex

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-09-28 16:03:24 +01:00
Nicholas Carrigan
6ccd0d21a1
fix(learn): Update test text in Profile Lookup (#39678) 2020-09-25 00:38:40 +05:30
Gaurav Khairnar
a338d4b79d
fix(learn): clear instructions for basic JavaScript: Appending Variables to Strings lesson (#39587) 2020-09-17 13:00:58 -05:00
Hassaan Pasha
80438cac3e
feat(client, learn): add helper functions for common validation operations (#38605)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-09-17 19:38:01 +05:30
Randell Dawson
30c61b808b
fix: consolidate misc comments (#39583) 2020-09-16 13:29:50 -05:00
Aleksa S. Stevic
5cb609dc5c
Changed "statement" to "expression" (#39564)
The ternary operator doesn't allow statements, just expressions.
2020-09-12 10:37:59 +02:00
Randell Dawson
c345bc9886
fix: removed scrimba video links that do not reflect current challenge (#39559) 2020-09-11 11:17:50 -05:00
Siddharth Pathak
5418307936
fix(learn): add whitespace check to else-if test (#39555) 2020-09-09 20:30:33 +01:00
Tom
b79a332984
fix: remove scrimba link for inaccurate video (#39545) 2020-09-08 13:09:53 -07:00
Oliver Eyton-Williams
bd68b70f3d
Feat: hide blocks not challenges (#39504)
* fix: remove isHidden flag from frontmatter

* fix: add isUpcomingChange

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>

* feat: hide blocks not challenges

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>
2020-09-03 15:07:40 -07:00
skaparate
f97c847e29
fix(learn): formatting bug preventing tests to pass (#39045)
* implemented object validation

* fix: formatting bug preventing tests to pass

* implemented object validation

* fix: formatting bug preventing tests to pass

* integrated changes again

* added suggested changes

* fix: refine instructions

* fix: revert some bad instructions and change album to albumTitle

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2020-09-03 12:34:12 +01:00
bhagerty
db15a44160
fix(learn): clarify instructions to remove confusion (#39479)
* Clarify instructions to remove confusion

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/accessing-object-properties-with-variables.english.md

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2020-09-02 18:41:59 +01:00
Beau Carnes
f334734e98
feat: split JS challenge into two (#39044)
* feat: split JS challenge into two

* fix/change-to-not-use-untaught-assignments

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2020-08-31 19:44:56 +01:00
anthony
20d397f719
remove MDN links from English challenges (#39337)
* remove MDN links from English challenges

* add push challenge reference to record-collection

* refactor truthy falsy verbiage

* replace MDN link with news link

* remove unnecessary whitespace
2020-07-31 15:19:49 +09:00
Bianca Zanardi
35f24c6085
Fix text inconsistency (#39203)
* Fix text inconsistency

To match the eight ECMAScript Language Types on the previous paragraph.

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2020-07-09 16:18:11 +02:00