CodeCow/freeCodeCamp
1
0
Fork 0
mirror of https://github.com/freeCodeCamp/freeCodeCamp.git synced 2026-06-22 21:08:12 +08:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

fix(client): only play scene when ready (#57893)

Browse Source
This commit is contained in:
Oliver Eyton-Williams 2025-01-07 04:18:29 +01:00 committed by GitHub
parent 553fe950f8
commit c603dabe3b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
client/src/templates/Challenges/components/scene/scene.tsx
View File

@ -127,7 +127,7 @@ export function Scene({
// TODO: if we manage the playing state in another module, we should not
// need the early return here. It should not be possible for this to be
// called at all if the scene is already playing.
if (isPlaying) return;
if (isPlaying || !sceneIsReady) return;
setIsPlaying(true);
setShowDialogue(true);
@ -240,6 +240,7 @@ export function Scene({
isPlaying,
duration,
sceneSubject,
sceneIsReady,
commands,
audio,
hasTimestamps,