From ab4d41caac82588ec3e0c6c56335d4646bf2bfb3 Mon Sep 17 00:00:00 2001 From: Huyen Nguyen <25715018+huyenltnguyen@users.noreply.github.com> Date: Tue, 14 May 2024 17:27:03 +0700 Subject: [PATCH] fix(client): badge title alignment and privacy settings message (#54779) --- client/i18n/locales/english/translations.json | 1 - client/src/components/profile/components/camper.tsx | 2 +- client/src/components/profile/profile.tsx | 5 ++--- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/client/i18n/locales/english/translations.json b/client/i18n/locales/english/translations.json index 28c20ca9534..6a1b87544bf 100644 --- a/client/i18n/locales/english/translations.json +++ b/client/i18n/locales/english/translations.json @@ -293,7 +293,6 @@ } }, "profile": { - "you-not-public": "You have not made your portfolio public.", "username-not-public": "{{username}} has not made their portfolio public.", "you-change-privacy": "You need to change your privacy setting in order for your portfolio to be seen by others. This is a preview of how your portfolio will look when made public.", "username-change-privacy": "{{username}} needs to change their privacy setting in order for you to view their portfolio.", diff --git a/client/src/components/profile/components/camper.tsx b/client/src/components/profile/components/camper.tsx index d43853f5095..5cf159c4b8e 100644 --- a/client/src/components/profile/components/camper.tsx +++ b/client/src/components/profile/components/camper.tsx @@ -60,7 +60,7 @@ function Camper({ {(isDonating || isTopContributor) && ( -

{t('profile.badges')}

+

{t('profile.badges')}

{isDonating && (
diff --git a/client/src/components/profile/profile.tsx b/client/src/components/profile/profile.tsx index 46ab416d4aa..ca1d15f4bf8 100644 --- a/client/src/components/profile/profile.tsx +++ b/client/src/components/profile/profile.tsx @@ -3,7 +3,7 @@ import Helmet from 'react-helmet'; import type { TFunction } from 'i18next'; import { useTranslation } from 'react-i18next'; -import { Container, Row } from '@freecodecamp/ui'; +import { Alert, Container, Row } from '@freecodecamp/ui'; import { FullWidthRow, Link, Spacer } from '../helpers'; import { User } from './../../redux/prop-types'; import Timeline from './components/time-line'; @@ -26,8 +26,7 @@ interface MessageProps { const UserMessage = ({ t }: Pick) => { return ( -

{t('profile.you-not-public')}

-

{t('profile.you-change-privacy')}

+ {t('profile.you-change-privacy')}
);