From 779bb5a574058472ac75139ee1693dbca86be613 Mon Sep 17 00:00:00 2001
From: Ilenia <26656284+ilenia-magoni@users.noreply.github.com>
Date: Wed, 25 Dec 2024 21:22:13 +0100
Subject: [PATCH] fix: improve tests in travel agency lab (#57743)

---
 .../669e2f60e83c011754f711f9.md                    | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/curriculum/challenges/english/25-front-end-development/lab-travel-agency-page/669e2f60e83c011754f711f9.md b/curriculum/challenges/english/25-front-end-development/lab-travel-agency-page/669e2f60e83c011754f711f9.md
index b32e505ea5b..0abba395c09 100644
--- a/curriculum/challenges/english/25-front-end-development/lab-travel-agency-page/669e2f60e83c011754f711f9.md
+++ b/curriculum/challenges/english/25-front-end-development/lab-travel-agency-page/669e2f60e83c011754f711f9.md
@@ -142,7 +142,7 @@ assert.strictEqual(
 You should have two items in your unordered list.
 
 ```js
-assert.lengthOf(document.querySelectorAll('li'), 2);
+assert.lengthOf(document.querySelectorAll('p + ul li'), 2);
 ```
 
 Both your list items should contain an anchor element.
@@ -205,17 +205,25 @@ Each `figure` element should contain a `figcaption` element as its second child.
 const figures = document.querySelectorAll('figure');
 assert.isNotEmpty(figures);
 for (let figure of figures) {
-  assert.equal(figure.children[1].tagName, 'FIGCAPTION');
+  assert.equal(figure.children[1]?.tagName, 'FIGCAPTION');
 }
 ```
 
+Each `figcaption` should contain some text.
+
+```js
+const figcaptionEls = document.querySelectorAll('figcaption');
+assert.isNotEmpty(figcaptionEls);
+figcaptionEls.forEach((figcaption => assert.isNotEmpty(figcaption.innerText)));
+```
+
 Each of the `a` elements that are children of your `figure` elements should contain an image.
 
 ```js
 const anchors = document.querySelectorAll('figure > a');
 assert.isNotEmpty(anchors);
 for (let anchor of anchors) {
-  assert.equal(anchor.children[0].tagName, 'IMG');
+  assert.equal(anchor.children[0]?.tagName, 'IMG');
 }
 ```