CodeCow/freeCodeCamp
1
0
Fork 0
mirror of https://github.com/freeCodeCamp/freeCodeCamp.git synced 2026-06-13 21:02:08 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

refactor: make renderHelpButton a component (#51620)

Browse Source 
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
This commit is contained in:
Muhammed Mustafa 2023-09-25 14:13:46 +03:00 committed by GitHub
parent 0586d9a5ed
commit 6972f593e2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
client/src/components/settings/internet.tsx
View File

@ -34,6 +34,10 @@ type InternetState = {
originalValues: Socials;
};
function Info({ message }: { message: string }) {
return message ? <HelpBlock>{message}</HelpBlock> : null;
}
class InternetSettings extends Component<InternetProps, InternetState> {
static displayName: string;
constructor(props: InternetProps) {
@ -148,9 +152,6 @@ class InternetSettings extends Component<InternetProps, InternetState> {
return null;
};
renderHelpBlock = (validationMessage: string) =>
validationMessage ? <HelpBlock>{validationMessage}</HelpBlock> : null;
renderCheck = (url: string, validation: string | null) =>
url && validation === 'success' ? (
<FormControl.Feedback>
@ -198,7 +199,7 @@ class InternetSettings extends Component<InternetProps, InternetState> {
value={githubProfile}
/>
{this.renderCheck(githubProfile, githubProfileValidation)}
{this.renderHelpBlock(githubProfileValidationMessage)}
<Info message={githubProfileValidationMessage} />
</FormGroup>
<FormGroup
controlId='internet-linkedin'
@ -212,7 +213,7 @@ class InternetSettings extends Component<InternetProps, InternetState> {
value={linkedin}
/>
{this.renderCheck(linkedin, linkedinValidation)}
{this.renderHelpBlock(linkedinValidationMessage)}
<Info message={linkedinValidationMessage} />
</FormGroup>
<FormGroup
controlId='internet-picture'
@ -226,7 +227,7 @@ class InternetSettings extends Component<InternetProps, InternetState> {
value={twitter}
/>
{this.renderCheck(twitter, twitterValidation)}
{this.renderHelpBlock(twitterValidationMessage)}
<Info message={twitterValidationMessage} />
</FormGroup>
<FormGroup
controlId='internet-website'
@ -240,7 +241,7 @@ class InternetSettings extends Component<InternetProps, InternetState> {
value={website}
/>
{this.renderCheck(website, websiteValidation)}
{this.renderHelpBlock(websiteValidationMessage)}
<Info message={websiteValidationMessage} />
</FormGroup>
</div>
<BlockSaveButton