From 248a135d0cb30fe0a7ea1238b0de1f8f93045b49 Mon Sep 17 00:00:00 2001 From: agilan11 <140779703+agilan11@users.noreply.github.com> Date: Mon, 27 Jan 2025 22:40:36 +0530 Subject: [PATCH] fix(curriculum): update hints and test for magazine layout lab (#58244) Co-authored-by: Ilenia <26656284+ilenia-magoni@users.noreply.github.com> --- .../lab-magazine-layout/6735a7370e0ae93a4577c689.md | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/curriculum/challenges/english/25-front-end-development/lab-magazine-layout/6735a7370e0ae93a4577c689.md b/curriculum/challenges/english/25-front-end-development/lab-magazine-layout/6735a7370e0ae93a4577c689.md index 42b09cf6a31..20a6de61271 100644 --- a/curriculum/challenges/english/25-front-end-development/lab-magazine-layout/6735a7370e0ae93a4577c689.md +++ b/curriculum/challenges/english/25-front-end-development/lab-magazine-layout/6735a7370e0ae93a4577c689.md @@ -107,10 +107,13 @@ const magazineCoverStyle = getComputedStyle(document.querySelector('.magazine-co assert.match(magazineCoverStyle.gridTemplateAreas, /("|')small-article1 small-article2 cover-image\1$/); ``` -Your `.magazine-cover` class should have a `grid-template-columns` property set to `1fr 1fr 1fr`. +Your `.magazine-cover` selector should use the `grid-template-columns` property to divide the space into three equal parts. Remember you can use either the `repeat` function or manually define each fractional unit. ```js -assert.equal(new __helpers.CSSHelp(document).getStyle('.magazine-cover')?.gridTemplateColumns, '1fr 1fr 1fr'); +assert.oneOf( + new __helpers.CSSHelp(document).getStyle('.magazine-cover')?.gridTemplateColumns, + ['1fr 1fr 1fr', 'repeat(3, 1fr)'] +); ``` Your `.magazine-cover` class should have a `grid-template-rows` property set to `auto 1fr 1fr`.