CodeCow/freeCodeCamp
1
0
Fork 0
mirror of https://github.com/freeCodeCamp/freeCodeCamp.git synced 2026-06-13 21:02:08 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

fix(api): always use the same logic when saving challenges (#64553)

Browse Source
This commit is contained in:
Oliver Eyton-Williams 2025-12-15 12:22:19 +01:00 committed by GitHub
parent 6fc07e3561
commit 001f884e21
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 17 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
api/src/routes/protected/challenge.test.ts
View File

@ -901,7 +901,13 @@ describe('challengeRoutes', () => {
alreadyCompleted: false,
points: 1,
completedDate,
savedChallenges: []
savedChallenges: [
{
files: jsFiles,
id: JsProjectId,
lastSavedDate: expect.any(Number)
}
]
});
expect(response.statusCode).toBe(200);
});
@ -1089,7 +1095,13 @@ describe('challengeRoutes', () => {
alreadyCompleted: false,
points: 1,
completedDate,
savedChallenges: []
savedChallenges: [
{
files: jsFiles,
id: JsProjectId,
lastSavedDate: expect.any(Number)
}
]
});
expect(response.statusCode).toBe(200);
});

7
api/src/routes/protected/challenge.ts
View File

@ -22,7 +22,7 @@ import {
formatCoderoadChallengeCompletedValidation,
formatProjectCompletedValidation
} from '../../utils/error-formatting.js';
import { challenges } from '../../utils/get-challenges.js';
import { challenges, savableChallenges } from '../../utils/get-challenges.js';
import { ProgressTimestamp, getPoints } from '../../utils/progress.js';
import {
validateExamFromDbSchema,
@ -1128,10 +1128,7 @@ async function postSaveChallenge(
files
};
if (
!multifileCertProjectIds.includes(challengeId) &&
!multifilePythonCertProjectIds.includes(challengeId)
) {
if (!savableChallenges.has(challengeId)) {
logger.warn(
{
challengeId

5
api/src/utils/common-challenge-functions.ts
View File

@ -194,10 +194,7 @@ export async function updateUserChallengeData(
? [...progressTimestamps, newProgressTimeStamp]
: progressTimestamps;
if (
multifileCertProjectIds.includes(challengeId) ||
multifilePythonCertProjectIds.includes(challengeId)
) {
if (savableChallenges.has(challengeId)) {
const challengeToSave: SavedChallenge = {
id: challengeId,
lastSavedDate: newProgressTimeStamp,