From afc494982f446b04529683b3c5e951d6c27de377 Mon Sep 17 00:00:00 2001 From: Jnewbon <48688400+Jnewbon@users.noreply.github.com> Date: Sat, 11 Jul 2020 15:37:05 +0100 Subject: [PATCH 01/10] #6718 Added Github action --- .github/workflows/job-changelog-check.yml | 28 +++++++++++++++++++++++ 1 file changed, 28 insertions(+) create mode 100644 .github/workflows/job-changelog-check.yml diff --git a/.github/workflows/job-changelog-check.yml b/.github/workflows/job-changelog-check.yml new file mode 100644 index 0000000000..7507e25649 --- /dev/null +++ b/.github/workflows/job-changelog-check.yml @@ -0,0 +1,28 @@ +# This workflow will triage pull requests and apply a label based on the +# paths that are modified in the pull request. +# +# To use this workflow, you will need to set up a .github/labeler.yml +# file with configuration. For more information, see: +# https://github.com/actions/labeler/blob/master/README.md + +name: Changlog Updated +on: + pull_request: + +jobs: + label: + + runs-on: ubuntu-latest + steps: + - id: file_changes + uses: trilom/file-changes-action@v1.2.3 + with: + pr: ${{ steps.pr.outputs.results }} + - name: List files + run: | + echo ${{ steps.file_changes.outputs.files_modified}} + if [[ "${{ steps.file_changes.outputs.files_modified}}" == *"ChangLog"* ]] then + echo "Changlog has been updated" + else + echo "::error file=app.js,line=10,col=15::Changelog hasnt been updated" + fi From a76bcf70c83f0cfd0adff2414e8f65e0e9d90db0 Mon Sep 17 00:00:00 2001 From: Jnewbon <48688400+Jnewbon@users.noreply.github.com> Date: Sat, 11 Jul 2020 15:43:49 +0100 Subject: [PATCH 02/10] #6718 Fixed bad name --- .github/workflows/job-changelog-check.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/job-changelog-check.yml b/.github/workflows/job-changelog-check.yml index 7507e25649..3a775591bb 100644 --- a/.github/workflows/job-changelog-check.yml +++ b/.github/workflows/job-changelog-check.yml @@ -8,6 +8,7 @@ name: Changlog Updated on: pull_request: + branches: [ master ] jobs: label: @@ -17,7 +18,7 @@ jobs: - id: file_changes uses: trilom/file-changes-action@v1.2.3 with: - pr: ${{ steps.pr.outputs.results }} + prNumber: ${{ steps.pr.outputs.results }} - name: List files run: | echo ${{ steps.file_changes.outputs.files_modified}} From 91544ef2b616b9b2b6b7eebbf00b660febdee8cf Mon Sep 17 00:00:00 2001 From: Jnewbon <48688400+Jnewbon@users.noreply.github.com> Date: Sat, 11 Jul 2020 15:48:05 +0100 Subject: [PATCH 03/10] #6718 Trying diffrent settings --- .github/workflows/job-changelog-check.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/job-changelog-check.yml b/.github/workflows/job-changelog-check.yml index 3a775591bb..e9f9898c0c 100644 --- a/.github/workflows/job-changelog-check.yml +++ b/.github/workflows/job-changelog-check.yml @@ -18,7 +18,10 @@ jobs: - id: file_changes uses: trilom/file-changes-action@v1.2.3 with: + githubToken: ${{ secrets.GITHUB_TOKEN }} prNumber: ${{ steps.pr.outputs.results }} + output: ' ' + fileOutput: ' ' - name: List files run: | echo ${{ steps.file_changes.outputs.files_modified}} From 4fc73ea49226edfde170c737b2fd49dafa04cfb3 Mon Sep 17 00:00:00 2001 From: Jnewbon <48688400+Jnewbon@users.noreply.github.com> Date: Sat, 11 Jul 2020 15:56:13 +0100 Subject: [PATCH 04/10] #6718 Trying without any options with tests --- .github/workflows/job-changelog-check.yml | 24 ++++++++++++++++++----- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git a/.github/workflows/job-changelog-check.yml b/.github/workflows/job-changelog-check.yml index e9f9898c0c..e9db12d94e 100644 --- a/.github/workflows/job-changelog-check.yml +++ b/.github/workflows/job-changelog-check.yml @@ -16,12 +16,26 @@ jobs: runs-on: ubuntu-latest steps: - id: file_changes + name: Get changed files uses: trilom/file-changes-action@v1.2.3 - with: - githubToken: ${{ secrets.GITHUB_TOKEN }} - prNumber: ${{ steps.pr.outputs.results }} - output: ' ' - fileOutput: ' ' + - name: echo changes + run: | + echo Files + cat $HOME/files.json + echo Modified + cat $HOME/files_modified.json + echo Added + cat $HOME/files_added.json + echo Removed + cat $HOME/files_removed.json + echo Files + echo '${{ steps.file_changes.outputs.files}}' + echo Modified + echo '${{ steps.file_changes.outputs.files_modified}}' + echo Added + echo '${{ steps.file_changes.outputs.files_added}}' + echo Removed + echo '${{ steps.file_changes.outputs.files_removed}}' - name: List files run: | echo ${{ steps.file_changes.outputs.files_modified}} From 951f22ab5d41861f418ce4ca89e212c0def6bb8b Mon Sep 17 00:00:00 2001 From: Jnewbon <48688400+Jnewbon@users.noreply.github.com> Date: Sat, 11 Jul 2020 15:59:02 +0100 Subject: [PATCH 05/10] #6718 Fixed bash syntax --- .github/workflows/job-changelog-check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/job-changelog-check.yml b/.github/workflows/job-changelog-check.yml index e9db12d94e..eed9d08d7a 100644 --- a/.github/workflows/job-changelog-check.yml +++ b/.github/workflows/job-changelog-check.yml @@ -39,7 +39,7 @@ jobs: - name: List files run: | echo ${{ steps.file_changes.outputs.files_modified}} - if [[ "${{ steps.file_changes.outputs.files_modified}}" == *"ChangLog"* ]] then + if [[ "${{ steps.file_changes.outputs.files_modified}}" == *"ChangLog"* ]]; then echo "Changlog has been updated" else echo "::error file=app.js,line=10,col=15::Changelog hasnt been updated" From 49c658e4cce301cd44e576f752f44f8e3faee064 Mon Sep 17 00:00:00 2001 From: Jnewbon <48688400+Jnewbon@users.noreply.github.com> Date: Sat, 11 Jul 2020 16:01:12 +0100 Subject: [PATCH 06/10] #6718 Added exit 1 for failure --- .github/workflows/job-changelog-check.yml | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/.github/workflows/job-changelog-check.yml b/.github/workflows/job-changelog-check.yml index eed9d08d7a..540cab1faa 100644 --- a/.github/workflows/job-changelog-check.yml +++ b/.github/workflows/job-changelog-check.yml @@ -20,14 +20,6 @@ jobs: uses: trilom/file-changes-action@v1.2.3 - name: echo changes run: | - echo Files - cat $HOME/files.json - echo Modified - cat $HOME/files_modified.json - echo Added - cat $HOME/files_added.json - echo Removed - cat $HOME/files_removed.json echo Files echo '${{ steps.file_changes.outputs.files}}' echo Modified @@ -43,4 +35,5 @@ jobs: echo "Changlog has been updated" else echo "::error file=app.js,line=10,col=15::Changelog hasnt been updated" + exit 1 fi From 4a4bab66d4ea0e6423b4dc19f44001e372cc723f Mon Sep 17 00:00:00 2001 From: Jamie Newbon Date: Sat, 11 Jul 2020 16:04:53 +0100 Subject: [PATCH 07/10] #4718 Updated changelog and removed label --- .github/workflows/job-changelog-check.yml | 2 -- ChangeLog | 1 + 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/job-changelog-check.yml b/.github/workflows/job-changelog-check.yml index 540cab1faa..21e2030706 100644 --- a/.github/workflows/job-changelog-check.yml +++ b/.github/workflows/job-changelog-check.yml @@ -11,8 +11,6 @@ on: branches: [ master ] jobs: - label: - runs-on: ubuntu-latest steps: - id: file_changes diff --git a/ChangeLog b/ChangeLog index bb08a0bb51..4d1bd22454 100644 --- a/ChangeLog +++ b/ChangeLog @@ -16,6 +16,7 @@ Enhancements: - #6714 Added windows core binaries upload to sandor - #6715 Updated language file from Crowdin - #6688 Fully migrate CI from Jenkins to Azure Pipelines +- #6718 Action to test PR's for updated changelog Features: - #6538 System-wide config for all system users From 56e2cab8d8fcd57a533175d1701df4f020820934 Mon Sep 17 00:00:00 2001 From: Jamie Newbon Date: Sat, 11 Jul 2020 16:07:39 +0100 Subject: [PATCH 08/10] #4718 Fixed Workflow --- .github/workflows/job-changelog-check.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/job-changelog-check.yml b/.github/workflows/job-changelog-check.yml index 21e2030706..437e729063 100644 --- a/.github/workflows/job-changelog-check.yml +++ b/.github/workflows/job-changelog-check.yml @@ -11,6 +11,7 @@ on: branches: [ master ] jobs: + check: runs-on: ubuntu-latest steps: - id: file_changes From 6a8419dcce55b17a670474ff704803e7d5c87a8f Mon Sep 17 00:00:00 2001 From: Jnewbon <48688400+Jnewbon@users.noreply.github.com> Date: Sat, 11 Jul 2020 16:18:07 +0100 Subject: [PATCH 09/10] #6718 Trying with output csv --- .github/workflows/job-changelog-check.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/job-changelog-check.yml b/.github/workflows/job-changelog-check.yml index 437e729063..f0d2e01a2d 100644 --- a/.github/workflows/job-changelog-check.yml +++ b/.github/workflows/job-changelog-check.yml @@ -17,6 +17,8 @@ jobs: - id: file_changes name: Get changed files uses: trilom/file-changes-action@v1.2.3 + with: + output: ',' - name: echo changes run: | echo Files @@ -29,7 +31,6 @@ jobs: echo '${{ steps.file_changes.outputs.files_removed}}' - name: List files run: | - echo ${{ steps.file_changes.outputs.files_modified}} if [[ "${{ steps.file_changes.outputs.files_modified}}" == *"ChangLog"* ]]; then echo "Changlog has been updated" else From cccc95d53777f840705805c39890aeca50fcd5f6 Mon Sep 17 00:00:00 2001 From: Jnewbon <48688400+Jnewbon@users.noreply.github.com> Date: Sat, 11 Jul 2020 16:23:12 +0100 Subject: [PATCH 10/10] #6718 Me and my spelling --- .github/workflows/job-changelog-check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/job-changelog-check.yml b/.github/workflows/job-changelog-check.yml index f0d2e01a2d..9bd9ca913d 100644 --- a/.github/workflows/job-changelog-check.yml +++ b/.github/workflows/job-changelog-check.yml @@ -31,7 +31,7 @@ jobs: echo '${{ steps.file_changes.outputs.files_removed}}' - name: List files run: | - if [[ "${{ steps.file_changes.outputs.files_modified}}" == *"ChangLog"* ]]; then + if [[ "${{ steps.file_changes.outputs.files_modified}}" == *"ChangeLog"* ]]; then echo "Changlog has been updated" else echo "::error file=app.js,line=10,col=15::Changelog hasnt been updated"