From 20bc88eb1f95f4bb6922fbd15040e27f25b59678 Mon Sep 17 00:00:00 2001 From: sithlord48 Date: Thu, 19 Jun 2025 22:29:34 -0400 Subject: [PATCH] refactor: PortalInputCapture sonar adjustments --- src/lib/platform/PortalInputCapture.cpp | 14 +++++--------- src/lib/platform/PortalInputCapture.h | 8 +++++--- 2 files changed, 10 insertions(+), 12 deletions(-) diff --git a/src/lib/platform/PortalInputCapture.cpp b/src/lib/platform/PortalInputCapture.cpp index d012155265..e9fc55c4f2 100644 --- a/src/lib/platform/PortalInputCapture.cpp +++ b/src/lib/platform/PortalInputCapture.cpp @@ -157,7 +157,7 @@ void PortalInputCapture::handleInitSession(GObject *object, GAsyncResult *res) handleZonesChanged(m_session, nullptr); } -void PortalInputCapture::handleSetPointerBarriers(const GObject *object, GAsyncResult *res) +void PortalInputCapture::handleSetPointerBarriers(const GObject *, GAsyncResult *res) { g_autoptr(GError) error = nullptr; @@ -239,7 +239,7 @@ void PortalInputCapture::release(double x, double y) m_isActive = false; } -void PortalInputCapture::handleDisabled(const XdpInputCaptureSession *session, const GVariant *option) +void PortalInputCapture::handleDisabled(const XdpInputCaptureSession *, const GVariant *) { LOG_DEBUG("portal cb disabled"); @@ -264,9 +264,7 @@ void PortalInputCapture::handleDisabled(const XdpInputCaptureSession *session, c ); } -void PortalInputCapture::handleActivated( - const XdpInputCaptureSession *session, std::uint32_t activationId, GVariant *options -) +void PortalInputCapture::handleActivated(const XdpInputCaptureSession *, std::uint32_t activationId, GVariant *options) { LOG_DEBUG("portal cb activated, id=%d", activationId); @@ -285,15 +283,13 @@ void PortalInputCapture::handleActivated( m_isActive = true; } -void PortalInputCapture::handleDeactivated( - const XdpInputCaptureSession *session, std::uint32_t activationId, const GVariant *options -) +void PortalInputCapture::handleDeactivated(const XdpInputCaptureSession *, std::uint32_t activationId, const GVariant *) { LOG_DEBUG("cb deactivated, id=%i", activationId); m_isActive = false; } -void PortalInputCapture::handleZonesChanged(XdpInputCaptureSession *session, GVariant *options) +void PortalInputCapture::handleZonesChanged(XdpInputCaptureSession *session, const GVariant *) { for (auto b : m_barriers) g_object_unref(b); diff --git a/src/lib/platform/PortalInputCapture.h b/src/lib/platform/PortalInputCapture.h index 07a7cb3e7b..bd568ad63d 100644 --- a/src/lib/platform/PortalInputCapture.h +++ b/src/lib/platform/PortalInputCapture.h @@ -42,7 +42,7 @@ private: void handleDisabled(const XdpInputCaptureSession *session, const GVariant *option); void handleActivated(const XdpInputCaptureSession *session, std::uint32_t activationId, GVariant *options); void handleDeactivated(const XdpInputCaptureSession *session, std::uint32_t activationId, const GVariant *options); - void handleZonesChanged(XdpInputCaptureSession *session, GVariant *options); + void handleZonesChanged(XdpInputCaptureSession *session, const GVariant *options); /// g_signal_connect callback wrapper static void sessionClosed(XdpSession *session, gpointer data) @@ -53,11 +53,13 @@ private: { static_cast(data)->handleDisabled(session, options); } - static void activated(XdpInputCaptureSession *session, std::uint32_t activationId, GVariant *options, gpointer data) + static void + activated(const XdpInputCaptureSession *session, std::uint32_t activationId, GVariant *options, gpointer data) { static_cast(data)->handleActivated(session, activationId, options); } - static void deactivated(XdpInputCaptureSession *session, std::uint32_t activationId, GVariant *options, gpointer data) + static void + deactivated(const XdpInputCaptureSession *session, std::uint32_t activationId, const GVariant *options, gpointer data) { static_cast(data)->handleDeactivated(session, activationId, options); }