mirror of
https://github.com/bitwarden/clients.git
synced 2026-07-07 21:10:55 +08:00
b85e096b49
* fix(dirt): check response.error before showing success toast for critical apps
The orchestrator's catchError converts API failures into next emissions
with response.error set. The component's next handler was unconditionally
showing a success toast without checking this field.
Now checks response.error and shows an error toast when the API call
failed. Selection is preserved on error so users can retry.
Also ensures updatingCriticalApps signal is reset on all paths (success,
caught error, and uncaught error).
[PM-33067]
* test(dirt): add tests for mark/unmark critical apps error handling
Tests verify that:
- Success toast shown when response.error is null
- Error toast shown when response.error is non-null
- Selection preserved on error, cleared on success
[PM-33067]
* fix(dirt): use specific error toast for unmark critical apps failure
Replace generic "An unexpected error has occurred" with
"Failed to unmark applications as critical" for consistency
with the mark-as-critical error toast.
* fix(dirt): check response.error in Review New Applications mark critical
The AllApplicationsComponent (Review New Applications widget) had the
same false success toast bug as the All Applications tab. The next
handler ignored the response parameter entirely, showing a success
toast even when response.error was set by the orchestrator's catchError.
Now checks response.error before showing toast. On error: shows
"Failed to mark applications as critical" and preserves selection.
Also resets markingAsCritical on all paths.
Adds unit tests for mark success and error paths.
[PM-33067]
* Revert "fix(dirt): check response.error in Review New Applications mark critical"
This reverts commit
|
||
|---|---|---|
| .. | ||
| app | ||
| connectors | ||
| images | ||
| locales | ||
| scss | ||
| utils | ||
| videos | ||
| .nojekyll | ||
| 404.html | ||
| app-id.json | ||
| browserconfig.xml | ||
| favicon.ico | ||
| global.d.ts | ||
| index.html | ||
| main.ts | ||
| manifest.json | ||
| polyfills.ts | ||
| theme.ts | ||
| translation-constants.ts | ||
| version.json | ||