Will Martin
34a4970527
Fix readonly lint errors in SendGeneratorDialogComponent ( #19480 )
...
Convert mutable class properties to readonly, using signals for
buttonLabel and generatedValue to satisfy the enforce-readonly-angular-properties rule.
2026-03-11 09:46:54 -04:00
bmbitwarden
8108a09701
PM-31202 implmeneted password modal menu ( #18829 )
...
* PM-31202 implmeneted password modal menu
* PM-31202 resolved lint issues
* PM-31202 included password generator inside navigation container for browser
* PM-31202 resolved lint issue
* PM-31202 resolved pr comments
---------
Co-authored-by: John Harrington <84741727+harr1424@users.noreply.github.com>
2026-03-10 19:26:49 -04:00
Will Martin
5e90565a79
[CL-1063] add enforce-readonly-angular-properties ESLint rule ( #19201 )
...
* Add enforce-readonly-angular-properties ESLint rule
2026-03-09 10:26:42 -07:00
Daniel James Smith
bc988b4312
Remove dependency on JslibModule for export components ( #19346 )
...
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2026-03-03 20:06:39 +00:00
John Harrington
8f75045d76
[PM-32466] Icons on the send page are not announced by the screen reader ( #19268 )
...
* hide aria on i elements and add companion sr elements
* move sr-only inside of button element
2026-03-02 08:15:39 -07:00
Bernd Schoolmann
0569ec9517
[PM-31880 | BEEEP] Move random out of keyservice to PureCrypto ( #18838 )
...
* Move random to PureCrypto
* Rename and fix builds
* Fix tests
* Fix build
* Prettier
* Fix tests
2026-02-20 19:09:52 +01:00
bmbitwarden
702e6086b9
PM-30876 resolved screenreader for icons on send table rows ( #18940 )
...
* PM-30876 resolved screenreader for icons on send table rows
* PM-30876 resolved grey icon issue
* PM-30876 resolved blank underline issue
* PM-30876 resolved screen reader
* PM-30876 resolved screen reader
2026-02-19 19:26:18 -05:00
John Harrington
263ec94124
[PM-32161] Remove all emails when email list field is cleared and send is saved ( #18959 )
...
* add new validation criteria to prevent authType.Email with an empty emails field
* simplify validation logic
2026-02-18 14:59:34 -07:00
bmbitwarden
ef786225c9
PM-18607 reimplemented errorOnUnknownProperties ( #18922 )
...
Chromatic / Check PR run (push) Has been cancelled
Scan / Check PR run (push) Has been cancelled
Testing / Run typechecking (push) Has been cancelled
Testing / Run tests - ${{ matrix.test-group.name }} (map[artifact:jest-coverage-browser junit:junit-browser.xml name:Browser paths:apps/browser bitwarden_license/bit-browser]) (push) Has been cancelled
Testing / Run tests - ${{ matrix.test-group.name }} (map[artifact:jest-coverage-cli junit:junit-cli.xml name:CLI paths:apps/cli bitwarden_license/bit-cli]) (push) Has been cancelled
Testing / Run tests - ${{ matrix.test-group.name }} (map[artifact:jest-coverage-desktop junit:junit-desktop.xml name:Desktop paths:apps/desktop]) (push) Has been cancelled
Testing / Run tests - ${{ matrix.test-group.name }} (map[artifact:jest-coverage-libs junit:junit-libs.xml name:Libs paths:libs bitwarden_license/bit-common]) (push) Has been cancelled
Testing / Run tests - ${{ matrix.test-group.name }} (map[artifact:jest-coverage-web junit:junit-web.xml name:Web paths:apps/web bitwarden_license/bit-web]) (push) Has been cancelled
Testing / Run Rust tests on ${{ matrix.os }} (macos-14) (push) Has been cancelled
Testing / Run Rust tests on ${{ matrix.os }} (ubuntu-22.04) (push) Has been cancelled
Testing / Run Rust tests on ${{ matrix.os }} (windows-2022) (push) Has been cancelled
Testing / Rust Coverage (push) Has been cancelled
Chromatic / Chromatic (push) Has been cancelled
Scan / Checkmarx (push) Has been cancelled
Scan / Sonar (push) Has been cancelled
Testing / Upload to Codecov (push) Has been cancelled
Testing / Run tests (push) Has been cancelled
* PM-18607 reimplemented errorOnUnknownProperties
* claude review
* claude review
---------
Co-authored-by: John Harrington <84741727+harr1424@users.noreply.github.com>
2026-02-16 19:37:36 -05:00
John Harrington
bd9734c14c
reorder form fields to match design specs ( #18964 )
2026-02-13 14:14:06 -07:00
Jordan Aasen
2a72d2e74d
[PM-25685][PM-31077] - Migrate all Folder models ( #17077 )
...
* enforce strict types on folders
* fix folder api service
* fix tests
* fix test
* fix type issue
* fix test
* add extra checks for folders. add specs
* fix folder.id checks
* fix id logic
* remove unecessary check
* name name and id optional in folder model
* fix tests
* Update folder and folderview
* fix folder with id export
* fix tests
* fix tests
* more defensive typing
* fix tests
* no need to check for presence
* check for empty name in folder toDomain
* fixes to folder
* initialize id in folder constructor. fix failing tests
* remove optional param to folder constructor
* fix folder
* fix test
* remove remaining checks for null folder id
* fix logic
* pass null for empty folder ids
* make id more explicit
* fix failing test
* fix failing test
* fix "No Folder" filter
2026-02-12 13:52:29 -08:00
John Harrington
f8976f992a
[PM-31611] [Defect] After entering an email, the Anyone with the link option cannot be selected anymore ( #18844 )
...
* add authType to to sendDetailsForm valueChanges
2026-02-11 13:37:20 -07:00
Mike Amirault
eb402a7ee8
[PM-30881] Add lock icon to browser Sends list for protected Sends ( #18635 )
...
* [PM-30881] Add lock icon to browser Sends list for protected Sends
* Trigger AI PR review
* [PM-30881] Add missing i18n key to browser file
2026-02-06 10:42:16 -05:00
Alex Dragovich
1b812d2274
Revert "Remove feature flag check from password generation ( #18003 )" ( #18794 )
...
This reverts commit 7c6d98b50e
2026-02-05 13:33:44 -08:00
Oscar Hinton
ad523179bf
[PM-30677] Convert SendSearchComponent to OnPush ( #18322 )
...
Converts SendSearchComponent to use OnPush change detection.
2026-02-05 22:03:42 +01:00
Mike Amirault
314c842b96
[PM-31435] Use muted colors for Send file and text type icons ( #18673 )
2026-02-05 14:51:36 -05:00
Mike Amirault
87bc57b3e2
[PM-31434] Match Send table options button size to other tables ( #18685 )
2026-02-05 14:48:40 -05:00
Mike Amirault
5e31ba9cce
[PM-27220] Switch export filetype select to simple select ( #17865 )
2026-02-05 11:30:37 -05:00
John Harrington
d88cb89618
PM-23851 False requirement to pop out extension when using send files ( #17950 )
...
* follow existing popout guard pattern to force popout on firefox when filepicker is exposed
* move firefox guard to tools ownership & revert changes to auth owned file
* initial refactor to consolidate logic using file-picker-popout.guard
* remove safari from guard & disable forced popout in vault import
* enforce popout on Safari with test coverage
* use userAgent and consistent detection for platform detection
* refactor guard tests involving routes
* replace imports lost during merge
* remove text sends from popout requirement and update tests
* add tooltip and screen-reader text describing popout behavior
2026-02-05 08:41:03 -07:00
adudek-bw
7c6d98b50e
Remove feature flag check from password generation ( #18003 )
...
* Remove feature flag check from password generation
2026-02-05 09:46:31 -05:00
Mike Amirault
51a99fecd8
[PM-31429] Add missing helper text for password protected Sends, remove unused one ( #18694 )
...
* [PM-31429] Add missing helper text for password protected Sends, remove unused one
* Put one UI change behind feature flag, add back required translations
* Reorder translation
* Add spaces
* Come full circle, remove last couple of committed changes
2026-02-03 15:18:23 -05:00
bmbitwarden
2d85b62beb
PM-31247 interchanged error message ( #18644 )
2026-02-03 12:18:10 -05:00
John Harrington
201d36201f
[PM-30247] Previously archived items are not archived after import ( #18546 )
2026-02-02 14:38:24 -07:00
Alex Dragovich
c5bd811dfd
[PM-31323] change text on toast for send link copy ( #18617 )
2026-01-28 10:49:20 -08:00
bmbitwarden
0138abf373
PM-29919 email verification on sends ( #18260 )
...
* PM-29919 email verification on sends
* PM-29919 resolved build issue
* PM-29919 refined who can view fields
* PM-29919 resolved lint issues
* PM-29919 resolved lint issues
* PM-29919 resolved unit tests
* PM-29919 resolved lint issues
* PM-29919 resolved unit test issue
* PM-29919 resolved pr comments
* PM-29919 resolved pr comments
* PM-29919 resolved unneeded label
* PM-29919 refactored to hide instead of disable
* PM-29919 resolved pr comments
* PM-29919 resolved no auth string in PM-31200
* PM-29919 resolved bugs
2026-01-28 09:39:37 -05:00
Oscar Hinton
f9c4e7c022
Fix send no search triggering whenever searching ( #18438 )
2026-01-20 12:30:34 +01:00
Mike Amirault
9f74178928
[PM-21774] Adjust icon and tooltip for protected Sends on the Sends l… ( #18293 )
...
* [PM-21774] Adjust icon and tooltip for protected Sends on the Sends list page
* [PM-21774] Update Sent table UI stories
* [PM-21774] Fix Send table UI story
2026-01-15 14:19:43 -05:00
Leslie Xiong
44bdaf71b3
Desktop/pm 18769/migrate vault filters ( #17919 )
...
Migrated vault filters to new v3 vault's navigation
* Decoupled existing vault filtering from vault component by using routed params with routed-vault-filter-bridge
* Converted vault filters to standalone components
* Removed extending filter Base Components from deprecated /libs/angular library and handled logic directly
* Moved shared 'models' and 'services' directories from web-vault into /libs/vault
2026-01-15 16:17:00 +01:00
bmbitwarden
27d43c500f
PM-28183 implemented new sends filter and search design ( #17901 )
...
* PM-28183 implemented new sends filter and search design
* PM-28183 resolved table issue fallout from merge conflict
* PM-28183 resolved browser paste url issue
* PM-28183 put new feature behind feature flag
* PM-28183 resolved feature flag
* PM-28183 resolved type-safe approach pr comment
* PM-28183 resolved DesktopSendUIRefresh feature flag is enabled. pr comment
* PM-28183 restored SendUIRefresh
* PM-28183 resolved query parameter subscription pr comment
* PM-28183 resolved pr comment re enum like objects
* PM-28183 resolved remove enum like objects pr comment
* PM-28183 resolved pr comment re defining filteredSends member variable
* PM-28183 resolved pr comment re Code Duplication in syncCompleted Handler
* PM-28183 resolved pr comment re Floating Promise
* PM-28183 restored feature flag
* PM-28183 resolved pr comment re Dual Binding Pattern
* PM28183 resolved options cell button pr comment
* PM 28183 resolved pr comment re Incorrect CSS Class - Breaking Layout
* PM 28183 resolved pr comment re uery Param Update Causes Redundant Filter Application
* PM-28183 resolved lint issues
* PM 28183 resolved lint issues
* PM-28183 resolved type issue with import
* PM-28183 resolved import in failling test
* chore: rerun web build
* PM-28183 resolved build issues
* PM-28183 resolved build issues
* PM-28183 resolved lint issues
2026-01-12 13:26:50 -05:00
Bernd Schoolmann
f167f06b62
[PM-30442] Fix cipherkey getting included in export of unencrypted json ( #18206 )
...
* Fix cipherkey being exported in unencrytped json export
* Fix unencrypted json exporting with cipher key
* Fix unencrypted export for org vaults
---------
Co-authored-by: SmithThe4th <gsmith@bitwarden.com>
2026-01-12 10:06:11 +00:00
bmbitwarden
92190d734c
Pm 28182 add success page ( #17814 )
...
* PM-28182-implemented send confirmation drawer
* PM-28182 resolved lint issue
* PM-28182 resolved pr comment
* PM-28182 put behind feature flag
* Fix feature flag checks in send component
* Fix feature flag checks in send dropdown component
* Add SendUIRefresh feature flag
* PM-28182 resolved lint issues
* PM-28182 resolved N bug in drawer message
* PM28182 resolved expirationDate replaced with delettionDate
* PM-28182 resolved build issue
* PM-28182 resolved failling tests
* PM-28182 resolved pr comment to consolidate expression
* chore: rerun web build
* PM-28182 removed unneeded export
2026-01-09 13:39:26 -05:00
Vincent Salucci
86764d807a
[PM-22434] Remove CreateDefaultLocation feature flag references and definition ( #18057 )
...
* chore: remove ff from vault-popup-list-filters.service, refs PM-22434
* chore: remove ff from confirm.command, refs PM-22434
* chore: remove ff from bulk-confirm-dialog.component, refs PM-22434
* chore: remove ff from member-actions.service and clean up leftover imports, refs PM-22434
* chore: remove ff from policy-edit-dialog.component, refs PM-22434
* chore: remove ff from organization-data-ownership.component, refs PM-22434
* chore: remove ff from vnext-organization-data-ownership.component, refs PM-22434
* chore: remove ff from vault-filter.service, refs PM-22434
* chore: remove ff from vault-filter.service (libs), refs PM-22434
* chore: remove ff from export.component, refs PM-22434
* chore: update observeMyItemsExclusionCriteria method documentation comments, refs PM-22434
* chore: remove ff from item-details-section.component, refs PM-22434
* chore: remove ff definition, refs PM-22434
* fix: remove configService from superclasses, refs PM-22434
* chore: update injection for VaultPopupListFilters service instantiation, refs PM-22434
* chore: update ConfirmCommand instantiation, refs PM-22434
* chore: update import order in member-actions.service, refs PM-22434
* fix: constructor argument update to amend merge conflict, refs PM-22434
* chore: remove unnecessary feature flag related tests for confirm user, refs PM-22434
* fix: remove unused services from member-actions.service.spec, refs PM-22434
2026-01-05 16:25:57 -06:00
Isaac Ivins
cf285abd3d
Feature/pm 25865 migrate send list desktop migration ( #18008 )
...
This PR moves the Desktop Send list UI into a shared library component and updates the Desktop Send v2 component to use modern Angular patterns (Signals, OnPush, no manual subscriptions)
2026-01-05 15:37:24 +01:00
Daniel James Smith
1c6a83f311
[BEEEP][PM-29441] Introduce bitwarden-encrypted-json-importer ( #17651 )
...
* Introduce bitwarden-encrypted-json-importer
An effort to introduce type guards and split the logic between the differently protected bitwarden-json import-formats
* Improved stricter types, but not quite ts-strict yet
* Add guard to prevent passing password-protected exports to the wrong importer.
* Only create one return object instead of multiple
* Updated changes afer npm ci and npm run prettier
---------
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
2025-12-29 21:28:33 +01:00
Mike Amirault
dfb597c236
[PM-24015] Handle Send form empty password field properly ( #17911 )
2025-12-22 11:04:14 -05:00
bmbitwarden
481386218a
PM-24189 improved screen reader parsing for special character checkbox ( #17361 )
...
* PM-24189 improved screen reader parsing for special character checkbox
* PM-24189 resolved voiceOver issue
* PM-24189 resolved voiceOver issue
* PM-27628 resolved pr comment re id and aria labels and comments
* PM-24189 resolved pr comment
2025-12-19 13:26:40 -05:00
Oscar Hinton
44b31fdade
[PM-29448] Consume the new send table in web ( #17923 )
...
2nd part of PM-29448. Consumes the new send table in the web vault. Also updates the send table to contain the responsive behaviour.
2025-12-19 16:00:37 +01:00
Mike Amirault
b63e1cb26c
[PM-28181] Open send dialog in drawer instead of popup in refreshed UI ( #17666 )
...
* [PM-28181] Open send dialog in drawer instead of popup in refreshed UI
* Fix types
* [PM-28181] Use drawer to edit sends with refreshed UI
* [PM-28181] Address bug where multiple Sends could not be navigated between
2025-12-16 13:34:31 -05:00
Alex Dragovich
14dd732b52
[PM-23258] changing verbiage from import data to import items ( #17123 )
...
* [PM-23258] changing verbiage from import data to import items
* [PM-23258] Removing vault and data from import and export titles, navs, and buttons
* [PM-23258] more verbiage changes
* [PM-23258] reverting unnecessary change
* [PM-23258] removing unused text from messages json files
* [PM-23258] small text changes from design
* [PM-23258] including secrets manager changes
2025-12-12 09:43:34 -08:00
Todd Martin
27d82aaf28
feat(accounts): Add creationDate of account to AccountInfo
...
* Add creationDate of account to AccountInfo
* Added initialization of creationDate.
* Removed extra changes.
* Fixed tests to initialize creation date
* Added helper method to abstract account initialization in tests.
* More test updates.
* Linting
* Additional test fixes.
* Fixed spec reference
* Fixed imports
* Linting.
* Fixed browser test.
* Modified tsconfig to reference spec file.
* Fixed import.
* Removed dependency on os. This is necessary so that the @bitwarden/common/spec lib package can be referenced in tests without node.
* Revert "Removed dependency on os. This is necessary so that the @bitwarden/common/spec lib package can be referenced in tests without node."
This reverts commit 669f6557b6b7d916e8dc
2025-12-12 10:03:31 -05:00
Bernd Schoolmann
51d29f777e
[PM-24353] Drop legacy pin support ( #17328 )
...
* Drop legacy pin support
* Fix cli build
* Fix browser build
* Remove pin key
* Fix comment
* Fix CI / tests
* Add migration to remove key
* Inline export key
* Extract vault export key generation
* Cleanup
* Add migrator
* Fix mv2 build
2025-12-11 13:01:09 +01:00
Oscar Hinton
267e488390
[BEEEP] [PM-28239] Migrate generators to standalone ( #17386 )
...
* Migrate generators to use standalone and control flow
* Resolve feedback
* Add variable for account
* Fix generators
2025-12-11 12:04:15 +01:00
renovate[bot]
7f892cf26a
[deps] Autofill: Update prettier to v3.7.3 ( #17853 )
...
* [deps] Autofill: Update prettier to v3.6.2
* fix: [PM-23425] Fix prettier issues related to dependency updte
Signed-off-by: Ben Brooks <bbrooks@bitwarden.com>
* [deps] Autofill: Update prettier to v3.6.2
* [deps] Autofill: Update prettier to v3.7.3
* [PM-29379] Fix prettier issues found with the updated Prettier 3.7.3
Signed-off-by: Ben Brooks <bbrooks@bitwarden.com>
---------
Signed-off-by: Ben Brooks <bbrooks@bitwarden.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Ben Brooks <bbrooks@bitwarden.com>
2025-12-10 10:57:36 -06:00
Shane Melton
f161a8c454
[PM-27662] Introduce vault item transfer service ( #17876 )
...
* [PM-27662] Add revision date to policy response
* [PM-27662] Introduce vault item transfer service
* [PM-27662] Add feature flag check
* [PM-27662] Add tests
* [PM-27662] Add basic implementation to Web vault
* [PM-27662] Remove redundant for loop
* [PM-27662] Remove unnecessary distinctUntilChanged
* [PM-27662] Avoid subscribing to userMigrationInfo$ if feature flag disabled
* [PM-27662] Make UserMigrationInfo type more strict
* [PM-27662] Typo
* [PM-27662] Fix missing i18n
* [PM-27662] Fix tests
* [PM-27662] Fix tests/types related to policy changes
* [PM-27662] Use getById operator
2025-12-09 15:14:40 -08:00
Oscar Hinton
508131ac1e
[PM-294489 Extract send table to libs/tools ( #17841 )
...
* Extract send table to libs/tools so it can be re-used in desktop
* Remove *ngIf
* Add story
* Move story under sends
* Remove duplicate class
* Move the dates to prevent any changes in storybook
* Revert changes to web component to speed up merge
2025-12-09 19:26:26 +01:00
Mike Amirault
c1c3e432f7
[PM-20080] Add spacing to new cipher/send buttons, unify sizing ( #17806 )
...
* [PM-20080] Add spacing to new cipher/send buttons, unify sizing
* [PM-20080] Use logical css properties and increase spacing
2025-12-09 10:55:30 -05:00
Mike Amirault
2d3b017cc2
[PM-24095] Ensure long Send file names do not overflow parent container ( #17774 )
...
* [PM-24095] Ensure long Send file names do not overflow parent container
* [PM-24095] Add styling to a couple other spots
2025-12-08 13:52:45 -05:00
John Harrington
6f5491f7dc
PM-22143 Refactor TS enums to be const objects (Send specific enums) ( #16399 )
2025-11-26 15:08:59 -07:00
Andreas Coroiu
a66227638e
Update sdk-internal to 374 (fix breaking changes) ( #17325 )
...
* feat: update sdk-internal
* fix: symbol.dispose breaking change
* fix: TextEncoder/Decoder breaking change
* fix: move polyfills to a global setup script
* typo
2025-11-11 15:01:03 +01:00
Maciej Zieniuk
ff12e672e6
[PM-23614] Remove activeUserOrgKeys$ from the key service ( #17045 )
...
* Remove activeUserOrgKeys$ from the key service
* test leftover
* test leftover
2025-11-06 19:27:13 +01:00
