* create libs/assets
* treeshake lib and filter out non-icons from icon story
* update docs
* fix icon colors in browser and desktop
* better name for vault icon
* move illustrations
* Throw error if appA11yTitle is null in icon button
* Add required label input
* Fix icon button errors in CL components and storeis
* fix popover aria-label errors
* remove commented code
* add labels to icon buttons in browser
* add labels to icon buttons in web
* add labels to icon buttons in license
* add labels to icon buttons in send
* add labels to icon buttons in angular
* fix missing pipe error
* fix sso icon button missed in error
* update labels in vault
* add section expand button label
* Adding labels to icon buttons
* Add lint rule to not allow icon buttons without label input
* rename util file
* trigger updates on title change
* update eslint rule name and folder
* add edit collection label to vault headers
* fix web header story label
* add show/hide summary labels
* update summary message
* fix breadcrumbs label message
* fix JSDoc to use correct input
* remove commented code
* use label as aria-label always. Remove init function
* add moreBreadcrumbs translation message to other apps
* add @bitwarden/team-ui-foundation as code owner for component eslint rules
* switch title to const variable
* add jsdoc comment on what the label input is used for
* [PM-22415] Tax ID notifications for Organizations and Providers (#15996)
* [NO LOGIC] Rename BillableEntity to BitwardenSubscriber
This helps us maintain paraody with server where we call this choice type ISubscriber. I chose BitwardenSubscriber to avoid overlap with RxJS
* [NO LOGIC] Move subscriber-billing.client to clients folder
* [NO LOGIC] Move organization warnings under organization folder
* Move getWarnings from OrganizationBillingApiService to new OrganizationBillingClient
I'd like us to move away from stashing so much in libs and utilizing the JsLibServicesModule when it's not necessary to do so. These are invocations used exclusively by the Web Vault and, until that changes, they should be treated as such
* Refactor OrganizationWarningsService
There was a case added to the Inactive Subscription warning for a free trial, but free trials do not represent inactive subscriptions so this was semantically incorrect. This creates another method that pulls the free trial warning and shows a dialog asking the user to subscribe if they're on one.
* Implement Tax ID Warnings throughout Admin Console and Provider Portal
* Fix linting error
* Jimmy's feedback
* remove duplicate messages keys
* revert changes to popover stories
* add back dupe myItems key for now as it was already here
* fix directive type errors
* remove variable left in error from merge conflict
* revert unintentional change to reports layout
* add back reports change
---------
Co-authored-by: Alex Morask <144709477+amorask-bitwarden@users.noreply.github.com>
* trigger Autofill BIT checks on browser build workflow completion and autofill-affecting file changes
* further adjustments
* hardcode bitwarden owner
* remove unneeded origin_repo data in dispatch payload
* add ownership for workflow
* use actions/create-github-app-token
* update CODEOWNERS line with suggestion
* update dockerfile and entrypoint script
* update entrypoint to sh
* add icu-libs to web container to fix startup errors
* remaining change needed for icu-libs
* pin alpine and update apk add commands
* [PM-22783] Add initial feature flag and settings toggle for autotype MVP
* [PM-22783] Undo Cargo.lock changes
* [PM-22783] Disable console.log block
* [PM-22783] Lint fix
* [PM-22783] Small updates
* [PM-22783] Build fix
* [PM-22783] Use combineLatest in updating the desktop autotype service
* [PM-22783] Check if the user is on Windows
* [PM-22783] Undo access selector html change, linting keeps removing this
* [PM-22783] Fix failing test
* [PM-22788] Add initial desktop native autotype crate based on spike ticket investigation
* [PM-22788] cargo fmt
* [PM-22783] Update autotypeEnabled to be stored in service
* [PM-22783] Add todo comments
* [PM-22783] Add SlimConfigService and MainDesktopAutotypeService
* [PM-22783] Small fixes
* [PM-22788] Add get_foreground_window_title() and cleanup
* [PM-22788] Add comment
* [PM-22788] Lint and cross platform build fixes
* [PM-22788] Update windows.rs in autotype_internal
* [PM-22788] Update windows.rs and dummy.rs in autotype_internal
* [PM-22788] cargo fmt
* [PM-22788] Edit napi result types
* [PM-22788] Edit napi result types again
* [PM-22788] Add autofill as a codeowner of the desktop_native/autotype directory
* [PM-22788] Refactor autotype code
* [PM-22788] Move autotype dependency out of windows only due to abstraction change
* [PM-22788] Fix lint errors
* [PM-22788] Updates based on PR comments
* [PM-22788] cargo fmt
* build(firefox): check file size
if building `firefox` or `firefox-mv3`
* check if any file(s) exceeds 4M (megabytes)
- If true, fail and provide basic message.
* style: add clarity
sytle: add error message
* fix: relocate step
ensure final step of source files before validating
* test: add failure condition
* fix: source file target directory
* fix: test for failure condition
* test: remove failure condition
remove lines used for testing
* [deps]: Update dtolnay/rust-toolchain digest to b3b07ba
* fix(build): comply with ci linter in the test workflow
---------
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Addison Beck <github@addisonbeck.com>
* feat(nx): add basic-lib generator for streamlined library creation
This adds a new nx-plugin library with a generator for creating "common" type
Bitwarden libs. It is set up to accept a lib name, description, team, and
directory. It then
- Creates a folder in the directory (default to libs)
- Sets up complete library scaffolding:
- README with team ownership
- Build, lint and test task configuration
- Test infrastructure
- Configures TypeScript path mapping
- Updates CODEOWNERS with team ownership
- Runs npm i
This will make library creation more consistent and reduce manual boilerplate setup.
The plugin design itself was generated by `npx nx g plugin`. This means we
used a plugin to generate a plugin that exports generators. To create our
generator generator, we first needed a generator.
* fix(dirt/card): correct tsconfig path in jest configuration
Fix the relative path to tsconfig.base in the dirt/card library's Jest config.
The path was incorrectly using four parent directory traversals (../../../../)
when only three (../../../) were needed to reach the project root.
* chore(codeowners): clarify some nx ownership stuff
* user key transferred over ipc within desktop app without its prototype.
`UserKey` object was transferred over IPC as regular `Object` type and not recreated as `SymmetricCryptoKey` type, losing its original functions and properties. As a result `inner` method did not exist and user key silently failed during decryption of encrypted client key halves during biometric unlock.
* ipc biometrics serializable user key type
* use encrypt service directly for decryption
* moving electron key service to KM
* log error when unlock via biometrics fails with exception in lock component
* bring back tech debt comment
* lock component logging prefix
Upgrades to Eslint v9. Since this is a major version there were breaking changes, but since we've previously migrated to flat configs in #12806 those were minimal.
* Add sdk-internal to ignored deps
* Grouped GH Action Minor
* Additional groupings added
* Added bitwarden-external back.
* Updated to include patch for linting.
* Removed comments on CODEOWNERS since we no longer group by file
* Tried to standardize group names
* Consolidated handling of TS and zone.js
* jest and rust coverage upload separated as one step
* wrong file paths when downloading coverage
* correct relative coverage paths with sources
* Update .github/workflows/test.yml
Co-authored-by: Matt Bishop <mbishop@bitwarden.com>
---------
Co-authored-by: Matt Bishop <mbishop@bitwarden.com>
Now that the last usages of ModalService is removed from the web portions we can finally remove jQuery and Popper.js. This PR also removes bootstrap js imports since it would drag in jQuery as a peer dependency.
Note: Both dependencies still exists in the lockfile as they are peer dependencies of boostrap.
* Enable Storybook test runner. Run a11y tests also
* no need to return checkA11y function
* add back decorator removed in error
* add test runner to our ownership
* add axe-playwright to our ownership
* Move access-intelligence and reports files from tools to dirt folder for new ownership. Update imports for these files
* Move bit-common/src/reports/risk-insights > dirt
* Update codeowners file for dirt team ownership
* Addressed linting issues by executing `npm run prettier`
---------
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
* Applies patch to enable the autofill extension
* Fixes the zip command
* Updates the signing identity
* Fixes a typo in a github action
* Moves the security command to a previous action
* Updates workflow to work on the PR branch
* Updates the workflow to build from this branch
* Forces native module build
* Adds profile to extension building
* Enables the autofill production config
* List the profiles
* Copies the autofill provisioning profile to Xcode
* Updates the provisioning profile used for the autofill extension
* Alters how the provisioning profile is provided to xcodebuild
* Adds a mas build with the autofill extension
* Print variables
* Removes spaces from the config file
* Updates all provisioning profile installation steps
* Adds a new provisioning profiles location
* Updates the inherited entitlements
* Passes in identity and provisioning profile in after sign call
* Removes mac dev cert from keychain
* Undoes after sign changes
* Adds resign step to workflow
* Fixes the codesign call
* Adds profile argument to electron builder
* Adds resign step to mas builds
* Removes resign step
* Enable debug messages for electron builder signing
* Copies autofill profile instead of desktop
* Add autofill extension to signIgnore list in electron-builder config
* Comment out if in test flight
* Bump version
* Moves the autofill extension building to after pack
* Update version
* Fixes windows and linux builds
* Forces native build
* Removes installation of unrelated certificates
* Comments out synchronous function call
* Update autofill project configuration
* Adds ls command to debug framework
* Moves the extension build script back
* Updates mac developer id provisioning profile
* Updates build location for autofill extension release versions
* Removes unnecessary extension build call
* Updates the version number
* Debug signing
* Removes team identifier from mac entitlements
* Adds new inherited entitlements for mac
* Updates the version number
* Debug version number
* Removes check for creating fastlane secrets
* Readds check for cache before building
* Reverts workflow changes in build-desktop.yml
* Cleans up after-sign and extension build script
* Removes installation of unnecessary mac signing certs
---------
Co-authored-by: Michal Checinski <mchecinski@bitwarden.com>
* Test ARM64 build
* Remove sudo
* Change to public preview runner
* Change cache key for architectures
* Test
* Test
* Test
* remove x86 musl target - troubleshooting build error
* native module troubleshooting
* remove cross-platform for testing
* attempt to resolve cross-platform issue
* support more arm64 build types
* fix missed amd to arm update
* missing dependency during env setup
* lxd troubleshooting
* install lxd with snap instead
* electron-builder debug
* simplified script for testing
* testing
* 22.04 to 20.04
* try ubuntu 24.04 runner
* add dist script
* update build command
* troubleshoot 24.04 compatibility
* remove lxd before merging main
* add comment, bump arm runner down to 22.04
* revert to tar.gz support only for this PR
* testing cli arm builds
* fix build target designation
* adjust runner designation
* runner name typo
* not needed currently
* adjust build.js logic and call in workflow
* address styling feedback and unnecessary rust toolchain call
* simplify build cli os matrix
* revert x86 linux builds to cross-platform command for build.js
---------
Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com>
* Added fork name to tag
* Added logging.
* Added pull_request_target
* Added repository name if on fork.
* Limited characters
* Added sanitization
* Moved to env var for extra security.
* Renamed groups and added consistent periods
* Fixed punctuation
Co-authored-by: Matt Bishop <mbishop@bitwarden.com>
---------
Co-authored-by: Matt Bishop <mbishop@bitwarden.com>
