Commit Graph

3686 Commits

Author SHA1 Message Date
Bernd Schoolmann
a942e21b22
[PM-31119] Run side-effects in sdk unlock service (#20004)
* Run side-effects in sdk unlock service

* Revert feature flag

* Tests and fix cli

* Set user ever had user key and add comment

* Update sdk

* Prettier

* Cleanup

* Only set biometric unlock when biometric enabled

* Clean up tests

* Fix DI

* Cleanup

* Cleanup

* Prettier

* Add test coverage and rename

* Cleanup tests

* Prettier

* Cleanup
2026-04-10 12:08:48 +02:00
Oscar Hinton
7c7c07e651
[PM-31875] Client changes for async sdk client get/set (#20032)
* Client changes for async sdk client get/set

* Bump sdk version
2026-04-09 14:19:27 -07:00
Jared
79c6b51599
[PM-26383] Remove feature flag to enable autoconfirm (#20015)
* Refactor: Remove ConfigService dependency from auto-confirm related components

- Eliminated ConfigService from MainBackground, AutoConfirmPolicy, UserLayoutComponent, WebVaultPromptService, and organizationPolicyGuard.
- Updated logic to directly use organization properties instead of feature flags for auto-confirm functionality.
- Adjusted tests in DefaultAutomaticUserConfirmationService to reflect the removal of feature flag checks.
- Cleaned up unused imports related to ConfigService across various files.

* Refactor: Update date handling in tests and remove unused feature flag checks

- Changed date calculation in WebVaultExtensionPromptService tests to use milliseconds for accuracy.
- Removed unused feature flag checks from WebVaultPromptService tests, simplifying the logic and improving clarity.

* Refactor: Update organizationPolicyGuard to include ConfigService in feature callback

- Modified the organizationPolicyGuard to accept ConfigService as an additional parameter in the feature callback.
- Adjusted the SendComponent route to align with the updated guard implementation.

* Fix: Adjust date calculation in WebVaultExtensionPromptService tests for accuracy

- Updated the test to set the exact date to 30 days prior using setDate method for clarity and to avoid potential issues with DST boundaries.
2026-04-09 15:36:38 -04:00
Nick Krantz
14cd2ad341
[PM-26713] Refactor Attachment Uploads to use XMLHTTPRequest (#19634)
* allow consumers of upload service to input block size

* implement progress bar for cipher attachment uploads

* refactor to use a constant for available block sizes

* rework tests to use AzureUploadBlockSize

* update cipher attachments to ensure 100% is shown for all attachments

* do not allocate real memory in test

* update file uploads to use `XMLHttpRequest` when possible to track progress

* remove unused block size

* update tests + make options optional

* fix unit tests to align with single block approach

* add optional chaining for optional parameter

* remove duplicate import

* catch error from xhr send

* remove redundant try/catch block

* use if/else syntax in attachment template

* add `applyPlatformHeaders` to consolidate header creations between methods.

* add feature flag for file upload changes for progress

* update constructor parameters

* only pass object when feature flag is enabled
2026-04-09 13:23:33 -05:00
Bernd Schoolmann
73aae34267
[PM-33101] Remove master key from uv service (#20076)
* Remove local masterkey hash

* Remove more instances of local master key hash

* remove dependence on service

* Remove master key from uv service

* Fix failing build

* Fix failing build

* Fix tests

* Fix test

* Fix

* Prettier

* Fix merge conflicts

* Fix cli
2026-04-10 01:48:13 +09:00
Dave
f3d22022e6
[PM-33524] Not able to set new Master Password in a previously TDE org (#19810)
* fix(saltForUser) [PM-33524] Update saltForUser$ for transition states

- e.g., TDE offboarding: user will have neither a master password nor
  salt during transition. This is not a failure to make unlock data, it
  is a gap in user state. A default salt should be provided to enable
  the state transition.

* test(saltForUser) [PM-33524] Add test cases for user transition states

* docs(email-to-salt) [PM-33524] Annotate emailToSalt callsites with changes planned for Stage 3.

* docs(master-password-service) [PM-33524] Reintroduce/modify comments after main merge.
2026-04-09 11:02:46 -05:00
Bernd Schoolmann
c9352c01d9
[PM-32864] Remove local masterkey hash (#19277)
* Remove local masterkey hash

* Remove more instances of local master key hash

* remove dependence on service

* Fix failing build

* Fix failing build

* Fix tests

* Fix test

* Fix

* Prettier

* Fix merge conflicts

* Fix cli

* Remove master key from uv service (#19278)

* Revert "Remove master key from uv service (#19278)" (#19697)

This reverts commit 8e53fe6a11.

* Cleanup local master key hash

* Fix test
2026-04-09 10:34:03 -04:00
Bernd Schoolmann
d40b401a0e
Fix emergency access fingerprint (#20072) 2026-04-09 09:25:11 -05:00
Nik Gilmore
b363389786
[PM-34142] BUGFIX: Allow moving a newly created cipher to org (#20025) 2026-04-08 14:54:44 -07:00
Jordan Aasen
fc06f386c4
handle undefined custom field values (#19676) 2026-04-08 13:26:08 -07:00
Jordan Aasen
75a8fc703c
add feature flag (#20019) 2026-04-08 09:27:32 -07:00
Kyle Spearrin
92b04c24fe
new event log for 2fa recovery (#20055) 2026-04-08 11:31:45 -04:00
Jared Snider
65e37bf577
Auth/pm-34506 - Login Strategy Session Cache Expiration Adjustment (#20009)
* PM-34506 - Fix inverted ternary in CACHE_EXPIRATION_KEY deserializer

* PM-34506 - LoginStrategyService tests - fix test name
2026-04-08 11:13:08 -04:00
Bryan Cunningham
3022c75c8e
[CL-1124] updated badge max width (#19864)
* use new badge api for icon

* new default max width for badges

* update js doc comment

* remove margin that was not rendering previously and keep whitespace for spacing
2026-04-08 10:19:17 -04:00
Kyle Spearrin
be9099defb
[PM-15489] 2fa account recovery (#19894)
* claude plan

* PR feedback

* implement 2fa reset to account recovery policy

* tests

* fix locales

* PR feedback

* PR fixes

* PR feedback

* fix CI build errors
2026-04-08 09:10:31 -04:00
Rui Tomé
b10e9482cb
[PM-34177] Fix feature flag key value for Organization Invite Links (#20039)
* [PM-34177] Fix feature flag key value for Organization Invite Links

* Rename feature flag key from OrganizationInviteLinks to GenerateInviteLink for clarity and consistency.
2026-04-07 19:21:24 +01:00
Rui Tomé
5e0a6845ea
[PM-34177] Add feature flag for Organization Invite Links (#20033) 2026-04-07 18:12:21 +01:00
Bernd Schoolmann
f3aff99db5
[PM-33554] Don't log out when trust denied for sdk key rotation (#19961)
* Don't log out when trust denied

* Cleanup
2026-04-08 00:07:13 +09:00
Andreas Coroiu
26cb88bd8c
Bitwarden IPC improvements/refactor (#19935)
* fix: types after SDK change

* feat: update SDK
2026-04-07 17:05:37 +02:00
Vijay Oommen
e0a9496bd6
[PM-34230] Blumira Integration using HEC (#20008) 2026-04-07 09:29:54 -05:00
Bryan Cunningham
b94e2ebf1e
update gray-050 primitive (#20016) 2026-04-07 09:40:19 -04:00
Nik Gilmore
ca0e443592
[PM-34500] Add PM-34500-strict-cipher-decryption feature flag (#19973)
* Add PM-34500-strict-cipher-decryption feature flag
2026-04-06 16:38:58 -07:00
Shane Melton
69f9c7d30d
[PM-25688] Migrate Folder API request model to TS strict (#17269)
* [PM-25688] Migrate folder.request.ts to TS strict

* [PM-25688] Remove ts-strict-ignore from FolderWithIdRequest and update importer service to use FolderRequest instead

* [PM-25688] Add unit test to ensure Folder Id is never set for import request

* [PM-25688] Introduce FolderWithOptionalIdRequest for Import service
2026-04-06 13:24:40 -07:00
Daniel García
767a979314
[PM-32783] Cached electron storage (#19590)
* [PM-32783] Cached electron storage

* Fix strict types

* Fix has bug

* Revert accidental change

* Revert import

* Fix review comments

* Add flag
2026-04-06 16:32:37 +02:00
renovate[bot]
83fbaec0f7
[deps] Architecture: Update Minor and patch linting updates (#17491)
* [deps] Architecture: Update Minor and patch linting updates

* Fix npm conflicts

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Hinton <hinton@users.noreply.github.com>
2026-04-06 08:20:58 -04:00
Jake Fink
adc49c14e6
[PM-34225] generate keypair even if there is no current one on password login (#19896)
* generate keypair even if there is no current one on password login

* fix imports for cli

* fix test

* fix more tests

* remove regen from login strategy

* add test for new regen condition

* change test to reflect what actually happens when public key is missing
2026-04-03 17:28:28 -04:00
Bryan Cunningham
5d530adc2a
remove base directive import (#19978)
* remove base directive import

* remove unused icon button import
2026-04-03 16:36:37 -04:00
Todd Martin
63e0d07a39
chore(docs): Update state readme warning callout. 2026-04-03 16:21:23 -04:00
Dave
52a507bc59
Revert "fix(login): clear validation errors on region change (#19407)" (#19979)
This reverts commit 1a1c5f4df2.
2026-04-03 16:02:28 -04:00
Jordan Aasen
d22a5a82c9
migrate cipher export and sub-models (#19050) 2026-04-03 11:29:02 -07:00
Matteo Bianchi
1a1c5f4df2
fix(login): clear validation errors on region change (#19407) 2026-04-03 14:09:46 -04:00
Vicki League
3751227752
[CL-958] Update avatar component to new styles (#18975) 2026-04-03 10:24:46 -04:00
Bernd Schoolmann
97329383a1
[PM-33173] Use unlock service for password login strategy (#19371)
Some checks failed
Scan / Check PR run (push) Has been cancelled
Testing / Run typechecking (push) Has been cancelled
Testing / Run tests - ${{ matrix.test-group.name }} (map[artifact:jest-coverage-browser junit:junit-browser.xml name:Browser paths:apps/browser bitwarden_license/bit-browser]) (push) Has been cancelled
Testing / Run tests - ${{ matrix.test-group.name }} (map[artifact:jest-coverage-cli junit:junit-cli.xml name:CLI paths:apps/cli bitwarden_license/bit-cli]) (push) Has been cancelled
Testing / Run tests - ${{ matrix.test-group.name }} (map[artifact:jest-coverage-desktop junit:junit-desktop.xml name:Desktop paths:apps/desktop]) (push) Has been cancelled
Testing / Run tests - ${{ matrix.test-group.name }} (map[artifact:jest-coverage-libs junit:junit-libs.xml name:Libs paths:libs bitwarden_license/bit-common]) (push) Has been cancelled
Testing / Run tests - ${{ matrix.test-group.name }} (map[artifact:jest-coverage-web junit:junit-web.xml name:Web paths:apps/web bitwarden_license/bit-web]) (push) Has been cancelled
Testing / Run Rust tests on ${{ matrix.os }} (macos-14) (push) Has been cancelled
Testing / Run Rust tests on ${{ matrix.os }} (ubuntu-22.04) (push) Has been cancelled
Testing / Run Rust tests on ${{ matrix.os }} (windows-2022) (push) Has been cancelled
Testing / Rust Coverage (push) Has been cancelled
Scan / Checkmarx (push) Has been cancelled
Scan / Sonar (push) Has been cancelled
Testing / Upload to Codecov (push) Has been cancelled
Testing / Run tests (push) Has been cancelled
* Use unlock service for login

* Fix build

* Apply feedback to move more logic behind feature flag, and use newer unlock service

* Fix types

* Fix type

* Fix test

* Fix dependencies on cli

* Cleanup

* Fix types

* Fix imports

* Fix eslint

* Prettier

* Address feedback

* Eslint

* Move unlockServiceForPasswordLogin to passwordloginstrategydata

* Eslint
2026-04-03 12:42:17 +09:00
Jared Snider
9093a35de1
Auth/PM-34242 - Device Management Comp - Fix upsert losing isTrusted state and show trust status on pending auth request devices (#19822)
* PM-34242 - Fix upsert losing isTrusted state and show trust status on pending auth request devices

* PM-34242 - Add back br that actually did things
2026-04-02 14:59:37 -04:00
Maciej Zieniuk
27efcdb9a0
[PM-32761] Lock causes log out on TDE account with PIN (#19594)
* switch back to default (Lock) session timeout action when PIN is enabled in master password less accounts.

* always reset to null (default) when only one action is available.

* unnecessary additional keys refresh on token storage migration
2026-04-02 18:48:53 +02:00
Conner Turnbull
037fff6e3a
[PM-31899] Remove m2 flag definition (#19869)
* Remove pm-23341-milestone-2 flagged logic from user-subscription component

Remove the enableDiscountDisplay$ feature flag observable and collapse the
ngIf/else template to always show the discount badge. The badge handles
null/no-discount gracefully.

* Remove PM23341_Milestone_2 flag definition from feature-flag enum
2026-04-02 09:07:31 -05:00
Alex Morask
7d43c72a82
fix(billing): map cart-level discount into discounts array in CartResponse (#19925) 2026-04-01 14:53:52 -05:00
Vicki League
9f68657f59
[CL-1130] Fix storybook a11y and console errors for admin console files (#19917) 2026-04-01 15:00:05 -04:00
Vicki League
f8cd437503
[CL-1105] Ensure hover and focus states match spec (#19638) 2026-04-01 14:39:55 -04:00
Bryan Cunningham
1b88d65f57
Update primitive colors (#19910)
* make sure primitives match figma

* update orange 600

* use lowercase in hex
2026-04-01 13:06:27 -04:00
John Harrington
650962aeb3
bump sendcontrols policy enum value (#19903) 2026-04-01 08:04:08 -07:00
BitToby
e96a0c5309
[PM-32584] fix: warn user about unsaved changes before applying desktop update (#19147)
* fix: warn user about unsaved changes before applying desktop update

* fix: update dialog

* fix: update restart to properly clean up IPC listeners on timeout and warn about unsaved Send forms

* revert: Revert AddEditComponent changes

* fix: solve type error

* fix: warn user about unsaved chagnes

* fix: use FormGroupDirective in DirtyFormService to detect dirty forms after form reassignment

---------

Co-authored-by: bittoby <bittoby@users.noreply.github.com>
2026-04-01 15:33:26 +02:00
John Harrington
3f39b88b4c
[PM-31885] Consolidate all Send policies to a single policy (#19314) 2026-03-31 13:57:01 -07:00
Jordan Aasen
6ee1f7eba5
[PM-32085] - popup width migration (#19408)
* add popup width migration

* fix width names

* add type guard for popupWidthOption
2026-03-31 12:45:09 -07:00
Jackson Engstrom
a26188fd36
[PM-32747] Empty TOTP secrets are being saved to ciphers in web based clients (#19645) 2026-03-31 09:19:33 -07:00
Kyle Denney
13bf3bc3bf
[PM-34223] discounts rounding bug fix (#19811) 2026-03-31 09:59:02 -05:00
Jordan Aasen
9b7452e8e2
set viewPassword in cipher encrypt (#19601) 2026-03-30 16:46:47 -07:00
Nik Gilmore
ab088536bb
[PM-33952] Fix cipher key encryption logic when editing ciphers (#19695) 2026-03-30 15:23:17 -07:00
Vicki League
eff884be5f
[CL-941] Remove router focus flag from client (#19812) 2026-03-30 16:23:02 -04:00
Bryan Cunningham
a847571ded
put focus management creation in effect to account for async menu item changes (#19871) 2026-03-30 14:01:50 -04:00