* [CL-1033] Migrate billing CTAs to new icon API
Migrates buttons and links in billing components (browser, web, libs) to use the new icon API.
* add back broken loading behavior
* add back variable removed in error
---------
Co-authored-by: Vicki League <vleague@bitwarden.com>
* [PM-34210] Move DeviceManagementComponentService provider to JslibServicesModule
The provider was incorrectly registered only in the web app's core.module.ts.
Moving it to JslibServicesModule makes it available to all clients (web, desktop,
CLI) without each needing to register it explicitly. Browser extension keeps its
own ExtensionDeviceManagementComponentService override which takes DI precedence.
* [PM-34210] Add pm-34210-desktop-add-devices feature flag
Adds the PM34210_DesktopAddDevices flag to gate the new Devices menu item
on the desktop Account menu. Defaults to true locally for development.
* [PM-34210] Add desktop device management dialog, service, and translations
- Adds DeviceManagementDialogComponent as a temporary dialog wrapper around
the shared DeviceManagementComponent, matching the ChangePasswordDialog pattern
- Adds DesktopDeviceManagementComponentService with showHeaderInformation=false
since the dialog provides its own header via bit-dialog
- Registers the desktop service in services.module.ts to override the jslib default
- Adds 13 missing device management i18n keys to the desktop en/messages.json
* [PM-34210] Add Devices item to desktop Account menu
Wires the feature-flagged Devices menu item into the desktop Electron Account
menu, positioned after Change Password. When clicked, sends openDevicesDialog
to the renderer which opens DeviceManagementDialogComponent via DialogService.
* Move device-management dialog on desktop to correct auth owned file.
* PM-34210 - Update all TODOs with proper ticket
* PM-34210 - Feature flag - don't check in true. duh
* PM-34210 - clean up incorrect todo
* PM-34210 - Fix desktop auth request answering service not including auth request id so that the device management page can upsert the device w/ the pending auth request.
* PM-34210 - Per PR feedback clean up dialog component of unused stuff.
* PM-34210 - Add new translations for devices screen to desktop
* PM-34506 - Extract LoginStrategyCacheService as single owner of mid-auth cache state
* PM-34506 - Refactor LoginStrategySessionTimeoutService: inject cache service, add MessageListener, expose abstraction
* PM-34506 - Remove cache state and timer logic from LoginStrategyService, delegate to collaborating services
* PM-34506 - Register LoginStrategyCacheService and LoginStrategySessionTimeoutService in all client DI contexts
* PM-34506 - Components read loginSessionTimeout$ from LoginStrategySessionTimeoutServiceAbstraction
* PM-34506 - Add tests for null cache, and non-API error cache-clear paths in LoginStrategyService
* PM-34506 - Add sessionTimeout test for logInNewDeviceVerification with no cached session
* PM-34506 - Rename abstractions to follow Default prefix convention (no Abstraction suffix)
* PM-34506 - Use fake timers in startSessionTimeout test to eliminate flaky date assertion
* PM-34506 - Move registerTaskHandler into DefaultLoginStrategySessionTimeoutService constructor, remove registerSessionTimeoutTask
* PM-34506 - PR feedback - DefaultLoginStrategySessionTimeoutService - make cache clear more resilient.
* PM-34506 - 2FA Auth Comp - fix tests
* PM-34506 - rename login strategy default service files to include default- prefix
Aligns file names with class names and the established codebase convention where
default implementations are prefixed with `default-` (e.g. default-logout.service.ts).
* PM-34506 - TEMP - Default Login Strategy Session Timeout - adjust to 30 seconds to make QA's life easier.
* PM-34506 - DefaultLoginStrategySessionTimeoutService - revert temp change and set LOGIN_SESSION_TIMEOUT_LENGTH back to 5 min
* Bump jest packages
jest is a transient dependency of ts-jest but because angular-devkit/build-angular drags in an older version of jest, we have to add jest 30.3.0 to our dependencies
* Fix some typescript issues due to stricter types on mockImplementation
* Update guide link in snapshots
* Fix jest-environment paths
* Fix typescript linting errors
* Address typescript errors due stricter mockImplementation
---------
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
* [PM-31438] Add save edits dialog to web vault Send page
* Fix Access Intelligence component
* Match design spec, address PR comment
* Fix lint problem
* Lots of lint fixes
* Test fix, add change lost during merge conflict
* Change close methods return type to DialogCloseRef
* Fix Dialog types
* One more type fix
* Address QA findings, fix problems from merge
* A couple of build fixes
* Address AI review comments
* Fix desktop build and lint
* PM-4659 - Refactor DeviceView and add lastActivityDate to DeviceResponse
Adds lastActivityDate (nullable) to DeviceResponse for backwards compatibility
with older server versions. Cleans up DeviceView by removing the response
sub-property escape hatch and declaring all properties directly on the view.
* PM-4659 - Add PM4516_DevicesLastActivityDate feature flag
Adds feature flag and its DefaultFeatureFlagValue entry (defaults to false).
* PM-4659 - Refactor sort utils: rename, restructure, and add sortDevicesWithActivity
Renames resort-devices.helper.ts to utils/device-sort.utils.ts and renames all
functions (resort → sort). Adds sortDevicesWithActivity with the new sort order:
current session → pending requests → most recently active → first login fallback.
Adds full test coverage for all three exported functions.
* PM-4659 - Add recently active display to device management
Adds 'Recently active' column/row to the device management table and item group
views, gated on the PM4516_DevicesLastActivityDate feature flag. Includes a pure
getDeviceLastActivityDateI18nKey utility that maps last activity dates to i18n
keys using calendar-day comparison in the user's local timezone (Math.round for
DST safety). Adds i18n keys for all activity buckets to web and browser locales.
* PM-4659 - DeviceManagement - split into two sections to play around with refactoring the layout.
* PM-4659 - DeviceManagementItemGroupComp - refactor to meet figma better
* PM-4659 - DeviceManagementTable - fix recent activity sort.
* PM-4659 - Device Management Item Group Comp - add missing margin top
* PM-4659 - Add tech debt todo for device sort
* PM-4659 - Guard against future lastActivityDate due to server clock skew
* PM-4659 - DeviceManagment - RecentActivitySort updated to separate func, updated logic per dicussion with product, and wrote tests for the sort.
* PM-4659 - Tiny clean up items
* PM-4659 - Device Sort - recentlyActiveSortFn - update docs
* PM-4659 - Upsert lastActivityDate and recentlyActiveText when pending auth request arrives for known device
* PM-4659 - Reset table sort to default when a pending auth request arrives
* PM-4659 - getDeviceLastActivityDateI18nKey - add more test scenarios
* PM-4659 - Update recentlyActive i18n keys and messages to use explicit rolling-window labels (Past 7/14/30 days)
* PM-4659 - Show isTrusted status for pending auth request devices in showRecentlyActive block
* create the FillAssistTargetingRules feature flag
* create TargetingRulesService
* move TargetingRulesService functionality into DomainSettingsService
* use targeting rules to qualify relevant fields
* add user autofill settings toggle for Fill Assist feature
* add feature flag check to getTargetingRulesForUrl
* add TargetingRulesDataService to update local state from data source
* enable the server to specify an override URI for targeting rules data
* add working data shape
* update data shape
* update logic to match new data shape expectations
* switch from hostname to host to support port inclusions
* add resource cache-buster
* do not update meta timestamp on resource fetch failure
* consolidate email and password update category to account update
* update targeting rules maps consumer logic
* add tests
* add support for host unicode key lookup
* cleanup
* address missing www-prefixed punycode URI case handling
* reduce targeting rules data fetching interval to 6 hours
* add punycode overflow guard and other edges
* cleanup
* add state handling for environment switching
* move constants
* update logic to match provider changes
* codify targeting rules form category requirement
* remove targeting rules totp implementation
* refactor targeting rules storage to key off resource domain
* use constants instead of string literals in cipher to field mapping
* add some basic schema validation
* Move DeleteAccountDialogComponent from web to libs/auth/angular
Export via libs/auth/angular barrel file
Replace imports from web's SharedModule by direct imports
Update import of UserVerificationFormInputComponent
Add eslint ignore to imports from bitwarden/components
* Use new DeleteAccountDialogComponent on desktop
* Delete desktop specific DeleteAccountComponent and UserVerificationComponent
* Move DeleteAccountDialogComponent from libs/auth/angular to libs/angular/auth
---------
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
Co-authored-by: Jared Snider <116684653+JaredSnider-Bitwarden@users.noreply.github.com>
* Run side-effects in sdk unlock service
* Revert feature flag
* Tests and fix cli
* Set user ever had user key and add comment
* Update sdk
* Prettier
* Cleanup
* Only set biometric unlock when biometric enabled
* Clean up tests
* Fix DI
* Cleanup
* Cleanup
* Prettier
* Add test coverage and rename
* Cleanup tests
* Prettier
* Cleanup
* Refactor: Remove ConfigService dependency from auto-confirm related components
- Eliminated ConfigService from MainBackground, AutoConfirmPolicy, UserLayoutComponent, WebVaultPromptService, and organizationPolicyGuard.
- Updated logic to directly use organization properties instead of feature flags for auto-confirm functionality.
- Adjusted tests in DefaultAutomaticUserConfirmationService to reflect the removal of feature flag checks.
- Cleaned up unused imports related to ConfigService across various files.
* Refactor: Update date handling in tests and remove unused feature flag checks
- Changed date calculation in WebVaultExtensionPromptService tests to use milliseconds for accuracy.
- Removed unused feature flag checks from WebVaultPromptService tests, simplifying the logic and improving clarity.
* Refactor: Update organizationPolicyGuard to include ConfigService in feature callback
- Modified the organizationPolicyGuard to accept ConfigService as an additional parameter in the feature callback.
- Adjusted the SendComponent route to align with the updated guard implementation.
* Fix: Adjust date calculation in WebVaultExtensionPromptService tests for accuracy
- Updated the test to set the exact date to 30 days prior using setDate method for clarity and to avoid potential issues with DST boundaries.
* allow consumers of upload service to input block size
* implement progress bar for cipher attachment uploads
* refactor to use a constant for available block sizes
* rework tests to use AzureUploadBlockSize
* update cipher attachments to ensure 100% is shown for all attachments
* do not allocate real memory in test
* update file uploads to use `XMLHttpRequest` when possible to track progress
* remove unused block size
* update tests + make options optional
* fix unit tests to align with single block approach
* add optional chaining for optional parameter
* remove duplicate import
* catch error from xhr send
* remove redundant try/catch block
* use if/else syntax in attachment template
* add `applyPlatformHeaders` to consolidate header creations between methods.
* add feature flag for file upload changes for progress
* update constructor parameters
* only pass object when feature flag is enabled
* [CL-1009] button style updates (#18301)
* add new button styles
* update disabled styles
* updated size stories
* update disabled button story names
* updated button stories
* add more explicit screenshots
* make class list a computed signal
* updated button docs
* allow unstyled button to inherit color
* use unstyled button in callouts until callout updates
* base button directive WIP
* add base button directive
* fix focus and hover styles
* fix lint error
* remove commented code that moved to base directive
* ensure buttonStype defaults correctly
* migrate legacy icon button types
* contrast button wips
* pull in latest and fix disabled with attr
* fix legacy variant
* add back nav contrast button variant
* updated icon button docs
* rename nav contrast variant and fix contrast focus
* fix button sizing
* fix product switcher button classes
* add contrast icon button story
* fix border color
* update to primaryGhost variant
* [CL-1025] icon font refresh (#18727)
* adding new icons
* migrate to new icon names
* updated icon build docs
* resolve conflicts and re-run migration
* add icons deps to uif ownership
* fix incorrect migration
* fix misnamed icon
* create filter icon and fix mapping error
* updated readme and add migration script to package.json
* fix prettier warnings
* remove browser alt from definition list
* add missing icon types
* fix image name migrated in error and update regex to not change these
* ensure icon array is updated automatically
* updated build comment
* remove unnecessary direct execution command
* remove direct run command
* allow legacy icon names to map to new icons
* [CL-1025] Icon font refresh - Temporary migration state with legacy names (#18948)
* Revert icon name migrations, preserve migration tooling
Reverted all icon name changes that were applied by the migration scripts,
while preserving:
- New icon SVG files in libs/assets/src/material-icons/
- Icon font files in libs/angular/src/scss/bwicons/
- Migration scripts in scripts/material-icons/
- NPM scripts and dependencies for icon tooling
This allows running the migration fresh when ready.
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
* Build icon font with bidirectional legacy/new name mapping
Ran icons:build to generate bidirectional icon mappings:
- SCSS now includes 155 icons (both Figma and legacy BWI names)
- TypeScript icon.ts updated with all 155 names
- All legacy names (e.g., bwi-question-circle, bwi-plus) point to new icon assets
- All new names (e.g., bwi-help, bwi-add) also available
- Codebase can continue using legacy names with new icon designs
This enables the temporary migration state where code uses existing
legacy icon names but displays the new refreshed icon assets.
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
* Fix: revert bwi-filter back to bwi-grid across codebase
bwi-grid is the correct new icon name and should not be reverted.
The changes from bwi-filter to bwi-grid were manual corrections,
not part of the automated migration.
Updated 16 files to restore bwi-grid icon references.
Addresses feedback from Bryan Cunningham on PR #18948
---------
Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
* remove duplicate key and add back dep ownership change
* fix formatting errors
---------
Co-authored-by: Will Martin <contact@willmartian.com>
Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
* fix button variant
* [CL-1040] updated palette colors (#19401)
* [CL-973] chip component (#18798)
* wip
* WIP
* create chip filter component
* trying to get truncation to work
* fix truncation
* create chip-action component
* fix type errors
* add chip component
* add shared story args
* have chips take label input
* fix test template and imports
* fixing arg types and disabled states
* simplify disabled logic
* fix dimssis button alignment
* update menu focus color
* updated chip docs
* update chip-select usage to chip-filter
* fix full width icon layout
* remove commited code
* export chip component
* remove commented code
* expose full width
* chip component should not go full width
* use bit-icon in filter template
* remove commented code
* updated chip docs
* remove extra truncate class
* fix dupe input definitions
* move import to correct line
* read base chip values directly
* remove standlaone as it's the default
* forward size correctly
* create full width arg type
* let type be infered
* updated jsdoc comments
* use more modern angular syntax
* rename components to use kebab case
* remove redundant docs
* remove inaccurate link docs
* remove enum like types
* remove dead code
* remove unused spec
* remove host bindings
* restructure chips folders
* add max width class
* remove full width docs
* add internal comment
* bind to missing controls
* fixing docs
* replace disabled verbiage with inactive
* remove unnecessary comment
* default to primary
* do not allow end icon in action chip
* take chip action screenshots in both themes
* use selected input for base directive
* fix width error
* coerce to boolean
* fixed end icon reference
* fix code reference to endIcon
* fixing chip filter specs
* fix missing input transform
* fix docs
* fix input and add truncate
* ensure chip content truncates
* updated slot naming
* updated example to use new flow control
* fix typing for option.icon
* fix failing test, fix filter type, and support colored icons in filter options
* fix failing test
* doc updates
* change dismissed event name
* remove standalone
* fix selector
* fix docs
* remove unused fvw data property and fix docs links
* use base as host directive in chip
* fix spec button selectors
* fix duplicate class binding
* fix incorrect variant resolution
* handle undefined size
* fix signal type
* remove duplicate input
* fix failing spec
* updated styles for trailing icon spacing and font size
* padding tweaks for visual design
* make variant a writable model
* use logical text align
* update slot names
* remove dismissible input
* add back missing import
* remove ability to set chip filter to small size
* create size arg type
---------
Co-authored-by: Vicki League <vleague@bitwarden.com>
* [CL-987] Update Nav Group and Nav Item components (#18965)
* updated side nav `nav-group` and `nav-item` components
* - added focus states
- set cursor pointer for nav-item
- updated arrow orientations
* - updated `navItemIndentationPadding`
- reverted `[treeDepth]` for `nav-group`
- removed placeholder arrow
* - removed text style from starting slot container
- fixed routes in story
* created shared container classes var
* fixes from rebase, override `border-radius` for collapse arrow button
* updated `tw-theme`: reverted `--color-bg-hover` and added `--color-bg-sidenav-hover`
* removed end slot `div` styles from rebase, updated `buttonType` in `nav-group` story
* added dark mode `--color-bg-sidenav-hover`
* added `xsmall` size variant to 'Icon Button'
* - updated navs to use 'xsmall' button
- fixed container padding
- removed custom arrow button styles
* fixed type error
* fixed focus-visible state by adding `tw-outline-none` to `nav-item`
* fixed type error
* placed arrow button directly in start slot
* defined `containerClasses` in template
* renamed 'item-active-hover' to 'active-item-hover' for consistency
* missed renaming from `item-active-hover` to `active-item-hover`
* fixed 'hover' and 'active' colors, added colors for arrow hover states
* - separated buttons sizes for 'Button' and 'Icon Button' from `BaseButtonDirective` into respective components
- moved `border-radius` style from Directive into own components
* fixed/simplified focus colors, added sidenav specific focus colors
* updated 'arrow' icon size for nav group, updated 'xsmall' font size
* trigger Claude review
* removed `tw-text-2xl` in nav-group for arrow button
* removed unused `NgClass` import
* more cleanup, removed unused `Ng` imports
* converted `_isActive` to signal and `showActiveStyles` to computed
* removed instances of `variant="tree"`
* renamed color variables from `admin-sidenav` to `sidenav-secondary`
---------
Co-authored-by: Will Martin <contact@willmartian.com>
* fix lint
* [CL-1096] Fix icon button width shrinking in flex containers (#19529)
Add tw-shrink-0 to prevent icon buttons from shrinking below their
fixed size when placed inside flex containers.
* [CL-1101] Fix chip dismiss button hover style and add interaction state stories (#19530)
Use the correct bg-bg-hover token for dismiss button hover background, matching
the Figma spec. The previous hover-contrast token was invisible on light backgrounds.
Add InteractionStates story showing Default, Hover, Focus, and Inactive states
for both large and small sizes.
* [CL-1098] Fix danger icon button color in form field suffix (#19532)
* [CL] Fix danger icon button color in form field suffix
Don't apply tw-text-muted to icon button suffixes — icon buttons manage
their own text color via buttonType, so the muted class was overriding
danger/primary colors (e.g. blue icon on red background in Cipher Form).
* [CL] Fix danger icon button color in form field suffix
Don't apply tw-text-muted to icon button suffixes — icon buttons manage
their own text color via buttonType, so the muted class was overriding
danger/primary colors (e.g. blue icon on red background in Cipher Form).
Also adds a DangerButtonInputGroup story to capture this case.
* [CL-1094] Update icon button default variant to primaryGhost (#19534)
* [CL-1094] Update icon button default variant to primaryGhost
Change buttonType from input to model in BaseButtonDirective, and set
the default to primaryGhost in the icon button constructor.
* [CL-1094] Fix icon button default variant using own input + effect
Using model.set() in the constructor is overridden by Angular's input
initialization lifecycle. Instead, own buttonType as an input directly
on BitIconButtonComponent with primaryGhost as the default, and sync to
the base directive via effect.
* [CL-959] update badge component styles (#19026)
* badge wip
* dynamic truncated badge tooltip
* support legacy variants for now
* add deprecation types and remove hover styles
* updated story docs
* add default icons for badges
* fix incorrect color mapping
* add ability to hide start icon
* take snapshot in both themes
* add icon size styles
* remove tooltip code
* update at risk password to use actual buttons
* more specific badge truncation docs
* remove badge module from imports
* use chip action for link
* fix missing import
* use chip in multi-select inputs
* update org badge to use primary chip
* update premium badge to accent primary action chip
* use chip action for vault item fill
* remove unnecessary icon in badge
* update obsolete notification variant
* replace usage of bitBadge on button in stories
* remove explicit input to hide startIcon
* use berry instead of badge
* fix type error
* fixing imports and badge usage
* use logical text align
* remove dead code and update jsdoc comment
* add back ability to not truncate
* remove default icon for accent-primary
* add missing translation keys to multi select story
* allow null as default icon type
* add element selector and update stories to use it
* conditionally apply truncate class
* conditionally apply title text
* migrate badge to berry
* use correct input for content
* use berry in toggle group stories
* remove unused template reference
* remove unused import of badge
* remove unused custom color code
* remove unused service injection
* [CL-1102] Fix help icon size in bit-label (#19533)
* [CL-1102] Fix help icon size in bit-label
Target bwi icons inside bit-label with [&_.bwi]:tw-text-xl to restore
correct icon sizing after recent icon style changes.
* [CL-1102] Fix text alignment regression in bit-label
Add tw-leading-none to bwi icons to prevent the line-height from
tw-text-xl from disrupting baseline alignment.
* remove bwi-sm from label icon
---------
Co-authored-by: Bryan Cunningham <bryan.cunningham@me.com>
* [CL-964] Update Callout Component (#19424)
* updated callout component
* renamed consumer bit-callout `type` from 'default' to 'subtle'
* updated callout 'end' slot
* migrated spotlight to callout, deleted spotlight
* - updated `title` comment
- updated stories and mdx
* removed `useAlertRole`
* added `CommonModule` import and updated `buttonType` in stories
* updated 'Accessibility' guidelines
* updated 'close' button
* - updated stories for clearer code
- set `(onDismiss)` only for WithCloseButton story
* added boolean switch for `persistent` to story
* fixed tests
* prettier fix
* - updated `bit-callout` instances of `buttonType="unstyled"` to use appropriate `buttonType`
- updated story for correct usage of button styles
* fixed `type` in `vault-list`
* updated to use `bit-icon`
* - fixed vertical centering of icon and text
- updated to 'OnPush' change detection
* fixed error: added 'close' to `mockLayoutI18n`
* updated `bit-callout` jsdoc comment and mdx
* fixed `persistent` callout in `admin-settings`
* removed "interrupt" language
* reverted fix for `bit-callout` `persistent`
* fixed type error
* added `close` translation to stories utilizing `bit-callout`
* converted to JSDoc comments
* updated 'close' button to check if `dismiss` output is bound
* fix: removed `readonly` from `isDismissible`
* converted `isDismissble` to signal
* added translation to `phishing-warning' story
* added bottom margin back in to callout component
* fixed type error, fixed `icon` values
* revert subscription-card callout icon to default if not defined
* fix: update 'bit-callout' type to 'subtle'
* updated colors in `tw-theme`
* added conditional check to compute vertical alignment class
* updated more colors, slight restructure to match design
* fixed vertical alignment with 'close button', avoid long text crowding/overflowing
* remove default icons on non-semantic variants (#19614)
* remove default icons on non-semantic variants
* add back info icon to info variant
* remove info icon again
* [CL-1095] add expanded state for disclosure button (#19637)
* add brand stronger colors
* add aria-expanded styling for primary ghost button
* make all variants aria-expanded style match hover styles
* update orage-600 color value to fix contrast
* minor spacing update to account for expanded button style
* do not show expanded state on sidenav buttons
* no expanded style on toggle width button
* remove extra letter spacing and update story copy (#19668)
* [CL-1123] fix ghost button inactive styles (#19669)
* fix ghost button inactive styles
* remove type declaration
* [CL-1119] toggle berry update (#19609)
* update toggle groups to use berry
* set berry variant based on selected state
* fix failing spec
* add spec to test berry variant set correctly
* fix import errors caused by bad merge conflict resolution
* remove unnecessary variant delaration
* update kitchen sink stories to use berry
* [CL-1122] BUG FIX: Migrated Icon Buttons with button type 'danger' to 'dangerGhost' (#19677)
* migrated `bitIconButton` with 'danger' `buttonType` to 'dangerGhost'
* reverted icon-button story
* fix button variant from merge
* [CL-1117] BUG FIX: Side nav collapse arrow is placed too far left (#19623)
* - updated spacing for side-nav collapse arrow button
- updated collapsed nav-item button spacing and dimensions
- moved individual nav-item wrapper padding into side-nav component
- added button to 'WithLongText' nav-item story
* added sidenav specific hover style to toggle collapse button
* - set horizontal padding back to 'nav-item'
- updated 'bit-divider' color to 'bg-border-brand'
* updated hover styles for interactive trailing elements
* added '4px' more end padding to trailing buttons
* updated 'bit-divider' colors for secondary and dark theme
* moved button hover styles into 'side-nav' button variant
* updated sidenav-divider color for dark theme
* removed `tw-w-10` on nav-item collapsed
* updated inline padding to `12px` for both collapse and expanded states
* [CL-1117] cleaned up, renamed, and organized sidenav color variables (#19665)
* - unified 'strong' styles and `showActiveStyles` into `[style]`
- updated 'side-nav' button variant's `aria-expanded` and `focus-visible` styles
* - inherit bg and fg from parent `sidenav`
- allow trailing buttons set own fg
* updated nav group story for trailing elements
* updated nav-logo 'focus' to nav focus style
* let toggle width arrow inherit 'aria-expanded' style from 'side-nav' buttontype
* removed danger button variants from nav group story
---------
Co-authored-by: Bryan Cunningham <bcunningham@bitwarden.com>
Co-authored-by: Vicki League <vleague@bitwarden.com>
Co-authored-by: Leslie Xiong <lxiong@livefront.com>
* PM-33353 - LoginStrategyService tests - add test to capture the bad behavior.
* PM-33353 - Extract Password Prelogin API logic to own service out of API service.
* PM-33353 - Rename prelogin request / response models to have password prefix for clarity
* PM-33353 - Build PasswordPrelogin domain service and domain model + tests
* PM-33353 - PasswordPrelogin - add barrel file
* PM-33353 - PasswordPreloginData - fromResponse - add validateKdfConfigForPrelogin so domain model is always valid.
* PM-33353 - Register PasswordPreloginApiService and PasswordPreloginService.
* PM-33353 - LoginComponent - wire up PasswordPreloginService
* PM-33353 - LoginStrategy updates - (1) Remove all password prelogin code from top level strategy service (2) Inject new PasswordPreloginService for use in the PasswordLoginStrategy.
* PM-33353 - Update Password Prelogin tests to use defaults
* PM-33353 - PasswordPreloginData model tests - update to use mins
* PM-33353 - Fix login strategy tests + get TS strict warnings fixed
* PM-33353 - Remove login component tests
* PM-33353 - Fix CLI
* PM-33353 - Password Login Strategy - add additional tests + fix misc issues + re-organized tests.
* PM-33353 - LoginComp - local AI review feedback - clean up prefetchPasswordPreloginData
* PM-33353 - Remove PM23801_PrefetchPasswordPrelogin feature flag
* PM-33353 - DefaultPasswordPreloginService - getPreloginData$ - fix shareReplay error bug state.
* PM-33353 - login-strategy.state.spec.ts - Remove incorrect todo and fix ts strict issues
* PM-33353 - Per PR feedback, Update PasswordPreloginService to add a cache clear mechanism to just tightly bound the service's memory to the lifetime of the key making process
* PM-32413 - Add hasPassword guard for future use.
* PM-32413 - Web - PasswordSettingsComp - add TODO for using new guard.
* PM-32413 - ChangePasswordComp - Add output emitter for when a password has been changed successfully.
* PM-32413 - Add feature flag
* PM-32413 - Desktop - implement change password component in a dialog.
* PM-32413 - Add change password to extension
* PM-32413 - Fix translations
* PM-32413 - Desktop - menu - add clean up todo
* PM-32413 - Feature flags - reset hardcoded true values
* PM-32413 - Add clean up todos
* PM-32413 - Extension Routing module - add hasPassword guard
* PM-32413 - add todo
* PM-32413 - Desktop / Extension - use InputPasswordFlow.ChangePassword instead of InputPasswordFlow.ChangePasswordWithOptionalUserKeyRotation
* PM-32413 - Finish last AI review items
* PM-32413 - Per PR feedback, update change-password-dialog title translation to one that we don't plan on removing.
* PM-32413 - Per PR feedback, update menu item id
* PM-32413 - Per local claud review - modify has-password to use UrlTree pattern.
* PM-32413 - ChangePassword comp - add this.passwordChanged.emit(); in newly flagged code branch
Updates the `ChangePasswordService` (`changePassword()` and `changePasswordForAccountRecovery()`) to use the new KM data types :
- `MasterPasswordAuthenticationData`
- `MasterPasswordUnlockData`
This allows us to move away from the deprecated `makeMasterKey()` method (which takes email as salt) as we seek to eventually separate the email from the salt.
Also moves current password validation into the default and web change password services.
Behind feature flag: `pm-27086-update-authentication-apis-for-input-password`
* adds premium-upsell service
* adds and updates tests
* changes name and type in test file
* fixes strict ts
* Update libs/angular/src/vault/services/premium-upsell.service.spec.ts
fix import
Co-authored-by: Jordan Aasen <166539328+jaasen-livefront@users.noreply.github.com>
* change initial value and fix import order
---------
Co-authored-by: Jordan Aasen <166539328+jaasen-livefront@users.noreply.github.com>
* fix(register): [PM-27085] Account Register Uses New Data Types - Initial changes.
* test(register): [PM-27085] Account Register Uses New Data Types - Fixed tests.
* test(register): [PM-27085] Account Register Uses New Data Types - Updated tests.
* feat(register): [PM-27085] Account Register Uses New Data Types - Added feature flag.
* fix(register): [PM-27085] Account Register Uses New Data Types - Removed unnecessary part of the payload.
* fix(register): [PM-27085] Account Register Uses New Data Types - Changed the feature flag to be gated with the other password input changes.
* fix(register): [PM-27085] Account Register Uses New Data Types - Added protection for feature flagged state.
* fix(register): [PM-27085] Account Register Uses New Data Types - Removed unnecessary comment.
* fix(register): [PM-27085] Account Register Uses New Data Types - Addressed feedback.
* fix(register): [PM-27085] Account Register Uses New Data Types - Fixed tests and added comment.
* fix(register): [PM-27085] Account Register Uses New Data Types - Fixed another test.
* fix(register): [PM-27085] Account Register Uses New Data Types - And last test fix.
* fix(register): [PM-27085] Account Register Uses New Data Types - Removed unneeded code.
* fix(register): [PM-27085] Account Register Uses New Data Types - Updated comments and fixed code from feedback.
* fix(register): [PM-27085] Account Register Uses New Data Types - Updated comments again with small styling fix.
* fix(register): [PM-27085] Account Register Uses New Data Types - Switched to snapshot testing and explicit checks for unlock and authentication data for feature flag on. Also addressed pr comments.
* test(register): [PM-27085] Account Register Uses New Data Types - Made explicit checks for critical pieces of data in tests.
* fix(feature-flag): [PM-27085] Account Register Uses New Data Types - Added in feedback from comments. Default registration tests have snapshots now and web registration has more dry code.
* Make TwoFactorIconComponent standalone
* Angular updates to TwoFactorIconComponent
- Migrate TwoFactorProviderType from enum to const (ADR25)
- Migrate Inputs to Signals
- Make provider a required input
- Use new Control Flow syntax
- Use OnPush change detection
- Memoize function for legacy providers (providers with png image)
- Add documentation
- Remove @ts-strict-ignore
- Fix type in TwoFactorSetupDuoComponent as it would default to number because of the migration of TwoFactorProviderType (enum to const). Now it can be overridden with any value of TwoFactorProviderType
* Add type guard for TwoFactorProviderType and fix CLI
* PM-32915 - Update TwoFactorProviderType to mark U2f as deprecated in favor of WebAuthn
* PM-32915 - TwoFactorIconComp - refactor to eliminate legacy providers and just use new, already available duo and yubikey SVG icons.
* PM-32915 - Add TODOs for cleaning up mfaType usages.
* PM-32915 - Remove unncessary ng-container
---------
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
Co-authored-by: Jared Snider <jsnider@bitwarden.com>
Co-authored-by: Jared Snider <116684653+JaredSnider-Bitwarden@users.noreply.github.com>
With the replacement of the vault cipher view and add-edit views on the desktop client, we no longer require the ColorPasswordCountPipe or the ColorPasswordPipe, as these are now handled by the ColorPasswordComponent from the Bitwarden component library
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
Updates the `setInitialPasswordTdeOffboarding` path to use new KM data types:
- `MasterPasswordAuthenticationData`
- `MasterPasswordUnlockData`
This allows us to move away from the deprecated `makeMasterKey()` method (which takes email as salt) as we seek to eventually separate the email from the salt.
Behind feature flag: `pm-27086-update-authentication-apis-for-input-password`
