* add updated background and background2x images, remove old image
* update build instructions with background file location
* test bumping electron-builder version to resolve bug
* drop electron-builder version to earliest with the background fix, newer version had breakage
* attempt to resolve build errors due to dep changes including prebuild files to be bundled with other platform types
* fix macos universal build conflicts due electron builder bump
* simplify approach, push to ci for further testing after local tests hit some arch friction
* pulling in @abergs change from PR#18474 to fix the same issue
* add identifier name, add desktop_napi version to see if that resolve it not being found during ci build
* address changes in getTreeFromWorkspaces in electron-builder
* bump electron-builder version further up to resolve dep getTreeFromWorkspaces resolution issue
* update pack script to work around bug during intermediate signing process for mac MAS app
* updated background resources, arrow moved up slightly. assets provided by design team
* electron-builder 26.8.2's collector only bundles modules found in _dependencies (from npm list). Workspace members must be explicitly declared as dependencies to appear there — the workspaces array alone is not sufficient. Without this, desktop-napi is silently missing from the asar on all platforms.
* filter by platform and arch
* update before pack script
* revert before-pack change, update x64 arch files in EB json
* fix linting fail due to missing dep, fix matching logic
* [CL-1009] button style updates (#18301)
* add new button styles
* update disabled styles
* updated size stories
* update disabled button story names
* updated button stories
* add more explicit screenshots
* make class list a computed signal
* updated button docs
* allow unstyled button to inherit color
* use unstyled button in callouts until callout updates
* base button directive WIP
* add base button directive
* fix focus and hover styles
* fix lint error
* remove commented code that moved to base directive
* ensure buttonStype defaults correctly
* migrate legacy icon button types
* contrast button wips
* pull in latest and fix disabled with attr
* fix legacy variant
* add back nav contrast button variant
* updated icon button docs
* rename nav contrast variant and fix contrast focus
* fix button sizing
* fix product switcher button classes
* add contrast icon button story
* fix border color
* update to primaryGhost variant
* [CL-1025] icon font refresh (#18727)
* adding new icons
* migrate to new icon names
* updated icon build docs
* resolve conflicts and re-run migration
* add icons deps to uif ownership
* fix incorrect migration
* fix misnamed icon
* create filter icon and fix mapping error
* updated readme and add migration script to package.json
* fix prettier warnings
* remove browser alt from definition list
* add missing icon types
* fix image name migrated in error and update regex to not change these
* ensure icon array is updated automatically
* updated build comment
* remove unnecessary direct execution command
* remove direct run command
* allow legacy icon names to map to new icons
* [CL-1025] Icon font refresh - Temporary migration state with legacy names (#18948)
* Revert icon name migrations, preserve migration tooling
Reverted all icon name changes that were applied by the migration scripts,
while preserving:
- New icon SVG files in libs/assets/src/material-icons/
- Icon font files in libs/angular/src/scss/bwicons/
- Migration scripts in scripts/material-icons/
- NPM scripts and dependencies for icon tooling
This allows running the migration fresh when ready.
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
* Build icon font with bidirectional legacy/new name mapping
Ran icons:build to generate bidirectional icon mappings:
- SCSS now includes 155 icons (both Figma and legacy BWI names)
- TypeScript icon.ts updated with all 155 names
- All legacy names (e.g., bwi-question-circle, bwi-plus) point to new icon assets
- All new names (e.g., bwi-help, bwi-add) also available
- Codebase can continue using legacy names with new icon designs
This enables the temporary migration state where code uses existing
legacy icon names but displays the new refreshed icon assets.
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
* Fix: revert bwi-filter back to bwi-grid across codebase
bwi-grid is the correct new icon name and should not be reverted.
The changes from bwi-filter to bwi-grid were manual corrections,
not part of the automated migration.
Updated 16 files to restore bwi-grid icon references.
Addresses feedback from Bryan Cunningham on PR #18948
---------
Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
* remove duplicate key and add back dep ownership change
* fix formatting errors
---------
Co-authored-by: Will Martin <contact@willmartian.com>
Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
* fix button variant
* [CL-1040] updated palette colors (#19401)
* [CL-973] chip component (#18798)
* wip
* WIP
* create chip filter component
* trying to get truncation to work
* fix truncation
* create chip-action component
* fix type errors
* add chip component
* add shared story args
* have chips take label input
* fix test template and imports
* fixing arg types and disabled states
* simplify disabled logic
* fix dimssis button alignment
* update menu focus color
* updated chip docs
* update chip-select usage to chip-filter
* fix full width icon layout
* remove commited code
* export chip component
* remove commented code
* expose full width
* chip component should not go full width
* use bit-icon in filter template
* remove commented code
* updated chip docs
* remove extra truncate class
* fix dupe input definitions
* move import to correct line
* read base chip values directly
* remove standlaone as it's the default
* forward size correctly
* create full width arg type
* let type be infered
* updated jsdoc comments
* use more modern angular syntax
* rename components to use kebab case
* remove redundant docs
* remove inaccurate link docs
* remove enum like types
* remove dead code
* remove unused spec
* remove host bindings
* restructure chips folders
* add max width class
* remove full width docs
* add internal comment
* bind to missing controls
* fixing docs
* replace disabled verbiage with inactive
* remove unnecessary comment
* default to primary
* do not allow end icon in action chip
* take chip action screenshots in both themes
* use selected input for base directive
* fix width error
* coerce to boolean
* fixed end icon reference
* fix code reference to endIcon
* fixing chip filter specs
* fix missing input transform
* fix docs
* fix input and add truncate
* ensure chip content truncates
* updated slot naming
* updated example to use new flow control
* fix typing for option.icon
* fix failing test, fix filter type, and support colored icons in filter options
* fix failing test
* doc updates
* change dismissed event name
* remove standalone
* fix selector
* fix docs
* remove unused fvw data property and fix docs links
* use base as host directive in chip
* fix spec button selectors
* fix duplicate class binding
* fix incorrect variant resolution
* handle undefined size
* fix signal type
* remove duplicate input
* fix failing spec
* updated styles for trailing icon spacing and font size
* padding tweaks for visual design
* make variant a writable model
* use logical text align
* update slot names
* remove dismissible input
* add back missing import
* remove ability to set chip filter to small size
* create size arg type
---------
Co-authored-by: Vicki League <vleague@bitwarden.com>
* [CL-987] Update Nav Group and Nav Item components (#18965)
* updated side nav `nav-group` and `nav-item` components
* - added focus states
- set cursor pointer for nav-item
- updated arrow orientations
* - updated `navItemIndentationPadding`
- reverted `[treeDepth]` for `nav-group`
- removed placeholder arrow
* - removed text style from starting slot container
- fixed routes in story
* created shared container classes var
* fixes from rebase, override `border-radius` for collapse arrow button
* updated `tw-theme`: reverted `--color-bg-hover` and added `--color-bg-sidenav-hover`
* removed end slot `div` styles from rebase, updated `buttonType` in `nav-group` story
* added dark mode `--color-bg-sidenav-hover`
* added `xsmall` size variant to 'Icon Button'
* - updated navs to use 'xsmall' button
- fixed container padding
- removed custom arrow button styles
* fixed type error
* fixed focus-visible state by adding `tw-outline-none` to `nav-item`
* fixed type error
* placed arrow button directly in start slot
* defined `containerClasses` in template
* renamed 'item-active-hover' to 'active-item-hover' for consistency
* missed renaming from `item-active-hover` to `active-item-hover`
* fixed 'hover' and 'active' colors, added colors for arrow hover states
* - separated buttons sizes for 'Button' and 'Icon Button' from `BaseButtonDirective` into respective components
- moved `border-radius` style from Directive into own components
* fixed/simplified focus colors, added sidenav specific focus colors
* updated 'arrow' icon size for nav group, updated 'xsmall' font size
* trigger Claude review
* removed `tw-text-2xl` in nav-group for arrow button
* removed unused `NgClass` import
* more cleanup, removed unused `Ng` imports
* converted `_isActive` to signal and `showActiveStyles` to computed
* removed instances of `variant="tree"`
* renamed color variables from `admin-sidenav` to `sidenav-secondary`
---------
Co-authored-by: Will Martin <contact@willmartian.com>
* fix lint
* [CL-1096] Fix icon button width shrinking in flex containers (#19529)
Add tw-shrink-0 to prevent icon buttons from shrinking below their
fixed size when placed inside flex containers.
* [CL-1101] Fix chip dismiss button hover style and add interaction state stories (#19530)
Use the correct bg-bg-hover token for dismiss button hover background, matching
the Figma spec. The previous hover-contrast token was invisible on light backgrounds.
Add InteractionStates story showing Default, Hover, Focus, and Inactive states
for both large and small sizes.
* [CL-1098] Fix danger icon button color in form field suffix (#19532)
* [CL] Fix danger icon button color in form field suffix
Don't apply tw-text-muted to icon button suffixes — icon buttons manage
their own text color via buttonType, so the muted class was overriding
danger/primary colors (e.g. blue icon on red background in Cipher Form).
* [CL] Fix danger icon button color in form field suffix
Don't apply tw-text-muted to icon button suffixes — icon buttons manage
their own text color via buttonType, so the muted class was overriding
danger/primary colors (e.g. blue icon on red background in Cipher Form).
Also adds a DangerButtonInputGroup story to capture this case.
* [CL-1094] Update icon button default variant to primaryGhost (#19534)
* [CL-1094] Update icon button default variant to primaryGhost
Change buttonType from input to model in BaseButtonDirective, and set
the default to primaryGhost in the icon button constructor.
* [CL-1094] Fix icon button default variant using own input + effect
Using model.set() in the constructor is overridden by Angular's input
initialization lifecycle. Instead, own buttonType as an input directly
on BitIconButtonComponent with primaryGhost as the default, and sync to
the base directive via effect.
* [CL-959] update badge component styles (#19026)
* badge wip
* dynamic truncated badge tooltip
* support legacy variants for now
* add deprecation types and remove hover styles
* updated story docs
* add default icons for badges
* fix incorrect color mapping
* add ability to hide start icon
* take snapshot in both themes
* add icon size styles
* remove tooltip code
* update at risk password to use actual buttons
* more specific badge truncation docs
* remove badge module from imports
* use chip action for link
* fix missing import
* use chip in multi-select inputs
* update org badge to use primary chip
* update premium badge to accent primary action chip
* use chip action for vault item fill
* remove unnecessary icon in badge
* update obsolete notification variant
* replace usage of bitBadge on button in stories
* remove explicit input to hide startIcon
* use berry instead of badge
* fix type error
* fixing imports and badge usage
* use logical text align
* remove dead code and update jsdoc comment
* add back ability to not truncate
* remove default icon for accent-primary
* add missing translation keys to multi select story
* allow null as default icon type
* add element selector and update stories to use it
* conditionally apply truncate class
* conditionally apply title text
* migrate badge to berry
* use correct input for content
* use berry in toggle group stories
* remove unused template reference
* remove unused import of badge
* remove unused custom color code
* remove unused service injection
* [CL-1102] Fix help icon size in bit-label (#19533)
* [CL-1102] Fix help icon size in bit-label
Target bwi icons inside bit-label with [&_.bwi]:tw-text-xl to restore
correct icon sizing after recent icon style changes.
* [CL-1102] Fix text alignment regression in bit-label
Add tw-leading-none to bwi icons to prevent the line-height from
tw-text-xl from disrupting baseline alignment.
* remove bwi-sm from label icon
---------
Co-authored-by: Bryan Cunningham <bryan.cunningham@me.com>
* [CL-964] Update Callout Component (#19424)
* updated callout component
* renamed consumer bit-callout `type` from 'default' to 'subtle'
* updated callout 'end' slot
* migrated spotlight to callout, deleted spotlight
* - updated `title` comment
- updated stories and mdx
* removed `useAlertRole`
* added `CommonModule` import and updated `buttonType` in stories
* updated 'Accessibility' guidelines
* updated 'close' button
* - updated stories for clearer code
- set `(onDismiss)` only for WithCloseButton story
* added boolean switch for `persistent` to story
* fixed tests
* prettier fix
* - updated `bit-callout` instances of `buttonType="unstyled"` to use appropriate `buttonType`
- updated story for correct usage of button styles
* fixed `type` in `vault-list`
* updated to use `bit-icon`
* - fixed vertical centering of icon and text
- updated to 'OnPush' change detection
* fixed error: added 'close' to `mockLayoutI18n`
* updated `bit-callout` jsdoc comment and mdx
* fixed `persistent` callout in `admin-settings`
* removed "interrupt" language
* reverted fix for `bit-callout` `persistent`
* fixed type error
* added `close` translation to stories utilizing `bit-callout`
* converted to JSDoc comments
* updated 'close' button to check if `dismiss` output is bound
* fix: removed `readonly` from `isDismissible`
* converted `isDismissble` to signal
* added translation to `phishing-warning' story
* added bottom margin back in to callout component
* fixed type error, fixed `icon` values
* revert subscription-card callout icon to default if not defined
* fix: update 'bit-callout' type to 'subtle'
* updated colors in `tw-theme`
* added conditional check to compute vertical alignment class
* updated more colors, slight restructure to match design
* fixed vertical alignment with 'close button', avoid long text crowding/overflowing
* remove default icons on non-semantic variants (#19614)
* remove default icons on non-semantic variants
* add back info icon to info variant
* remove info icon again
* [CL-1095] add expanded state for disclosure button (#19637)
* add brand stronger colors
* add aria-expanded styling for primary ghost button
* make all variants aria-expanded style match hover styles
* update orage-600 color value to fix contrast
* minor spacing update to account for expanded button style
* do not show expanded state on sidenav buttons
* no expanded style on toggle width button
* remove extra letter spacing and update story copy (#19668)
* [CL-1123] fix ghost button inactive styles (#19669)
* fix ghost button inactive styles
* remove type declaration
* [CL-1119] toggle berry update (#19609)
* update toggle groups to use berry
* set berry variant based on selected state
* fix failing spec
* add spec to test berry variant set correctly
* fix import errors caused by bad merge conflict resolution
* remove unnecessary variant delaration
* update kitchen sink stories to use berry
* [CL-1122] BUG FIX: Migrated Icon Buttons with button type 'danger' to 'dangerGhost' (#19677)
* migrated `bitIconButton` with 'danger' `buttonType` to 'dangerGhost'
* reverted icon-button story
* fix button variant from merge
* [CL-1117] BUG FIX: Side nav collapse arrow is placed too far left (#19623)
* - updated spacing for side-nav collapse arrow button
- updated collapsed nav-item button spacing and dimensions
- moved individual nav-item wrapper padding into side-nav component
- added button to 'WithLongText' nav-item story
* added sidenav specific hover style to toggle collapse button
* - set horizontal padding back to 'nav-item'
- updated 'bit-divider' color to 'bg-border-brand'
* updated hover styles for interactive trailing elements
* added '4px' more end padding to trailing buttons
* updated 'bit-divider' colors for secondary and dark theme
* moved button hover styles into 'side-nav' button variant
* updated sidenav-divider color for dark theme
* removed `tw-w-10` on nav-item collapsed
* updated inline padding to `12px` for both collapse and expanded states
* [CL-1117] cleaned up, renamed, and organized sidenav color variables (#19665)
* - unified 'strong' styles and `showActiveStyles` into `[style]`
- updated 'side-nav' button variant's `aria-expanded` and `focus-visible` styles
* - inherit bg and fg from parent `sidenav`
- allow trailing buttons set own fg
* updated nav group story for trailing elements
* updated nav-logo 'focus' to nav focus style
* let toggle width arrow inherit 'aria-expanded' style from 'side-nav' buttontype
* removed danger button variants from nav group story
---------
Co-authored-by: Bryan Cunningham <bcunningham@bitwarden.com>
Co-authored-by: Vicki League <vleague@bitwarden.com>
Co-authored-by: Leslie Xiong <lxiong@livefront.com>
* feat: add full middleware pipeline support
* Retrieve cookies from storage and attach cookies using Electron session
* Register middleware to act on fetch redirect to acquire cookie for SSO
* Add missing tests
* fix: acquireCookies call
* fix: cookies not getting set
* feat: add vaultUrl to server communication config
* feat: adapt to receiving vaultUrl in acquireCookies
* fix: remove localhost connector override
* Fix requests can't be re-used
* Add small delay to ensure cookies are saved before retrying requests
* Fix vaultUrl being set twice
* Add mock clone method
* Fix sso-cookie.main tests
* Remove old FIXME
* Re-use request and fix test
* Add missing coverage checking that needsBootsrap is called
* In case the hostname can't be extracted, the response is returned
* Only check the responseType instead of also checking statuscodes for redirects
* Bump the sdk-version
* Prepend https:// if necessary before launching the connector url
* Do not retry if needsBootstrap returns false
---------
Co-authored-by: Andreas Coroiu <andreas.coroiu@gmail.com>
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
* [PM-31696] Add reverse proxy emulator for load balancer cookie testing
Adds a local dev/QA tool that emulates AWS ELB authentication without
real AWS infrastructure. It gates all traffic behind a
BitwardenLoadBalancerCookie and serves a simple auth page to issue it,
enabling testing of the load balancer cookie bootstrap flow (PM-27124).
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* [PM-31696] Replace http-proxy with Node.js built-ins
http-proxy has not been published in 6 years and uses the deprecated
util._extend API. Replace it with https.request + piping for HTTP and
tls.connect + socket piping for WebSocket, removing the dependency and
the --no-deprecation workaround entirely.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* [PM-31696] Fix TLS verification for public backends
Extend the default CA bundle with the self-signed cert instead of
replacing it, so both localhost dev servers and public backends
(e.g. vault.bitwarden.com) are trusted without --insecure.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* [PM-31696] Add cookie rotation via R keypress
Press R while the proxy is running to increment the cookie generation,
immediately invalidating all existing session cookies and forcing
clients to re-authenticate on their next request.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* docs: tweak docs
* feat: improve error messages
* docs: update readme
---------
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* [PM-27772] Add TrendWidget component with Chart.js implementation (#19078)
Add reusable TrendWidget component with Chart.js line chart for displaying risk trends over time in Access Intelligence.
- Configurable datetime/linear x-axis scales
- Theme-aware colors from design system (brand-700/400, gray-200/600)
- Full i18n support (10 new translation keys)
- Loading spinner and error state handling
- Proper Chart.js lifecycle management
* [PM-28530] Implement period selector UI component (#19162)
* feat(dirt): define TimePeriod type for risk-over-time period selector
Add const object type for 5 time periods (month, 3mo, 6mo, 12mo, all)
following ADR-0025 no-enum pattern. Includes PeriodOption interface
and PERIOD_OPTIONS config for rendering.
[PM-28530]
* feat(dirt): create PeriodSelectorComponent using bit-menu
Custom trigger button with bit-menu dropdown for risk-over-time
time period selection. No clear button, neutral styling matching
Figma design. Check icon marks current selection.
[PM-28530]
* feat(dirt): add barrel export for period selector
[PM-28530]
* feat(dirt): add i18n strings for period selector options
Add translation keys for time period labels: pastMonth, last3Months,
last6Months, last12Months, and timePeriod placeholder.
[PM-28530]
* feat(dirt): add Storybook stories for PeriodSelectorComponent
Stories for default state, pre-selected 3 months, and disabled state.
[PM-28530]
* test(dirt): add unit tests for PeriodSelectorComponent
Tests cover default state, period options with pre-translated labels,
selection changes, and selected label reactivity.
[PM-28530]
* feat(dirt): integrate PeriodSelector into TrendWidget component
Replace placeholder with dirt-period-selector dropdown. Add TimePeriod
to TrendWidgetTimespan mapping layer to bridge the two type systems.
Remove standalone Storybook story and disabled input per review feedback
— component now lives inside TrendWidget, not standalone.
[PM-28530]
* refactor(dirt): replace model() with signal() + output() for PeriodSelector
Switch from Angular's model() API to the signal() + output() pattern
used throughout the Access Intelligence module. This matches the
existing convention in TrendWidget (selectedTimespan/timespanChanged),
app-table-row-scrollable (checkboxChange/selectAllChange), and
review-applications-view (onToggleSelection/onToggleAll).
Changes:
- Replace model<TimePeriod>() with signal<TimePeriod>() for internal state
- Add explicit selectedPeriodChange output for parent notification
- Manual .emit() in selectPeriod() to match module convention
- Update test to verify output emission via subscribe spy
No functional change — both patterns emit selectedPeriodChange events.
The template binding (selectedPeriodChange)="..." is unchanged.
* refactor(dirt): update labels to match Figma and unify type system
Update period selector labels per Figma design:
- "Last 3 months" → "Past 3 months" (past3Months)
- "Last 6 months" → "Past 6 months" (past6Months)
- "Last 12 months" → "Past year" (pastYear)
- "All" → "All time" (allTime, new key — pre-existing "all" key untouched)
Rename TimePeriod const keys to match labels:
- Last3Months → Past3Months
- Last6Months → Past6Months
- Last12Months → PastYear
- All → AllTime
Wire values unchanged ("month", "3mo", "6mo", "12mo", "all") to
preserve server API compatibility.
Remove TrendWidgetTimespan entirely — TrendWidget now uses TimePeriod
directly for signals, outputs, and data model. Eliminates the temporary
mapping layer (timePeriodMap + onPeriodSelectorChange). Period selector
wires directly to onTimespanChange().
[PM-28530]
* [PM-28533] Add view selector to TrendWidget component (#19163)
Adds the view selector button group to the TrendWidget component. Hooks up to existing signal and emits events when the view mode is changed. In future development, the parent component of TrendWidget will need to handle these events to fetch updated chart data from the API.
View options are:
Applications
Passwords
Members
* Fix TimePeriod type errors in TrendWidget stories (#19239)
Replace invalid "past-month" string literals with TimePeriod.PastMonth
constant to match the TimePeriod type definition. The TimePeriod const
object uses "month" as the value for PastMonth, not "past-month".
* [PM-32056] Add feature flag for access intelligence trend chart (#19164)
* feat(dirt): add feature flag for access intelligence trend chart
Register the `pm-26961-access-intelligence-trend-chart` feature flag
to gate the upcoming TrendChart widget in the Activity tab. Default
is FALSE (disabled). PM-32057 will consume this flag when wiring up
the widget component.
[PM-32056]
* feat(dirt): read trend chart feature flag in activity component
Inject ConfigService into AllActivityComponent and read the
AccessIntelligenceTrendChart flag on init. This prepares the
component for the TrendChart widget to be conditionally rendered.
[PM-32056]
* feat(dirt): add conditional wrapper for trend chart widget
Add an @if block gated by the AccessIntelligenceTrendChart feature
flag in the Activity tab template. The TrendChart widget will be
placed inside this block when wired up.
[PM-32056]
* reset package files to main
* install chartjs using node v22
* add chartjs to dirt team deps (#19244)
* [PM-32055] Download TrendWidget chart to PNG and CSV (#19245)
This PR adds a download button to the TrendWidget component that supports downloading the "Risk over time" chart data as a PNG or in CSV format.
Logic to dynamically add a chart title and x/y axis labels is included. This required creating a service that recreates a copy of the chart with title and axis labels applied, in an off screen canvas element, and then exporting to blob for file download. This logic is owned by the ChartExportService.
* Fix readonly variables. Update chart variable to use signal
* Fix any type in test file
---------
Co-authored-by: Brad <44413459+lastbestdev@users.noreply.github.com>
Co-authored-by: Alex <55413326+AlexRubik@users.noreply.github.com>
Co-authored-by: Brad Deibert <bdeibert@bitwarden.com>
* feat(platform): extract vaultUrl from /api/config response
Updates DefaultConfigService to extract the vault URL from the server's
/api/config response and populate it in the ServerCommunicationConfig that
gets passed to the SDK.
The vaultUrl field is extracted from response.environment.vault using
optional chaining to safely handle cases where the environment field may
be undefined. This follows the TypeScript camelCase naming convention and
integrates with the SDK's vault_url parameter added in the previous SDK
commits.
This enables the SDK to receive an explicit vault URL for SSO cookie
acquisition redirects, which fixes two critical issues:
1. Port preservation: Prevents localhost:8000 being stripped to localhost
in local development environments
2. Multi-subdomain routing: Ensures redirects use vault.bitwarden.com
instead of api.bitwarden.com when the cookie domain differs from the
vault hostname
The TypeScript interface definition will be added in the next commit to
complete type safety.
Refs: PM-33352
* fix(platform): add vaultUrl parameter to noop acquireCookies
Updates the NoopServerCommunicationConfigPlatformApiService implementation
to match the SDK's ServerCommunicationConfigPlatformApi trait interface
change from SDK PR #832.
The SDK's acquire_cookies() method now requires both hostname and
vault_url parameters. This commit adds the vaultUrl parameter to the
noop implementation's method signature to maintain TypeScript type
compatibility.
The noop service remains a no-op - it continues to return undefined
but now accepts the additional parameter that the SDK interface expects.
This prevents TypeScript compilation errors when the clients repo updates
to SDK version 0.2.0-main.580 or later.
Refs: PM-33352
* feat: update sdk
* fix: add missing vault_url to tests
* review: guard ssoCookieVendor on vaultUrl
Passing undefined for vaultUrl into the SDK's Rust
SsoCookieVendorConfig struct causes a panic at the WASM
boundary. Extract vaultUrl into a local variable and add a
null guard so that configs missing a vault URL fall back to
{ bootstrap: { type: "direct" } } instead of reaching the
SDK with an incomplete struct.
Update the existing ssoCookieVendor test to assert vaultUrl
in the expected output, and add a new case verifying the
direct fallback when environment is absent.
---------
Co-authored-by: Andreas Coroiu <andreas.coroiu@gmail.com>
* feat: remove reference to otp_invalid response since it is not used anymore
* remove usage of otpInvalid in CLI receive command
* fix: remove vestigial error types.
* chore: update sdk
* chore: fix failing test
---------
Co-authored-by: John Harrington <84741727+harr1424@users.noreply.github.com>
* [deps] Vault: Update @koa/router to v15
* update router imports from `@koa/router`
* remove `@types/koa__router` no longer needed with update to `@koa/router`
---------
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Nick Krantz <125900171+nick-livefront@users.noreply.github.com>
Co-authored-by: Nick Krantz <nick@livefront.com>
* Support v2 encryption for JIT Password signups
* TDE set master password split
* update sdk-internal dependency
* moved encryption v2 to InitializeJitPasswordUserService
* remove account cryptographic state legacy states from #18164
* legacy state comments
* sdk update
* unit test coverage
* consolidate do SetInitialPasswordService
* replace legacy master key with setLegacyMasterKeyFromUnlockData
* typo
* web and desktop overrides with unit tests
* early return
* compact validation
* simplify super prototype
