CodeCow/clients
1
0
Fork 0
mirror of https://github.com/bitwarden/clients.git synced 2026-06-25 21:02:59 +08:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

Only import BrowserModule once (#14354)

Browse Source 
Desktop imported BrowserModule & BrowserAnimationModule multiple times which can result in compile errors. Following the patterns used in our other clients this updates the BrowserModule import to only occur in app.module.
This commit is contained in:
Oscar Hinton 2025-04-22 11:59:52 +02:00 committed by GitHub
parent 98fa07f7b9
commit fbe86da98b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
apps/desktop/src/app/app.module.ts
View File

@ -4,6 +4,7 @@ import "zone.js";
import "../platform/app/locales";
import { NgModule } from "@angular/core";
import { BrowserAnimationsModule } from "@angular/platform-browser/animations";
import { ColorPasswordCountPipe } from "@bitwarden/angular/pipes/color-password-count.pipe";
import { ColorPasswordPipe } from "@bitwarden/angular/pipes/color-password.pipe";
@ -44,6 +45,8 @@ import { SharedModule } from "./shared/shared.module";
@NgModule({
imports: [
BrowserAnimationsModule,
SharedModule,
AppRoutingModule,
VaultFilterModule,

10
apps/desktop/src/app/shared/shared.module.ts
View File

@ -2,11 +2,9 @@ import { A11yModule } from "@angular/cdk/a11y";
import { DragDropModule } from "@angular/cdk/drag-drop";
import { OverlayModule } from "@angular/cdk/overlay";
import { ScrollingModule } from "@angular/cdk/scrolling";
import { DatePipe } from "@angular/common";
import { CommonModule, DatePipe } from "@angular/common";
import { NgModule } from "@angular/core";
import { FormsModule, ReactiveFormsModule } from "@angular/forms";
import { BrowserModule } from "@angular/platform-browser";
import { BrowserAnimationsModule } from "@angular/platform-browser/animations";
import { JslibModule } from "@bitwarden/angular/jslib.module";
@ -15,9 +13,8 @@ import { ServicesModule } from "../services/services.module";
@NgModule({
imports: [
CommonModule,
A11yModule,
BrowserAnimationsModule,
BrowserModule,
DragDropModule,
FormsModule,
JslibModule,
@ -28,9 +25,8 @@ import { ServicesModule } from "../services/services.module";
],
declarations: [AvatarComponent],
exports: [
CommonModule,
A11yModule,
BrowserAnimationsModule,
BrowserModule,
DatePipe,
DragDropModule,
FormsModule,

4
apps/desktop/src/vault/app/vault/vault-filter/vault-filter.module.ts
View File

@ -1,5 +1,5 @@
import { CommonModule } from "@angular/common";
import { NgModule } from "@angular/core";
import { BrowserModule } from "@angular/platform-browser";
import { JslibModule } from "@bitwarden/angular/jslib.module";
import { DeprecatedVaultFilterService as DeprecatedVaultFilterServiceAbstraction } from "@bitwarden/angular/vault/abstractions/deprecated-vault-filter.service";
@ -13,7 +13,7 @@ import { TypeFilterComponent } from "./filters/type-filter.component";
import { VaultFilterComponent } from "./vault-filter.component";
@NgModule({
imports: [BrowserModule, JslibModule],
imports: [CommonModule, JslibModule],
declarations: [
VaultFilterComponent,
CollectionFilterComponent,