CodeCow/clients
1
0
Fork 0
mirror of https://github.com/bitwarden/clients.git synced 2026-06-22 21:02:34 +08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

[PM-15410][PM-15410] add nullish check when referencing document in BrowserPopupUtils (#12162)
Some checks failed
Chromatic / Check PR run (push) Has been cancelled
Details
Scan / Check PR run (push) Has been cancelled
Details
Testing / Check for test secrets (push) Has been cancelled
Details
Testing / Run Rust tests on ${{ matrix.os }} (macos-latest) (push) Has been cancelled
Details
Testing / Run Rust tests on ${{ matrix.os }} (ubuntu-22.04) (push) Has been cancelled
Details
Testing / Run Rust tests on ${{ matrix.os }} (windows-latest) (push) Has been cancelled
Details
Chromatic / Chromatic (push) Has been cancelled
Details
Scan / SAST scan (push) Has been cancelled
Details
Scan / Quality scan (push) Has been cancelled
Details
Testing / Run tests (push) Has been cancelled
Details

Browse Source 
* check if document is undefined before accessing `body`
This commit is contained in:
Will Martin 2024-11-27 09:14:03 -05:00 committed by GitHub
parent d5b14d11d4
commit d448db5ed7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
apps/browser/src/platform/popup/browser-popup-utils.ts
View File

@ -109,7 +109,10 @@ class BrowserPopupUtils {
const defaultPopoutWindowOptions: chrome.windows.CreateData = {
type: "popup",
focused: true,
width: Math.max(PopupWidthOptions.default, document.body.clientWidth),
width: Math.max(
PopupWidthOptions.default,
typeof document === "undefined" ? PopupWidthOptions.default : document.body.clientWidth,
),
height: 630,
};
const offsetRight = 15;