add data-testids to log in elements (#21458)

This commit is contained in:
Ned Thompson 2026-06-24 10:31:16 -04:00 committed by GitHub
parent 291d5527e2
commit b60c6f39d1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 26 additions and 3 deletions

View File

@ -15,7 +15,9 @@ import { LinkModule } from "@bitwarden/components";
template: `
<div class="tw-text-center" *ngIf="!(isUserRegistrationDisabled$ | async)">
{{ "newToBitwarden" | i18n }}
<a bitLink routerLink="/signup">{{ "createAccount" | i18n }}</a>
<a bitLink routerLink="/signup" data-testid="login-create-account-link">{{
"createAccount" | i18n
}}</a>
</div>
`,
})

View File

@ -9,6 +9,7 @@
formControlName="email"
bitInput
appAutofocus
data-testid="login-email-input"
(input)="onEmailInput($event)"
(keyup.enter)="ssoRequired ? handleSsoClick() : continuePressed()"
/>
@ -19,6 +20,7 @@
<input
type="checkbox"
formControlName="rememberEmail"
data-testid="login-remember-email"
(input)="onRememberEmailInput($event)"
bitCheckbox
/>
@ -32,6 +34,7 @@
bitButton
block
buttonType="primary"
data-testid="login-continue-button"
(click)="continuePressed()"
[bitTooltip]="ssoRequired ? ('yourOrganizationRequiresSingleSignOn' | i18n) : ''"
[addTooltipToDescribedby]="ssoRequired"
@ -49,6 +52,7 @@
bitButton
block
buttonType="secondary"
data-testid="login-with-passkey-button"
(click)="handleLoginWithPasskeyClick()"
[bitTooltip]="ssoRequired ? ('yourOrganizationRequiresSingleSignOn' | i18n) : ''"
[addTooltipToDescribedby]="ssoRequired"
@ -65,6 +69,7 @@
bitButton
block
[buttonType]="ssoRequired ? 'primary' : 'secondary'"
data-testid="login-sso-button"
(click)="handleSsoClick()"
>
<bit-icon name="bwi-provider" class="tw-mr-1"></bit-icon>
@ -83,6 +88,7 @@
autocomplete="current-password"
formControlName="masterPassword"
bitInput
data-testid="login-master-password-input"
#masterPasswordInputRef
/>
<button type="button" bitIconButton bitSuffix bitPasswordInputToggle></button>
@ -95,7 +101,14 @@
<div class="tw-grid tw-gap-3">
<!-- Submit button to Login with Master Password -->
<button type="submit" bitButton bitFormButton block buttonType="primary">
<button
type="submit"
bitButton
bitFormButton
block
buttonType="primary"
data-testid="login-submit-button"
>
{{ "logIn" | i18n }}
</button>
@ -108,6 +121,7 @@
bitButton
block
buttonType="secondary"
data-testid="login-with-device-button"
(click)="startAuthRequestLogin()"
>
<bit-icon name="bwi-mobile"></bit-icon>
@ -117,7 +131,14 @@
<!-- Back button -->
<ng-container *ngIf="shouldShowBackButton()">
<button type="button" bitButton block buttonType="secondary" (click)="backButtonClicked()">
<button
type="button"
bitButton
block
buttonType="secondary"
data-testid="login-back-button"
(click)="backButtonClicked()"
>
{{ "back" | i18n }}
</button>
</ng-container>