CodeCow/clients
1
0
Fork 0
mirror of https://github.com/bitwarden/clients.git synced 2026-07-07 21:10:55 +08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

[PM-29525] Typefixes in services/autofill-overlay-content.service.ts (#19555)

Browse Source 
* fix typing issues

* replace ts-strict-ignore for remaining work
This commit is contained in:
Jonathan Prusik 2026-03-18 12:05:09 -04:00 committed by GitHub
parent aaf239a2c5
commit a883fe5192
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 17 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
apps/browser/src/autofill/services/autofill-overlay-content.service.ts
View File

@ -59,8 +59,8 @@ import { AutoFillConstants } from "./autofill-constants";
export class AutofillOverlayContentService implements AutofillOverlayContentServiceInterface {
pageDetailsUpdateRequired = false;
private showInlineMenuIdentities: boolean;
private showInlineMenuCards: boolean;
private showInlineMenuIdentities: boolean = false;
private showInlineMenuCards: boolean = false;
private readonly findTabs = tabbable;
private readonly sendExtensionMessage = sendExtensionMessage;
private formFieldElements: Map<ElementWithOpId<FormFieldElement>, AutofillField> = new Map();
@ -72,10 +72,10 @@ export class AutofillOverlayContentService implements AutofillOverlayContentServ
private ignoredFieldTypes: Set<string> = new Set(AutoFillConstants.ExcludedInlineMenuTypes);
private userFilledFields: Record<string, FillableFormFieldElement> = {};
private focusableElements: FocusableElement[] = [];
private mostRecentlyFocusedField: ElementWithOpId<FormFieldElement>;
private focusedFieldData: FocusedFieldData;
private closeInlineMenuOnRedirectTimeout: number | NodeJS.Timeout;
private focusInlineMenuListTimeout: number | NodeJS.Timeout;
private mostRecentlyFocusedField: ElementWithOpId<FormFieldElement> | null = null;
private focusedFieldData: FocusedFieldData | null = null;
private closeInlineMenuOnRedirectTimeout: number | NodeJS.Timeout | null = null;
private focusInlineMenuListTimeout: number | NodeJS.Timeout | null = null;
private eventHandlersMemo: { [key: string]: EventListener } = {};
private readonly extensionMessageHandlers: AutofillOverlayContentExtensionMessageHandlers = {
addNewVaultItemFromOverlay: ({ message }) => this.addNewVaultItem(message),
@ -1129,7 +1129,9 @@ export class AutofillOverlayContentService implements AutofillOverlayContentServ
}
autofillFieldData.inlineMenuFillType = CipherType.Login;
autofillFieldData.showPasskeys = autofillFieldData.autoCompleteType.includes("webauthn");
autofillFieldData.showPasskeys = (
autofillFieldData.autoCompleteType || ([] as string[])
).includes("webauthn");
this.qualifyAccountCreationFieldType(autofillFieldData);
}
@ -1369,7 +1371,7 @@ export class AutofillOverlayContentService implements AutofillOverlayContentServ
*
* @param element - The element to get the root node active element for.
*/
private getRootNodeActiveElement(element: Element): Element {
private getRootNodeActiveElement(element: Element): Element | null {
if (!element) {
return null;
}
@ -1389,7 +1391,7 @@ export class AutofillOverlayContentService implements AutofillOverlayContentServ
): Promise<SubFrameOffsetData | null> {
const { subFrameUrl } = message;
const subFrameUrlVariations = this.getSubFrameUrlVariations(subFrameUrl);
const subFrameUrlVariations = subFrameUrl && this.getSubFrameUrlVariations(subFrameUrl);
if (!subFrameUrlVariations) {
return null;
}
@ -1558,7 +1560,7 @@ export class AutofillOverlayContentService implements AutofillOverlayContentServ
const parentFrameId = await this.sendExtensionMessage("getCurrentTabFrameId");
if (typeof parentFrameId !== "undefined") {
subFrameData.parentFrameIds.push(parentFrameId);
subFrameData.parentFrameIds?.push(parentFrameId);
}
break;
@ -1785,8 +1787,11 @@ export class AutofillOverlayContentService implements AutofillOverlayContentServ
await this.updateMostRecentlyFocusedField(this.mostRecentlyFocusedField);
const focusedFieldRectsTop = this.focusedFieldData?.focusedFieldRects?.top;
const focusedFieldRectsBottom =
focusedFieldRectsTop + this.focusedFieldData?.focusedFieldRects?.height;
const focusedFieldRectsHeight = this.focusedFieldData?.focusedFieldRects?.height;
if (!focusedFieldRectsTop || !focusedFieldRectsHeight) {
return false;
}
const focusedFieldRectsBottom = focusedFieldRectsTop + focusedFieldRectsHeight;
const viewportHeight = globalThis.innerHeight + globalThis.scrollY;
return (
!globalThis.isNaN(focusedFieldRectsTop) &&