CodeCow/clients
1
0
Fork 0
mirror of https://github.com/bitwarden/clients.git synced 2026-07-01 21:10:49 +08:00
Code Issues Actions 9 Packages Projects Releases Wiki Activity

Improve routing during account switching to ensure feature flags are triggered (#18037)
Some checks failed
Chromatic / Check PR run (push) Has been cancelled
Details
Scan / Check PR run (push) Has been cancelled
Details
Testing / Run tests (push) Has been cancelled
Details
Testing / Run Rust tests on ${{ matrix.os }} (macos-14) (push) Has been cancelled
Details
Testing / Run Rust tests on ${{ matrix.os }} (ubuntu-22.04) (push) Has been cancelled
Details
Testing / Run Rust tests on ${{ matrix.os }} (windows-2022) (push) Has been cancelled
Details
Testing / Rust Coverage (push) Has been cancelled
Details
Chromatic / Chromatic (push) Has been cancelled
Details
Scan / Checkmarx (push) Has been cancelled
Details
Scan / Sonar (push) Has been cancelled
Details
Testing / Upload to Codecov (push) Has been cancelled
Details

Browse Source 
When account switching from the old layout it's not bringing you into the new design. This resolves it by ensuring the route guard for vault is triggered after account switching.
This commit is contained in:
Oscar Hinton 2026-01-13 11:23:29 +01:00 committed by GitHub
parent bea6fb26f8
commit 5fe01323bb
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
apps/desktop/src/app/app-routing.module.ts
View File

@ -114,6 +114,8 @@ const routes: Routes = [
authGuard,
canAccessFeature(FeatureFlag.DesktopUiMigrationMilestone1, false, "new-vault", false),
],
// Needed to ensure feature flag changes are picked up on account switching
runGuardsAndResolvers: "always",
},
{
path: "send",

5
apps/desktop/src/app/app.component.ts
View File

@ -492,9 +492,8 @@ export class AppComponent implements OnInit, OnDestroy {
this.loading = true;
await this.syncService.fullSync(false);
this.loading = false;
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
// eslint-disable-next-line @typescript-eslint/no-floating-promises
this.router.navigate(["vault"]);
// Force reload to ensure route guards are activated
await this.router.navigate(["vault"], { onSameUrlNavigation: "reload" });
}
this.messagingService.send("finishSwitchAccount");
break;